5028 2005-09-17 13:46:25 -0700 9 layout tests fail following the change from long to int 2005-09-20 02:24:30 -0700 1 1 1 Unclassified WebKit New Bugs 420+ Mac OS X 10.4 VERIFIED FIXED P1 Normal --- 1 mitz ggaren oldest_to_newest 19799 0 mitz 2005-09-17 13:46:25 -0700 After applying the patch for bug 4547, the following layout tests fail: dom/html/level2/html/HTMLTableElement35 dom/html/level2/html/HTMLTableElement38 dom/html/level2/html/HTMLTableRowElement16 dom/html/level2/html/HTMLTableRowElement19 dom/html/level2/html/HTMLTableSectionElement26 dom/html/level2/html/HTMLTableSectionElement29 fast/js/date-big-setmonth fast/js/date-parse-date fast/dom/quadraticCurveTo (draws a sine with ~1px amplitude along the axis) I'm putting them all together in one bug because it's likely that they have a common root cause (something broken in the way JS does math), and because I'm lazy. 19971 1 3942 ggaren 2005-09-18 15:39:52 -0700 Created attachment 3942 Fix by rolling out simple_number.h changes Because we have JavaScriptCore test failures on TOT, I can't be sure that this patch is the right solution, but it fixes all the layout tests without introducing additional regressions to the JavaScriptCore tests. 19972 2 3942 ggaren 2005-09-18 15:41:15 -0700 Comment on attachment 3942 Fix by rolling out simple_number.h changes I think we should land this patch, land a fix for the other JSC regressions, and then go back and redo the int/long modifications to simple_number.h, once we have a working baseline of tests. 19998 3 3942 mjs 2005-09-19 00:26:04 -0700 Comment on attachment 3942 Fix by rolling out simple_number.h changes Given that this fixes the bug, r=me This change should be revisited however. 20028 4 mitz 2005-09-19 15:24:26 -0700 I'm marking this verified even though date-big-setmonth is still failing for me. I seem to remember it failing even before the long->int move. 20033 5 ggaren 2005-09-19 15:40:01 -0700 date-big-setmonth was failing because it's not written to be TZ independent. I'll fix that. 20080 6 mitz 2005-09-20 02:24:30 -0700 Opened bug 5061 about date-big-setmonth 3942 2005-09-18 15:39:52 -0700 2005-09-19 00:26:04 -0700 Fix by rolling out simple_number.h changes patch.txt text/plain 2906 ggaren SW5kZXg6IHNpbXBsZV9udW1iZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvSmF2 YVNjcmlwdENvcmUva2pzL3NpbXBsZV9udW1iZXIuaCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4x NQpkaWZmIC11IC1yMS4xNSBzaW1wbGVfbnVtYmVyLmgKLS0tIHNpbXBsZV9udW1iZXIuaAkxNiBT ZXAgMjAwNSAyMjo0MjozMCAtMDAwMAkxLjE1CisrKyBzaW1wbGVfbnVtYmVyLmgJMTggU2VwIDIw MDUgMjI6Mzk6NTQgLTAwMDAKQEAgLTM2LDggKzM2LDYgQEAKIHVzaW5nIHN0ZDo6c2lnbmJpdDsK ICNlbmRpZgogCi0jZGVmaW5lIEtKU19NSU5fTUFDUk8oYSwgYikgKChhKSA8IChiKSA/IChhKSA6 IChiKSkKLQogbmFtZXNwYWNlIEtKUyB7CiAKICAgICBjbGFzcyBWYWx1ZUltcDsKQEAgLTUzLDI5 ICs1MSwyMCBAQAogICAgIAogICAgIGNsYXNzIFNpbXBsZU51bWJlciB7CiAgICAgcHVibGljOgot CWVudW0gewotICAgICAgICAgICAgdGFnID0gMSwKLSAgICAgICAgICAgIHNoaWZ0ID0gMiwKLSAg ICAgICAgICAgIG1hc2sgPSAoMSA8PCBzaGlmdCkgLSAxLAotICAgICAgICAgICAgYml0cyA9IEtK U19NSU5fTUFDUk8oc2l6ZW9mKFZhbHVlSW1wICopICogOCAtIHNoaWZ0LCBzaXplb2YobG9uZykg KiA4KSwKLSAgICAgICAgICAgIHNpZ24gPSAxVUwgPDwgKGJpdHMgKyBzaGlmdCAtIDEpLAotICAg ICAgICAgICAgdW1heCA9IHNpZ24gPj4gMSwKLSAgICAgICAgICAgIHNtYXggPSBzdGF0aWNfY2Fz dDxsb25nPih1bWF4KSwKLSAgICAgICAgICAgIHNtaW4gPSBzdGF0aWNfY2FzdDxsb25nPigtdW1h eCAtIDEpCi0gICAgICAgIH07Ci0gICAgICAgIAorCWVudW0geyB0YWcgPSAxLCBzaGlmdCA9IDIs IG1hc2sgPSAoMSA8PCBzaGlmdCkgLSAxLCBzaWduID0gMUwgPDwgKHNpemVvZihsb25nKSAqIDgg LSAxICksIG1heCA9ICgxTCA8PCAoKHNpemVvZihsb25nKSAqIDggLSAxKSAtIHNoaWZ0KSkgLSAx LCBtaW4gPSAtbWF4IC0gMSwgaW1heCA9ICgxTCA8PCAoKHNpemVvZihpbnQpICogOCAtIDEpIC0g c2hpZnQpKSAtIDEsIGltaW4gPSAtaW1heCAtIDEgfTsKKwogCXN0YXRpYyBpbmxpbmUgYm9vbCBp cyhjb25zdCBWYWx1ZUltcCAqaW1wKSB7IHJldHVybiAoKGxvbmcpaW1wICYgbWFzaykgPT0gdGFn OyB9Ci0gICAgICAgIHN0YXRpYyBpbmxpbmUgbG9uZyB2YWx1ZShjb25zdCBWYWx1ZUltcCAqaW1w KSB7IHJldHVybiAoKGxvbmcpaW1wID4+IHNoaWZ0KSB8ICgoKGxvbmcpaW1wICYgc2lnbikgPyB+ dW1heCA6IDApOyB9CisJc3RhdGljIGlubGluZSBsb25nIHZhbHVlKGNvbnN0IFZhbHVlSW1wICpp bXApIHsgcmV0dXJuICgobG9uZylpbXAgPj4gc2hpZnQpIHwgKCgobG9uZylpbXAgJiBzaWduKSA/ IH5tYXggOiAwKTsgfQogCi0gICAgICAgIHN0YXRpYyBpbmxpbmUgYm9vbCBmaXRzKGludCBpKSB7 IHJldHVybiBpIDw9IHNtYXggJiYgaSA+PSBzbWluOyB9Ci0Jc3RhdGljIGlubGluZSBib29sIGZp dHModW5zaWduZWQgaSkgeyByZXR1cm4gaSA8PSB1bWF4OyB9Ci0Jc3RhdGljIGlubGluZSBib29s IGZpdHMobG9uZyBpKSB7IHJldHVybiBpIDw9IHNtYXggJiYgaSA+PSBzbWluOyB9Ci0Jc3RhdGlj IGlubGluZSBib29sIGZpdHModW5zaWduZWQgbG9uZyBpKSB7IHJldHVybiBpIDw9IHVtYXg7IH0K LQlzdGF0aWMgaW5saW5lIGJvb2wgZml0cyhsb25nIGxvbmcgaSkgeyByZXR1cm4gaSA8PSBzbWF4 ICYmIGkgPj0gc21pbjsgfQotCXN0YXRpYyBpbmxpbmUgYm9vbCBmaXRzKHVuc2lnbmVkIGxvbmcg bG9uZyBpKSB7IHJldHVybiBpIDw9IHVtYXg7IH0KLQlzdGF0aWMgaW5saW5lIGJvb2wgaW50ZWdl ckZpdHMoZG91YmxlIGQpIHsgcmV0dXJuICEoZCA8IHNtaW4gfHwgZCA+IHNtYXgpOyB9Ci0Jc3Rh dGljIGlubGluZSBib29sIGZpdHMoZG91YmxlIGQpIHsgcmV0dXJuIGQgPj0gc21pbiAmJiBkIDw9 IHNtYXggJiYgZCA9PSAoZG91YmxlKShsb25nKWQgJiYgIWlzTmVnYXRpdmVaZXJvKGQpOyB9Ci0J c3RhdGljIGlubGluZSBWYWx1ZUltcCAqbWFrZShsb25nIGkpIHsgcmV0dXJuIHJlaW50ZXJwcmV0 X2Nhc3Q8VmFsdWVJbXAgKj4oc3RhdGljX2Nhc3Q8dWludHB0cl90PigoaSA8PCBzaGlmdCkgfCB0 YWcpKTsgfQorCXN0YXRpYyBpbmxpbmUgYm9vbCBmaXRzKGludCBpKSB7IHJldHVybiBpIDw9IGlt YXggJiYgaSA+PSBpbWluOyB9CisJc3RhdGljIGlubGluZSBib29sIGZpdHModW5zaWduZWQgaSkg eyByZXR1cm4gaSA8PSAodW5zaWduZWQpbWF4OyB9CisJc3RhdGljIGlubGluZSBib29sIGZpdHMo bG9uZyBpKSB7IHJldHVybiBpIDw9IG1heCAmJiBpID49IG1pbjsgfQorCXN0YXRpYyBpbmxpbmUg Ym9vbCBmaXRzKHVuc2lnbmVkIGxvbmcgaSkgeyByZXR1cm4gaSA8PSAodW5zaWduZWQpbWF4OyB9 CisgICAgICAgIHN0YXRpYyBpbmxpbmUgYm9vbCBmaXRzKGxvbmcgbG9uZyBpKSB7IHJldHVybiBp IDw9IG1heCAmJiBpID49IG1pbjsgfQorICAgICAgICBzdGF0aWMgaW5saW5lIGJvb2wgZml0cyh1 bnNpZ25lZCBsb25nIGxvbmcgaSkgeyByZXR1cm4gaSA8PSAodW5zaWduZWQpbWF4OyB9CisJc3Rh dGljIGlubGluZSBib29sIGludGVnZXJGaXRzKGRvdWJsZSBkKSB7IHJldHVybiAhKGQgPCBtaW4g fHwgZCA+IG1heCk7IH0KKwlzdGF0aWMgaW5saW5lIGJvb2wgZml0cyhkb3VibGUgZCkgeyByZXR1 cm4gZCA+PSBtaW4gJiYgZCA8PSBtYXggJiYgZCA9PSAoZG91YmxlKShsb25nKWQgJiYgIWlzTmVn YXRpdmVaZXJvKGQpOyB9CisJc3RhdGljIGlubGluZSBWYWx1ZUltcCAqbWFrZShsb25nIGkpIHsg cmV0dXJuIChWYWx1ZUltcCAqKSgoaSA8PCBzaGlmdCkgfCB0YWcpOyB9CiAgICAgfTsKIAogfQo=