50271 2010-11-30 13:37:44 -0800 [V8] Code generation script misplaces headers 2010-12-01 13:58:46 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Android Linux RESOLVED DUPLICATE 50244 P2 Blocker --- 0 russellbrenner webkit-unassigned japhet levin steveblock oldest_to_newest 315282 0 russellbrenner 2010-11-30 13:37:44 -0800 While merging webkit r72274 onto android, compilation errors were found in the output of CodeGeneratorV8.pm associated with these native types: SVGListPropertyTearOff, SVGStaticListPropertyTearOff, and SVGTransformListPropertyTearOff. The problem is resolved by moving associated header files from $implIncludes to $headerIncludes (patch to follow shortly). 315290 1 75198 russellbrenner 2010-11-30 13:47:17 -0800 Created attachment 75198 proposed patch 315692 2 75198 steveblock 2010-12-01 09:31:52 -0800 Comment on attachment 75198 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=75198&action=review Set cq? if you'd like the reviewer to land the patch via the commit queue once it's r+'ed. > WebCore/ChangeLog:5 > + [V8] Code generation script misplaces headers Use spaces, not tabs. > WebCore/ChangeLog:13 > + All WebCore ChangeLog entries need a line saying which (new) tests they're covered by, or why no tests are required. Here 'Build fix only, no new tests' is OK. 315705 3 75281 russellbrenner 2010-12-01 09:55:21 -0800 Created attachment 75281 proposed patch Replaced tabs with spaces and added line for "no new tests" in ChangeLog. 315715 4 75281 steveblock 2010-12-01 10:16:51 -0800 Comment on attachment 75281 proposed patch LGTM, but there's no point me setting cq+ because it looks like you need to rebase (the try-bots failed to apply the patch). 315847 5 russellbrenner 2010-12-01 13:14:16 -0800 *** This bug has been marked as a duplicate of bug 50244 *** 315859 6 75281 levin 2010-12-01 13:30:39 -0800 Comment on attachment 75281 proposed patch Cleared flags on obsolete patch. 315862 7 75318 steveblock 2010-12-01 13:40:19 -0800 Created attachment 75318 Patch 315869 8 75318 steveblock 2010-12-01 13:58:46 -0800 Comment on attachment 75318 Patch No longer required 75198 2010-11-30 13:47:17 -0800 2010-12-01 09:55:21 -0800 proposed patch bug-50271.patch text/plain 1847 russellbrenner SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3Mjk1OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMTEtMzAgIFJ1c3NlbGwgQnJlbm5lciAgPHJ1c3NlbGxicmVu bmVyQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KwlbVjhdIENvZGUgZ2VuZXJhdGlvbiBzY3JpcHQgbWlzcGxhY2VzIGhlYWRlcnMKKwlodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTAyNzEKKworCUluIEdldFNWR1Byb3Bl cnR5VHlwZXMsIHdoZW4gdGhlIG5hdGl2ZSB0eXBlIGlzIFNWR0xpc3RQcm9wZXJ0eVRlYXJPZmYs CisJU1ZHU3RhdGljTGlzdFByb3BlcnR5VGVhck9mZiwgb3IgU1ZHVHJhbnNmb3JtTGlzdFByb3Bl cnR5VGVhck9mZiwKKwlhc3NvY2lhdGVkIGhlYWRlcnMgYXJlIG5lZWRlZCBieSB0aGUgZ2VuZXJh dGVkIC5oIGZpbGVzLCBzbyB0aGV5IGJlbG9uZworCWluICRoZWFkZXJJbmNsdWRlcyByYXRoZXIg dGhhbiAkaW1wbEluY2x1ZGVzLgorCQorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2Rl R2VuZXJhdG9yVjgucG06CisKIDIwMTAtMTEtMzAgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtc2Fu Y2hlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IENocmlzIEZsZWl6YWNoLgpJ bmRleDogV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCShyZXZp c2lvbiA3MjI3NCkKKysrIFdlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgu cG0JKHdvcmtpbmcgY29weSkKQEAgLTIwMSwxMSArMjAxLDExIEBACiAgICAgICAgICRpbXBsSW5j bHVkZXN7IlNWR0FuaW1hdGVkUHJvcGVydHlUZWFyT2ZmLmgifSA9IDE7CiAgICAgfSBlbHNpZiAo JHN2Z05hdGl2ZVR5cGUgPX4gL1NWR0xpc3RQcm9wZXJ0eVRlYXJPZmYvIG9yICRzdmdOYXRpdmVU eXBlID1+IC9TVkdTdGF0aWNMaXN0UHJvcGVydHlUZWFyT2ZmLykgewogICAgICAgICAkc3ZnTGlz dFByb3BlcnR5VHlwZSA9ICRzdmdXcmFwcGVkTmF0aXZlVHlwZTsKLSAgICAgICAgJGltcGxJbmNs dWRlc3siU1ZHQW5pbWF0ZWRMaXN0UHJvcGVydHlUZWFyT2ZmLmgifSA9IDE7CisgICAgICAgICRo ZWFkZXJJbmNsdWRlc3siU1ZHQW5pbWF0ZWRMaXN0UHJvcGVydHlUZWFyT2ZmLmgifSA9IDE7CiAg ICAgfSBlbHNpZiAoJHN2Z05hdGl2ZVR5cGUgPX4gL1NWR1RyYW5zZm9ybUxpc3RQcm9wZXJ0eVRl YXJPZmYvKSB7CiAgICAgICAgICRzdmdMaXN0UHJvcGVydHlUeXBlID0gJHN2Z1dyYXBwZWROYXRp dmVUeXBlOwotICAgICAgICAkaW1wbEluY2x1ZGVzeyJTVkdBbmltYXRlZExpc3RQcm9wZXJ0eVRl YXJPZmYuaCJ9ID0gMTsKLSAgICAgICAgJGltcGxJbmNsdWRlc3siU1ZHVHJhbnNmb3JtTGlzdFBy b3BlcnR5VGVhck9mZi5oIn0gPSAxOworICAgICAgICAkaGVhZGVySW5jbHVkZXN7IlNWR0FuaW1h dGVkTGlzdFByb3BlcnR5VGVhck9mZi5oIn0gPSAxOworICAgICAgICAkaGVhZGVySW5jbHVkZXN7 IlNWR1RyYW5zZm9ybUxpc3RQcm9wZXJ0eVRlYXJPZmYuaCJ9ID0gMTsKICAgICB9CiAKICAgICBp ZiAoJHN2Z1Byb3BlcnR5VHlwZSkgewo= 75281 2010-12-01 09:55:21 -0800 2010-12-01 13:40:13 -0800 proposed patch bug-50271-a.patch text/plain 1935 russellbrenner SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3Mjk1OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMTEtMzAgIFJ1c3NlbGwgQnJlbm5lciAgPHJ1c3NlbGxicmVu bmVyQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgW1Y4XSBDb2RlIGdlbmVyYXRpb24gc2NyaXB0IG1pc3BsYWNlcyBoZWFkZXJzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MDI3MQorCisg ICAgICAgIEluIEdldFNWR1Byb3BlcnR5VHlwZXMsIHdoZW4gdGhlIG5hdGl2ZSB0eXBlIGlzIFNW R0xpc3RQcm9wZXJ0eVRlYXJPZmYsCisgICAgICAgIFNWR1N0YXRpY0xpc3RQcm9wZXJ0eVRlYXJP ZmYsIG9yIFNWR1RyYW5zZm9ybUxpc3RQcm9wZXJ0eVRlYXJPZmYsCisgICAgICAgIGFzc29jaWF0 ZWQgaGVhZGVycyBhcmUgbmVlZGVkIGJ5IHRoZSBnZW5lcmF0ZWQgLmggZmlsZXMsIHNvIHRoZXkg YmVsb25nCisgICAgICAgIGluICRoZWFkZXJJbmNsdWRlcyByYXRoZXIgdGhhbiAkaW1wbEluY2x1 ZGVzLgorICAgICAgICAKKyAgICAgICAgQnVpbGQgZml4IG9ubHksIG5vIG5ldyB0ZXN0cy4KKwor ICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtOgorCiAyMDEwLTEx LTMwICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBDaHJpcyBGbGVpemFjaC4KSW5kZXg6IFdlYkNvcmUvYmluZGluZ3Mvc2Ny aXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy9z Y3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQkocmV2aXNpb24gNzIyNzQpCisrKyBXZWJDb3JlL2Jp bmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCSh3b3JraW5nIGNvcHkpCkBAIC0yMDEs MTEgKzIwMSwxMSBAQAogICAgICAgICAkaW1wbEluY2x1ZGVzeyJTVkdBbmltYXRlZFByb3BlcnR5 VGVhck9mZi5oIn0gPSAxOwogICAgIH0gZWxzaWYgKCRzdmdOYXRpdmVUeXBlID1+IC9TVkdMaXN0 UHJvcGVydHlUZWFyT2ZmLyBvciAkc3ZnTmF0aXZlVHlwZSA9fiAvU1ZHU3RhdGljTGlzdFByb3Bl cnR5VGVhck9mZi8pIHsKICAgICAgICAgJHN2Z0xpc3RQcm9wZXJ0eVR5cGUgPSAkc3ZnV3JhcHBl ZE5hdGl2ZVR5cGU7Ci0gICAgICAgICRpbXBsSW5jbHVkZXN7IlNWR0FuaW1hdGVkTGlzdFByb3Bl cnR5VGVhck9mZi5oIn0gPSAxOworICAgICAgICAkaGVhZGVySW5jbHVkZXN7IlNWR0FuaW1hdGVk TGlzdFByb3BlcnR5VGVhck9mZi5oIn0gPSAxOwogICAgIH0gZWxzaWYgKCRzdmdOYXRpdmVUeXBl ID1+IC9TVkdUcmFuc2Zvcm1MaXN0UHJvcGVydHlUZWFyT2ZmLykgewogICAgICAgICAkc3ZnTGlz dFByb3BlcnR5VHlwZSA9ICRzdmdXcmFwcGVkTmF0aXZlVHlwZTsKLSAgICAgICAgJGltcGxJbmNs dWRlc3siU1ZHQW5pbWF0ZWRMaXN0UHJvcGVydHlUZWFyT2ZmLmgifSA9IDE7Ci0gICAgICAgICRp bXBsSW5jbHVkZXN7IlNWR1RyYW5zZm9ybUxpc3RQcm9wZXJ0eVRlYXJPZmYuaCJ9ID0gMTsKKyAg ICAgICAgJGhlYWRlckluY2x1ZGVzeyJTVkdBbmltYXRlZExpc3RQcm9wZXJ0eVRlYXJPZmYuaCJ9 ID0gMTsKKyAgICAgICAgJGhlYWRlckluY2x1ZGVzeyJTVkdUcmFuc2Zvcm1MaXN0UHJvcGVydHlU ZWFyT2ZmLmgifSA9IDE7CiAgICAgfQogCiAgICAgaWYgKCRzdmdQcm9wZXJ0eVR5cGUpIHsK 75318 2010-12-01 13:40:19 -0800 2010-12-01 13:58:46 -0800 Patch bug-50271-20101201214017.patch text/plain 1666 steveblock SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MzA2MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMTItMDEgIFJ1c3NlbGwgQnJlbm5lciAgPHJ1c3NlbGxicmVu bmVyQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgW1Y4XSBDb2RlIGdlbmVyYXRpb24gc2NyaXB0IG1pc3BsYWNlcyBoZWFkZXJzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MDI3MQorCisg ICAgICAgIEluIEdldFNWR1Byb3BlcnR5VHlwZXMsIHdoZW4gdGhlIG5hdGl2ZSB0eXBlIGlzIFNW R0xpc3RQcm9wZXJ0eVRlYXJPZmYKKyAgICAgICAgb3IgU1ZHU3RhdGljTGlzdFByb3BlcnR5VGVh ck9mZiwgYXNzb2NpYXRlZCBoZWFkZXJzIGFyZSBuZWVkZWQgYnkgdGhlCisgICAgICAgIGdlbmVy YXRlZCAuaCBmaWxlcywgc28gdGhleSBiZWxvbmcgaW4gJGhlYWRlckluY2x1ZGVzIHJhdGhlciB0 aGFuCisgICAgICAgICRpbXBsSW5jbHVkZXMuCisKKyAgICAgICAgQnVpbGQgZml4IG9ubHksIG5v IG5ldyB0ZXN0cy4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4 LnBtOgorCiAyMDEwLTEyLTAxICBEYXZpZCBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFdlYkNvcmUvYmluZGluZ3Mvc2Ny aXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy9z Y3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQkocmV2aXNpb24gNzMwNjMpCisrKyBXZWJDb3JlL2Jp bmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCSh3b3JraW5nIGNvcHkpCkBAIC0yMDEs NyArMjAxLDcgQEAgc3ViIEdldFNWR1Byb3BlcnR5VHlwZXMKICAgICAgICAgJGltcGxJbmNsdWRl c3siU1ZHQW5pbWF0ZWRQcm9wZXJ0eVRlYXJPZmYuaCJ9ID0gMTsKICAgICB9IGVsc2lmICgkc3Zn TmF0aXZlVHlwZSA9fiAvU1ZHTGlzdFByb3BlcnR5VGVhck9mZi8gb3IgJHN2Z05hdGl2ZVR5cGUg PX4gL1NWR1N0YXRpY0xpc3RQcm9wZXJ0eVRlYXJPZmYvKSB7CiAgICAgICAgICRzdmdMaXN0UHJv cGVydHlUeXBlID0gJHN2Z1dyYXBwZWROYXRpdmVUeXBlOwotICAgICAgICAkaW1wbEluY2x1ZGVz eyJTVkdBbmltYXRlZExpc3RQcm9wZXJ0eVRlYXJPZmYuaCJ9ID0gMTsKKyAgICAgICAgJGhlYWRl ckluY2x1ZGVzeyJTVkdBbmltYXRlZExpc3RQcm9wZXJ0eVRlYXJPZmYuaCJ9ID0gMTsKICAgICB9 IGVsc2lmICgkc3ZnTmF0aXZlVHlwZSA9fiAvU1ZHVHJhbnNmb3JtTGlzdFByb3BlcnR5VGVhck9m Zi8pIHsKICAgICAgICAgJHN2Z0xpc3RQcm9wZXJ0eVR5cGUgPSAkc3ZnV3JhcHBlZE5hdGl2ZVR5 cGU7CiAgICAgICAgICRoZWFkZXJJbmNsdWRlc3siU1ZHQW5pbWF0ZWRMaXN0UHJvcGVydHlUZWFy T2ZmLmgifSA9IDE7Cg==