<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>50258</bug_id>
          
          <creation_ts>2010-11-30 11:52:28 -0800</creation_ts>
          <short_desc>[chromium] enable WebCore compiler warnings on Linux take 3</short_desc>
          <delta_ts>2010-11-30 13:49:57 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Tony Chang">tony</reporter>
          <assigned_to name="Tony Chang">tony</assigned_to>
          <cc>jamesr</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>315209</commentid>
    <comment_count>0</comment_count>
    <who name="Tony Chang">tony</who>
    <bug_when>2010-11-30 11:52:28 -0800</bug_when>
    <thetext>[chromium] enable WebCore compiler warnings on Linux take 3</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>315211</commentid>
    <comment_count>1</comment_count>
      <attachid>75177</attachid>
    <who name="Tony Chang">tony</who>
    <bug_when>2010-11-30 11:53:16 -0800</bug_when>
    <thetext>Created attachment 75177
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>315212</commentid>
    <comment_count>2</comment_count>
    <who name="Tony Chang">tony</who>
    <bug_when>2010-11-30 11:53:49 -0800</bug_when>
    <thetext>See https://bugs.webkit.org/show_bug.cgi?id=50168 for the compiler error we were getting.

This passes on my hardy machine in Release.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>315221</commentid>
    <comment_count>3</comment_count>
      <attachid>75177</attachid>
    <who name="James Robinson">jamesr</who>
    <bug_when>2010-11-30 12:02:08 -0800</bug_when>
    <thetext>Comment on attachment 75177
Patch

Fingers crossed!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>315293</commentid>
    <comment_count>4</comment_count>
    <who name="Tony Chang">tony</who>
    <bug_when>2010-11-30 13:49:57 -0800</bug_when>
    <thetext>Committed r72960: &lt;http://trac.webkit.org/changeset/72960&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>75177</attachid>
            <date>2010-11-30 11:53:16 -0800</date>
            <delta_ts>2010-11-30 12:02:08 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-50258-20101130115401.patch</filename>
            <type>text/plain</type>
            <size>2308</size>
            <attacher name="Tony Chang">tony</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
MTI2OTNiYjI0NWFjMWY0ZjhjZGE3MmZlZGI3NDgxNWMwNDZkNjlmYi4uOTM2NWI1OGZhOGRjY2Q2
N2MwZDA5ZmQ0MDZlN2MyMWU5NjI4MGFmNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK
KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0xMS0zMCAgVG9u
eSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gZW5hYmxlIFdlYkNvcmUgY29tcGlsZXIg
d2FybmluZ3Mgb24gTGludXggdGFrZSAzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn
L3Nob3dfYnVnLmNnaT9pZD01MDI1OAorCisgICAgICAgICogV2ViQ29yZS5neXAvV2ViQ29yZS5n
eXA6CisKIDIwMTAtMTEtMzAgIFZpdGFseSBSZXBlc2hrbyAgPHZpdGFseXJAY2hyb21pdW0ub3Jn
PgogCiAgICAgICAgIFVucmV2aWV3ZWQuCmRpZmYgLS1naXQgYS9XZWJDb3JlL1dlYkNvcmUuZ3lw
L1dlYkNvcmUuZ3lwIGIvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cAppbmRleCA0MWZh
ZWEyOGFiOWMyZGU5ZTE5NDFiYWY2OGEwYjI3OWE1ZGU2ZTliLi43OTc5ZDFmYjc0YTI1NWM1Nzg0
ZDg1NDExY2JiNjQzN2Q4YjllYmIyIDEwMDY0NAotLS0gYS9XZWJDb3JlL1dlYkNvcmUuZ3lwL1dl
YkNvcmUuZ3lwCisrKyBiL1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5neXAKQEAgLTI0NSw5
ICsyNDUsNiBAQAogICAgICAgICAgICcuLi9wbGF0Zm9ybS9tYWMnLAogICAgICAgICAgICcuLi9w
bGF0Zm9ybS90ZXh0L21hYycsCiAgICAgICAgIF0sCi0gICAgICAgICMgZW5hYmxlIC1XYWxsIGFu
ZCAtV2Vycm9yLCBqdXN0IGZvciBMaW51eCBidWlsZHMgZm9yIG5vdwotICAgICAgICAjIEZJWE1F
OiBBbHNvIGVuYWJsZSB0aGlzIGZvciBMaW51eC9XaW5kb3dzIGFmdGVyIHZlcmlmeWluZyBubyB3
YXJuaW5ncwotICAgICAgICAnY2hyb21pdW1fY29kZSc6IDEsCiAgICAgICB9XSwKICAgICAgIFsn
T1M9PSJ3aW4iJywgewogICAgICAgICAnd2ViY29yZV9pbmNsdWRlX2RpcnMnOiBbCkBAIC0yNTYs
NiArMjUzLDEwIEBACiAgICAgICAgICAgJy4uL3BsYXRmb3JtL3RleHQvd2luJywKICAgICAgICAg
ICAnLi4vcGxhdGZvcm0vd2luJywKICAgICAgICAgXSwKKyAgICAgIH0seworICAgICAgICAjIGVu
YWJsZSAtV2FsbCBhbmQgLVdlcnJvciwganVzdCBmb3IgTWFjIGFuZCBMaW51eCBidWlsZHMgZm9y
IG5vdworICAgICAgICAjIEZJWE1FOiBBbHNvIGVuYWJsZSB0aGlzIGZvciBXaW5kb3dzIGFmdGVy
IHZlcmlmeWluZyBubyB3YXJuaW5ncworICAgICAgICAnY2hyb21pdW1fY29kZSc6IDEsCiAgICAg
ICB9XSwKICAgICAgIFsnT1M9PSJ3aW4iIGFuZCBidWlsZHR5cGU9PSJPZmZpY2lhbCInLCB7CiAg
ICAgICAgICMgT24gd2luZG93cyBvZmZpY2lhbCByZWxlYXNlIGJ1aWxkcywgd2UgdHJ5IHRvIHBy
ZXNlcnZlIHN5bWJvbCBzcGFjZS4KQEAgLTI3Myw3ICsyNzQsNyBAQAogICAgICAgICAgICc8KFNI
QVJFRF9JTlRFUk1FRElBVEVfRElSKS93ZWJraXQvYmluZGluZ3MvVjhEZXJpdmVkU291cmNlczcu
Y3BwJywKICAgICAgICAgICAnPChTSEFSRURfSU5URVJNRURJQVRFX0RJUikvd2Via2l0L2JpbmRp
bmdzL1Y4RGVyaXZlZFNvdXJjZXM4LmNwcCcsCiAgICAgICAgIF0sCi0gICAgICB9XQorICAgICAg
fV0sCiAgICAgXSwKICAgfSwKICAgJ3RhcmdldHMnOiBbCkBAIC0xMzM4LDYgKzEzMzksMTEgQEAK
ICAgICAgICAgICAgIFsnZXhjbHVkZScsICdyZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJvbWl1bVNr
aWFcXC5jcHAkJ10sCiAgICAgICAgICAgXSwKICAgICAgICAgfV0sCisgICAgICAgIFsnKE9TPT0i
bGludXgiIG9yIE9TPT0iZnJlZWJzZCIgb3IgT1M9PSJvcGVuYnNkIikgYW5kIGdjY192ZXJzaW9u
PT00MicsIHsKKyAgICAgICAgICAjIER1ZSB0byBhIGJ1ZyBpbiBnY2MgNC4yLjEgKHRoZSBjdXJy
ZW50IHZlcnNpb24gb24gaGFyZHkpLCB3ZSBnZXQKKyAgICAgICAgICAjIHdhcm5pbmdzIGFib3V0
IHVuaW5pdGlhbGl6ZWQgdGhpcy43LgorICAgICAgICAgICdjZmxhZ3MnOiBbJy1Xbm8tdW5pbml0
aWFsaXplZCddLAorICAgICAgICB9XSwKICAgICAgICAgWydPUyE9ImxpbnV4IiBhbmQgT1MhPSJm
cmVlYnNkIicsIHsKICAgICAgICAgICAnc291cmNlcy8nOiBbCiAgICAgICAgICAgICBbJ2V4Y2x1
ZGUnLCAnKEd0a3xMaW51eClcXC5jcHAkJ10sCg==
</data>
<flag name="review"
          id="65933"
          type_id="1"
          status="+"
          setter="jamesr"
    />
          </attachment>
      

    </bug>

</bugzilla>