50256 2010-11-30 11:37:48 -0800 Web Inspector: [CRASH] on "Revert to this revision" of style with import. 2011-11-21 06:43:41 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman abarth apavlov bweinstein eric joepeck keishi loislo pfeldman pmuellr rik webkit.review.bot yurys oldest_to_newest 315198 0 pfeldman 2010-11-30 11:37:48 -0800 1. Go to apple.com 2. Open inspector 3. edit font-size in body's selector 4. Revert to original in the resources tab CRASH: #0 0x1016cdc81 in WebCore::Document::removePendingSheet at Document.cpp:2856 #1 0x10195e1ce in WebCore::HTMLLinkElement::sheetLoaded at HTMLLinkElement.cpp:362 #2 0x10167bc70 in WebCore::CSSStyleSheet::checkLoaded at CSSStyleSheet.cpp:232 #3 0x102024bf1 in WebCore::StyleBase::checkLoaded at StyleBase.cpp:40 #4 0x10167bc3b in WebCore::CSSStyleSheet::checkLoaded at CSSStyleSheet.cpp:226 #5 0x1015f0283 in WebCore::CSSImportRule::setCSSStyleSheet at CSSImportRule.cpp:104 #6 0x10153f545 in WebCore::CachedCSSStyleSheet::didAddClient at CachedCSSStyleSheet.cpp:57 #7 0x1015470a7 in WebCore::CachedResource::addClient at CachedResource.cpp:216 #8 0x1015ef8c7 in WebCore::CSSImportRule::insertedIntoParent at CSSImportRule.cpp:148 #9 0x102029f82 in WebCore::StyleList::append at StyleList.cpp:35 #10 0x1015e4848 in cssyyparse at CSSGrammar.y:385 #11 0x10160d2e3 in WebCore::CSSParser::parseSheet at CSSParser.cpp:233 #12 0x10167bf98 in WebCore::CSSStyleSheet::parseStringAtLine at CSSStyleSheet.cpp:206 #13 0x10167bff3 in WebCore::CSSStyleSheet::parseString at CSSStyleSheet.cpp:199 #14 0x101a91e4d in WebCore::InspectorStyleSheet::reparseStyleSheet at InspectorStyleSheet.cpp:590 #15 0x101a2ffa2 in WebCore::InspectorCSSAgent::setStyleSheetText2 at InspectorCSSAgent.cpp:298 Here is where it crashes: // This method is called whenever a top-level stylesheet has finished loading. void Document::removePendingSheet() { // Make sure we knew this sheet was pending, and that our count isn't out of sync. ASSERT(m_pendingStylesheets > 0); m_pendingStylesheets--; 315300 1 75200 pfeldman 2010-11-30 14:04:24 -0800 Created attachment 75200 [PATCH] Proposed fix. 315305 2 75200 hyatt 2010-11-30 14:11:04 -0800 Comment on attachment 75200 [PATCH] Proposed fix. r=me 315450 3 pfeldman 2010-11-30 17:42:43 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/css/CSSImportRule.cpp Committed r72988 315473 4 webkit.review.bot 2010-11-30 18:31:44 -0800 http://trac.webkit.org/changeset/72988 might have broken Qt Linux ARMv5 Release 318067 5 pfeldman 2010-12-06 22:55:57 -0800 (this fix is being rolled out due to https://bugs.webkit.org/show_bug.cgi?id=50502) 321760 6 75200 eric 2010-12-14 01:26:04 -0800 Comment on attachment 75200 [PATCH] Proposed fix. Marking r- since this was rolled out. 506919 7 apavlov 2011-11-21 06:43:41 -0800 This is no longer crashing, fixed a while ago under a different bug. 75200 2010-11-30 14:04:24 -0800 2010-12-14 01:26:04 -0800 [PATCH] Proposed fix. imported text/plain 1471 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDFhZWVhYS4uZTFmOWM2YyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOCBAQAogMjAxMC0xMS0zMCAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBbQ1JBU0hdIG9uICJSZXZlcnQgdG8g dGhpcyByZXZpc2lvbiIgb2Ygc3R5bGUgd2l0aCBpbXBvcnQuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MDI1NgorCisgICAgICAgIFJvbGxlZCBiYWNr IG9uZSBsaW5lIGZyb20gaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMzY5MDQgYXMg YWdyZWVkIHdpdGgKKyAgICAgICAgRGF2aWQuCisKKyAgICAgICAgKiBjc3MvQ1NTSW1wb3J0UnVs ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NJbXBvcnRSdWxlOjppbnNlcnRlZEludG9QYXJl bnQpOgorCisyMDEwLTExLTMwICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3Jn PgorCiAgICAgICAgIFJldmlld2VkIGJ5IFl1cnkgU2VtaWtoYXRza3kuCiAKICAgICAgICAgV2Vi IEluc3BlY3RvcjogaW1wbGVtZW50ICJSZXZlcnQgdG8gdGhpcyByZXZpc2lvbiIgaW4gcmVzb3Vy Y2VzIHBhbmVsLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9jc3MvQ1NTSW1wb3J0UnVsZS5jcHAgYi9X ZWJDb3JlL2Nzcy9DU1NJbXBvcnRSdWxlLmNwcAppbmRleCA4MWFkZTM5Li5hMTFjMzFjIDEwMDY0 NAotLS0gYS9XZWJDb3JlL2Nzcy9DU1NJbXBvcnRSdWxlLmNwcAorKysgYi9XZWJDb3JlL2Nzcy9D U1NJbXBvcnRSdWxlLmNwcApAQCAtMTQyLDcgKzE0Miw3IEBAIHZvaWQgQ1NTSW1wb3J0UnVsZTo6 aW5zZXJ0ZWRJbnRvUGFyZW50KCkKICAgICAgICAgLy8gaWYgdGhlIGltcG9ydCBydWxlIGlzIGlz c3VlZCBkeW5hbWljYWxseSwgdGhlIHNoZWV0IG1heSBiZQogICAgICAgICAvLyByZW1vdmVkIGZy b20gdGhlIHBlbmRpbmcgc2hlZXQgY291bnQsIHNvIGxldCB0aGUgZG9jIGtub3cKICAgICAgICAg Ly8gdGhlIHNoZWV0IGJlaW5nIGltcG9ydGVkIGlzIHBlbmRpbmcuCi0gICAgICAgIGlmIChwYXJl bnRTaGVldCAmJiBwYXJlbnRTaGVldC0+bG9hZENvbXBsZXRlZCgpICYmIHJvb3QgPT0gcGFyZW50 U2hlZXQpCisgICAgICAgIGlmIChwYXJlbnRTaGVldCAmJiBwYXJlbnRTaGVldC0+bG9hZENvbXBs ZXRlZCgpICYmIHBhcmVudFNoZWV0LT5kb2N1bWVudCgpKQogICAgICAgICAgICAgcGFyZW50U2hl ZXQtPmRvY3VtZW50KCktPmFkZFBlbmRpbmdTaGVldCgpOwogICAgICAgICBtX2xvYWRpbmcgPSB0 cnVlOwogICAgICAgICBtX2NhY2hlZFNoZWV0LT5hZGRDbGllbnQodGhpcyk7Cg==