50252 2010-11-30 11:04:33 -0800 [GTK] Fix compilation warnings reported by clang 2010-12-05 11:22:28 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 alex webkit-unassigned mrobinson webkit.review.bot xan.lopez oldest_to_newest 315168 0 alex 2010-11-30 11:04:33 -0800 Running with clang outputs some warnings, there are still other issues that avoid the compilation that we will probably have to fix before in other projects to have the complete support. 315220 1 75179 alex 2010-11-30 12:01:22 -0800 Created attachment 75179 Proposed patch 315223 2 webkit.review.bot 2010-11-30 12:03:10 -0800 Attachment 75179 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebCore/ChangeLog', u'WebCore/platform/graphics/Path.h', u'WebCore/platform/network/soup/ResourceHandleSoup.cpp', u'WebKitTools/ChangeLog', u'WebKitTools/GtkLauncher/main.c']" exit_code: 1 WebKitTools/GtkLauncher/main.c:221: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 315225 3 alex 2010-11-30 12:07:17 -0800 (In reply to comment #2) > Attachment 75179 [details] did not pass style-queue: > > Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebCore/ChangeLog', u'WebCore/platform/graphics/Path.h', u'WebCore/platform/network/soup/ResourceHandleSoup.cpp', u'WebKitTools/ChangeLog', u'WebKitTools/GtkLauncher/main.c']" exit_code: 1 > WebKitTools/GtkLauncher/main.c:221: Extra space before ( in function call [whitespace/parens] [4] > Total errors found: 1 in 5 files > False positive, that file has gtk style, not sure if we should change that at some point. 315226 4 75179 xan.lopez 2010-11-30 12:10:24 -0800 Comment on attachment 75179 Proposed patch Should either make GtkLauncher follow WebKit style or make an exception in the script. My vote goes for the former. 315229 5 alex 2010-11-30 12:15:49 -0800 (In reply to comment #4) > (From update of attachment 75179 [details]) > Should either make GtkLauncher follow WebKit style or make an exception in the script. My vote goes for the former. I agree, I'll upload another bug for that. 317396 6 alex 2010-12-05 11:22:28 -0800 landed http://trac.webkit.org/changeset/73344 75179 2010-11-30 12:01:22 -0800 2010-11-30 12:10:24 -0800 Proposed patch 0001-2010-11-30-Alejandro-G.-Castro-alex-igalia.com.patch text/plain 4734 alex RnJvbSBmNjg0OTVhOGQxYWFkMDJmM2I3MDRmYjgyZjQwODBkMzk4MzZlZjI3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGVqYW5kcm8gRy4gQ2FzdHJvIDxhbGV4QGlnYWxpYS5jb20+ CkRhdGU6IFR1ZSwgMzAgTm92IDIwMTAgMjA6MzM6NTMgKzAxMDAKU3ViamVjdDogW1BBVENIXSAy MDEwLTExLTMwICBBbGVqYW5kcm8gRy4gQ2FzdHJvICA8YWxleEBpZ2FsaWEuY29tPgoKICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgW0dUS10gRml4IGNvbXBpbGF0 aW9uIHdhcm5pbmdzIHJlcG9ydGVkIGJ5IGNsYW5nCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTUwMjUyCgogICAgICAgICogR3RrTGF1bmNoZXIvbWFpbi5j OgogICAgICAgIChjcmVhdGVfd2luZG93KTogVGhlIGNyZWF0ZV9zdGF0dXNiYXIgZnVuY3Rpb24g ZG9lcyBub3QgaGF2ZQogICAgICAgIHBhcmFtZXRlcnMuCgoyMDEwLTExLTMwICBBbGVqYW5kcm8g Ry4gQ2FzdHJvICA8YWxleEBpZ2FsaWEuY29tPgoKICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KCiAgICAgICAgW0dUS10gRml4IGNvbXBpbGF0aW9uIHdhcm5pbmdzIHJlcG9ydGVk IGJ5IGNsYW5nCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTUwMjUyCgogICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvUGF0aC5oOiBDYWlyb1BhdGggaXMg bm93IGEgY2xhc3MsIG5vdCBhCiAgICAgICAgc3RydWN0LgogICAgICAgICogcGxhdGZvcm0vbmV0 d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHA6CiAgICAgICAgKFdlYkNvcmU6OnNlbmRS ZXF1ZXN0Q2FsbGJhY2spOiBDYXN0IHRoZSBzdGF0dXNfY29kZSB0byBpbnQuCi0tLQogV2ViQ29y ZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDEyICsrKysr KysrKysrKwogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9QYXRoLmggICAgICAgICAgICAgICAg ICAgfCAgICAyICstCiAuLi4vcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291 cC5jcHAgICB8ICAgIDIgKy0KIFdlYktpdFRvb2xzL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHwgICAxMSArKysrKysrKysrKwogV2ViS2l0VG9vbHMvR3RrTGF1bmNoZXIv bWFpbi5jICAgICAgICAgICAgICAgICAgICAgfCAgICAyICstCiA1IGZpbGVzIGNoYW5nZWQsIDI2 IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFu Z2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4ODg5NjczLi4xNjAzOTJlIDEwMDY0NAot LS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE1IEBACisyMDEwLTExLTMwICBBbGVqYW5kcm8gRy4gQ2FzdHJvICA8YWxleEBpZ2FsaWEuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtd IEZpeCBjb21waWxhdGlvbiB3YXJuaW5ncyByZXBvcnRlZCBieSBjbGFuZworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTAyNTIKKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL1BhdGguaDogQ2Fpcm9QYXRoIGlzIG5vdyBhIGNsYXNzLCBub3QgYQor ICAgICAgICBzdHJ1Y3QuCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNl SGFuZGxlU291cC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpzZW5kUmVxdWVzdENhbGxiYWNrKTog Q2FzdCB0aGUgc3RhdHVzX2NvZGUgdG8gaW50LgorCiAyMDEwLTExLTMwICBEYXJpbiBBZGxlciAg PGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBKb24gSG9uZXljdXR0Lgpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9QYXRoLmggYi9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL1BhdGguaAppbmRleCBiYTI1ZGMyLi40MjNhNzkyIDEwMDY0NAotLS0g YS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1BhdGguaAorKysgYi9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL1BhdGguaApAQCAtNDYsNyArNDYsNyBAQCBjbGFzcyB3eEdyYXBoaWNzUGF0aDsK IHR5cGVkZWYgd3hHcmFwaGljc1BhdGggUGxhdGZvcm1QYXRoOwogI2VsaWYgUExBVEZPUk0oQ0FJ Uk8pCiBuYW1lc3BhY2UgV2ViQ29yZSB7Ci0gICAgc3RydWN0IENhaXJvUGF0aDsKK2NsYXNzIENh aXJvUGF0aDsKIH0KIHR5cGVkZWYgV2ViQ29yZTo6Q2Fpcm9QYXRoIFBsYXRmb3JtUGF0aDsKICNl bGlmIFBMQVRGT1JNKFNLSUEpCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv c291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3Nv dXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcAppbmRleCBjMTkzM2UzLi5hM2ZmZWIyIDEwMDY0NAot LS0gYS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3Bw CisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5j cHAKQEAgLTQ5Miw3ICs0OTIsNyBAQCBzdGF0aWMgdm9pZCBzZW5kUmVxdWVzdENhbGxiYWNrKEdP YmplY3QqIHNvdXJjZSwgR0FzeW5jUmVzdWx0KiByZXMsIGdwb2ludGVyIHVzZQogICAgICAgICBp ZiAoaXNUcmFuc3BvcnRFcnJvciB8fCAoZXJyb3ItPmRvbWFpbiA9PSBHX0lPX0VSUk9SKSkgewog ICAgICAgICAgICAgU291cFVSSSogdXJpID0gd2Via2l0X3NvdXBfcmVxdWVzdF9nZXRfdXJpKGQt Pm1fc291cFJlcXVlc3QuZ2V0KCkpOwogICAgICAgICAgICAgR093blB0cjxjaGFyPiB1cmlTdHIo c291cF91cmlfdG9fc3RyaW5nKHVyaSwgZmFsc2UpKTsKLSAgICAgICAgICAgIGdpbnQgZXJyb3JD b2RlID0gaXNUcmFuc3BvcnRFcnJvciA/IHNvdXBNc2ctPnN0YXR1c19jb2RlIDogZXJyb3ItPmNv ZGU7CisgICAgICAgICAgICBnaW50IGVycm9yQ29kZSA9IGlzVHJhbnNwb3J0RXJyb3IgPyBzdGF0 aWNfY2FzdDxnaW50Pihzb3VwTXNnLT5zdGF0dXNfY29kZSkgOiBlcnJvci0+Y29kZTsKICAgICAg ICAgICAgIGNvbnN0IGdjaGFyKiBlcnJvck1zZyA9IGlzVHJhbnNwb3J0RXJyb3IgPyBzb3VwTXNn LT5yZWFzb25fcGhyYXNlIDogZXJyb3ItPm1lc3NhZ2U7CiAgICAgICAgICAgICBjb25zdCBnY2hh ciogcXVhcmtTdHIgPSBpc1RyYW5zcG9ydEVycm9yID8gZ19xdWFya190b19zdHJpbmcoU09VUF9I VFRQX0VSUk9SKSA6IGdfcXVhcmtfdG9fc3RyaW5nKEdfSU9fRVJST1IpOwogICAgICAgICAgICAg UmVzb3VyY2VFcnJvciByZXNvdXJjZUVycm9yKHF1YXJrU3RyLCBlcnJvckNvZGUsIHVyaVN0ci5n ZXQoKSwgU3RyaW5nOjpmcm9tVVRGOChlcnJvck1zZykpOwpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9v bHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmluZGV4IGM2ODZiOGEuLjIwZjRj NzIgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZworKysgYi9XZWJLaXRUb29scy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0xMS0zMCAgQWxlamFuZHJvIEcuIENhc3Ry byAgPGFsZXhAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBbR1RLXSBGaXggY29tcGlsYXRpb24gd2FybmluZ3MgcmVwb3J0ZWQgYnkg Y2xhbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUw MjUyCisKKyAgICAgICAgKiBHdGtMYXVuY2hlci9tYWluLmM6CisgICAgICAgIChjcmVhdGVfd2lu ZG93KTogVGhlIGNyZWF0ZV9zdGF0dXNiYXIgZnVuY3Rpb24gZG9lcyBub3QgaGF2ZQorICAgICAg ICBwYXJhbWV0ZXJzLgorCiAyMDEwLTExLTI5ICBNaWhhaSBQYXJwYXJpdGEgIDxtaWhhaXBAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRvbnkgQ2hhbmcuCmRpZmYgLS1naXQg YS9XZWJLaXRUb29scy9HdGtMYXVuY2hlci9tYWluLmMgYi9XZWJLaXRUb29scy9HdGtMYXVuY2hl ci9tYWluLmMKaW5kZXggNGFiZWUwOC4uZjc5NjUwZCAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMv R3RrTGF1bmNoZXIvbWFpbi5jCisrKyBiL1dlYktpdFRvb2xzL0d0a0xhdW5jaGVyL21haW4uYwpA QCAtMjE4LDcgKzIxOCw3IEBAIGNyZWF0ZV93aW5kb3cgKFdlYktpdFdlYlZpZXcqKiBvdXRfd2Vi X3ZpZXcpCiAgICAgdXJpX2VudHJ5ID0gZ3RrX2VudHJ5X25ldyAoKTsKIAogICAgIHZib3ggPSBn dGtfdmJveF9uZXcgKEZBTFNFLCAwKTsKLSAgICBzdGF0dXNiYXIgPSBjcmVhdGVfc3RhdHVzYmFy ICh3ZWJfdmlldyk7CisgICAgc3RhdHVzYmFyID0gY3JlYXRlX3N0YXR1c2JhciAoKTsKICAgICBn dGtfYm94X3BhY2tfc3RhcnQgKEdUS19CT1ggKHZib3gpLCBjcmVhdGVfdG9vbGJhciAodXJpX2Vu dHJ5LCB3ZWJfdmlldyksIEZBTFNFLCBGQUxTRSwgMCk7CiAgICAgZ3RrX2JveF9wYWNrX3N0YXJ0 IChHVEtfQk9YICh2Ym94KSwgY3JlYXRlX2Jyb3dzZXIgKHdpbmRvdywgdXJpX2VudHJ5LCBzdGF0 dXNiYXIsIHdlYl92aWV3KSwgVFJVRSwgVFJVRSwgMCk7CiAgICAgZ3RrX2JveF9wYWNrX3N0YXJ0 IChHVEtfQk9YICh2Ym94KSwgc3RhdHVzYmFyLCBGQUxTRSwgRkFMU0UsIDApOwotLSAKMS43LjIu MwoK