50249 2010-11-30 10:51:31 -0800 Web Inspector: disable cookies tab in network resource view by default, enable for chromium 2010-12-01 05:30:11 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 caseq caseq apavlov bweinstein commit-queue joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 315155 0 caseq 2010-11-30 10:51:31 -0800 Cookies view support in network resource view is conditional on browser support for raw headers (request cookies are added in the browser after inspector receives willSendRequest; response cookies need LF ("\n") to be used when coalescing headers). Disabling cookies tab by default, re-enabling it for Chromium. 315176 1 75171 caseq 2010-11-30 11:14:40 -0800 Created attachment 75171 patch 315604 2 75171 commit-queue 2010-12-01 05:30:05 -0800 Comment on attachment 75171 patch Clearing flags on attachment: 75171 Committed r73017: <http://trac.webkit.org/changeset/73017> 315605 3 commit-queue 2010-12-01 05:30:11 -0800 All reviewed patches have been landed. Closing bug. 75171 2010-11-30 11:14:40 -0800 2010-12-01 05:30:04 -0800 patch disable-cookies-tab.diff text/plain 3892 caseq ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NDM3YjhhMy4uMGExYjhhYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0xMS0zMCAgQW5kcmV5IEtvc3lh a292ICA8Y2FzZXFAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IGRpc2FibGUgY29va2llcyB0YWIgaW4g bmV0d29yayByZXNvdXJjZSB2aWV3IGJ5IGRlZmF1bHQsIGVuYWJsZSBmb3IgY2hyb21pdW0KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUwMjQ5CisKKyAg ICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL05ldHdvcmtJdGVtVmlldy5qczoKKyAgICAgICAg KFdlYkluc3BlY3Rvci5OZXR3b3JrSXRlbVZpZXcpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLk5l dHdvcmtJdGVtVmlldy5wcm90b3R5cGUucmVzaXplKToKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJv bnQtZW5kL1NldHRpbmdzLmpzOgorCiAyMDEwLTExLTI5ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5m cmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9qYW4gVmFmYWkuCmRpZmYg LS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvTmV0d29ya0l0ZW1WaWV3LmpzIGIv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL05ldHdvcmtJdGVtVmlldy5qcwppbmRleCA5Mjdl ODQwLi40OGUzYjE5IDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvTmV0 d29ya0l0ZW1WaWV3LmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9OZXR3b3Jr SXRlbVZpZXcuanMKQEAgLTM3LDcgKzM3LDYgQEAgV2ViSW5zcGVjdG9yLk5ldHdvcmtJdGVtVmll dyA9IGZ1bmN0aW9uKHJlc291cmNlKQogICAgIHRoaXMuX2hlYWRlcnNWaWV3ID0gbmV3IFdlYklu c3BlY3Rvci5SZXNvdXJjZUhlYWRlcnNWaWV3KHJlc291cmNlKTsKICAgICAvLyBEbyBub3Qgc3Rv cmUgcmVmZXJlbmNlIHRvIGNvbnRlbnQgdmlldyAtIGl0IGNhbiBiZSByZWNyZWF0ZWQuCiAgICAg dmFyIGNvbnRlbnRWaWV3ID0gV2ViSW5zcGVjdG9yLlJlc291cmNlTWFuYWdlci5yZXNvdXJjZVZp ZXdGb3JSZXNvdXJjZShyZXNvdXJjZSk7Ci0gICAgdGhpcy5fY29va2llc1ZpZXcgPSBuZXcgV2Vi SW5zcGVjdG9yLlJlc291cmNlQ29va2llc1ZpZXcocmVzb3VyY2UpOwogCiAgICAgdGhpcy5fdGFi YmVkUGFuZSA9IG5ldyBXZWJJbnNwZWN0b3IuVGFiYmVkUGFuZSh0aGlzLmVsZW1lbnQpOwogICAg IHRoaXMuX3RhYmJlZFBhbmUuYXBwZW5kVGFiKCJoZWFkZXJzIiwgV2ViSW5zcGVjdG9yLlVJU3Ry aW5nKCJIZWFkZXJzIiksIHRoaXMuX2hlYWRlcnNWaWV3KTsKQEAgLTQ2LDggKzQ1LDEwIEBAIFdl Ykluc3BlY3Rvci5OZXR3b3JrSXRlbVZpZXcgPSBmdW5jdGlvbihyZXNvdXJjZSkKICAgICAgICAg Y29udGVudFZpZXcudmlzaWJsZSA9IGZhbHNlOwogICAgICAgICB0aGlzLl90YWJiZWRQYW5lLmFw cGVuZFRhYigiY29udGVudCIsIFdlYkluc3BlY3Rvci5VSVN0cmluZygiQ29udGVudCIpLCBjb250 ZW50Vmlldyk7CiAgICAgfQotICAgIHRoaXMuX3RhYmJlZFBhbmUuYXBwZW5kVGFiKCJjb29raWVz IiwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJDb29raWVzIiksIHRoaXMuX2Nvb2tpZXNWaWV3KTsK LQorICAgIGlmIChQcmVmZXJlbmNlcy5zaG93Q29va2llc1RhYikgeworICAgICAgICB0aGlzLl9j b29raWVzVmlldyA9IG5ldyBXZWJJbnNwZWN0b3IuUmVzb3VyY2VDb29raWVzVmlldyhyZXNvdXJj ZSk7CisgICAgICAgIHRoaXMuX3RhYmJlZFBhbmUuYXBwZW5kVGFiKCJjb29raWVzIiwgV2ViSW5z cGVjdG9yLlVJU3RyaW5nKCJDb29raWVzIiksIHRoaXMuX2Nvb2tpZXNWaWV3KTsKKyAgICB9CiAg ICAgaWYgKFByZWZlcmVuY2VzLnNob3dUaW1pbmdUYWIpIHsKICAgICAgICAgdmFyIHRpbWluZ1Zp ZXcgPSBuZXcgV2ViSW5zcGVjdG9yLlJlc291cmNlVGltaW5nVmlldyhyZXNvdXJjZSk7CiAgICAg ICAgIHRoaXMuX3RhYmJlZFBhbmUuYXBwZW5kVGFiKCJ0aW1pbmciLCBXZWJJbnNwZWN0b3IuVUlT dHJpbmcoIlRpbWluZyIpLCB0aW1pbmdWaWV3KTsKQEAgLTgyLDcgKzgzLDcgQEAgV2ViSW5zcGVj dG9yLk5ldHdvcmtJdGVtVmlldy5wcm90b3R5cGUgPSB7CiAKICAgICByZXNpemU6IGZ1bmN0aW9u KCkKICAgICB7Ci0gICAgICAgIGlmICh0aGlzLl9jb29raWVzVmlldy52aXNpYmxlKQorICAgICAg ICBpZiAodGhpcy5fY29va2llc1ZpZXcgJiYgdGhpcy5fY29va2llc1ZpZXcudmlzaWJsZSkKICAg ICAgICAgICAgIHRoaXMuX2Nvb2tpZXNWaWV3LnJlc2l6ZSgpOwogICAgIH0KIH0KZGlmZiAtLWdp dCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TZXR0aW5ncy5qcyBiL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9TZXR0aW5ncy5qcwppbmRleCA5YWFjNjI2Li4xNjNiMTg0IDEwMDY0 NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2V0dGluZ3MuanMKKysrIGIvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NldHRpbmdzLmpzCkBAIC00OCw2ICs0OCw3IEBAIHZh ciBQcmVmZXJlbmNlcyA9IHsKICAgICBmaWxlU3lzdGVtRW5hYmxlZDogZmFsc2UsCiAgICAgdXNl RGF0YVVSTEZvclJlc291cmNlSW1hZ2VJY29uczogdHJ1ZSwKICAgICBzaG93VGltaW5nVGFiOiBm YWxzZSwKKyAgICBzaG93Q29va2llc1RhYjogZmFsc2UsCiAgICAgZGVidWdNb2RlOiBmYWxzZQog fQogCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvV2ViS2l0L2Nocm9t aXVtL0NoYW5nZUxvZwppbmRleCAzZjllZmM5Li4zNjM3N2ZkIDEwMDY0NAotLS0gYS9XZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxMC0xMS0zMCAgQW5kcmV5IEtvc3lha292ICA8Y2FzZXFAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdl YiBJbnNwZWN0b3I6IGRpc2FibGUgY29va2llcyB0YWIgaW4gbmV0d29yayByZXNvdXJjZSB2aWV3 IGJ5IGRlZmF1bHQsIGVuYWJsZSBmb3IgY2hyb21pdW0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUwMjQ5CisKKyAgICAgICAgKiBzcmMvanMvRGV2VG9v bHMuanM6CisKIDIwMTAtMTEtMjkgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hlci4KZGlmZiAtLWdpdCBhL1dlYktpdC9j aHJvbWl1bS9zcmMvanMvRGV2VG9vbHMuanMgYi9XZWJLaXQvY2hyb21pdW0vc3JjL2pzL0RldlRv b2xzLmpzCmluZGV4IDExZWJjMWYuLjViYjE1MGMgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1 bS9zcmMvanMvRGV2VG9vbHMuanMKKysrIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9qcy9EZXZUb29s cy5qcwpAQCAtNDgsNiArNDgsNyBAQCB2YXIgY29udGV4dCA9IHt9OyAgLy8gVXNlZCBieSBXZWJD b3JlJ3MgaW5zcGVjdG9yIHJvdXRpbmVzLgogICAgIFByZWZlcmVuY2VzLm5hdGl2ZUluc3RydW1l bnRhdGlvbkVuYWJsZWQgPSB0cnVlOwogICAgIFByZWZlcmVuY2VzLmZpbGVTeXN0ZW1FbmFibGVk ID0gZmFsc2U7CiAgICAgUHJlZmVyZW5jZXMuc2hvd1RpbWluZ1RhYiA9IHRydWU7CisgICAgUHJl ZmVyZW5jZXMuc2hvd0Nvb2tpZXNUYWIgPSB0cnVlOwogfSkoKTsKIAogdmFyIGRldnRvb2xzID0g ZGV2dG9vbHMgfHwge307Cg==