50236 2010-11-30 06:52:44 -0800 [Qt] Implement layoutTestController.findString 2011-11-17 10:54:20 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED LayoutTestFailure, PlatformOnly, Qt, QtTriaged P2 Normal --- 1 aroben benjamin benjamin commit-queue mitz mkosiba oldest_to_newest 315006 0 aroben 2010-11-30 06:52:44 -0800 r72887 added layoutTestController.findString and r72889 added the one test that uses it to the Skipped list. We should implement layoutTestController.findString so that we can run that test (and any future tests that are added that use it). 315103 1 75158 benjamin 2010-11-30 09:35:50 -0800 Created attachment 75158 Patch Add the missing function. I don't cq? yet, the test does not pass, all find() call with AtWordStarts fail. 315129 2 benjamin 2010-11-30 10:11:47 -0800 Ok, the test fails when Qt is compiled without ICU (default) because r72887 only implements the feature only for USE(ICU_UNICODE). 315301 3 75158 tonikitoo 2010-11-30 14:05:35 -0800 Comment on attachment 75158 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=75158&action=review > WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:461 > + // 2. find the string I'd drop (1) and (2) comments here ... they are useless :) 315503 4 75158 commit-queue 2010-11-30 20:19:01 -0800 Comment on attachment 75158 Patch Clearing flags on attachment: 75158 Committed r73007: <http://trac.webkit.org/changeset/73007> 315504 5 commit-queue 2010-11-30 20:19:06 -0800 All reviewed patches have been landed. Closing bug. 504987 6 mkosiba 2011-11-17 10:54:20 -0800 You forgot to uncomment the skipped findString layout test in platform/qt/Skipped:720. 75158 2010-11-30 09:35:50 -0800 2010-11-30 20:19:01 -0800 Patch 50236.patch text/plain 5627 benjamin ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmlu ZGV4IDVjNTRkYjIuLjZjOWMzNDIgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysr IGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEwLTExLTMwICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW4ucG91bGFpbkBub2tpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBJbXBsZW1lbnQgbGF5b3V0 VGVzdENvbnRyb2xsZXIuZmluZFN0cmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NTAyMzYKKworICAgICAgICBBZGQgc3VwcG9ydCBmb3IgdGhlIG5l dyBhZHZhbmNlZCBmaW5kU3RyaW5nKCkuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9EdW1w UmVuZGVyVHJlZVN1cHBvcnRRdC5jcHA6CisgICAgICAgIChEdW1wUmVuZGVyVHJlZVN1cHBvcnRR dDo6ZmluZFN0cmluZyk6CisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVT dXBwb3J0UXQuaDoKKwogMjAxMC0xMS0yNSAgTm9yYmVydCBMZXNlciAgPG5vcmJlcnQubGVzZXJA bm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IExhc3psbyBHb21ib3MuCmRpZmYgLS1n aXQgYS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQuY3Bw IGIvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydFF0LmNwcApp bmRleCBhNWE3MjcwLi5hMjg2M2IxIDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBv cnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQuY3BwCisrKyBiL1dlYktpdC9xdC9XZWJDb3JlU3Vw cG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRRdC5jcHAKQEAgLTQzNyw2ICs0MzcsMzIgQEAgYm9v bCBEdW1wUmVuZGVyVHJlZVN1cHBvcnRRdDo6aXNDb21tYW5kRW5hYmxlZChRV2ViUGFnZSogcGFn ZSwgY29uc3QgUVN0cmluZyYgbmEKICAgICByZXR1cm4gcGFnZS0+aGFuZGxlKCktPnBhZ2UtPmZv Y3VzQ29udHJvbGxlcigpLT5mb2N1c2VkT3JNYWluRnJhbWUoKS0+ZWRpdG9yKCktPmNvbW1hbmQo bmFtZSkuaXNFbmFibGVkKCk7CiB9CiAKK2Jvb2wgRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQ6OmZp bmRTdHJpbmcoUVdlYlBhZ2UqIHBhZ2UsIGNvbnN0IFFTdHJpbmcmIHN0cmluZywgY29uc3QgUVN0 cmluZ0xpc3QmIG9wdGlvbkFycmF5KQoreworICAgIC8vIDEuIFBhcnNlIHRoZSBvcHRpb25zIGZy b20gdGhlIGFycmF5CisgICAgV2ViQ29yZTo6RmluZE9wdGlvbnMgb3B0aW9ucyA9IDA7CisgICAg Y29uc3QgaW50IG9wdGlvbkNvdW50ID0gb3B0aW9uQXJyYXkuc2l6ZSgpOworICAgIGZvciAoaW50 IGkgPSAwOyBpIDwgb3B0aW9uQ291bnQ7ICsraSkgeworICAgICAgICBjb25zdCBRU3RyaW5nJiBv cHRpb24gPSBvcHRpb25BcnJheS5hdChpKTsKKyAgICAgICAgaWYgKG9wdGlvbiA9PSBRTGF0aW4x U3RyaW5nKCJDYXNlSW5zZW5zaXRpdmUiKSkKKyAgICAgICAgICAgIG9wdGlvbnMgfD0gV2ViQ29y ZTo6Q2FzZUluc2Vuc2l0aXZlOworICAgICAgICBlbHNlIGlmIChvcHRpb24gPT0gUUxhdGluMVN0 cmluZygiQXRXb3JkU3RhcnRzIikpCisgICAgICAgICAgICBvcHRpb25zIHw9IFdlYkNvcmU6OkF0 V29yZFN0YXJ0czsKKyAgICAgICAgZWxzZSBpZiAob3B0aW9uID09IFFMYXRpbjFTdHJpbmcoIlRy ZWF0TWVkaWFsQ2FwaXRhbEFzV29yZFN0YXJ0IikpCisgICAgICAgICAgICBvcHRpb25zIHw9IFdl YkNvcmU6OlRyZWF0TWVkaWFsQ2FwaXRhbEFzV29yZFN0YXJ0OworICAgICAgICBlbHNlIGlmIChv cHRpb24gPT0gUUxhdGluMVN0cmluZygiQmFja3dhcmRzIikpCisgICAgICAgICAgICBvcHRpb25z IHw9IFdlYkNvcmU6OkJhY2t3YXJkczsKKyAgICAgICAgZWxzZSBpZiAob3B0aW9uID09IFFMYXRp bjFTdHJpbmcoIldyYXBBcm91bmQiKSkKKyAgICAgICAgICAgIG9wdGlvbnMgfD0gV2ViQ29yZTo6 V3JhcEFyb3VuZDsKKyAgICAgICAgZWxzZSBpZiAob3B0aW9uID09IFFMYXRpbjFTdHJpbmcoIlN0 YXJ0SW5TZWxlY3Rpb24iKSkKKyAgICAgICAgICAgIG9wdGlvbnMgfD0gV2ViQ29yZTo6U3RhcnRJ blNlbGVjdGlvbjsKKyAgICB9CisKKyAgICAvLyAyLiBmaW5kIHRoZSBzdHJpbmcKKyAgICBXZWJD b3JlOjpGcmFtZSogZnJhbWUgPSBwYWdlLT5oYW5kbGUoKS0+cGFnZS0+Zm9jdXNDb250cm9sbGVy KCktPmZvY3VzZWRPck1haW5GcmFtZSgpOworICAgIHJldHVybiBmcmFtZSAmJiBmcmFtZS0+ZWRp dG9yKCktPmZpbmRTdHJpbmcoc3RyaW5nLCBvcHRpb25zKTsKK30KKwogUVN0cmluZyBEdW1wUmVu ZGVyVHJlZVN1cHBvcnRRdDo6bWFya2VyVGV4dEZvckxpc3RJdGVtKGNvbnN0IFFXZWJFbGVtZW50 JiBsaXN0SXRlbSkKIHsKICAgICByZXR1cm4gV2ViQ29yZTo6bWFya2VyVGV4dEZvckxpc3RJdGVt KGxpc3RJdGVtLm1fZWxlbWVudCk7CmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBv cnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQuaCBiL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9E dW1wUmVuZGVyVHJlZVN1cHBvcnRRdC5oCmluZGV4IDgyZDkzMTkuLjk4ZjJiOTQgMTAwNjQ0Ci0t LSBhL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRRdC5oCisr KyBiL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRRdC5oCkBA IC00NCw2ICs0NCw3IEBAIHB1YmxpYzoKIAogICAgIHN0YXRpYyB2b2lkIGV4ZWN1dGVDb3JlQ29t bWFuZEJ5TmFtZShRV2ViUGFnZSogcGFnZSwgY29uc3QgUVN0cmluZyYgbmFtZSwgY29uc3QgUVN0 cmluZyYgdmFsdWUpOwogICAgIHN0YXRpYyBib29sIGlzQ29tbWFuZEVuYWJsZWQoUVdlYlBhZ2Uq IHBhZ2UsIGNvbnN0IFFTdHJpbmcmIG5hbWUpOworICAgIHN0YXRpYyBib29sIGZpbmRTdHJpbmco UVdlYlBhZ2UqIHBhZ2UsIGNvbnN0IFFTdHJpbmcmIHN0cmluZywgY29uc3QgUVN0cmluZ0xpc3Qm IG9wdGlvbkFycmF5KTsKICAgICBzdGF0aWMgdm9pZCBzZXRTbWFydEluc2VydERlbGV0ZUVuYWJs ZWQoUVdlYlBhZ2UqIHBhZ2UsIGJvb2wgZW5hYmxlZCk7CiAgICAgc3RhdGljIHZvaWQgc2V0U2Vs ZWN0VHJhaWxpbmdXaGl0ZXNwYWNlRW5hYmxlZChRV2ViUGFnZSogcGFnZSwgYm9vbCBlbmFibGVk KTsKICAgICBzdGF0aWMgUVZhcmlhbnRMaXN0IHNlbGVjdGVkUmFuZ2UoUVdlYlBhZ2UqIHBhZ2Up OwpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdl TG9nCmluZGV4IDFmMmVlMWMuLjkwNzFkN2MgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5n ZUxvZworKysgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0x MS0zMCAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluLnBvdWxhaW5Abm9raWEuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gSW1wbGVt ZW50IGxheW91dFRlc3RDb250cm9sbGVyLmZpbmRTdHJpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUwMjM2CisKKyAgICAgICAgQWRkIHRoZSBtaXNz aW5nIGZ1bmN0aW9uIHRvIHRoZSBMYXlvdXRUZXN0Q29udHJvbGxlci4KKworICAgICAgICAqIER1 bXBSZW5kZXJUcmVlL3F0L0xheW91dFRlc3RDb250cm9sbGVyUXQuY3BwOgorICAgICAgICAoTGF5 b3V0VGVzdENvbnRyb2xsZXI6OmZpbmRTdHJpbmcpOgorICAgICAgICAqIER1bXBSZW5kZXJUcmVl L3F0L0xheW91dFRlc3RDb250cm9sbGVyUXQuaDoKKwogMjAxMC0xMS0yOSAgRGFuIEJlcm5zdGVp biAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIEdUSyBEdW1wUmVuZGVyVHJlZSBidWlsZCBm aXggYWZ0ZXIgcjcyODg3LgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUv cXQvTGF5b3V0VGVzdENvbnRyb2xsZXJRdC5jcHAgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJl ZS9xdC9MYXlvdXRUZXN0Q29udHJvbGxlclF0LmNwcAppbmRleCAwZjVmNmUxLi44YjQ5NWJlIDEw MDY0NAotLS0gYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9MYXlvdXRUZXN0Q29udHJv bGxlclF0LmNwcAorKysgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9MYXlvdXRUZXN0 Q29udHJvbGxlclF0LmNwcApAQCAtNzA3LDYgKzcwNywxMSBAQCBib29sIExheW91dFRlc3RDb250 cm9sbGVyOjppc0NvbW1hbmRFbmFibGVkKGNvbnN0IFFTdHJpbmcmIG5hbWUpIGNvbnN0CiAgICAg cmV0dXJuIER1bXBSZW5kZXJUcmVlU3VwcG9ydFF0Ojppc0NvbW1hbmRFbmFibGVkKG1fZHJ0LT53 ZWJQYWdlKCksIG5hbWUpOwogfQogCitib29sIExheW91dFRlc3RDb250cm9sbGVyOjpmaW5kU3Ry aW5nKGNvbnN0IFFTdHJpbmcmIHN0cmluZywgY29uc3QgUVN0cmluZ0xpc3QmIG9wdGlvbkFycmF5 KQoreworICAgIHJldHVybiBEdW1wUmVuZGVyVHJlZVN1cHBvcnRRdDo6ZmluZFN0cmluZyhtX2Ry dC0+d2ViUGFnZSgpLCBzdHJpbmcsIG9wdGlvbkFycmF5KTsKK30KKwogUVN0cmluZyBMYXlvdXRU ZXN0Q29udHJvbGxlcjo6bWFya2VyVGV4dEZvckxpc3RJdGVtKGNvbnN0IFFXZWJFbGVtZW50JiBs aXN0SXRlbSkKIHsKICAgICByZXR1cm4gRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQ6Om1hcmtlclRl eHRGb3JMaXN0SXRlbShsaXN0SXRlbSk7CmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9EdW1wUmVu ZGVyVHJlZS9xdC9MYXlvdXRUZXN0Q29udHJvbGxlclF0LmggYi9XZWJLaXRUb29scy9EdW1wUmVu ZGVyVHJlZS9xdC9MYXlvdXRUZXN0Q29udHJvbGxlclF0LmgKaW5kZXggNTkwMjI1Yi4uOWJhMjM2 NCAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvTGF5b3V0VGVzdENv bnRyb2xsZXJRdC5oCisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0xheW91dFRl c3RDb250cm9sbGVyUXQuaApAQCAtMTY4LDYgKzE2OCw3IEBAIHB1YmxpYyBzbG90czoKICAgICB2 b2lkIHNldFNlbGVjdFRyYWlsaW5nV2hpdGVzcGFjZUVuYWJsZWQoYm9vbCBlbmFibGUpOwogICAg IHZvaWQgZXhlY0NvbW1hbmQoY29uc3QgUVN0cmluZyYgbmFtZSwgY29uc3QgUVN0cmluZyYgdmFs dWUgPSBRU3RyaW5nKCkpOwogICAgIGJvb2wgaXNDb21tYW5kRW5hYmxlZChjb25zdCBRU3RyaW5n JiBuYW1lKSBjb25zdDsKKyAgICBib29sIGZpbmRTdHJpbmcoY29uc3QgUVN0cmluZyYgc3RyaW5n LCBjb25zdCBRU3RyaW5nTGlzdCYgb3B0aW9uQXJyYXkpOwogCiAgICAgYm9vbCBwYXVzZUFuaW1h dGlvbkF0VGltZU9uRWxlbWVudFdpdGhJZChjb25zdCBRU3RyaW5nJiBhbmltYXRpb25OYW1lLCBk b3VibGUgdGltZSwgY29uc3QgUVN0cmluZyYgZWxlbWVudElkKTsKICAgICBib29sIHBhdXNlVHJh bnNpdGlvbkF0VGltZU9uRWxlbWVudFdpdGhJZChjb25zdCBRU3RyaW5nJiBwcm9wZXJ0eU5hbWUs IGRvdWJsZSB0aW1lLCBjb25zdCBRU3RyaW5nJiBlbGVtZW50SWQpOwo=