50217 2010-11-30 02:49:54 -0800 [WINCE] add main() function 2010-12-01 08:51:19 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 1 paroga paroga aroben webkit.review.bot oldest_to_newest 314921 0 paroga 2010-11-30 02:49:54 -0800 see patch 314924 1 75118 paroga 2010-11-30 02:53:39 -0800 Created attachment 75118 Patch 314927 2 webkit.review.bot 2010-11-30 02:56:39 -0800 Attachment 75118 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebKit/wince/main.cpp']" exit_code: 1 WebKit/wince/main.cpp:26: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit/wince/main.cpp:117: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 2 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style. 315021 3 75118 aroben 2010-11-30 07:08:58 -0800 Comment on attachment 75118 Patch It doesn't seem appropriate to have a full browser in WebKit itself. Perhaps you should move this code to a new WebKitTools/WinCELauncher directory. 315070 4 75152 paroga 2010-11-30 08:36:54 -0800 Created attachment 75152 Patch (In reply to comment #3) > (From update of attachment 75118 [details]) > It doesn't seem appropriate to have a full browser in WebKit itself. Perhaps you should move this code to a new WebKitTools/WinCELauncher directory. Uuups, now in the corret directory and with ChangeLog. 315073 5 webkit.review.bot 2010-11-30 08:39:46 -0800 Attachment 75152 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebKitTools/ChangeLog', u'WebKitTools/WinCELauncher/main.cpp']" exit_code: 1 WebKitTools/WinCELauncher/main.cpp:26: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKitTools/WinCELauncher/main.cpp:117: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 315620 6 75152 aroben 2010-12-01 06:45:03 -0800 Comment on attachment 75152 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=75152&action=review > WebKitTools/WinCELauncher/main.cpp:103 > + if (fullscreen) > + SetWindowPos(hMainWindow, HWND_TOPMOST, 0, 0, GetSystemMetrics(SM_CXSCREEN), > + GetSystemMetrics(SM_CYSCREEN), SWP_SHOWWINDOW); This should be enclosed in braces, since it is more than one line (even though it's only a single statement). > WebKitTools/WinCELauncher/main.cpp:123 > + delete webView; Could you use an OwnPtr here? 315621 7 aroben 2010-12-01 06:45:46 -0800 (In reply to comment #5) > Attachment 75152 [details] did not pass style-queue: > > Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebKitTools/ChangeLog', u'WebKitTools/WinCELauncher/main.cpp']" exit_code: 1 > WebKitTools/WinCELauncher/main.cpp:26: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] > WebKitTools/WinCELauncher/main.cpp:117: One line control clauses should not use braces. [whitespace/braces] [4] > Total errors found: 2 in 2 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. You should change WebKitTools/Scripts/webkitpy/style/checkers.py to exclude the build/include_order rule when checking the WinCELauncher directory. 315627 8 paroga 2010-12-01 07:12:59 -0800 (In reply to comment #6) > (From update of attachment 75152 [details]) > > WebKitTools/WinCELauncher/main.cpp:123 > > + delete webView; > > Could you use an OwnPtr here? I'm not sure if it's cool to use "private" WebKit classes outside of it. WinLauncher.cpp does a "gWebView->Release()" too, but I can change it. (In reply to comment #7) > You should change WebKitTools/Scripts/webkitpy/style/checkers.py to exclude the build/include_order rule when checking the WinCELauncher directory. Are there any examples? I didn't find the place :-/. 315651 9 aroben 2010-12-01 08:14:58 -0800 (In reply to comment #8) > (In reply to comment #6) > > (From update of attachment 75152 [details] [details]) > > > WebKitTools/WinCELauncher/main.cpp:123 > > > + delete webView; > > > > Could you use an OwnPtr here? > I'm not sure if it's cool to use "private" WebKit classes outside of it. > WinLauncher.cpp does a "gWebView->Release()" too, but I can change it. We have other projects that use WTF headers (e.g., DumpRenderTree). As long as you're only using the header and not actually linking against WTF it seems fine. > (In reply to comment #7) > > You should change WebKitTools/Scripts/webkitpy/style/checkers.py to exclude the build/include_order rule when checking the WinCELauncher directory. > Are there any examples? I didn't find the place :-/. You'd add to the _PATH_RULES_SPECIFIER list <http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/style/checker.py#L114>. Probably something like this: ([# WinCELauncher has no config.h. "WebKitTools/WinCELauncher"], ["-build/include_order"]), 315669 10 75152 paroga 2010-12-01 08:50:55 -0800 Comment on attachment 75152 Patch Clearing flags on attachment: 75152 Manually committed r73026: <http://trac.webkit.org/changeset/73026> 315670 11 paroga 2010-12-01 08:51:19 -0800 All reviewed patches have been landed. Closing bug. 75118 2010-11-30 02:53:39 -0800 2010-11-30 08:36:54 -0800 Patch bug-50217.patch text/plain 4433 paroga ZGlmZiAtLWdpdCBhL1dlYktpdC93aW5jZS9tYWluLmNwcCBiL1dlYktpdC93aW5jZS9tYWluLmNw cApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi43NTZiOWExCi0tLSAvZGV2L251 bGwKKysrIGIvV2ViS2l0L3dpbmNlL21haW4uY3BwCkBAIC0wLDAgKzEsMTMwIEBACisvKgorICog Q29weXJpZ2h0IChDKSAyMDEwIFBhdHJpY2sgR2Fuc3RlcmVyIDxwYXJvZ2FAcGFyb2dhLmNvbT4K KyAqCisgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1z LCB3aXRoIG9yIHdpdGhvdXQKKyAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRl ZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucworICogYXJlIG1ldDoKKyAqIDEuIFJlZGlz dHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0 CisgKiAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5n IGRpc2NsYWltZXIuCisgKiAyLiBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCBy ZXByb2R1Y2UgdGhlIGFib3ZlIGNvcHlyaWdodAorICogICAgbm90aWNlLCB0aGlzIGxpc3Qgb2Yg Y29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyIGluIHRoZQorICogICAgZG9j dW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGggdGhlIGRpc3Ry aWJ1dGlvbi4KKyAqCisgKiBUSElTIFNPRlRXQVJFIElTIFBST1ZJREVEIEJZIEFQUExFIEFORCBJ VFMgQ09OVFJJQlVUT1JTICJBUyBJUyIgQU5EIEFOWQorICogRVhQUkVTUyBPUiBJTVBMSUVEIFdB UlJBTlRJRVMsIElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLCBUSEUgSU1QTElFRAorICog V0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxB UiBQVVJQT1NFIEFSRQorICogRElTQ0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwgQVBQTEUgT1Ig SVRTIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWQorICogRElSRUNULCBJTkRJUkVDVCwg SU5DSURFTlRBTCwgU1BFQ0lBTCwgRVhFTVBMQVJZLCBPUiBDT05TRVFVRU5USUFMIERBTUFHRVMK KyAqIChJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywgUFJPQ1VSRU1FTlQgT0YgU1VCU1RJ VFVURSBHT09EUyBPUiBTRVJWSUNFUzsKKyAqIExPU1MgT0YgVVNFLCBEQVRBLCBPUiBQUk9GSVRT OyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORAorICogT04gQU5Z IFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJ VFksIE9SIFRPUlQKKyAqIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJ TkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRSBPRgorICogVEhJUyBTT0ZUV0FSRSwgRVZFTiBJ RiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KKyAqLworCisjaW5j bHVkZSAiY29uZmlnLmgiCisjaW5jbHVkZSAiV2ViVmlldy5oIgorI2luY2x1ZGUgPHdpbmRvd3Mu aD4KKworc3RhdGljIGNvbnN0IExQQ1dTVFIga01haW5XaW5kb3dUaXRsZSA9IEwiV2ViS2l0IGZv ciBXaW5DRSI7CitzdGF0aWMgY29uc3QgTFBDV1NUUiBrTWFpbldpbmRvd0NsYXNzTmFtZSA9IEwi TWFpbldpbmRvd0NsYXNzIjsKKworCitzdGF0aWMgTFJFU1VMVCBDQUxMQkFDSyBXbmRQcm9jKEhX TkQgaFduZCwgVUlOVCBtZXNzYWdlLCBXUEFSQU0gd1BhcmFtLCBMUEFSQU0gbFBhcmFtKQorewor ICAgIHN3aXRjaCAobWVzc2FnZSkgeworICAgIGNhc2UgV01fREVTVFJPWToKKyAgICAgICAgUG9z dFF1aXRNZXNzYWdlKDApOworICAgICAgICBicmVhazsKKworICAgIGRlZmF1bHQ6CisgICAgICAg IHJldHVybiBEZWZXaW5kb3dQcm9jKGhXbmQsIG1lc3NhZ2UsIHdQYXJhbSwgbFBhcmFtKTsKKyAg ICB9CisKKyAgICByZXR1cm4gMDsKK30KKworaW50IEFQSUVOVFJZIF90V2luTWFpbihISU5TVEFO Q0UgaEluc3RhbmNlLCBISU5TVEFOQ0UgaFByZXZJbnN0YW5jZSwgTFBUU1RSIGxwQ21kTGluZSwg aW50IG5DbWRTaG93KQoreworICAgIFVOUkVGRVJFTkNFRF9QQVJBTUVURVIoaFByZXZJbnN0YW5j ZSk7CisKKyAgICBDb0luaXRpYWxpemVFeCgwLCBDT0lOSVRfTVVMVElUSFJFQURFRCk7CisgICAg V2ViVmlldzo6aW5pdGlhbGl6ZShoSW5zdGFuY2UpOworCisgICAgTFBDV1NUUiBob21lVXJsID0g bHBDbWRMaW5lOworICAgIGJvb2wgZW5hYmxlRG91YmxlQnVmZmVyID0gdHJ1ZTsKKyAgICBib29s IGZ1bGxzY3JlZW4gPSBmYWxzZTsKKworICAgIGlmIChob21lVXJsWzBdID09ICctJykgeworICAg ICAgICBmb3IgKDsgKmhvbWVVcmwgJiYgKmhvbWVVcmwgIT0gJyAnOyArK2hvbWVVcmwpIHsKKyAg ICAgICAgICAgIHN3aXRjaCAoKmhvbWVVcmwpIHsKKyAgICAgICAgICAgIGNhc2UgJ2QnOgorICAg ICAgICAgICAgICAgIGVuYWJsZURvdWJsZUJ1ZmZlciA9IGZhbHNlOworICAgICAgICAgICAgICAg IGJyZWFrOworICAgICAgICAgICAgY2FzZSAnZic6CisgICAgICAgICAgICAgICAgZnVsbHNjcmVl biA9IHRydWU7CisgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICBkZWZhdWx0Ogor ICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgfQorICAgICAgICB9CisgICAgICAg IGlmICgqaG9tZVVybCkKKyAgICAgICAgICAgICsraG9tZVVybDsKKyAgICB9CisKKyAgICBEV09S RCBzdHlsZXMgPSBXU19WSVNJQkxFOworCisgICAgaWYgKCFmdWxsc2NyZWVuKQorICAgICAgICBz dHlsZXMgfD0gV1NfQ0FQVElPTgorICAgICAgICAgICAgfCBXU19NQVhJTUlaRUJPWAorICAgICAg ICAgICAgfCBXU19NSU5JTUlaRUJPWAorICAgICAgICAgICAgfCBXU19PVkVSTEFQUEVECisgICAg ICAgICAgICB8IFdTX1NZU01FTlUKKyAgICAgICAgICAgIHwgV1NfVEhJQ0tGUkFNRTsKKworICAg IFdORENMQVNTVyB3YzsKKyAgICB3Yy5zdHlsZSAgICAgICAgICA9IENTX0hSRURSQVcgfCBDU19W UkVEUkFXOworICAgIHdjLmxwZm5XbmRQcm9jICAgID0gV25kUHJvYzsKKyAgICB3Yy5jYkNsc0V4 dHJhICAgICA9IDA7CisgICAgd2MuY2JXbmRFeHRyYSAgICAgPSAwOworICAgIHdjLmhJbnN0YW5j ZSAgICAgID0gaEluc3RhbmNlOworICAgIHdjLmhJY29uICAgICAgICAgID0gMDsKKyAgICB3Yy5o Q3Vyc29yICAgICAgICA9IDA7CisgICAgd2MuaGJyQmFja2dyb3VuZCAgPSBzdGF0aWNfY2FzdDxI QlJVU0g+KEdldFN0b2NrT2JqZWN0KFdISVRFX0JSVVNIKSk7CisgICAgd2MubHBzek1lbnVOYW1l ICAgPSAwOworICAgIHdjLmxwc3pDbGFzc05hbWUgID0ga01haW5XaW5kb3dDbGFzc05hbWU7Cisg ICAgUmVnaXN0ZXJDbGFzcygmd2MpOworCisgICAgSFdORCBoTWFpbldpbmRvdyA9IENyZWF0ZVdp bmRvd1coa01haW5XaW5kb3dDbGFzc05hbWUsIGtNYWluV2luZG93VGl0bGUsIHN0eWxlcywKKyAg ICAgICAgQ1dfVVNFREVGQVVMVCwgMCwgQ1dfVVNFREVGQVVMVCwgMCwgMCwgMCwgaEluc3RhbmNl LCAwKTsKKworICAgIGlmIChmdWxsc2NyZWVuKQorICAgICAgICBTZXRXaW5kb3dQb3MoaE1haW5X aW5kb3csIEhXTkRfVE9QTU9TVCwgMCwgMCwgR2V0U3lzdGVtTWV0cmljcyhTTV9DWFNDUkVFTiks CisgICAgICAgICAgICBHZXRTeXN0ZW1NZXRyaWNzKFNNX0NZU0NSRUVOKSwgU1dQX1NIT1dXSU5E T1cpOworCisgICAgU2hvd1dpbmRvdyhoTWFpbldpbmRvdywgbkNtZFNob3cpOworICAgIFVwZGF0 ZVdpbmRvdyhoTWFpbldpbmRvdyk7CisKKyAgICBXZWJWaWV3KiB3ZWJWaWV3ID0gbmV3IFdlYlZp ZXcoaE1haW5XaW5kb3csIGVuYWJsZURvdWJsZUJ1ZmZlciA/IFdlYlZpZXc6OkVuYWJsZURvdWJs ZUJ1ZmZlcmluZyA6IFdlYlZpZXc6Ok5vRmVhdHVyZSk7CisgICAgd2ViVmlldy0+bG9hZChob21l VXJsKTsKKworICAgIC8vIE1haW4gbWVzc2FnZSBsb29wOgorICAgIE1TRyBtc2c7CisgICAgQk9P TCBiUmV0OworICAgIHdoaWxlIChiUmV0ID0gR2V0TWVzc2FnZSgmbXNnLCAwLCAwLCAwKSkgewor ICAgICAgICBpZiAoYlJldCA9PSAtMSkgeworICAgICAgICAgICAgLy8gRklYTUU6IEhhbmRsZSB0 aGUgZXJyb3IgYW5kIHBvc3NpYmx5IGV4aXQuCisgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAg ICBUcmFuc2xhdGVNZXNzYWdlKCZtc2cpOworICAgICAgICAgICAgRGlzcGF0Y2hNZXNzYWdlKCZt c2cpOworICAgICAgICB9CisgICAgfQorCisgICAgZGVsZXRlIHdlYlZpZXc7CisgICAgRGVzdHJv eVdpbmRvdyhoTWFpbldpbmRvdyk7CisKKyAgICBXZWJWaWV3OjpjbGVhbnVwKCk7CisgICAgQ29V bmluaXRpYWxpemUoKTsKKworICAgIHJldHVybiBtc2cud1BhcmFtOworfQo= 75152 2010-11-30 08:36:54 -0800 2010-12-01 08:50:55 -0800 Patch bug-50217b.patch text/plain 4962 paroga ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAxZjJlZTFjLi40Y2EyMTViIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMTEt MzAgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1dJTkNFXSBBZGQgV2luQ0VMYXVu Y2hlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTAy MTcKKworICAgICAgICAqIFdpbkNFTGF1bmNoZXIvbWFpbi5jcHA6IEFkZGVkLgorCiAyMDEwLTEx LTI5ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgR1RLIER1bXBS ZW5kZXJUcmVlIGJ1aWxkIGZpeCBhZnRlciByNzI4ODcuCmRpZmYgLS1naXQgYS9XZWJLaXRUb29s cy9XaW5DRUxhdW5jaGVyL21haW4uY3BwIGIvV2ViS2l0VG9vbHMvV2luQ0VMYXVuY2hlci9tYWlu LmNwcApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi43NTZiOWExCi0tLSAvZGV2 L251bGwKKysrIGIvV2ViS2l0VG9vbHMvV2luQ0VMYXVuY2hlci9tYWluLmNwcApAQCAtMCwwICsx LDEzMCBAQAorLyoKKyAqIENvcHlyaWdodCAoQykgMjAxMCBQYXRyaWNrIEdhbnN0ZXJlciA8cGFy b2dhQHBhcm9nYS5jb20+CisgKgorICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2Ug YW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CisgKiBtb2RpZmljYXRpb24sIGFyZSBw ZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKKyAqIGFyZSBt ZXQ6CisgKiAxLiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhl IGFib3ZlIGNvcHlyaWdodAorICogICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBh bmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorICogMi4gUmVkaXN0cmlidXRpb25zIGluIGJp bmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAgIG5vdGlj ZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBp biB0aGUKKyAqICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRl ZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uCisgKgorICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURF RCBCWSBBUFBMRSBBTkQgSVRTIENPTlRSSUJVVE9SUyAiQVMgSVMiIEFORCBBTlkKKyAqIEVYUFJF U1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywg VEhFIElNUExJRUQKKyAqIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNT IEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRSBBUkUKKyAqIERJU0NMQUlNRUQuIElOIE5PIEVWRU5U IFNIQUxMIEFQUExFIE9SIElUUyBDT05UUklCVVRPUlMgQkUgTElBQkxFIEZPUiBBTlkKKyAqIERJ UkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsIFNQRUNJQUwsIEVYRU1QTEFSWSwgT1IgQ09OU0VR VUVOVElBTCBEQU1BR0VTCisgKiAoSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFBST0NV UkVNRU5UIE9GIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7CisgKiBMT1NTIE9GIFVTRSwg REFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNF RCBBTkQKKyAqIE9OIEFOWSBUSEVPUlkgT0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNU LCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCisgKiAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1Ig T1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UgT0YKKyAqIFRISVMg U09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1B R0UuCisgKi8KKworI2luY2x1ZGUgImNvbmZpZy5oIgorI2luY2x1ZGUgIldlYlZpZXcuaCIKKyNp bmNsdWRlIDx3aW5kb3dzLmg+CisKK3N0YXRpYyBjb25zdCBMUENXU1RSIGtNYWluV2luZG93VGl0 bGUgPSBMIldlYktpdCBmb3IgV2luQ0UiOworc3RhdGljIGNvbnN0IExQQ1dTVFIga01haW5XaW5k b3dDbGFzc05hbWUgPSBMIk1haW5XaW5kb3dDbGFzcyI7CisKKworc3RhdGljIExSRVNVTFQgQ0FM TEJBQ0sgV25kUHJvYyhIV05EIGhXbmQsIFVJTlQgbWVzc2FnZSwgV1BBUkFNIHdQYXJhbSwgTFBB UkFNIGxQYXJhbSkKK3sKKyAgICBzd2l0Y2ggKG1lc3NhZ2UpIHsKKyAgICBjYXNlIFdNX0RFU1RS T1k6CisgICAgICAgIFBvc3RRdWl0TWVzc2FnZSgwKTsKKyAgICAgICAgYnJlYWs7CisKKyAgICBk ZWZhdWx0OgorICAgICAgICByZXR1cm4gRGVmV2luZG93UHJvYyhoV25kLCBtZXNzYWdlLCB3UGFy YW0sIGxQYXJhbSk7CisgICAgfQorCisgICAgcmV0dXJuIDA7Cit9CisKK2ludCBBUElFTlRSWSBf dFdpbk1haW4oSElOU1RBTkNFIGhJbnN0YW5jZSwgSElOU1RBTkNFIGhQcmV2SW5zdGFuY2UsIExQ VFNUUiBscENtZExpbmUsIGludCBuQ21kU2hvdykKK3sKKyAgICBVTlJFRkVSRU5DRURfUEFSQU1F VEVSKGhQcmV2SW5zdGFuY2UpOworCisgICAgQ29Jbml0aWFsaXplRXgoMCwgQ09JTklUX01VTFRJ VEhSRUFERUQpOworICAgIFdlYlZpZXc6OmluaXRpYWxpemUoaEluc3RhbmNlKTsKKworICAgIExQ Q1dTVFIgaG9tZVVybCA9IGxwQ21kTGluZTsKKyAgICBib29sIGVuYWJsZURvdWJsZUJ1ZmZlciA9 IHRydWU7CisgICAgYm9vbCBmdWxsc2NyZWVuID0gZmFsc2U7CisKKyAgICBpZiAoaG9tZVVybFsw XSA9PSAnLScpIHsKKyAgICAgICAgZm9yICg7ICpob21lVXJsICYmICpob21lVXJsICE9ICcgJzsg Kytob21lVXJsKSB7CisgICAgICAgICAgICBzd2l0Y2ggKCpob21lVXJsKSB7CisgICAgICAgICAg ICBjYXNlICdkJzoKKyAgICAgICAgICAgICAgICBlbmFibGVEb3VibGVCdWZmZXIgPSBmYWxzZTsK KyAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgIGNhc2UgJ2YnOgorICAgICAgICAg ICAgICAgIGZ1bGxzY3JlZW4gPSB0cnVlOworICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAg ICAgICAgZGVmYXVsdDoKKyAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgIH0KKyAg ICAgICAgfQorICAgICAgICBpZiAoKmhvbWVVcmwpCisgICAgICAgICAgICArK2hvbWVVcmw7Cisg ICAgfQorCisgICAgRFdPUkQgc3R5bGVzID0gV1NfVklTSUJMRTsKKworICAgIGlmICghZnVsbHNj cmVlbikKKyAgICAgICAgc3R5bGVzIHw9IFdTX0NBUFRJT04KKyAgICAgICAgICAgIHwgV1NfTUFY SU1JWkVCT1gKKyAgICAgICAgICAgIHwgV1NfTUlOSU1JWkVCT1gKKyAgICAgICAgICAgIHwgV1Nf T1ZFUkxBUFBFRAorICAgICAgICAgICAgfCBXU19TWVNNRU5VCisgICAgICAgICAgICB8IFdTX1RI SUNLRlJBTUU7CisKKyAgICBXTkRDTEFTU1cgd2M7CisgICAgd2Muc3R5bGUgICAgICAgICAgPSBD U19IUkVEUkFXIHwgQ1NfVlJFRFJBVzsKKyAgICB3Yy5scGZuV25kUHJvYyAgICA9IFduZFByb2M7 CisgICAgd2MuY2JDbHNFeHRyYSAgICAgPSAwOworICAgIHdjLmNiV25kRXh0cmEgICAgID0gMDsK KyAgICB3Yy5oSW5zdGFuY2UgICAgICA9IGhJbnN0YW5jZTsKKyAgICB3Yy5oSWNvbiAgICAgICAg ICA9IDA7CisgICAgd2MuaEN1cnNvciAgICAgICAgPSAwOworICAgIHdjLmhickJhY2tncm91bmQg ID0gc3RhdGljX2Nhc3Q8SEJSVVNIPihHZXRTdG9ja09iamVjdChXSElURV9CUlVTSCkpOworICAg IHdjLmxwc3pNZW51TmFtZSAgID0gMDsKKyAgICB3Yy5scHN6Q2xhc3NOYW1lICA9IGtNYWluV2lu ZG93Q2xhc3NOYW1lOworICAgIFJlZ2lzdGVyQ2xhc3MoJndjKTsKKworICAgIEhXTkQgaE1haW5X aW5kb3cgPSBDcmVhdGVXaW5kb3dXKGtNYWluV2luZG93Q2xhc3NOYW1lLCBrTWFpbldpbmRvd1Rp dGxlLCBzdHlsZXMsCisgICAgICAgIENXX1VTRURFRkFVTFQsIDAsIENXX1VTRURFRkFVTFQsIDAs IDAsIDAsIGhJbnN0YW5jZSwgMCk7CisKKyAgICBpZiAoZnVsbHNjcmVlbikKKyAgICAgICAgU2V0 V2luZG93UG9zKGhNYWluV2luZG93LCBIV05EX1RPUE1PU1QsIDAsIDAsIEdldFN5c3RlbU1ldHJp Y3MoU01fQ1hTQ1JFRU4pLAorICAgICAgICAgICAgR2V0U3lzdGVtTWV0cmljcyhTTV9DWVNDUkVF TiksIFNXUF9TSE9XV0lORE9XKTsKKworICAgIFNob3dXaW5kb3coaE1haW5XaW5kb3csIG5DbWRT aG93KTsKKyAgICBVcGRhdGVXaW5kb3coaE1haW5XaW5kb3cpOworCisgICAgV2ViVmlldyogd2Vi VmlldyA9IG5ldyBXZWJWaWV3KGhNYWluV2luZG93LCBlbmFibGVEb3VibGVCdWZmZXIgPyBXZWJW aWV3OjpFbmFibGVEb3VibGVCdWZmZXJpbmcgOiBXZWJWaWV3OjpOb0ZlYXR1cmUpOworICAgIHdl YlZpZXctPmxvYWQoaG9tZVVybCk7CisKKyAgICAvLyBNYWluIG1lc3NhZ2UgbG9vcDoKKyAgICBN U0cgbXNnOworICAgIEJPT0wgYlJldDsKKyAgICB3aGlsZSAoYlJldCA9IEdldE1lc3NhZ2UoJm1z ZywgMCwgMCwgMCkpIHsKKyAgICAgICAgaWYgKGJSZXQgPT0gLTEpIHsKKyAgICAgICAgICAgIC8v IEZJWE1FOiBIYW5kbGUgdGhlIGVycm9yIGFuZCBwb3NzaWJseSBleGl0LgorICAgICAgICB9IGVs c2UgeworICAgICAgICAgICAgVHJhbnNsYXRlTWVzc2FnZSgmbXNnKTsKKyAgICAgICAgICAgIERp c3BhdGNoTWVzc2FnZSgmbXNnKTsKKyAgICAgICAgfQorICAgIH0KKworICAgIGRlbGV0ZSB3ZWJW aWV3OworICAgIERlc3Ryb3lXaW5kb3coaE1haW5XaW5kb3cpOworCisgICAgV2ViVmlldzo6Y2xl YW51cCgpOworICAgIENvVW5pbml0aWFsaXplKCk7CisKKyAgICByZXR1cm4gbXNnLndQYXJhbTsK K30K