50208 2010-11-29 22:16:45 -0800 [GTK] Build warnings in assertion code 2010-11-30 20:00:09 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Trivial --- 0 nicolas webkit-unassigned commit-queue eric mrobinson xan.lopez oldest_to_newest 314858 0 nicolas 2010-11-29 22:16:45 -0800 I just went across some code that returns wrong type in assertions (g_return_val_if_fail(...)). Will attach a patch soon. 314861 1 75105 nicolas 2010-11-29 22:24:16 -0800 Created attachment 75105 [GTK] Fix wrong type in assert return value Use appropriate return type in different g_return_val_if_fail(). This removes some compiler warning. 315082 2 commit-queue 2010-11-30 09:04:05 -0800 The commit-queue encountered the following flaky tests while processing attachment 75105: inspector/elements-panel-styles.html fast/workers/storage/use-same-database-in-page-and-workers.html Please file bugs against the tests. These tests were authored by dumi@chromium.org and pfeldman@chromium.org. The commit-queue is continuing to process your patch. 315097 3 commit-queue 2010-11-30 09:26:55 -0800 The commit-queue encountered the following flaky tests while processing attachment 75105: compositing/iframes/overlapped-nested-iframes.html compositing/iframes/iframe-size-from-zero.html Please file bugs against the tests. These tests were authored by ajwong@chromium.org and simon.fraser@apple.com. The commit-queue is continuing to process your patch. 315128 4 commit-queue 2010-11-30 10:10:57 -0800 The commit-queue encountered the following flaky tests while processing attachment 75105: fast/js/sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.14_String.prototype.split/S15.5.4.14_A2_T29.html fast/workers/storage/use-same-database-in-page-and-workers.html Please file bugs against the tests. These tests were authored by ap@webkit.org and dumi@chromium.org. The commit-queue is continuing to process your patch. 315194 5 eric 2010-11-30 11:35:22 -0800 Bug 50255 tracks the flakey compositing test. 315475 6 commit-queue 2010-11-30 18:39:57 -0800 The commit-queue encountered the following flaky tests while processing attachment 75105: compositing/iframes/overlapped-nested-iframes.html fast/workers/storage/use-same-database-in-page-and-workers.html Please file bugs against the tests. These tests were authored by dumi@chromium.org and simon.fraser@apple.com. The commit-queue is continuing to process your patch. 315498 7 75105 commit-queue 2010-11-30 20:00:03 -0800 Comment on attachment 75105 [GTK] Fix wrong type in assert return value Clearing flags on attachment: 75105 Committed r73006: <http://trac.webkit.org/changeset/73006> 315499 8 commit-queue 2010-11-30 20:00:09 -0800 All reviewed patches have been landed. Closing bug. 75105 2010-11-29 22:24:16 -0800 2010-11-30 20:00:03 -0800 [GTK] Fix wrong type in assert return value 0001-GTK-Fix-wrong-type-in-assert-return-value.patch text/plain 3066 nicolas RnJvbSAxNmE5ZDY0MDc5YThhMjA1ODExNjVhOTc0ZDViY2M5MDU3OTA3OWMwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBOaWNvbGFzIER1ZnJlc25lIDxuaWNvbGFzLmR1ZnJlc25lQGNv bGxhYm9yYS5jby51az4KRGF0ZTogRnJpLCA1IE5vdiAyMDEwIDE1OjQxOjIxIC0wNDAwClN1Ympl Y3Q6IFtQQVRDSF0gW0dUS10gRml4IHdyb25nIHR5cGUgaW4gYXNzZXJ0IHJldHVybiB2YWx1ZQoK aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUwMjA4CgpVc2UgYXBwcm9w cmlhdGUgcmV0dXJuIHR5cGUgaW4gZGlmZmVyZW50IGdfcmV0dXJuX3ZhbF9pZl9mYWlsKCkuIFRo aXMKcmVtb3ZlcyBzb21lIGNvbXBpbGVyIHdhcm5pbmcuCi0tLQogV2ViS2l0L2d0ay9DaGFuZ2VM b2cgICAgICAgICAgICAgICAgICAgICAgfCAgIDE2ICsrKysrKysrKysrKysrKysKIFdlYktpdC9n dGsvd2Via2l0L3dlYmtpdHdlYmRhdGFzb3VyY2UuY3BwIHwgICAgMiArLQogV2ViS2l0L2d0ay93 ZWJraXQvd2Via2l0d2ViZnJhbWUuY3BwICAgICAgfCAgICA0ICsrLS0KIDMgZmlsZXMgY2hhbmdl ZCwgMTkgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXQv Z3RrL0NoYW5nZUxvZyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCmluZGV4IGVjZGM2ZGQuLmQyYWZi N2QgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9ndGsvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMTEtMjkgIE5pY29sYXMgRHVmcmVzbmUgIDxu aWNvbGFzLmR1ZnJlc25lQGNvbGxhYm9yYS5jby51az4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSBGaXggd3JvbmcgdHlwZSBpbiBhc3NlcnQg cmV0dXJuIHZhbHVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD01MDIwOAorCisgICAgICAgIFVzZSBhcHByb3ByaWF0ZSByZXR1cm4gdHlwZSBpbiBkaWZm ZXJlbnQgZ19yZXR1cm5fdmFsX2lmX2ZhaWwoKS4gVGhpcworICAgICAgICByZW1vdmVzIHNvbWUg Y29tcGlsZXIgd2FybmluZy4KKworICAgICAgICAqIHdlYmtpdC93ZWJraXR3ZWJkYXRhc291cmNl LmNwcDoKKyAgICAgICAgKHdlYmtpdF93ZWJfZGF0YV9zb3VyY2VfaXNfbG9hZGluZyk6CisgICAg ICAgICogd2Via2l0L3dlYmtpdHdlYmZyYW1lLmNwcDoKKyAgICAgICAgKHdlYmtpdF93ZWJfZnJh bWVfcGFnZV9udW1iZXJfZm9yX2VsZW1lbnRfYnlfaWQpOgorICAgICAgICAod2Via2l0X3dlYl9m cmFtZV9udW1iZXJfb2ZfcGFnZXMpOgorCiAyMDEwLTExLTI5ICBYYW4gTG9wZXogIDx4bG9wZXpA aWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYXJ0aW4gUm9iaW5zb24uCmRpZmYg LS1naXQgYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJkYXRhc291cmNlLmNwcCBiL1dlYktp dC9ndGsvd2Via2l0L3dlYmtpdHdlYmRhdGFzb3VyY2UuY3BwCmluZGV4IDM4YzljNDguLjM2NzNh OTkgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYmRhdGFzb3VyY2UuY3Bw CisrKyBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYmRhdGFzb3VyY2UuY3BwCkBAIC0zMTgs NyArMzE4LDcgQEAgR19DT05TVF9SRVRVUk4gZ2NoYXIqIHdlYmtpdF93ZWJfZGF0YV9zb3VyY2Vf Z2V0X2VuY29kaW5nKFdlYktpdFdlYkRhdGFTb3VyY2UqIHcKICAqLwogZ2Jvb2xlYW4gd2Via2l0 X3dlYl9kYXRhX3NvdXJjZV9pc19sb2FkaW5nKFdlYktpdFdlYkRhdGFTb3VyY2UqIHdlYkRhdGFT b3VyY2UpCiB7Ci0gICAgZ19yZXR1cm5fdmFsX2lmX2ZhaWwoV0VCS0lUX0lTX1dFQl9EQVRBX1NP VVJDRSh3ZWJEYXRhU291cmNlKSwgTlVMTCk7CisgICAgZ19yZXR1cm5fdmFsX2lmX2ZhaWwoV0VC S0lUX0lTX1dFQl9EQVRBX1NPVVJDRSh3ZWJEYXRhU291cmNlKSwgRkFMU0UpOwogCiAgICAgV2Vi S2l0V2ViRGF0YVNvdXJjZVByaXZhdGUqIHByaXYgPSB3ZWJEYXRhU291cmNlLT5wcml2OwogCmRp ZmYgLS1naXQgYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJmcmFtZS5jcHAgYi9XZWJLaXQv Z3RrL3dlYmtpdC93ZWJraXR3ZWJmcmFtZS5jcHAKaW5kZXggZmNiNTE5Ny4uMGUwYzNjNiAxMDA2 NDQKLS0tIGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2ViZnJhbWUuY3BwCisrKyBiL1dlYktp dC9ndGsvd2Via2l0L3dlYmtpdHdlYmZyYW1lLmNwcApAQCAtODQ3LDcgKzg0Nyw3IEBAIGdjaGFy KiB3ZWJraXRfd2ViX2ZyYW1lX2NvdW50ZXJfdmFsdWVfZm9yX2VsZW1lbnRfYnlfaWQoV2ViS2l0 V2ViRnJhbWUqIGZyYW1lLCBjCiAgKi8KIGludCB3ZWJraXRfd2ViX2ZyYW1lX3BhZ2VfbnVtYmVy X2Zvcl9lbGVtZW50X2J5X2lkKFdlYktpdFdlYkZyYW1lKiBmcmFtZSwgY29uc3QgZ2NoYXIqIGlk LCBmbG9hdCBwYWdlV2lkdGgsIGZsb2F0IHBhZ2VIZWlnaHQpCiB7Ci0gICAgZ19yZXR1cm5fdmFs X2lmX2ZhaWwoV0VCS0lUX0lTX1dFQl9GUkFNRShmcmFtZSksIE5VTEwpOworICAgIGdfcmV0dXJu X3ZhbF9pZl9mYWlsKFdFQktJVF9JU19XRUJfRlJBTUUoZnJhbWUpLCAwKTsKIAogICAgIEZyYW1l KiBjb3JlRnJhbWUgPSBjb3JlKGZyYW1lKTsKICAgICBpZiAoIWNvcmVGcmFtZSkKQEAgLTg2OSw3 ICs4NjksNyBAQCBpbnQgd2Via2l0X3dlYl9mcmFtZV9wYWdlX251bWJlcl9mb3JfZWxlbWVudF9i eV9pZChXZWJLaXRXZWJGcmFtZSogZnJhbWUsIGNvbnN0CiAgKi8KIGludCB3ZWJraXRfd2ViX2Zy YW1lX251bWJlcl9vZl9wYWdlcyhXZWJLaXRXZWJGcmFtZSogZnJhbWUsIGZsb2F0IHBhZ2VXaWR0 aCwgZmxvYXQgcGFnZUhlaWdodCkKIHsKLSAgICBnX3JldHVybl92YWxfaWZfZmFpbChXRUJLSVRf SVNfV0VCX0ZSQU1FKGZyYW1lKSwgTlVMTCk7CisgICAgZ19yZXR1cm5fdmFsX2lmX2ZhaWwoV0VC S0lUX0lTX1dFQl9GUkFNRShmcmFtZSksIDApOwogCiAgICAgRnJhbWUqIGNvcmVGcmFtZSA9IGNv cmUoZnJhbWUpOwogICAgIGlmICghY29yZUZyYW1lKQotLSAKMS43LjMuMgoK