50168 2010-11-29 11:56:26 -0800 [chromium] try to enable WebCore compiler warnings on linux 2010-11-29 17:11:09 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tony tony abarth eric jamesr webkit.review.bot oldest_to_newest 314547 0 tony 2010-11-29 11:56:26 -0800 [chromium] try to enable WebCore compiler warnings on linux 314548 1 75048 tony 2010-11-29 11:56:57 -0800 Created attachment 75048 Patch 314551 2 tony 2010-11-29 12:00:14 -0800 This passes for me on hardy in a debug build and seems to pass on the bots in release (all the warnings are in third party code): http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Linux/builds/2769/steps/compile/logs/stdio 314572 3 75048 jamesr 2010-11-29 12:50:30 -0800 Comment on attachment 75048 Patch Go for it! I ran into completely nonsense-looking compile errors on the bots last time, so hopefully you'll have better luck. 314590 4 tony 2010-11-29 13:23:03 -0800 Committed r72824: <http://trac.webkit.org/changeset/72824> 314605 5 tony 2010-11-29 13:41:13 -0800 Meh, turning warnings off. Here's the error: cc1plus: warnings being treated as errors WebCore/platform/Length.h: In constructor ‘WebCore::FillLayer::FillLayer(WebCore::EFillLayerType)’: WebCore/platform/Length.h:56: warning: ‘this.7’ is used uninitialized in this function WebCore/platform/Length.h:56: note: ‘this.7’ was declared here WebCore/platform/Length.h:56: warning: ‘this.7’ is used uninitialized in this function WebCore/platform/Length.h:56: note: ‘this.7’ was declared here make: *** [out/Release/obj.target/webcore_remaining/WebCore/rendering/style/FillLayer.o] Error 1 make: *** Waiting for unfinished jobs.... cc1plus: warnings being treated as errors WebCore/platform/graphics/Color.h: In constructor ‘WebCore::StyleBackgroundData::StyleBackgroundData()’: WebCore/platform/graphics/Color.h:81: warning: ‘this.9’ is used uninitialized in this function WebCore/platform/graphics/Color.h:81: note: ‘this.9’ was declared here make: *** [out/Release/obj.target/webcore_remaining/WebCore/rendering/style/StyleBackgroundData.o] Error 1 314616 6 webkit.review.bot 2010-11-29 13:49:29 -0800 http://trac.webkit.org/changeset/72824 might have broken Chromium Linux Release 314748 7 tony 2010-11-29 17:11:09 -0800 (In reply to comment #5) > Meh, turning warnings off. Here's the error: > cc1plus: warnings being treated as errors > WebCore/platform/Length.h: In constructor ‘WebCore::FillLayer::FillLayer(WebCore::EFillLayerType)’: > WebCore/platform/Length.h:56: warning: ‘this.7’ is used uninitialized in this function > WebCore/platform/Length.h:56: note: ‘this.7’ was declared here > WebCore/platform/Length.h:56: warning: ‘this.7’ is used uninitialized in this function > WebCore/platform/Length.h:56: note: ‘this.7’ was declared here > make: *** [out/Release/obj.target/webcore_remaining/WebCore/rendering/style/FillLayer.o] Error 1 It looks like this is a compiler bug. I'm trying to find a reasonable workaround that isn't too gross. For example, in FillLayer.cpp, if I make the following change: @@ -27,8 +27,8 @@ namespace WebCore { FillLayer::FillLayer(EFillLayerType type) : m_next(0) , m_image(FillLayer::initialFillImage(type)) - , m_xPosition(FillLayer::initialFillXPosition(type)) - , m_yPosition(FillLayer::initialFillYPosition(type)) + , m_xPosition(Length(0.0, Percent)) + , m_yPosition(Length(0.0, Percent)) it works (where FillLayer::initialFillXPosition just returns Length(0.0, Percent)). Other options are to add a #pragma to the file to suppress the warning in gcc. Maybe that's less bad. 75048 2010-11-29 11:56:57 -0800 2010-11-29 12:50:30 -0800 Patch bug-50168-20101129115741.patch text/plain 4812 tony ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MzI5OTRlNDgzYWU5NGIwMmE0OWQ3ODcxMGFkYjJlODk4MjdjN2YxNC4uNDEzNWM5MDMwZGU3N2Vi MWJmMDY3ZDdjMzk5NDJkMjU0MmVlZmU0NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0xMS0yOSAgVG9u eSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gdHJ5IHRvIGVuYWJsZSBXZWJDb3JlIGNv bXBpbGVyIHdhcm5pbmdzIG9uIGxpbnV4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD01MDE2OAorCisgICAgICAgICogV2ViQ29yZS5neXAvV2ViQ29yZS5n eXA6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRm9udExpbnV4LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlRleHRSdW5XYWxrZXI6OnNldFBhZGRpbmcpOgorICAgICAgICAo V2ViQ29yZTo6VGV4dFJ1bldhbGtlcjo6c2V0R2x5cGhYUG9zaXRpb25zKToKKyAgICAgICAgKFdl YkNvcmU6OmdseXBoSW5kZXhGb3JYUG9zaXRpb25JblNjcmlwdFJ1bik6CisKIDIwMTAtMTEtMjkg IFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgRGFuIEJlcm5zdGVpbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvV2ViQ29yZS5neXAvV2Vi Q29yZS5neXAgYi9XZWJDb3JlL1dlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lwCmluZGV4IGU4ZjM0M2Fj MmUzMmYwM2IzYzE1ZTk5MjE0YTIzNWFlOWE4OTRhYzIuLmJiMTgwOTU2MGE5MzQxZGRmZTFiYTY0 NGYzMjRmYmRiMGI0MzdlYTIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29y ZS5neXAKKysrIGIvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cApAQCAtMjQ1LDE0ICsy NDUsNyBAQAogICAgICAgICAgICcuLi9wbGF0Zm9ybS9tYWMnLAogICAgICAgICAgICcuLi9wbGF0 Zm9ybS90ZXh0L21hYycsCiAgICAgICAgIF0sCi0gICAgICAgICMgZW5hYmxlIC1XYWxsIGFuZCAt V2Vycm9yLCBqdXN0IGZvciBNYWMgYW5kIExpbnV4IGJ1aWxkcyBmb3Igbm93Ci0gICAgICAgICMg RklYTUU6IEFsc28gZW5hYmxlIHRoaXMgZm9yIFdpbmRvd3MgYWZ0ZXIgdmVyaWZ5aW5nIG5vIHdh cm5pbmdzCi0gICAgICAgICdjaHJvbWl1bV9jb2RlJzogMSwKICAgICAgIH1dLAotIyBGSVhNRTog ZGlzYWJsZWQgZm9yIG5vdyBkdWUgdG8gZmFpbHVyZXMgb24gZGlmZmVyZW50IGdjYyB2ZXJzaW9u cwotIyAgICAgWydPUz09ImxpbnV4IicsIHsKLSMgICAgICAgICdjaHJvbWl1bV9jb2RlJzogMSwK LSMgICAgICB9XSwKICAgICAgIFsnT1M9PSJ3aW4iJywgewogICAgICAgICAnd2ViY29yZV9pbmNs dWRlX2RpcnMnOiBbCiAgICAgICAgICAgJy4uL3BhZ2Uvd2luJywKQEAgLTI2MCw2ICsyNTMsMTAg QEAKICAgICAgICAgICAnLi4vcGxhdGZvcm0vdGV4dC93aW4nLAogICAgICAgICAgICcuLi9wbGF0 Zm9ybS93aW4nLAogICAgICAgICBdLAorICAgICAgfSx7CisgICAgICAgICMgZW5hYmxlIC1XYWxs IGFuZCAtV2Vycm9yLCBqdXN0IGZvciBNYWMgYW5kIExpbnV4IGJ1aWxkcyBmb3Igbm93CisgICAg ICAgICMgRklYTUU6IEFsc28gZW5hYmxlIHRoaXMgZm9yIFdpbmRvd3MgYWZ0ZXIgdmVyaWZ5aW5n IG5vIHdhcm5pbmdzCisgICAgICAgICdjaHJvbWl1bV9jb2RlJzogMSwKICAgICAgIH1dLAogICAg ICAgWydPUz09IndpbiIgYW5kIGJ1aWxkdHlwZT09Ik9mZmljaWFsIicsIHsKICAgICAgICAgIyBP biB3aW5kb3dzIG9mZmljaWFsIHJlbGVhc2UgYnVpbGRzLCB3ZSB0cnkgdG8gcHJlc2VydmUgc3lt Ym9sIHNwYWNlLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1 bS9Gb250TGludXguY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Gb250 TGludXguY3BwCmluZGV4IDc5YjJjYWZiMDY3NzU3MTkyMzY0MWYwNjg0NDg4OGJiMzM2MDZlZDIu LjgyYjlkZjczMThiN2NjZGQwMmJhYWE2ZmU4Yjc0ZjgxZDIzZWJhYzkgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRm9udExpbnV4LmNwcAorKysgYi9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZvbnRMaW51eC5jcHAKQEAgLTM0MSw3ICsz NDEsNiBAQCB2b2lkIFRleHRSdW5XYWxrZXI6OnNldFBhZGRpbmcoaW50IHBhZGRpbmcpCiAgICAg Ly8gYW1vdW50IHRvIGVhY2ggc3BhY2UuIFRoZSBsYXN0IHNwYWNlIGdldHMgdGhlIHNtYWxsZXIg YW1vdW50LCBpZgogICAgIC8vIGFueS4KICAgICB1bnNpZ25lZCBudW1Xb3JkQnJlYWtzID0gMDsK LSAgICBib29sIGlzUlRMID0gbV9pdGVyYXRlQmFja3dhcmRzOwogCiAgICAgZm9yICh1bnNpZ25l ZCBpID0gMDsgaSA8IG1faXRlbS5zdHJpbmdMZW5ndGg7IGkrKykgewogICAgICAgICBpZiAoaXNX b3JkQnJlYWsoaSkpCkBAIC01MjQsNyArNTIzLDcgQEAgdm9pZCBUZXh0UnVuV2Fsa2VyOjpzZXRH bHlwaFhQb3NpdGlvbnMoYm9vbCBpc1JUTCkKICAgICAgICAgICAgICAgICAvLyBXaGl0ZXNwYWNl IG11c3QgYmUgbGFpZCBvdXQgaW4gbG9naWNhbCBvcmRlciwgc28gd2hlbiBpbnNlcnRpbmcKICAg ICAgICAgICAgICAgICAvLyBzcGFjZXMgaW4gUlRMIChidXQgaXRlcmF0aW5nIGluIExUUiBvcmRl cikgd2UgbXVzdCBpbnNlcnQgc3BhY2VzCiAgICAgICAgICAgICAgICAgLy8gX2JlZm9yZV8gdGhl IG5leHQgZ2x5cGguCi0gICAgICAgICAgICAgICAgaWYgKGkgKyAxID49IG1faXRlbS5udW1fZ2x5 cGhzIHx8IG1faXRlbS5hdHRyaWJ1dGVzW2kgKyAxXS5jbHVzdGVyU3RhcnQpCisgICAgICAgICAg ICAgICAgaWYgKHN0YXRpY19jYXN0PHVuc2lnbmVkPihpICsgMSkgPj0gbV9pdGVtLm51bV9nbHlw aHMgfHwgbV9pdGVtLmF0dHJpYnV0ZXNbaSArIDFdLmNsdXN0ZXJTdGFydCkKICAgICAgICAgICAg ICAgICAgICAgcG9zaXRpb24gKz0gbV9sZXR0ZXJTcGFjaW5nOwogCiAgICAgICAgICAgICAgICAg cG9zaXRpb24gKz0gZGV0ZXJtaW5lV29yZEJyZWFrU3BhY2luZyhsb2dDbHVzdGVyc0luZGV4KTsK QEAgLTU0MSw3ICs1NDAsNyBAQCB2b2lkIFRleHRSdW5XYWxrZXI6OnNldEdseXBoWFBvc2l0aW9u cyhib29sIGlzUlRMKQogICAgICAgICAgICAgICAgIHBvc2l0aW9uICs9IHRydW5jYXRlRml4ZWRQ b2ludFRvSW50ZWdlcihtX2l0ZW0uYWR2YW5jZXNbaV0pOwogICAgICAgICB9CiAgICAgfSBlbHNl IHsKLSAgICAgICAgZm9yIChpbnQgaSA9IDA7IGkgPCBtX2l0ZW0ubnVtX2dseXBoczsgKytpKSB7 CisgICAgICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgbV9pdGVtLm51bV9nbHlwaHM7ICsraSkg ewogICAgICAgICAgICAgbV9nbHlwaHMxNltpXSA9IG1faXRlbS5nbHlwaHNbaV07CiAgICAgICAg ICAgICBkb3VibGUgb2Zmc2V0WCA9IHRydW5jYXRlRml4ZWRQb2ludFRvSW50ZWdlcihtX2l0ZW0u b2Zmc2V0c1tpXS54KTsKICAgICAgICAgICAgIG1feFBvc2l0aW9uc1tpXSA9IG1fb2Zmc2V0WCAr IHBvc2l0aW9uICsgb2Zmc2V0WDsKQEAgLTU1Niw3ICs1NTUsNyBAQCB2b2lkIFRleHRSdW5XYWxr ZXI6OnNldEdseXBoWFBvc2l0aW9ucyhib29sIGlzUlRMKQogICAgICAgICAgICAgaWYgKG1faXRl bS5hdHRyaWJ1dGVzW2ldLmNsdXN0ZXJTdGFydCkKICAgICAgICAgICAgICAgICBhZHZhbmNlICs9 IG1fbGV0dGVyU3BhY2luZzsKIAotICAgICAgICAgICAgd2hpbGUgKGxvZ0NsdXN0ZXJzSW5kZXgg PCBtX2l0ZW0uaXRlbS5sZW5ndGggJiYgbG9nQ2x1c3RlcnMoKVtsb2dDbHVzdGVyc0luZGV4XSA9 PSBpKQorICAgICAgICAgICAgd2hpbGUgKHN0YXRpY19jYXN0PHVuc2lnbmVkPihsb2dDbHVzdGVy c0luZGV4KSA8IG1faXRlbS5pdGVtLmxlbmd0aCAmJiBsb2dDbHVzdGVycygpW2xvZ0NsdXN0ZXJz SW5kZXhdID09IGkpCiAgICAgICAgICAgICAgICAgbG9nQ2x1c3RlcnNJbmRleCsrOwogCiAgICAg ICAgICAgICBwb3NpdGlvbiArPSBhZHZhbmNlOwpAQCAtNzA4LDcgKzcwNyw3IEBAIHN0YXRpYyBp bnQgZ2x5cGhJbmRleEZvclhQb3NpdGlvbkluU2NyaXB0UnVuKGNvbnN0IFRleHRSdW5XYWxrZXIm IHdhbGtlciwgaW50IHgpCiAgICAgICAgIGZvciAoZ2x5cGhJbmRleCA9IHdhbGtlci5sZW5ndGgo KSAtIDE7IGdseXBoSW5kZXggPj0gMDsgLS1nbHlwaEluZGV4KSB7CiAgICAgICAgICAgICAvLyBX aGVuIGl0ZXJhdGluZyBMVFIgb3ZlciBSVEwgdGV4dCwgd2UgbXVzdCBpbmNsdWRlIHRoZSB3aGl0 ZXNwYWNlCiAgICAgICAgICAgICAvLyBfYmVmb3JlXyB0aGUgZ2x5cGgsIHNvIG5vICsgMSBoZXJl LgotICAgICAgICAgICAgaWYgKHggPCAod2Fsa2VyLmxlbmd0aCgpIC0gZ2x5cGhJbmRleCkgKiBs ZXR0ZXJTcGFjaW5nICsgdHJ1bmNhdGVGaXhlZFBvaW50VG9JbnRlZ2VyKGFkdmFuY2VzW2dseXBo SW5kZXhdKSkKKyAgICAgICAgICAgIGlmICh4IDwgKHN0YXRpY19jYXN0PGludD4od2Fsa2VyLmxl bmd0aCgpKSAtIGdseXBoSW5kZXgpICogbGV0dGVyU3BhY2luZyArIHRydW5jYXRlRml4ZWRQb2lu dFRvSW50ZWdlcihhZHZhbmNlc1tnbHlwaEluZGV4XSkpCiAgICAgICAgICAgICAgICAgYnJlYWs7 CiAgICAgICAgICAgICB4IC09IHRydW5jYXRlRml4ZWRQb2ludFRvSW50ZWdlcihhZHZhbmNlc1tn bHlwaEluZGV4XSk7CiAgICAgICAgIH0K