50161 2010-11-29 08:56:50 -0800 [GTK] Leaks in SoupCache code 2010-11-29 20:12:40 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P3 Normal --- 0 svillar webkit-unassigned commit-queue oldest_to_newest 314449 0 svillar 2010-11-29 08:56:50 -0800 ==16427== 32 bytes in 1 blocks are definitely lost in loss record 8,367 of 15,082 ==16427== at 0x4005BDC: malloc (vg_replace_malloc.c:195) ==16427== by 0x4005C66: realloc (vg_replace_malloc.c:476) ==16427== by 0x8EAC6F9: g_realloc (gmem.c:233) ==16427== by 0x8ECA744: g_string_maybe_expand (gstring.c:401) ==16427== by 0x8ECA7AB: g_string_sized_new (gstring.c:426) ==16427== by 0x7A5734C: soup_uri_to_string (soup-uri.c:435) ==16427== by 0x4C6DC86: soup_message_get_cache_key (soup-cache.c:279) ==16427== by 0x4C6F4F2: webkit_soup_cache_send_response (soup-cache.c:999) ==16427== by 0x4C6BE53: send_async_cb (soup-request-http.c:210) ==16427== by 0x8EA7174: g_timeout_dispatch (gmain.c:3873) ==16427== by 0x8EA402A: g_main_dispatch (gmain.c:2436) ==16427== by 0x8EA538E: g_main_context_dispatch (gmain.c:3009) ==16427== 104 bytes in 2 blocks are definitely lost in loss record 13,432 of 15,082 ==16427== at 0x4005BDC: malloc (vg_replace_malloc.c:195) ==16427== by 0x8EAC5E8: g_malloc (gmem.c:164) ==16427== by 0x8EC47A6: g_slice_alloc (gslice.c:842) ==16427== by 0x8EC47EB: g_slice_alloc0 (gslice.c:854) ==16427== by 0x7C172EB: g_type_create_instance (gtype.c:1867) ==16427== by 0x7BFD722: g_object_constructor (gobject.c:1603) ==16427== by 0x7BFCDEE: g_object_newv (gobject.c:1386) ==16427== by 0x7BFCB64: g_object_new (gobject.c:1298) ==16427== by 0x8DA3B81: g_simple_async_result_new (gsimpleasyncresult.c:322) ==16427== by 0x4C69CA4: webkit_soup_http_input_stream_send_async_internal (soup-http-input-stream.c:629) ==16427== by 0x4C69DC3: webkit_soup_http_input_stream_send_async (soup-http-input-stream.c:667) ==16427== by 0x4C6C16D: webkit_soup_request_http_send_async (soup-request-http.c:303) ==16427== 481 (144 direct, 337 indirect) bytes in 3 blocks are definitely lost in loss record 14,315 of 15,082 ==16427== at 0x4005BDC: malloc (vg_replace_malloc.c:195) ==16427== by 0x8EAC5E8: g_malloc (gmem.c:164) ==16427== by 0x8EC47A6: g_slice_alloc (gslice.c:842) ==16427== by 0x8E91FD1: g_hash_table_new_full (ghash.c:629) ==16427== by 0x7A3DEB3: parse_param_list (soup-headers.c:700) ==16427== by 0x7A3E022: soup_header_parse_param_list (soup-headers.c:761) ==16427== by 0x4C6D86A: get_cacheability (soup-cache.c:125) ==16427== by 0x4C702F2: webkit_soup_cache_get_cacheability (soup-cache.c:1403) ==16427== by 0x4C6F06B: msg_got_headers_cb (soup-cache.c:894) ==16427== by 0x7C11D7A: g_cclosure_marshal_VOID__VOID (gmarshal.c:79) ==16427== by 0x7BF8C5C: g_closure_invoke (gclosure.c:766) ==16427== by 0x7C1157B: signal_emit_unlocked_R (gsignal.c:3252) 314453 1 75036 svillar 2010-11-29 09:05:17 -0800 Created attachment 75036 Fix for the bug 314458 2 75036 mrobinson 2010-11-29 09:18:40 -0800 Comment on attachment 75036 Fix for the bug Great. 314687 3 commit-queue 2010-11-29 15:31:59 -0800 The commit-queue encountered the following flaky tests while processing attachment 75036: http/tests/appcache/foreign-fallback.html fast/workers/storage/use-same-database-in-page-and-workers.html Please file bugs against the tests. These tests were authored by ap@webkit.org and dumi@chromium.org. The commit-queue is continuing to process your patch. 314826 4 commit-queue 2010-11-29 19:20:30 -0800 The commit-queue encountered the following flaky tests while processing attachment 75036: fast/workers/storage/use-same-database-in-page-and-workers.html inspector/elements-panel-xhtml-structure.xhtml Please file bugs against the tests. These tests were authored by apavlov@chromium.org, dumi@chromium.org, and pfeldman@chromium.org. The commit-queue is continuing to process your patch. 314830 5 commit-queue 2010-11-29 19:55:26 -0800 The commit-queue encountered the following flaky tests while processing attachment 75036: transitions/transition-end-event-transform.html fast/workers/storage/use-same-database-in-page-and-workers.html Please file bugs against the tests. These tests were authored by dino@apple.com, dumi@chromium.org, ojan@chromium.org, and pol@apple.com. The commit-queue is continuing to process your patch. 314833 6 75036 commit-queue 2010-11-29 20:12:35 -0800 Comment on attachment 75036 Fix for the bug Clearing flags on attachment: 75036 Committed r72870: <http://trac.webkit.org/changeset/72870> 314834 7 commit-queue 2010-11-29 20:12:40 -0800 All reviewed patches have been landed. Closing bug. 75036 2010-11-29 09:05:17 -0800 2010-11-29 20:12:35 -0800 Fix for the bug 0001-Fix-for-50161.patch text/plain 5018 svillar RnJvbSA2MTViZmVhODAzZGFiNDc4ZGQ3NGRkYTRmZjM5NTBjOTkxNTczNzM1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTZXJnaW8gVmlsbGFyIFNlbmluIDxzdmlsbGFyQGlnYWxpYS5j b20+CkRhdGU6IE1vbiwgMjkgTm92IDIwMTAgMTg6MDM6MzggKzAxMDAKU3ViamVjdDogW1BBVENI XSBGaXggZm9yIDUwMTYxCgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHwgICAxNyArKysrKysrKysrKysrKysrKwogLi4uL25ldHdvcmsvc291 cC9jYWNoZS9zb3VwLWh0dHAtaW5wdXQtc3RyZWFtLmMgICAgfCAgICAxICsKIC4uLi9uZXR3b3Jr L3NvdXAvY2FjaGUvd2Via2l0L3NvdXAtY2FjaGUuYyAgICAgICAgIHwgICAxOCArKysrKysrKyst LS0tLS0tLS0KIDMgZmlsZXMgY2hhbmdlZCwgMjcgaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmlu ZGV4IDlkYjAxNWIuLmE4M2QzYjEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBi L1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTAtMTEtMjkgIFNlcmdpbyBW aWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gTGVha3MgaW4gU291cENhY2hlIGNvZGUK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUwMTYxCisK KyAgICAgICAgRml4ZXMgc29tZSBtZW1vcnkgbGVha3MgaW4gU291cENhY2hlIGNvZGUuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3NvdXAvY2FjaGUvc291cC1odHRwLWlucHV0LXN0cmVh bS5jOgorICAgICAgICAoc2VuZF9hc3luY19maW5pc2hlZCk6IEFkZGVkIGEgbWlzc2luZyBnX29i amVjdF91bnJlZi4KKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3NvdXAvY2FjaGUvd2Via2l0 L3NvdXAtY2FjaGUuYzoKKyAgICAgICAgKGdldF9jYWNoZWFiaWxpdHkpOiBBZGRlZCBzb3VwX2hl YWRlcl9mcmVlX3BhcmFtX2xpc3QuCisgICAgICAgICh3ZWJraXRfc291cF9jYWNoZV9lbnRyeV9z ZXRfZnJlc2huZXNzKTogRGl0dG8uCisgICAgICAgICh3ZWJraXRfc291cF9jYWNoZV9zZW5kX3Jl c3BvbnNlKTogRGl0dG8uCisgICAgICAgICh3ZWJraXRfc291cF9jYWNoZV9oYXNfcmVzcG9uc2Up OiBEaXR0by4KKwogMjAxMC0xMS0yOCAgRGltaXRyaSBHbGF6a292ICA8ZGdsYXprb3ZAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvY2FjaGUvc291cC1odHRwLWlucHV0LXN0cmVh bS5jIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvY2FjaGUvc291cC1odHRwLWlucHV0 LXN0cmVhbS5jCmluZGV4IGRjOTVkNmUuLjE5NWM0NTggMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxh dGZvcm0vbmV0d29yay9zb3VwL2NhY2hlL3NvdXAtaHR0cC1pbnB1dC1zdHJlYW0uYworKysgYi9X ZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9jYWNoZS9zb3VwLWh0dHAtaW5wdXQtc3RyZWFt LmMKQEAgLTU5OCw2ICs1OTgsNyBAQCBzZW5kX2FzeW5jX2ZpbmlzaGVkIChHSW5wdXRTdHJlYW0g KnN0cmVhbSkKIAkJZ19lcnJvcl9mcmVlIChlcnJvcik7CiAJfQogCWdfc2ltcGxlX2FzeW5jX3Jl c3VsdF9jb21wbGV0ZSAocmVzdWx0KTsKKwlnX29iamVjdF91bnJlZiAocmVzdWx0KTsKIH0KIAog c3RhdGljIHZvaWQKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL2Nh Y2hlL3dlYmtpdC9zb3VwLWNhY2hlLmMgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9j YWNoZS93ZWJraXQvc291cC1jYWNoZS5jCmluZGV4IDQ4MzU3NTAuLmYxZTU5NDkgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL2NhY2hlL3dlYmtpdC9zb3VwLWNhY2hl LmMKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvY2FjaGUvd2Via2l0L3NvdXAt Y2FjaGUuYwpAQCAtMTQ3LDYgKzE0Nyw4IEBAIGdldF9jYWNoZWFiaWxpdHkgKFdlYktpdFNvdXBD YWNoZSAqY2FjaGUsIFNvdXBNZXNzYWdlICptc2cpCiAJCQlzb3VwX2hlYWRlcl9mcmVlX3BhcmFt X2xpc3QgKGhhc2gpOwogCQkJcmV0dXJuIFdFQktJVF9TT1VQX0NBQ0hFX1VOQ0FDSEVBQkxFOwog CQl9CisKKwkJc291cF9oZWFkZXJfZnJlZV9wYXJhbV9saXN0IChoYXNoKTsKIAl9CiAKIAlzd2l0 Y2ggKG1zZy0+c3RhdHVzX2NvZGUpIHsKQEAgLTI4NCwxNCArMjg2LDEyIEBAIHdlYmtpdF9zb3Vw X2NhY2hlX2VudHJ5X3NldF9mcmVzaG5lc3MgKFdlYktpdFNvdXBDYWNoZUVudHJ5ICplbnRyeSwg U291cE1lc3NhZ2UKIHsKIAljb25zdCBjaGFyICpjYWNoZV9jb250cm9sOwogCWNvbnN0IGNoYXIg KmV4cGlyZXMsICpkYXRlLCAqbGFzdF9tb2RpZmllZDsKLQlHSGFzaFRhYmxlICpoYXNoOwotCi0J aGFzaCA9IE5VTEw7CiAKIAljYWNoZV9jb250cm9sID0gc291cF9tZXNzYWdlX2hlYWRlcnNfZ2V0 IChlbnRyeS0+aGVhZGVycywgIkNhY2hlLUNvbnRyb2wiKTsKIAlpZiAoY2FjaGVfY29udHJvbCkg ewogCQljb25zdCBjaGFyICptYXhfYWdlLCAqc19tYXhhZ2U7CiAJCWdpbnQ2NCBmcmVzaG5lc3Nf bGlmZXRpbWUgPSAwOworCQlHSGFzaFRhYmxlICpoYXNoOwogCQlXZWJLaXRTb3VwQ2FjaGVQcml2 YXRlICpwcml2ID0gV0VCS0lUX1NPVVBfQ0FDSEVfR0VUX1BSSVZBVEUgKGNhY2hlKTsKIAogCQlo YXNoID0gc291cF9oZWFkZXJfcGFyc2VfcGFyYW1fbGlzdCAoY2FjaGVfY29udHJvbCk7CkBAIC0z MjMsMTAgKzMyMyw5IEBAIHdlYmtpdF9zb3VwX2NhY2hlX2VudHJ5X3NldF9mcmVzaG5lc3MgKFdl YktpdFNvdXBDYWNoZUVudHJ5ICplbnRyeSwgU291cE1lc3NhZ2UKIAkJCXNvdXBfaGVhZGVyX2Zy ZWVfcGFyYW1fbGlzdCAoaGFzaCk7CiAJCQlyZXR1cm47CiAJCX0KLQl9CiAKLQlpZiAoaGFzaCAh PSBOVUxMKQogCQlzb3VwX2hlYWRlcl9mcmVlX3BhcmFtX2xpc3QgKGhhc2gpOworCX0KIAogCS8q IElmIHRoZSAnRXhwaXJlcycgcmVzcG9uc2UgaGVhZGVyIGlzIHByZXNlbnQsIHVzZSBpdHMgdmFs dWUKIAkgKiBtaW51cyB0aGUgdmFsdWUgb2YgdGhlICdEYXRlJyByZXNwb25zZSBoZWFkZXIKQEAg LTk5OCw2ICs5OTcsNyBAQCB3ZWJraXRfc291cF9jYWNoZV9zZW5kX3Jlc3BvbnNlIChXZWJLaXRT b3VwQ2FjaGUgKmNhY2hlLCBTb3VwTWVzc2FnZSAqbXNnKQogCiAJa2V5ID0gc291cF9tZXNzYWdl X2dldF9jYWNoZV9rZXkgKG1zZyk7CiAJZW50cnkgPSBnX2hhc2hfdGFibGVfbG9va3VwIChjYWNo ZS0+cHJpdi0+Y2FjaGUsIGtleSk7CisJZ19mcmVlIChrZXkpOwogCWdfcmV0dXJuX3ZhbF9pZl9m YWlsIChlbnRyeSwgTlVMTCk7CiAKIAkvKiBJZiB3ZSBhcmUgdG9sZCB0byBzZW5kIGEgcmVzcG9u c2UgZnJvbSBjYWNoZSBhbnkgdmFsaWRhdGlvbgpAQCAtMTI1Nyw3ICsxMjU3LDYgQEAgd2Via2l0 X3NvdXBfY2FjaGVfaGFzX3Jlc3BvbnNlIChXZWJLaXRTb3VwQ2FjaGUgKmNhY2hlLCBTb3VwTWVz c2FnZSAqbXNnKQogCWNoYXIgKmtleTsKIAlXZWJLaXRTb3VwQ2FjaGVFbnRyeSAqZW50cnk7CiAJ Y29uc3QgY2hhciAqY2FjaGVfY29udHJvbDsKLQlHSGFzaFRhYmxlICpoYXNoOwogCWdwb2ludGVy IHZhbHVlOwogCWdib29sZWFuIG11c3RfcmV2YWxpZGF0ZTsKIAlpbnQgbWF4X2FnZSwgbWF4X3N0 YWxlLCBtaW5fZnJlc2g7CkBAIC0xMjY1LDYgKzEyNjQsNyBAQCB3ZWJraXRfc291cF9jYWNoZV9o YXNfcmVzcG9uc2UgKFdlYktpdFNvdXBDYWNoZSAqY2FjaGUsIFNvdXBNZXNzYWdlICptc2cpCiAK IAlrZXkgPSBzb3VwX21lc3NhZ2VfZ2V0X2NhY2hlX2tleSAobXNnKTsKIAllbnRyeSA9IGdfaGFz aF90YWJsZV9sb29rdXAgKGNhY2hlLT5wcml2LT5jYWNoZSwga2V5KTsKKwlnX2ZyZWUgKGtleSk7 CiAKIAkvKiAxLiBUaGUgcHJlc2VudGVkIFJlcXVlc3QtVVJJIGFuZCB0aGF0IG9mIHN0b3JlZCBy ZXNwb25zZQogCSAqIG1hdGNoCkBAIC0xMzIxLDEwICsxMzIxLDEwIEBAIHdlYmtpdF9zb3VwX2Nh Y2hlX2hhc19yZXNwb25zZSAoV2ViS2l0U291cENhY2hlICpjYWNoZSwgU291cE1lc3NhZ2UgKm1z ZykKIAogCWNhY2hlX2NvbnRyb2wgPSBzb3VwX21lc3NhZ2VfaGVhZGVyc19nZXQgKG1zZy0+cmVx dWVzdF9oZWFkZXJzLCAiQ2FjaGUtQ29udHJvbCIpOwogCWlmIChjYWNoZV9jb250cm9sKSB7Ci0J CWhhc2ggPSBzb3VwX2hlYWRlcl9wYXJzZV9wYXJhbV9saXN0IChjYWNoZV9jb250cm9sKTsKKwkJ R0hhc2hUYWJsZSAqaGFzaCA9IHNvdXBfaGVhZGVyX3BhcnNlX3BhcmFtX2xpc3QgKGNhY2hlX2Nv bnRyb2wpOwogCiAJCWlmIChnX2hhc2hfdGFibGVfbG9va3VwX2V4dGVuZGVkIChoYXNoLCAibm8t c3RvcmUiLCBOVUxMLCBOVUxMKSkgewotCQkJZ19oYXNoX3RhYmxlX2Rlc3Ryb3kgKGhhc2gpOwor CQkJc291cF9oZWFkZXJfZnJlZV9wYXJhbV9saXN0IChoYXNoKTsKIAkJCXJldHVybiBXRUJLSVRf U09VUF9DQUNIRV9SRVNQT05TRV9TVEFMRTsKIAkJfQogCkBAIC0xMzQ4LDcgKzEzNDgsNyBAQCB3 ZWJraXRfc291cF9jYWNoZV9oYXNfcmVzcG9uc2UgKFdlYktpdFNvdXBDYWNoZSAqY2FjaGUsIFNv dXBNZXNzYWdlICptc2cpCiAJCWlmICh2YWx1ZSkKIAkJCW1pbl9mcmVzaCA9IChpbnQpTUlOIChn X2FzY2lpX3N0cnRvbGwgKHZhbHVlLCBOVUxMLCAxMCksIEdfTUFYSU5UMzIpOwogCi0JCWdfaGFz aF90YWJsZV9kZXN0cm95IChoYXNoKTsKKwkJc291cF9oZWFkZXJfZnJlZV9wYXJhbV9saXN0ICho YXNoKTsKIAogCQlpZiAobWF4X2FnZSAhPSAtMSkgewogCQkJZ3VpbnQgY3VycmVudF9hZ2UgPSB3 ZWJraXRfc291cF9jYWNoZV9lbnRyeV9nZXRfY3VycmVudF9hZ2UgKGVudHJ5KTsKLS0gCjEuNy4x Cgo=