50154 2010-11-29 07:12:30 -0800 [GTK] Null-check needed in DRT's AccessibilityUIElement::allAtributes() 2010-11-29 10:35:53 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 mario webkit-unassigned abarth eric webkit.review.bot oldest_to_newest 314391 0 mario 2010-11-29 07:12:30 -0800 Currently, we're getting the following stderr output when running LayoutTests/accessibility/non-data-table-cell-title-ui-element.html: atk_object_get_attributes: assertion `ATK_IS_OBJECT (accessible)' failed ...which is caused because of the following function in DRT is not properly checking m_element, as it's done in the rest of the functions. 314422 1 75028 mario 2010-11-29 08:27:00 -0800 Created attachment 75028 Patch proposal Attached -yet another really simple- patch to fix this issue, found while working on bug 50062 (unrelated, though) 314437 2 75034 mario 2010-11-29 08:43:01 -0800 Created attachment 75034 Patch proposal Sorry, need to sleep better the night before when I'm planning to multitask as I'm doing today... Now attaching the right patch 314442 3 75034 mrobinson 2010-11-29 08:45:56 -0800 Comment on attachment 75034 Patch proposal Looks good. No test needed for this, as it should fix an issue observed during tests. 314460 4 mario 2010-11-29 09:24:24 -0800 Committed r72804: <http://trac.webkit.org/changeset/72804> 314504 5 webkit.review.bot 2010-11-29 10:35:53 -0800 http://trac.webkit.org/changeset/72804 might have broken Leopard Intel Release (Tests) 75028 2010-11-29 08:27:00 -0800 2010-11-29 08:43:01 -0800 Patch proposal 0001-2010-11-29-Mario-Sanchez-Prada-msanchez-igalia.com.patch text/plain 2087 mario RnJvbSBkNjc4ZmIzZjYzMzgxNWQ0YTE3NDM5Y2Y1ZDI2ZmQ4YTgyNmZiNzk0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBNb24sIDI5IE5vdiAyMDEwIDE3OjE3OjI5ICswMTAwClN1YmplY3Q6IFtQQVRD SF0gMjAxMC0xMS0yOSAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+ CgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBbR1RLXSBOdWxs LWNoZWNrIG5lZWRlZCBpbiBEUlQncyBBY2Nlc3NpYmlsaXR5VUlFbGVtZW50OjphbGxBdHJpYnV0 ZXMoKQogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MDE1 NAoKICAgICAgICBBZGRlZCBtaXNzaW5nIGNoZWNrcyB0byBhbGxBdHRyaWJ1dGVzKCkuCgogICAg ICAgICogRHVtcFJlbmRlclRyZWUvZ3RrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRHdGsuY3BwOgog ICAgICAgIChBY2Nlc3NpYmlsaXR5VUlFbGVtZW50OjphbGxBdHRyaWJ1dGVzKTogQWRkZWQgbWlz c2luZyBjaGVja3MuCi0tLQogV2ViS2l0VG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgfCAgIDEyICsrKysrKysrKysrKwogLi4uL2d0ay9BY2Nlc3NpYmlsaXR5VUlF bGVtZW50R3RrLmNwcCAgICAgICAgICAgICAgfCAgICA0ICsrKysKIDIgZmlsZXMgY2hhbmdlZCwg MTYgaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKaW5kZXggMTQxMmVlMi4uNTIzNmY4 MyAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCisrKyBiL1dlYktpdFRvb2xzL0No YW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEwLTExLTI5ICBNYXJpbyBTYW5jaGV6IFByYWRh ICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBbR1RLXSBOdWxsLWNoZWNrIG5lZWRlZCBpbiBEUlQncyBBY2Nlc3Np YmlsaXR5VUlFbGVtZW50OjphbGxBdHJpYnV0ZXMoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTAxNTQKKworICAgICAgICBBZGRlZCBtaXNzaW5nIGNo ZWNrcyB0byBhbGxBdHRyaWJ1dGVzKCkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9ndGsv QWNjZXNzaWJpbGl0eVVJRWxlbWVudEd0ay5jcHA6CisgICAgICAgIChBY2Nlc3NpYmlsaXR5VUlF bGVtZW50OjphbGxBdHRyaWJ1dGVzKTogQWRkZWQgbWlzc2luZyBjaGVja3MuCisKIDIwMTAtMTEt MjQgIEFuZHJhcyBCZWNzaSAgPGFiZWNzaUBpbmYudS1zemVnZWQuaHU+CiAKICAgICAgICAgVW5y ZXZpZXdlZC4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9BY2Nl c3NpYmlsaXR5VUlFbGVtZW50R3RrLmNwcCBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0 ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50R3RrLmNwcAppbmRleCA4NDkzZjFhLi42OGVkZTNkIDEw MDY0NAotLS0gYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvQWNjZXNzaWJpbGl0eVVJ RWxlbWVudEd0ay5jcHAKKysrIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0FjY2Vz c2liaWxpdHlVSUVsZW1lbnRHdGsuY3BwCkBAIC0xNTEsNiArMTUxLDEwIEBAIGdjaGFyKiBhdHRy aWJ1dGVTZXRUb1N0cmluZyhBdGtBdHRyaWJ1dGVTZXQqIGF0dHJpYnV0ZVNldCkKIAogSlNTdHJp bmdSZWYgQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6YWxsQXR0cmlidXRlcygpCiB7CisgICAgaWYg KCFtX2VsZW1lbnQpCisgICAgICAgIHJldHVybiAwOworCisgICAgQVNTRVJUKEFUS19JU19PQkpF Q1QobV9lbGVtZW50KSk7CiAgICAgcmV0dXJuIEpTU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5n KGF0dHJpYnV0ZVNldFRvU3RyaW5nKGF0a19vYmplY3RfZ2V0X2F0dHJpYnV0ZXMoQVRLX09CSkVD VChtX2VsZW1lbnQpKSkpOwogfQogCi0tIAoxLjcuMy4yCgo= 75034 2010-11-29 08:43:01 -0800 2010-11-29 08:45:56 -0800 Patch proposal 0001-2010-11-29-Mario-Sanchez-Prada-msanchez-igalia.com.patch text/plain 2120 mario RnJvbSAwZjljNDA5NTIwZjBmN2NhNjM5YjQ1ZWMxZWZmMTY2NzVlNWU2ZWQ4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBNb24sIDI5IE5vdiAyMDEwIDE3OjE3OjI5ICswMTAwClN1YmplY3Q6IFtQQVRD SF0gMjAxMC0xMS0yOSAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+ CgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBbR1RLXSBOdWxs LWNoZWNrIG5lZWRlZCBpbiBEUlQncyBBY2Nlc3NpYmlsaXR5VUlFbGVtZW50OjphbGxBdHJpYnV0 ZXMoKQogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MDE1 NAoKICAgICAgICBBZGRlZCBtaXNzaW5nIGNoZWNrcyB0byBhbGxBdHRyaWJ1dGVzKCkuCgogICAg ICAgICogRHVtcFJlbmRlclRyZWUvZ3RrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRHdGsuY3BwOgog ICAgICAgIChBY2Nlc3NpYmlsaXR5VUlFbGVtZW50OjphbGxBdHRyaWJ1dGVzKTogQWRkZWQgbWlz c2luZyBjaGVja3MuCi0tLQogV2ViS2l0VG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgfCAgIDEyICsrKysrKysrKysrKwogLi4uL2d0ay9BY2Nlc3NpYmlsaXR5VUlF bGVtZW50R3RrLmNwcCAgICAgICAgICAgICAgfCAgICA0ICsrKysKIDIgZmlsZXMgY2hhbmdlZCwg MTYgaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKaW5kZXggMTQxMmVlMi4uNTIzNmY4 MyAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCisrKyBiL1dlYktpdFRvb2xzL0No YW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEwLTExLTI5ICBNYXJpbyBTYW5jaGV6IFByYWRh ICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBbR1RLXSBOdWxsLWNoZWNrIG5lZWRlZCBpbiBEUlQncyBBY2Nlc3Np YmlsaXR5VUlFbGVtZW50OjphbGxBdHJpYnV0ZXMoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTAxNTQKKworICAgICAgICBBZGRlZCBtaXNzaW5nIGNo ZWNrcyB0byBhbGxBdHRyaWJ1dGVzKCkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9ndGsv QWNjZXNzaWJpbGl0eVVJRWxlbWVudEd0ay5jcHA6CisgICAgICAgIChBY2Nlc3NpYmlsaXR5VUlF bGVtZW50OjphbGxBdHRyaWJ1dGVzKTogQWRkZWQgbWlzc2luZyBjaGVja3MuCisKIDIwMTAtMTEt MjQgIEFuZHJhcyBCZWNzaSAgPGFiZWNzaUBpbmYudS1zemVnZWQuaHU+CiAKICAgICAgICAgVW5y ZXZpZXdlZC4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9BY2Nl c3NpYmlsaXR5VUlFbGVtZW50R3RrLmNwcCBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0 ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50R3RrLmNwcAppbmRleCA4NDkzZjFhLi5lMDlkZTMzIDEw MDY0NAotLS0gYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvQWNjZXNzaWJpbGl0eVVJ RWxlbWVudEd0ay5jcHAKKysrIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0FjY2Vz c2liaWxpdHlVSUVsZW1lbnRHdGsuY3BwCkBAIC0xNTEsNiArMTUxLDEwIEBAIGdjaGFyKiBhdHRy aWJ1dGVTZXRUb1N0cmluZyhBdGtBdHRyaWJ1dGVTZXQqIGF0dHJpYnV0ZVNldCkKIAogSlNTdHJp bmdSZWYgQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6YWxsQXR0cmlidXRlcygpCiB7CisgICAgaWYg KCFtX2VsZW1lbnQpCisgICAgICAgIHJldHVybiBKU1N0cmluZ0NyZWF0ZVdpdGhDaGFyYWN0ZXJz KDAsIDApOworCisgICAgQVNTRVJUKEFUS19JU19PQkpFQ1QobV9lbGVtZW50KSk7CiAgICAgcmV0 dXJuIEpTU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKGF0dHJpYnV0ZVNldFRvU3RyaW5nKGF0 a19vYmplY3RfZ2V0X2F0dHJpYnV0ZXMoQVRLX09CSkVDVChtX2VsZW1lbnQpKSkpOwogfQogCi0t IAoxLjcuMy4yCgo=