50148 2010-11-29 04:16:50 -0800 [chromium] pass webframe to web frame client's cookieJar 2010-11-30 02:36:42 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jochen jochen commit-queue fishd oldest_to_newest 314350 0 jochen 2010-11-29 04:16:50 -0800 [chromium] pass webframe to web frame client's cookieJar 314351 1 75014 jochen 2010-11-29 04:18:28 -0800 Created attachment 75014 Patch 314438 2 75014 fishd 2010-11-29 08:44:14 -0800 Comment on attachment 75014 Patch To avoid breaking Chromium builds with this commit, I think you should land a Chromium change first that has RenderView::cookieJar(WebFrame*) implemented. That way, when this patch lands, everything will continue working. 314456 3 jochen 2010-11-29 09:10:02 -0800 landed chromium side 314655 4 75014 commit-queue 2010-11-29 14:32:46 -0800 Comment on attachment 75014 Patch Rejecting patch 75014 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 2 Last 500 characters of output: c++ com.apple.compilers.gcc.4_2 CompileC /Projects/CommitQueue/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/x86_64/RenderStyle.o /Projects/CommitQueue/WebCore/rendering/style/RenderStyle.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 CompileC /Projects/CommitQueue/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/x86_64/RenderSVGContainer.o /Projects/CommitQueue/WebCore/rendering/RenderSVGContainer.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 (358 failures) Full output: http://queues.webkit.org/results/6400105 314889 5 75014 abarth 2010-11-30 00:23:20 -0800 Comment on attachment 75014 Patch Compile failed, but maybe try again? 314897 6 75014 commit-queue 2010-11-30 01:17:21 -0800 Comment on attachment 75014 Patch Rejecting patch 75014 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 2 Last 500 characters of output: e/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/JSSVGPolygonElement.o /Projects/CommitQueue/WebKitBuild/Release/DerivedSources/WebCore/JSSVGPolygonElement.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 CompileC /Projects/CommitQueue/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/JSSVGStyleElement.o /Projects/CommitQueue/WebKitBuild/Release/DerivedSources/WebCore/JSSVGStyleElement.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 (305 failures) Full output: http://queues.webkit.org/results/6354102 314905 7 75014 jochen 2010-11-30 02:10:11 -0800 Comment on attachment 75014 Patch trying commit queue once more after rolling chromium deps 314913 8 75014 commit-queue 2010-11-30 02:36:37 -0800 Comment on attachment 75014 Patch Clearing flags on attachment: 75014 Committed r72901: <http://trac.webkit.org/changeset/72901> 314914 9 commit-queue 2010-11-30 02:36:42 -0800 All reviewed patches have been landed. Closing bug. 75014 2010-11-29 04:18:28 -0800 2010-11-30 02:36:37 -0800 Patch bug-50148-20101129131826.patch text/plain 2076 jochen ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDRmNWIyMWEyNjhkMWVmMTZmZWFkYWNmMjg4NjZiNTlkYzAwOTRiM2Yu LjZlYjY4OWFiMTM5NmZiNGM3ZWQzNDliODE3ZTMyNzU0Yjk0OGNkODcgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE1IEBACisyMDEwLTExLTI5ICBKb2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hy b21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFtjaHJvbWl1bV0gcGFzcyB3ZWJmcmFtZSB0byB3ZWIgZnJhbWUgY2xpZW50J3MgY29va2ll SmFyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MDE0 OAorCisgICAgICAgICogcHVibGljL1dlYkZyYW1lQ2xpZW50Lmg6CisgICAgICAgIChXZWJLaXQ6 OldlYkZyYW1lQ2xpZW50Ojpjb29raWVKYXIpOgorICAgICAgICAqIHNyYy9DaHJvbWl1bUJyaWRn ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpnZXRDb29raWVKYXIpOgorCiAyMDEwLTExLTI2ICBB bmRyZWkgUG9wZXNjdSAgPGFuZHJlaXBAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBKZXJlbXkgT3Jsb3cuCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZy YW1lQ2xpZW50LmggYi9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZyYW1lQ2xpZW50LmgKaW5k ZXggOTA2MzM1MDBkOTBhNzY0ZThlYjY4ZmYwNmNjNzYyMDUwZjkxYWUzOS4uMWM2ZmQwNGFmMWE2 MDlhODNlYTBlZjA3MDFjNzJlYmY2MDQ2ZmI5MiAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVt L3B1YmxpYy9XZWJGcmFtZUNsaWVudC5oCisrKyBiL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2Vi RnJhbWVDbGllbnQuaApAQCAtODYsNyArODYsNyBAQCBwdWJsaWM6CiAKICAgICAvLyBBIGZyYW1l IHNwZWNpZmljIGNvb2tpZSBqYXIuICBNYXkgcmV0dXJuIG51bGwsIGluIHdoaWNoIGNhc2UKICAg ICAvLyBXZWJLaXRDbGllbnQ6OmNvb2tpZUphcigpIHdpbGwgYmUgY2FsbGVkIHRvIGFjY2VzcyBj b29raWVzLgotICAgIHZpcnR1YWwgV2ViQ29va2llSmFyKiBjb29raWVKYXIoKSB7IHJldHVybiAw OyB9CisgICAgdmlydHVhbCBXZWJDb29raWVKYXIqIGNvb2tpZUphcihXZWJGcmFtZSopIHsgcmV0 dXJuIDA7IH0KIAogCiAgICAgLy8gR2VuZXJhbCBub3RpZmljYXRpb25zIC0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hy b21pdW0vc3JjL0Nocm9taXVtQnJpZGdlLmNwcCBiL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21p dW1CcmlkZ2UuY3BwCmluZGV4IDRhYzNmNmY2OGM4MWIwM2RjZDk2ZWEzOTczZDIxZTVjNWQ2MTE1 ZjguLmU3YTEzMDUyMTQ2NzlmMjdlNDU3N2JkNjBjZTgxOTNmYTY1ODNiMzUgMTAwNjQ0Ci0tLSBh L1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21pdW1CcmlkZ2UuY3BwCisrKyBiL1dlYktpdC9jaHJv bWl1bS9zcmMvQ2hyb21pdW1CcmlkZ2UuY3BwCkBAIC0xMzQsNyArMTM0LDcgQEAgc3RhdGljIFdl YkNvb2tpZUphciogZ2V0Q29va2llSmFyKGNvbnN0IERvY3VtZW50KiBkb2N1bWVudCkKICAgICBX ZWJGcmFtZUltcGwqIGZyYW1lSW1wbCA9IFdlYkZyYW1lSW1wbDo6ZnJvbUZyYW1lKGRvY3VtZW50 LT5mcmFtZSgpKTsKICAgICBpZiAoIWZyYW1lSW1wbCB8fCAhZnJhbWVJbXBsLT5jbGllbnQoKSkK ICAgICAgICAgcmV0dXJuIDA7Ci0gICAgV2ViQ29va2llSmFyKiBjb29raWVKYXIgPSBmcmFtZUlt cGwtPmNsaWVudCgpLT5jb29raWVKYXIoKTsKKyAgICBXZWJDb29raWVKYXIqIGNvb2tpZUphciA9 IGZyYW1lSW1wbC0+Y2xpZW50KCktPmNvb2tpZUphcihmcmFtZUltcGwpOwogICAgIGlmICghY29v a2llSmFyKQogICAgICAgICBjb29raWVKYXIgPSB3ZWJLaXRDbGllbnQoKS0+Y29va2llSmFyKCk7 CiAgICAgcmV0dXJuIGNvb2tpZUphcjsK