50138 2010-11-28 22:40:17 -0800 Web Inspector: $x: any node should work in optional context parameter. 2011-02-08 07:38:21 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Enhancement --- 0 yonathan webkit-unassigned apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 314260 0 74987 yonathan 2010-11-28 22:40:17 -0800 Created attachment 74987 patch for the $x function. The optional context parameter of the $x function currently has to be a document, but it should allow any node. Note: Firebug's $x doesn't have the context parameter at all. Example invocation: $x('body', document.documentElement) 314312 1 74987 apavlov 2010-11-29 01:53:21 -0800 Comment on attachment 74987 patch for the $x function. This change lacks at least a ChangeLog entry. Please see http://webkit.org/coding/contributing.html for contributing guidelines. I'm not a reviewer to r- the change, though. 314597 2 pfeldman 2010-11-29 13:30:55 -0800 This change looks good. Please include WebCore/ChangeLog entry pointing to this bug (see other entries for reference) and I'll be able to r+ it. Thanks for the patch! 315868 3 75319 yonathan 2010-12-01 13:56:35 -0800 Created attachment 75319 Patch to $x function including ChangeLog. 315870 4 yonathan 2010-12-01 13:59:29 -0800 Sorry it took so long to get the patch with ChangeLog. I recompiled and tried to make a unit test but apparently $x isn't available in injection tests (at least with --use-drt). 347291 5 75319 pfeldman 2011-02-08 05:30:52 -0800 Comment on attachment 75319 Patch to $x function including ChangeLog. I'll rebase and land. 347357 6 pfeldman 2011-02-08 07:35:53 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebCore/ChangeLog M Source/WebCore/inspector/InjectedScriptSource.js Committed r77931 347358 7 pfeldman 2011-02-08 07:38:21 -0800 I accidentally generated changelog entry with my name, will fix it in the next commit. 74987 2010-11-28 22:40:17 -0800 2010-12-01 13:56:35 -0800 patch for the $x function. x.patch text/plain 781 yonathan SW5kZXg6IFdlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9JbmplY3RlZFNjcmlwdC5qcwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSW5qZWN0ZWRTY3JpcHQuanMJ KHJldmlzaW9uIDY4NjUxKQorKysgV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0luamVjdGVk U2NyaXB0LmpzCSh3b3JraW5nIGNvcHkpCkBAIC02MjQsOCArNjI0LDkgQEAgQ29tbWFuZExpbmVB UEkucHJvdG90eXBlID0gewogICAgIHsKICAgICAgICAgdmFyIG5vZGVzID0gW107CiAgICAgICAg IHRyeSB7Ci0gICAgICAgICAgICB2YXIgZG9jID0gY29udGV4dCB8fCBkb2N1bWVudDsKLSAgICAg ICAgICAgIHZhciByZXN1bHRzID0gZG9jLmV2YWx1YXRlKHhwYXRoLCBkb2MsIG51bGwsIFhQYXRo UmVzdWx0LkFOWV9UWVBFLCBudWxsKTsKKyAgICAgICAgICAgIGNvbnRleHQgPSBjb250ZXh0IHx8 IGRvY3VtZW50OworICAgICAgICAgICAgdmFyIGRvYyA9IGNvbnRleHQub3duZXJEb2N1bWVudCB8 fCBjb250ZXh0OworICAgICAgICAgICAgdmFyIHJlc3VsdHMgPSBkb2MuZXZhbHVhdGUoeHBhdGgs IGNvbnRleHQsIG51bGwsIFhQYXRoUmVzdWx0LkFOWV9UWVBFLCBudWxsKTsKICAgICAgICAgICAg IHZhciBub2RlOwogICAgICAgICAgICAgd2hpbGUgKG5vZGUgPSByZXN1bHRzLml0ZXJhdGVOZXh0 KCkpCiAgICAgICAgICAgICAgICAgbm9kZXMucHVzaChub2RlKTsKCg== 75319 2010-12-01 13:56:35 -0800 2011-02-08 05:30:52 -0800 Patch to $x function including ChangeLog. x.patch text/plain 1356 yonathan SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDczMDYz KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMTIt MDEgIFlvbmF0aGFuIFJhbmRvbHBoICA8eW9uYXRoYW5AZ21haWwuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6ICR4OiBh bnkgbm9kZSBzaG91bGQgd29yayBpbiBvcHRpb25hbCBjb250ZXh0IHBhcmFtZXRlci4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUwMTM4CisKKyAgICAg ICAgVGhyZWUgYXJlbid0IGFueSB0ZXN0cyBmb3IgQ29tbWFuZExpbmVBUEkgZnVuY3Rpb25zLgor CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9JbmplY3RlZFNjcmlwdC5qczoKKyAgICAg ICAgKGluamVjdGVkU2NyaXB0Q29uc3RydWN0b3IuKToKKwogMjAxMC0xMi0wMSAgRGF2aWQgSHlh dHQgIDxoeWF0dEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIu CkluZGV4OiBpbnNwZWN0b3IvZnJvbnQtZW5kL0luamVjdGVkU2NyaXB0LmpzCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIGluc3BlY3Rvci9mcm9udC1lbmQvSW5qZWN0ZWRTY3JpcHQuanMJKHJldmlzaW9uIDY4NjUx KQorKysgaW5zcGVjdG9yL2Zyb250LWVuZC9JbmplY3RlZFNjcmlwdC5qcwkod29ya2luZyBjb3B5 KQpAQCAtNjI0LDggKzYyNCw5IEBACiAgICAgewogICAgICAgICB2YXIgbm9kZXMgPSBbXTsKICAg ICAgICAgdHJ5IHsKLSAgICAgICAgICAgIHZhciBkb2MgPSBjb250ZXh0IHx8IGRvY3VtZW50Owot ICAgICAgICAgICAgdmFyIHJlc3VsdHMgPSBkb2MuZXZhbHVhdGUoeHBhdGgsIGRvYywgbnVsbCwg WFBhdGhSZXN1bHQuQU5ZX1RZUEUsIG51bGwpOworICAgICAgICAgICAgY29udGV4dCA9IGNvbnRl eHQgfHwgZG9jdW1lbnQ7CisgICAgICAgICAgICB2YXIgZG9jID0gY29udGV4dC5vd25lckRvY3Vt ZW50IHx8IGNvbnRleHQ7CisgICAgICAgICAgICB2YXIgcmVzdWx0cyA9IGRvYy5ldmFsdWF0ZSh4 cGF0aCwgY29udGV4dCwgbnVsbCwgWFBhdGhSZXN1bHQuQU5ZX1RZUEUsIG51bGwpOwogICAgICAg ICAgICAgdmFyIG5vZGU7CiAgICAgICAgICAgICB3aGlsZSAobm9kZSA9IHJlc3VsdHMuaXRlcmF0 ZU5leHQoKSkKICAgICAgICAgICAgICAgICBub2Rlcy5wdXNoKG5vZGUpOwoK