50135 2010-11-28 14:39:26 -0800 Wrong positioning due to wrong width calculation wrt width:0 2012-05-07 11:40:28 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) PC Windows XP RESOLVED FIXED http://therealcrisp.xs4all.nl/meuk/webkitbug.html P2 Major --- 0 crisp pravind.2k4 eric hyatt jchaffraix leviw mitz pravind.2k4 webkit.review.bot oldest_to_newest 314231 0 crisp 2010-11-28 14:39:26 -0800 See testcase (also attached); when a blocklevel element is positioned to the right, containing another blocklevel element that has it's width set to 0 but which has a positive padding-left-value, it appears that the zero-width is ignored and the positioning of the containing element is wrong. Changing the width to a non-zero value doesn't exhibit this behaviour. 314232 1 74981 crisp 2010-11-28 14:40:50 -0800 Created attachment 74981 Testcase 617649 2 140539 pravind.2k4 2012-05-07 09:39:23 -0700 Created attachment 140539 Patch 617653 3 pravind.2k4 2012-05-07 09:45:42 -0700 The issue is this: When a block parent has a child element with width:0 specified, the width of the parent block is calculated as though the child element's width is not specified and takes the child elements width to set as auto. However the content of the child element will not be painted as the child knows its width is zero. The cause is that while checking for width type (fixed, auto , etc), in the case of type fixed , the width value is expected to be positive. The check however does not consider the case when width is zero. 617746 4 140539 eric 2012-05-07 11:18:02 -0700 Comment on attachment 140539 Patch This looks reasonable. 617748 5 pravind.2k4 2012-05-07 11:19:39 -0700 (In reply to comment #4) > (From update of attachment 140539 [details]) > This looks reasonable. Thnk you 617752 6 140539 eric 2012-05-07 11:22:18 -0700 Comment on attachment 140539 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=140539&action=review > Source/WebCore/ChangeLog:1 > +2012-05-07 Pravin D <pravind.2k4@gmail.com> Normally contributors write their full names here. 617760 7 pravind.2k4 2012-05-07 11:26:38 -0700 (In reply to comment #6) > (From update of attachment 140539 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=140539&action=review > > > Source/WebCore/ChangeLog:1 > > +2012-05-07 Pravin D <pravind.2k4@gmail.com> > > Normally contributors write their full names here. Pravin D is my full name or atleast how it is in official records :) 617764 8 eric 2012-05-07 11:28:19 -0700 A pleasure to meet you then. :) 617768 9 pravind.2k4 2012-05-07 11:31:06 -0700 (In reply to comment #8) > A pleasure to meet you then. :) The pleasure mine. :) 617777 10 140539 webkit.review.bot 2012-05-07 11:40:23 -0700 Comment on attachment 140539 Patch Clearing flags on attachment: 140539 Committed r116331: <http://trac.webkit.org/changeset/116331> 617779 11 webkit.review.bot 2012-05-07 11:40:28 -0700 All reviewed patches have been landed. Closing bug. 74981 2010-11-28 14:40:50 -0800 2010-11-28 14:40:50 -0800 Testcase webkitbug.html text/html 1161 crisp PCFkb2N0eXBlIGh0bWw+CjxodG1sPgo8aGVhZD4KPHRpdGxlPldlYmtpdCBCdWc8L3RpdGxlPgo8 c3R5bGU+Cgoud3JhcHBlciB7CgloZWlnaHQ6IDcwcHg7Cgl3aWR0aDogNDAwcHg7Cglib3JkZXI6 IDFweCBzb2xpZCByZWQ7Cglwb3NpdGlvbjogcmVsYXRpdmU7CglwYWRkaW5nLXRvcDogNTBweDsK CW1hcmdpbi1ib3R0b206IDEwcHg7Cn0KCi53cmFwcGVyIHAgewoJcG9zaXRpb246IGFic29sdXRl OwoJbWFyZ2luOiAwOwp9Ci53cmFwcGVyIHAudG9wbGVmdCB7Cgl0b3A6IDA7CglsZWZ0OiAwOwp9 Ci53cmFwcGVyIHAudG9wcmlnaHQgewoJdG9wOiAwOwoJcmlnaHQ6IDA7Cn0KLndyYXBwZXIgcC5i b3R0b21sZWZ0IHsKCWJvdHRvbTogMDsKCWxlZnQ6IDA7Cn0KLndyYXBwZXIgcC5ib3R0b21yaWdo dCB7Cglib3R0b206IDA7CglyaWdodDogMDsKfQoKLndyYXBwZXIgcCBzcGFuIHsKCWRpc3BsYXk6 IGJsb2NrOwoJd2lkdGg6IDA7CgloZWlnaHQ6IDUwcHg7CglwYWRkaW5nLWxlZnQ6IDUwcHg7Cglv dmVyZmxvdzogaGlkZGVuOwoJYmFja2dyb3VuZDogeWVsbG93Owp9Cgo8L3N0eWxlPgo8L2hlYWQ+ Cjxib2R5Pgo8ZGl2IGNsYXNzPSJ3cmFwcGVyIj4KCVRoZSB5ZWxsb3cgY3ViZSBzaG91bGQgYmUg cG9zaXRpb25lZCB0b3AtbGVmdAoJPHAgY2xhc3M9InRvcGxlZnQiPgoJCTxzcGFuPlRoaXMgdGV4 dCBpcyBoaWRkZW48L3NwYW4+Cgk8L3A+CjwvZGl2Pgo8ZGl2IGNsYXNzPSJ3cmFwcGVyIj4KCVRo ZSB5ZWxsb3cgY3ViZSBzaG91bGQgYmUgcG9zaXRpb25lZCB0b3AtcmlnaHQKCTxwIGNsYXNzPSJ0 b3ByaWdodCI+CgkJPHNwYW4+VGhpcyB0ZXh0IGlzIGhpZGRlbjwvc3Bhbj4KCTwvcD4KPC9kaXY+ CjxkaXYgY2xhc3M9IndyYXBwZXIiPgoJVGhlIHllbGxvdyBjdWJlIHNob3VsZCBiZSBwb3NpdGlv bmVkIGJvdHRvbS1sZWZ0Cgk8cCBjbGFzcz0iYm90dG9tbGVmdCI+CgkJPHNwYW4+VGhpcyB0ZXh0 IGlzIGhpZGRlbjwvc3Bhbj4KCTwvcD4KPC9kaXY+CjxkaXYgY2xhc3M9IndyYXBwZXIiPgoJVGhl IHllbGxvdyBjdWJlIHNob3VsZCBiZSBwb3NpdGlvbmVkIGJvdHRvbS1yaWdodAoJPHAgY2xhc3M9 ImJvdHRvbXJpZ2h0Ij4KCQk8c3Bhbj5UaGlzIHRleHQgaXMgaGlkZGVuPC9zcGFuPgoJPC9wPgo8 L2Rpdj4KPC9ib2R5Pgo8L2h0bWw+ 140539 2012-05-07 09:39:23 -0700 2012-05-07 11:40:23 -0700 Patch bug-50135-20120508033856.patch text/plain 5038 pravind.2k4 SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNjMxMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA1LTA3ICBQcmF2aW4g RCAgPHByYXZpbmQuMms0QGdtYWlsLmNvbT4KKworICAgICAgICBXcm9uZyBwb3NpdGlvbmluZyBk dWUgdG8gd3Jvbmcgd2lkdGggY2FsY3VsYXRpb24gd3J0IHdpZHRoOjAKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUwMTM1CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogZmFzdC9ibG9jay9ibG9jay1w YXJlbnQtd2l0aC16ZXJvLXdpZHRoLWNoaWxkLmh0bWwKKworICAgICAgICAqIHJlbmRlcmluZy9S ZW5kZXJCbG9jay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9jazo6Y29tcHV0ZVBy ZWZlcnJlZExvZ2ljYWxXaWR0aHMpOgorICAgICAgICBXaGVuIHdpZHRoIGlzIGZpeGVkLCB0aGUg c3BlY2lmaWVkIHdpZHRoIG11c3QgYmUgdGFrZW4sIHByb3ZpZGVkIHRoZSB2YWx1ZSBpcyBwb3Np dGl2ZS4KKyAgICAgICAgV2lkdGg9MCBjYXNlIHdhcyBiZWluZyBpZ25vcmVkLgorCiAyMDEyLTA1 LTA3ICBDaHJpc3RvcGhlIER1bWV6ICA8Y2hyaXN0b3BoZS5kdW1lekBpbnRlbC5jb20+CiAKICAg ICAgICAgW0VGTF0gbWVkaWEvdHJhY2svdHJhY2stY3VlLXJlbmRlcmluZy1zbmFwLXRvLWxpbmVz LW5vdC1zZXQuaHRtbCBmYWlscwpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckJsb2NrLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy QmxvY2suY3BwCShyZXZpc2lvbiAxMTYzMDkpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyQmxvY2suY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01MTYwLDcgKzUxNjAsNyBAQCB2b2lk IFJlbmRlckJsb2NrOjpjb21wdXRlUHJlZmVycmVkTG9naWNhCiAgICAgdXBkYXRlRmlyc3RMZXR0 ZXIoKTsKIAogICAgIFJlbmRlclN0eWxlKiBzdHlsZVRvVXNlID0gc3R5bGUoKTsKLSAgICBpZiAo IWlzVGFibGVDZWxsKCkgJiYgc3R5bGVUb1VzZS0+bG9naWNhbFdpZHRoKCkuaXNGaXhlZCgpICYm IHN0eWxlVG9Vc2UtPmxvZ2ljYWxXaWR0aCgpLnZhbHVlKCkgPiAwICYmIHN0eWxlKCktPm1hcnF1 ZWVCZWhhdmlvcigpICE9IE1BTFRFUk5BVEUpCisgICAgaWYgKCFpc1RhYmxlQ2VsbCgpICYmIHN0 eWxlVG9Vc2UtPmxvZ2ljYWxXaWR0aCgpLmlzRml4ZWQoKSAmJiBzdHlsZVRvVXNlLT5sb2dpY2Fs V2lkdGgoKS52YWx1ZSgpID49IDAgJiYgc3R5bGUoKS0+bWFycXVlZUJlaGF2aW9yKCkgIT0gTUFM VEVSTkFURSkKICAgICAgICAgbV9taW5QcmVmZXJyZWRMb2dpY2FsV2lkdGggPSBtX21heFByZWZl cnJlZExvZ2ljYWxXaWR0aCA9IGNvbXB1dGVDb250ZW50Qm94TG9naWNhbFdpZHRoKHN0eWxlVG9V c2UtPmxvZ2ljYWxXaWR0aCgpLnZhbHVlKCkpOwogICAgIGVsc2UgewogICAgICAgICBtX21pblBy ZWZlcnJlZExvZ2ljYWxXaWR0aCA9IDA7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMTYzMTMpCisrKyBM YXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAx Mi0wNS0wNyAgUHJhdmluIEQgIDxwcmF2aW5kLjJrNEBnbWFpbC5jb20+CisKKyAgICAgICAgV3Jv bmcgcG9zaXRpb25pbmcgZHVlIHRvIHdyb25nIHdpZHRoIGNhbGN1bGF0aW9uIHdydCB3aWR0aDow CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MDEzNQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9i bG9jay9ibG9jay1wYXJlbnQtd2l0aC16ZXJvLXdpZHRoLWNoaWxkLWV4cGVjdGVkLnR4dDogQWRk ZWQuCisgICAgICAgICogZmFzdC9ibG9jay9ibG9jay1wYXJlbnQtd2l0aC16ZXJvLXdpZHRoLWNo aWxkLmh0bWw6IEFkZGVkLgorCiAyMDEyLTA1LTA3ICBDaHJpc3RvcGhlIER1bWV6ICA8Y2hyaXN0 b3BoZS5kdW1lekBpbnRlbC5jb20+CiAKICAgICAgICAgW0VGTF0gbWVkaWEvdHJhY2svdHJhY2st Y3VlLXJlbmRlcmluZy1zbmFwLXRvLWxpbmVzLW5vdC1zZXQuaHRtbCBmYWlscwpJbmRleDogTGF5 b3V0VGVzdHMvZmFzdC9ibG9jay9ibG9jay1wYXJlbnQtd2l0aC16ZXJvLXdpZHRoLWNoaWxkLWV4 cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2Jsb2NrL2Jsb2NrLXBh cmVudC13aXRoLXplcm8td2lkdGgtY2hpbGQtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysg TGF5b3V0VGVzdHMvZmFzdC9ibG9jay9ibG9jay1wYXJlbnQtd2l0aC16ZXJvLXdpZHRoLWNoaWxk LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMSBAQAorVGhpcyB0ZXN0cyBp ZiB0aGUgcGFyZW50IGJsb2NrIGhhcyB0aGUgY29ycmVjdCBzaXplIHdoZW4gdGhlIGNoaWxkIGVs ZW1lbnQgaGFzIGZpeGVkIHdpZHRoIGFzIHplcm8uCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNl ZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRF Ii4KKworCitQQVNTIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJwX3RvcFJpZ2h0IikuZ2V0Q2xp ZW50UmVjdHMoKVswXS53aWR0aCAgaXMgNTAKK1BBU1MgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo InBfYm90UmlnaHQiKS5nZXRDbGllbnRSZWN0cygpWzBdLndpZHRoICBpcyA1MAorUEFTUyBzdWNj ZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKSW5kZXg6IExheW91dFRl c3RzL2Zhc3QvYmxvY2svYmxvY2stcGFyZW50LXdpdGgtemVyby13aWR0aC1jaGlsZC5odG1sCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvYmxvY2svYmxvY2stcGFyZW50LXdpdGgtemVy by13aWR0aC1jaGlsZC5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9ibG9j ay9ibG9jay1wYXJlbnQtd2l0aC16ZXJvLXdpZHRoLWNoaWxkLmh0bWwJKHJldmlzaW9uIDApCkBA IC0wLDAgKzEsNzMgQEAKKzxoZWFkPgorPHRpdGxlPlRlc3QgY2FzZSBmb3IgYnVnIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MDEzNTwvdGl0bGU+Cis8c2NyaXB0IHNy Yz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzxzdHlsZT4KKwor LndyYXBwZXIgeworCWhlaWdodDogNzBweDsKKwl3aWR0aDogNDAwcHg7CisJYm9yZGVyOiAxcHgg c29saWQgcmVkOworCXBvc2l0aW9uOiByZWxhdGl2ZTsKKwlwYWRkaW5nLXRvcDogNTBweDsKKwlt YXJnaW4tYm90dG9tOiAxMHB4OworfQorCisud3JhcHBlciBwIHsKKwlwb3NpdGlvbjogYWJzb2x1 dGU7CisJbWFyZ2luOiAwOworfQorCisud3JhcHBlciBwLnRvcHJpZ2h0IHsKKwl0b3A6IDA7CisJ cmlnaHQ6IDA7Cit9CisKKy53cmFwcGVyIHAuYm90dG9tcmlnaHQgeworCWJvdHRvbTogMDsKKwly aWdodDogMDsKK30KKworLndyYXBwZXIgcCBzcGFuIHsKKwlkaXNwbGF5OiBibG9jazsKKwl3aWR0 aDogMDsKKwloZWlnaHQ6IDUwcHg7CisJcGFkZGluZy1sZWZ0OiA1MHB4OworCW92ZXJmbG93OiBo aWRkZW47CisJYmFja2dyb3VuZDogeWVsbG93OworfQorCis8L3N0eWxlPgorPHNjcmlwdD4KK2Z1 bmN0aW9uIHN0YXJ0VGVzdCgpeworCitzaG91bGRCZSgnZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo InBfdG9wUmlnaHQiKS5nZXRDbGllbnRSZWN0cygpWzBdLndpZHRoICcsICc1MCcpOworc2hvdWxk QmUoJ2RvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJwX2JvdFJpZ2h0IikuZ2V0Q2xpZW50UmVjdHMo KVswXS53aWR0aCAnLCAnNTAnKTsKK2lzU3VjY2Vzc2Z1bGx5UGFyc2VkKCk7CisKKy8vIENsZWFu dXAKK3ZhciBkaXZMaXN0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudHNCeUNsYXNzTmFtZSgnd3JhcHBl cicpOword2hpbGUoZGl2TGlzdC5sZW5ndGgpeworIHZhciBub2RlID0gZGl2TGlzdC5pdGVtKGRp dkxpc3QubGVuZ3RoIC0gMSk7CisgZG9jdW1lbnQuYm9keS5yZW1vdmVDaGlsZChub2RlKTsKK30K KworfQorPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBvbmxvYWQ9InN0YXJ0VGVzdCgpOyI+Cis8 c2NyaXB0PgorICAgIGRlc2NyaXB0aW9uKCJUaGlzIHRlc3RzIGlmIHRoZSBwYXJlbnQgYmxvY2sg aGFzIHRoZSBjb3JyZWN0IHNpemUgd2hlbiB0aGUgY2hpbGQgZWxlbWVudCBoYXMgZml4ZWQgd2lk dGggYXMgemVyby4iKQorPC9zY3JpcHQ+Cis8ZGl2IGNsYXNzPSJ3cmFwcGVyIj4KKwlUaGUgeWVs bG93IGN1YmUgc2hvdWxkIGJlIHBvc2l0aW9uZWQgdG9wLXJpZ2h0CisJPHAgaWQ9InBfdG9wUmln aHQiIGNsYXNzPSJ0b3ByaWdodCI+CisJCTxzcGFuPlRoaXMgdGV4dCBpcyBoaWRkZW48L3NwYW4+ CisJPC9wPgorPC9kaXY+Cis8ZGl2IGNsYXNzPSJ3cmFwcGVyIj4KKwlUaGUgeWVsbG93IGN1YmUg c2hvdWxkIGJlIHBvc2l0aW9uZWQgYm90dG9tLXJpZ2h0CisJPHAgaWQ9InBfYm90UmlnaHQiIGNs YXNzPSJib3R0b21yaWdodCI+CisJCTxzcGFuPlRoaXMgdGV4dCBpcyBoaWRkZW48L3NwYW4+CisJ PC9wPgorPC9kaXY+Cis8L2JvZHk+Cg==