50134 2010-11-28 08:58:58 -0800 [Qt] Move some build logic from Qt to platform independent code 2010-11-30 11:04:21 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED Qt P2 Normal --- 50251 1 laszlo.gombos webkit-unassigned commit-queue oldest_to_newest 314198 0 laszlo.gombos 2010-11-28 08:58:58 -0800 The step to create some directories for WebKit2 can be moved form WebKit2/DerivedSources.pro to WebKitTools/Scripts/generate-forwarding-headers.pl. Main motivation behind this was to fix a Symbian build break for Symbian. 314200 1 74977 laszlo.gombos 2010-11-28 09:11:48 -0800 Created attachment 74977 proposed change 314212 2 74977 kenneth 2010-11-28 10:08:08 -0800 Comment on attachment 74977 proposed change have you tested our webkit2 build? LGTM 314214 3 commit-queue 2010-11-28 10:31:31 -0800 The commit-queue encountered the following flaky tests while processing attachment 74977: fast/profiler/throw-exception-from-eval.html Please file bugs against the tests. These tests were authored by kmccullough@apple.com, oliver@apple.com, and timothy@apple.com. The commit-queue is continuing to process your patch. 314215 4 74977 commit-queue 2010-11-28 10:32:47 -0800 Comment on attachment 74977 proposed change Clearing flags on attachment: 74977 Committed r72779: <http://trac.webkit.org/changeset/72779> 314216 5 commit-queue 2010-11-28 10:32:52 -0800 All reviewed patches have been landed. Closing bug. 74977 2010-11-28 09:11:48 -0800 2010-11-28 10:32:47 -0800 proposed change 50134.patch text/plain 2984 laszlo.gombos ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg ZWY0YzkyYS4uZThhNzk2ZSAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvV2Vi S2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0xMS0yOCAgTGFzemxvIEdvbWJv cyAgPGxhc3psby4xLmdvbWJvc0Bub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBNb3ZlIHNvbWUgYnVpbGQgbG9naWMgZnJvbSBR dCB0byBwbGF0Zm9ybSBpbmRlcGVuZGVudCBjb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MDEzNAorCisgICAgICAgIFJlbW92ZSB0aGUgY3JlYXRp b24gb2YgdGhlIGRpcmVjdG9yaWVzIHVuZGVyICQkT1VUUFVUX0RJUi9pbmNsdWRlCisgICAgICAg IGFzIHRoZXNlIHdpbGwgYmUgaGFuZGxlZCBieSB0aGUgZndoZWFkZXJfZ2VuZXJhdG9yIHRhcmdl dC4KKworICAgICAgICBSZW1vdmUgdGhlIGV4cGxpY2l0IGdlbmVyYXRpb24gb2YgJCRPVVRQVVRf RElSL1dlYktpdDIvZ2VuZXJhdGVkIGFzCisgICAgICAgIHRoaXMgaXMgbm90IHJlcXVpcmVkLgor CisgICAgICAgICogRGVyaXZlZFNvdXJjZXMucHJvOgorCiAyMDEwLTExLTI0ICBCcmFkeSBFaWRz b24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBpbXBsaWNpdGx5IGJ5 IEpvaG4gU3VsbGl2YW4uCmRpZmYgLS1naXQgYS9XZWJLaXQyL0Rlcml2ZWRTb3VyY2VzLnBybyBi L1dlYktpdDIvRGVyaXZlZFNvdXJjZXMucHJvCmluZGV4IGZhNjQ2ZTQuLjJiNmEwOWQgMTAwNjQ0 Ci0tLSBhL1dlYktpdDIvRGVyaXZlZFNvdXJjZXMucHJvCisrKyBiL1dlYktpdDIvRGVyaXZlZFNv dXJjZXMucHJvCkBAIC0zNiwxMCArMzYsNiBAQCBTQk9YX0NIRUNLID0gJCQoX1NCT1hfRElSKQog CiAKIERJUlMgPSBcCi0gICAgJCRPVVRQVVRfRElSL2luY2x1ZGUvSmF2YVNjcmlwdENvcmUgXAot ICAgICQkT1VUUFVUX0RJUi9pbmNsdWRlL1dlYkNvcmUgXAotICAgICQkT1VUUFVUX0RJUi9pbmNs dWRlL1dlYktpdDIgXAotICAgICQkT1VUUFVUX0RJUi9XZWJLaXQyL2dlbmVyYXRlZCBcCiAgICAg JCRPVVRQVVRfRElSL1dlYktpdFRvb2xzL01pbmlCcm93c2VyL3F0CiAKIGZvcihESVIsIERJUlMp IHsKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5n ZUxvZwppbmRleCA1NWNlZGFlLi40Zjg4ZmQ5IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFu Z2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAt MTEtMjggIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gTW92ZSBzb21l IGJ1aWxkIGxvZ2ljIGZyb20gUXQgdG8gcGxhdGZvcm0gaW5kZXBlbmRlbnQgY29kZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTAxMzQKKworICAgICAg ICBDcmVhdGUgdGFyZ2V0IGRpcmVjdG9yaWVzIGluc2lkZSBnZW5lcmF0ZS1mb3J3YXJkaW5nLWhl YWRlcnMucGwuCisKKyAgICAgICAgKiBTY3JpcHRzL2dlbmVyYXRlLWZvcndhcmRpbmctaGVhZGVy cy5wbDoKKwogMjAxMC0xMS0yNCAgTmljb2xhcyBEdWZyZXNuZSAgPG5pY29sYXMuZHVmcmVzbmVA Y29sbGFib3JhLmNvLnVrPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hcnRpbiBSb2JpbnNvbi4K ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvZ2VuZXJhdGUtZm9yd2FyZGluZy1oZWFk ZXJzLnBsIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9nZW5lcmF0ZS1mb3J3YXJkaW5nLWhlYWRlcnMu cGwKaW5kZXggZWQ1ODcwMi4uZDVhYmI1YiAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0 cy9nZW5lcmF0ZS1mb3J3YXJkaW5nLWhlYWRlcnMucGwKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0 cy9nZW5lcmF0ZS1mb3J3YXJkaW5nLWhlYWRlcnMucGwKQEAgLTMwLDYgKzMwLDcgQEAgdXNlIHN0 cmljdDsKIHVzZSBDd2QgcXcoYWJzX3BhdGggcmVhbHBhdGgpOwogdXNlIEZpbGU6OkZpbmQ7CiB1 c2UgRmlsZTo6QmFzZW5hbWU7Cit1c2UgRmlsZTo6UGF0aCBxdyhta3BhdGgpOwogdXNlIEZpbGU6 OlNwZWM6OkZ1bmN0aW9uczsKIAogbXkgJHNyY1Jvb3QgPSByZWFscGF0aChGaWxlOjpTcGVjLT5j YXRmaWxlKGRpcm5hbWUoYWJzX3BhdGgoJDApKSwgIi4uLy4uIikpOwpAQCAtODEsOCArODIsMTAg QEAgc3ViIGNvbGxlY3RGYW1ld29ya0hlYWRlclBhdGhzIHsKIH0KIAogc3ViIGNyZWF0ZUZvcndh cmRpbmdIZWFkZXJzRm9yRnJhbWV3b3JrIHsKKyAgICBteSAkdGFyZ2V0RGlyZWN0b3J5ID0gRmls ZTo6U3BlYy0+Y2F0ZmlsZSgkb3V0cHV0RGlyZWN0b3J5LCAkZnJhbWV3b3JrKTsKKyAgICBta3Bh dGgoJHRhcmdldERpcmVjdG9yeSk7CiAgICAgZm9yZWFjaCBteSAkaGVhZGVyIChAZnJhbWV3b3Jr SGVhZGVycykgewotICAgICAgICBteSAkZm9yd2FyZGluZ0hlYWRlclBhdGggPSBGaWxlOjpTcGVj LT5jYXRmaWxlKCRvdXRwdXREaXJlY3RvcnksICRmcmFtZXdvcmssIGJhc2VuYW1lKCRoZWFkZXIp KTsKKyAgICAgICAgbXkgJGZvcndhcmRpbmdIZWFkZXJQYXRoID0gRmlsZTo6U3BlYy0+Y2F0Zmls ZSgkdGFyZ2V0RGlyZWN0b3J5LCBiYXNlbmFtZSgkaGVhZGVyKSk7CiAgICAgICAgIG15ICRleHBl Y3RlZEluY2x1ZGVTdGF0ZW1lbnQgPSAiI2luY2x1ZGUgXCIkaGVhZGVyXCIiOwogICAgICAgICBt eSAkZm91bmRJbmNsdWRlU3RhdGVtZW50ID0gMDsKICAgICAgICAgJGZvdW5kSW5jbHVkZVN0YXRl bWVudCA9IDxFWElTVElOR19IRUFERVI+IGlmIG9wZW4oRVhJU1RJTkdfSEVBREVSLCAiPCRmb3J3 YXJkaW5nSGVhZGVyUGF0aCIpOwo=