50132 2010-11-28 07:52:46 -0800 [Qt] Remove unused BASE_DIR from the build system 2010-11-28 09:34:48 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED Qt P2 Normal --- 1 laszlo.gombos webkit-unassigned commit-queue oldest_to_newest 314192 0 laszlo.gombos 2010-11-28 07:52:46 -0800 Seems BASE_DIR is unused and it is a left over from http://trac.webkit.org/changeset/21235. It does not really cause any harm, except it is somewhat confusing. 314193 1 74975 laszlo.gombos 2010-11-28 07:54:46 -0800 Created attachment 74975 proposed patch 314201 2 commit-queue 2010-11-28 09:14:11 -0800 The commit-queue encountered the following flaky tests while processing attachment 74975: fast/workers/storage/use-same-database-in-page-and-workers.html fast/profiler/throw-exception-from-eval.html Please file bugs against the tests. These tests were authored by dumi@chromium.org, kmccullough@apple.com, oliver@apple.com, and timothy@apple.com. The commit-queue is continuing to process your patch. 314205 3 74975 commit-queue 2010-11-28 09:34:42 -0800 Comment on attachment 74975 proposed patch Clearing flags on attachment: 74975 Committed r72778: <http://trac.webkit.org/changeset/72778> 314206 4 commit-queue 2010-11-28 09:34:48 -0800 All reviewed patches have been landed. Closing bug. 74975 2010-11-28 07:54:46 -0800 2010-11-28 09:34:41 -0800 proposed patch 50132.patch text/plain 736 laszlo.gombos ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA1NTY1MDYzLi5kMGRmN2Jl IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTAtMTEtMjggIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gUmVt b3ZlIHVudXNlZCBCQVNFX0RJUiBmcm9tIHRoZSBidWlsZCBzeXN0ZW0KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUwMTMyCisKKyAgICAgICAgKiBXZWJL aXQucHJpOgorCiAyMDEwLTExLTE5ICBNaWhhaSBQYXJwYXJpdGEgIDxtaWhhaXBAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIEFkZCByZWNlbnQgdXBzdHJlYW0gQ2hyb21pdW0gZGVwZW5kZW5jaWVz IHRvIC5naXRpZ25vcmUuCmRpZmYgLS1naXQgYS9XZWJLaXQucHJpIGIvV2ViS2l0LnByaQppbmRl eCBmZTEzODcyLi42YjAxYjQ5IDEwMDY0NAotLS0gYS9XZWJLaXQucHJpCisrKyBiL1dlYktpdC5w cmkKQEAgLTU1LDggKzU1LDYgQEAgQ09ORklHKHJlbGVhc2UsIGRlYnVnfHJlbGVhc2UpIHsKICAg ICBERUZJTkVTICs9IE5ERUJVRwogfQogCi1CQVNFX0RJUiA9ICQkUFdECi0KIHN5bWJpYW4gewog ICAgIElOQ0xVREVQQVRIICs9ICQkUFdEL2luY2x1ZGUvUXRXZWJLaXQKIH0gZWxzZSB7Cg==