50119 2010-11-26 17:13:37 -0800 RenderObject::minimumPreferredLogicalWidth() sometimes reports wrong value 2010-12-02 23:45:15 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 aa webkit-unassigned commit-queue hyatt jamesr sam oldest_to_newest 314100 0 aa 2010-11-26 17:13:37 -0800 I noticed a change in the behavior of RenderObject::minimumPreferredLogicalWidth() for the root renderer recently, and tracked it to this change: http://trac.webkit.org/changeset/70546/trunk/WebCore/rendering/RenderBox.cpp Also see http://code.google.com/p/chromium/issues/detail?id=61370 for the Chromium bug where this was noticed. It looks to me like a style can sometimes be applied to a body element before it is appended to the tree. In this case, the dirty bit for minimumPreferredLogicalWidth will not be propagated up the tree. I have a patch that appears to fix the problem, but I would like feedback on: a) Whether this is a good way to fix it, and b) How to create a test case Patch to follow. 314101 1 74955 aa 2010-11-26 17:17:49 -0800 Created attachment 74955 Patch 314102 2 74956 aa 2010-11-26 17:21:24 -0800 Created attachment 74956 Patch 314103 3 74956 aa 2010-11-26 17:23:04 -0800 Comment on attachment 74956 Patch Whoops :) 315397 4 75223 aa 2010-11-30 16:41:03 -0800 Created attachment 75223 Patch 315905 5 75223 hyatt 2010-12-01 15:32:19 -0800 Comment on attachment 75223 Patch r=me 316120 6 75223 commit-queue 2010-12-02 06:59:06 -0800 Comment on attachment 75223 Patch Rejecting patch 75223 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'land-attachment', '--force-clean', '--ignore-builders', '--non-interactive', '--parent-command=commit-queue', 75223]" exit_code: 2 Last 500 characters of output: ommitting to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/rendering/RenderBox.cpp A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output: svnlook: Can't write to stream: Broken pipe The following ChangeLog files contain OOPS: trunk/WebCore/ChangeLog Please don't ever say "OOPS" in a ChangeLog file. at /usr/local/git/libexec/git-core/git-svn line 558 Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1 Full output: http://queues.webkit.org/results/6732012 316639 7 75458 aa 2010-12-02 20:24:11 -0800 Created attachment 75458 Patch 316640 8 75458 webkit.review.bot 2010-12-02 20:25:46 -0800 Comment on attachment 75458 Patch Rejecting patch 75458 from review queue. aa@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. 316697 9 commit-queue 2010-12-02 23:43:17 -0800 The commit-queue encountered the following flaky tests while processing attachment 75458: animations/dynamic-stylesheet-loading.html Please file bugs against the tests. These tests were authored by cmarrin@apple.com. The commit-queue is continuing to process your patch. 316699 10 75458 commit-queue 2010-12-02 23:45:09 -0800 Comment on attachment 75458 Patch Clearing flags on attachment: 75458 Committed r73245: <http://trac.webkit.org/changeset/73245> 316700 11 commit-queue 2010-12-02 23:45:15 -0800 All reviewed patches have been landed. Closing bug. 74955 2010-11-26 17:17:49 -0800 2010-11-26 17:21:21 -0800 Patch bug-50119-20101126171748.patch text/plain 1341 aa ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg N2JkOTg0OGZlMDM4MzY3ZjNmODY3NmUzMzg1ZTg0NjQyMjYyNjczMi4uOGYyYjk5YTdlNDYzODc4 NWNhNzJlMTlmNzc2YmQxYTlkYjU0MmE1NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0xMS0yNiAgQWFy b24gQm9vZG1hbiAgPGFhQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBSZW5kZXJPYmplY3Q6Om1pbmltdW1QcmVmZXJyZWRMb2dp Y2FsV2lkdGgoKSBzb21ldGltZXMgcmVwb3J0cyB3cm9uZyB2YWx1ZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTAxMTkKKworICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJPYmplY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyT2JqZWN0Ojph ZGRDaGlsZCk6IFByb3BhZ2F0ZSBwcmVmZXJyZWRMb2dpY2FsV2lkdGhzRGlydHkoKSBiaXQgdXAg dGhlIHRyZWUgd2hlbiBhcHBlbmRpbmcgY2hpbGQgcmVuZGVyZXIuCisKIDIwMTAtMTEtMjYgIERh biBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbnR0 aSBLb2l2aXN0by4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5j cHAgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwCmluZGV4IGUxM2IxZjllYzc0 YjM3YzMzNmIwMzA5NDU5NjY5NjVhMmYyYjdiMGUuLjNlM2NjY2UzMDA1NTA4ZjQ3MjdiN2VhZGQ5 OGI4MGFlYTg2ODIyNzYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVj dC5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcApAQCAtMzIwLDYg KzMyMCw5IEBAIHZvaWQgUmVuZGVyT2JqZWN0OjphZGRDaGlsZChSZW5kZXJPYmplY3QqIG5ld0No aWxkLCBSZW5kZXJPYmplY3QqIGJlZm9yZUNoaWxkKQogICAgICAgICBpZiAodGV4dFRvVHJhbnNm b3JtKQogICAgICAgICAgICAgdG9SZW5kZXJUZXh0KG5ld0NoaWxkKS0+c2V0VGV4dCh0ZXh0VG9U cmFuc2Zvcm0ucmVsZWFzZSgpLCB0cnVlKTsKICAgICB9CisKKyAgICBpZiAobmV3Q2hpbGQtPnBy ZWZlcnJlZExvZ2ljYWxXaWR0aHNEaXJ0eSgpKQorICAgICAgICBpbnZhbGlkYXRlQ29udGFpbmVy UHJlZmVycmVkTG9naWNhbFdpZHRocygpOwogfQogCiB2b2lkIFJlbmRlck9iamVjdDo6cmVtb3Zl Q2hpbGQoUmVuZGVyT2JqZWN0KiBvbGRDaGlsZCkK 74956 2010-11-26 17:21:24 -0800 2010-11-30 16:41:00 -0800 Patch bug-50119-20101126172123.patch text/plain 1334 aa ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg N2JkOTg0OGZlMDM4MzY3ZjNmODY3NmUzMzg1ZTg0NjQyMjYyNjczMi4uOGYyYjk5YTdlNDYzODc4 NWNhNzJlMTlmNzc2YmQxYTlkYjU0MmE1NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0xMS0yNiAgQWFy b24gQm9vZG1hbiAgPGFhQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBSZW5kZXJPYmplY3Q6Om1pbmltdW1QcmVmZXJyZWRMb2dp Y2FsV2lkdGgoKSBzb21ldGltZXMgcmVwb3J0cyB3cm9uZyB2YWx1ZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTAxMTkKKworICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJPYmplY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyT2JqZWN0Ojph ZGRDaGlsZCk6IFByb3BhZ2F0ZSBwcmVmZXJyZWRMb2dpY2FsV2lkdGhzRGlydHkoKSBiaXQgdXAg dGhlIHRyZWUgd2hlbiBhcHBlbmRpbmcgY2hpbGQgcmVuZGVyZXIuCisKIDIwMTAtMTEtMjYgIERh biBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbnR0 aSBLb2l2aXN0by4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5j cHAgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwCmluZGV4IGUxM2IxZjllYzc0 YjM3YzMzNmIwMzA5NDU5NjY5NjVhMmYyYjdiMGUuLmMyYmIzYjZhN2E1YjgwZDM2MmYyZmRiMDE5 OGM3ZjVjODMxZDJiOGIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVj dC5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcApAQCAtMzIwLDYg KzMyMCw5IEBAIHZvaWQgUmVuZGVyT2JqZWN0OjphZGRDaGlsZChSZW5kZXJPYmplY3QqIG5ld0No aWxkLCBSZW5kZXJPYmplY3QqIGJlZm9yZUNoaWxkKQogICAgICAgICBpZiAodGV4dFRvVHJhbnNm b3JtKQogICAgICAgICAgICAgdG9SZW5kZXJUZXh0KG5ld0NoaWxkKS0+c2V0VGV4dCh0ZXh0VG9U cmFuc2Zvcm0ucmVsZWFzZSgpLCB0cnVlKTsKICAgICB9CisKKyAgICBpZiAobmV3Q2hpbGQtPnBy ZWZlcnJlZExvZ2ljYWxXaWR0aHNEaXJ0eSgpKQorICAgICAgICBzZXRQcmVmZXJyZWRMb2dpY2Fs V2lkdGhzRGlydHkodHJ1ZSk7CiB9CiAKIHZvaWQgUmVuZGVyT2JqZWN0OjpyZW1vdmVDaGlsZChS ZW5kZXJPYmplY3QqIG9sZENoaWxkKQo= 75223 2010-11-30 16:41:03 -0800 2010-12-02 20:24:07 -0800 Patch bug-50119-20101130164102.patch text/plain 2665 aa ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZWY5MTM4NGMwZGE3MzYwNjJkZTI1MGNiM2JiOGRlOGQyZjk3MzlhYS4uZWM2NzZlMGViOTdiYTEy MjkzMWU0YTg3OTIzNDRiOTZhZDI5MTYwNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0xMS0zMCAgQWFy b24gQm9vZG1hbiAgPGFhQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBSZW5kZXJPYmplY3Q6Om1pbmltdW1QcmVmZXJyZWRMb2dp Y2FsV2lkdGgoKSBzb21ldGltZXMgcmVwb3J0cyB3cm9uZyB2YWx1ZS4KKyAgICAgICAgVGhpcyBp cyBhIHF1aWNrIGZpeCBmb3IgTFRSIHBhZ2VzLiBTdWJzZXF1ZW50IHdvcmsgd2lsbCBmaXggdGhl IGdlbmVyYWwgY2FzZS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NTAxMTkKKworICAgICAgICBObyBuZXcgdGVzdHMuIChPT1BTISkKKworICAgICAg ICAqIHJlbmRlcmluZy9SZW5kZXJCb3guY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQm94 OjpzdHlsZURpZENoYW5nZSk6CisKIDIwMTAtMTEtMzAgIFlhZWwgQWhhcm9uICA8eWFlbC5haGFy b25Abm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0t Z2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcCBiL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckJveC5jcHAKaW5kZXggMjBkNjI3YTdlN2RkYTc5ZGU1NGRlOTNkMzAxMDRkMjdmNTE3 NmQ4Yy4uYTg0Y2E2Yjg3NWIwM2QzYmM1ZjA3MjI2ZjI4NTdjZmI2ZDVhMzk0ZiAxMDA2NDQKLS0t IGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcAorKysgYi9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJCb3guY3BwCkBAIC0zMDYsMjMgKzMwNiwyNCBAQCB2b2lkIFJlbmRlckJveDo6c3R5 bGVEaWRDaGFuZ2UoU3R5bGVEaWZmZXJlbmNlIGRpZmYsIGNvbnN0IFJlbmRlclN0eWxlKiBvbGRT dHlsZQogICAgIC8vIFNldCB0aGUgdGV4dCBjb2xvciBpZiB3ZSdyZSB0aGUgYm9keS4KICAgICBp ZiAoaXNCb2R5UmVuZGVyZXIpCiAgICAgICAgIGRvY3VtZW50KCktPnNldFRleHRDb2xvcihzdHls ZSgpLT52aXNpdGVkRGVwZW5kZW50Q29sb3IoQ1NTUHJvcGVydHlDb2xvcikpOwotICAgIAotICAg IGlmICgoaXNSb290UmVuZGVyZXIgfHwgaXNCb2R5UmVuZGVyZXIpICYmICghb2xkU3R5bGUgfHwg b2xkU3R5bGUtPndyaXRpbmdNb2RlKCkgIT0gc3R5bGUoKS0+d3JpdGluZ01vZGUoKSB8fCBvbGRT dHlsZS0+ZGlyZWN0aW9uKCkgIT0gc3R5bGUoKS0+ZGlyZWN0aW9uKCkpKSB7CisKKyAgICBpZiAo aXNSb290UmVuZGVyZXIgfHwgaXNCb2R5UmVuZGVyZXIpIHsKICAgICAgICAgLy8gUHJvcGFnYXRl IHRoZSBuZXcgd3JpdGluZyBtb2RlIGFuZCBkaXJlY3Rpb24gdXAgdG8gdGhlIFJlbmRlclZpZXcu CiAgICAgICAgIFJlbmRlclZpZXcqIHZpZXdSZW5kZXJlciA9IHZpZXcoKTsKICAgICAgICAgUmVu ZGVyU3R5bGUqIHZpZXdTdHlsZSA9IHZpZXdSZW5kZXJlci0+c3R5bGUoKTsKLSAgICAgICAgaWYg KGlzUm9vdFJlbmRlcmVyIHx8ICFkb2N1bWVudCgpLT5kaXJlY3Rpb25TZXRPbkRvY3VtZW50RWxl bWVudCgpKSB7CisgICAgICAgIGlmICh2aWV3U3R5bGUtPmRpcmVjdGlvbigpICE9IHN0eWxlKCkt PmRpcmVjdGlvbigpICYmIChpc1Jvb3RSZW5kZXJlciB8fCAhZG9jdW1lbnQoKS0+ZGlyZWN0aW9u U2V0T25Eb2N1bWVudEVsZW1lbnQoKSkpIHsKICAgICAgICAgICAgIHZpZXdTdHlsZS0+c2V0RGly ZWN0aW9uKHN0eWxlKCktPmRpcmVjdGlvbigpKTsKICAgICAgICAgICAgIGlmIChpc0JvZHlSZW5k ZXJlcikKICAgICAgICAgICAgICAgICBkb2N1bWVudCgpLT5kb2N1bWVudEVsZW1lbnQoKS0+cmVu ZGVyZXIoKS0+c3R5bGUoKS0+c2V0RGlyZWN0aW9uKHN0eWxlKCktPmRpcmVjdGlvbigpKTsKKyAg ICAgICAgICAgIHNldE5lZWRzTGF5b3V0QW5kUHJlZldpZHRoc1JlY2FsYygpOwogICAgICAgICB9 Ci0gICAgICAgIAotICAgICAgICBpZiAoaXNSb290UmVuZGVyZXIgfHwgIWRvY3VtZW50KCktPndy aXRpbmdNb2RlU2V0T25Eb2N1bWVudEVsZW1lbnQoKSkgeworCisgICAgICAgIGlmICh2aWV3U3R5 bGUtPndyaXRpbmdNb2RlKCkgIT0gc3R5bGUoKS0+d3JpdGluZ01vZGUoKSAmJiAoaXNSb290UmVu ZGVyZXIgfHwgIWRvY3VtZW50KCktPndyaXRpbmdNb2RlU2V0T25Eb2N1bWVudEVsZW1lbnQoKSkp IHsKICAgICAgICAgICAgIHZpZXdTdHlsZS0+c2V0V3JpdGluZ01vZGUoc3R5bGUoKS0+d3JpdGlu Z01vZGUoKSk7CiAgICAgICAgICAgICBpZiAoaXNCb2R5UmVuZGVyZXIpCiAgICAgICAgICAgICAg ICAgZG9jdW1lbnQoKS0+ZG9jdW1lbnRFbGVtZW50KCktPnJlbmRlcmVyKCktPnN0eWxlKCktPnNl dFdyaXRpbmdNb2RlKHN0eWxlKCktPndyaXRpbmdNb2RlKCkpOworICAgICAgICAgICAgc2V0TmVl ZHNMYXlvdXRBbmRQcmVmV2lkdGhzUmVjYWxjKCk7CiAgICAgICAgIH0KLSAgICAgICAgc2V0TmVl ZHNMYXlvdXRBbmRQcmVmV2lkdGhzUmVjYWxjKCk7CiAgICAgfQogfQogCg== 75458 2010-12-02 20:24:11 -0800 2010-12-02 23:45:09 -0800 Patch bug-50119-20101202202409.patch text/plain 2736 aa ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OGVjNTQzNzA0NmY5ODFmMTY3NjFlMmY3ZTRiMzdjZTUxN2ExMWVmZC4uMGVlNDA3YTBmNjFkYTBh NTRmN2U5NmVhNzk4Mjc1OWExNTM3NjU0MiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0xMi0wMiAgQWFy b24gQm9vZG1hbiAgPGFhQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBEYXZp ZCBIeWF0dC4KKworICAgICAgICBSZWR1Y2UgdGhlIG51bWJlciBvZiBjYXNlcyB3aGVyZSB3ZSBl bmQgdXAgd2l0aCBhIHN0YWxlIHZhbHVlIGZvcgorICAgICAgICBtaW5pbXVtUHJlZmVycmVkTG9n aWNhbFdpZHRoKCkuIFRoaXMgaXNuJ3QgYSBjb21wbGV0ZSBmaXgsIGJ1dCBmaXhlcyBhCisgICAg ICAgIGxhcmdlIG51bWJlciBvZiBjYXNlcy4KKworICAgICAgICBSZW5kZXJPYmplY3Q6Om1pbmlt dW1QcmVmZXJyZWRMb2dpY2FsV2lkdGgoKSBzb21ldGltZXMgcmVwb3J0cyB3cm9uZyB2YWx1ZS4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUwMTE5CisK KyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlckJveDo6c3R5bGVEaWRDaGFuZ2UpOgorCiAyMDEwLTEyLTAyICBZdXRhIEtpdGFtdXJhICA8 eXV0YWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFsZXhleSBQcm9za3Vy eWFrb3YuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guY3BwIGIvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcAppbmRleCBjZjAwZGYwYzk4ZDM3MjU2YmY5NDg1 MzhkOWM4NzMxYjdkNjEzZmViLi45ZDVmZjMzMmY2ZTQ5ZjFiNTU4ODczN2Y5MjkwZGNlNTkyYjhm NDcxIDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guY3BwCisrKyBiL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAKQEAgLTMwNiwyMyArMzA2LDI0IEBAIHZvaWQg UmVuZGVyQm94OjpzdHlsZURpZENoYW5nZShTdHlsZURpZmZlcmVuY2UgZGlmZiwgY29uc3QgUmVu ZGVyU3R5bGUqIG9sZFN0eWxlCiAgICAgLy8gU2V0IHRoZSB0ZXh0IGNvbG9yIGlmIHdlJ3JlIHRo ZSBib2R5LgogICAgIGlmIChpc0JvZHlSZW5kZXJlcikKICAgICAgICAgZG9jdW1lbnQoKS0+c2V0 VGV4dENvbG9yKHN0eWxlKCktPnZpc2l0ZWREZXBlbmRlbnRDb2xvcihDU1NQcm9wZXJ0eUNvbG9y KSk7Ci0gICAgCi0gICAgaWYgKChpc1Jvb3RSZW5kZXJlciB8fCBpc0JvZHlSZW5kZXJlcikgJiYg KCFvbGRTdHlsZSB8fCBvbGRTdHlsZS0+d3JpdGluZ01vZGUoKSAhPSBzdHlsZSgpLT53cml0aW5n TW9kZSgpIHx8IG9sZFN0eWxlLT5kaXJlY3Rpb24oKSAhPSBzdHlsZSgpLT5kaXJlY3Rpb24oKSkp IHsKKworICAgIGlmIChpc1Jvb3RSZW5kZXJlciB8fCBpc0JvZHlSZW5kZXJlcikgewogICAgICAg ICAvLyBQcm9wYWdhdGUgdGhlIG5ldyB3cml0aW5nIG1vZGUgYW5kIGRpcmVjdGlvbiB1cCB0byB0 aGUgUmVuZGVyVmlldy4KICAgICAgICAgUmVuZGVyVmlldyogdmlld1JlbmRlcmVyID0gdmlldygp OwogICAgICAgICBSZW5kZXJTdHlsZSogdmlld1N0eWxlID0gdmlld1JlbmRlcmVyLT5zdHlsZSgp OwotICAgICAgICBpZiAoaXNSb290UmVuZGVyZXIgfHwgIWRvY3VtZW50KCktPmRpcmVjdGlvblNl dE9uRG9jdW1lbnRFbGVtZW50KCkpIHsKKyAgICAgICAgaWYgKHZpZXdTdHlsZS0+ZGlyZWN0aW9u KCkgIT0gc3R5bGUoKS0+ZGlyZWN0aW9uKCkgJiYgKGlzUm9vdFJlbmRlcmVyIHx8ICFkb2N1bWVu dCgpLT5kaXJlY3Rpb25TZXRPbkRvY3VtZW50RWxlbWVudCgpKSkgewogICAgICAgICAgICAgdmll d1N0eWxlLT5zZXREaXJlY3Rpb24oc3R5bGUoKS0+ZGlyZWN0aW9uKCkpOwogICAgICAgICAgICAg aWYgKGlzQm9keVJlbmRlcmVyKQogICAgICAgICAgICAgICAgIGRvY3VtZW50KCktPmRvY3VtZW50 RWxlbWVudCgpLT5yZW5kZXJlcigpLT5zdHlsZSgpLT5zZXREaXJlY3Rpb24oc3R5bGUoKS0+ZGly ZWN0aW9uKCkpOworICAgICAgICAgICAgc2V0TmVlZHNMYXlvdXRBbmRQcmVmV2lkdGhzUmVjYWxj KCk7CiAgICAgICAgIH0KLSAgICAgICAgCi0gICAgICAgIGlmIChpc1Jvb3RSZW5kZXJlciB8fCAh ZG9jdW1lbnQoKS0+d3JpdGluZ01vZGVTZXRPbkRvY3VtZW50RWxlbWVudCgpKSB7CisKKyAgICAg ICAgaWYgKHZpZXdTdHlsZS0+d3JpdGluZ01vZGUoKSAhPSBzdHlsZSgpLT53cml0aW5nTW9kZSgp ICYmIChpc1Jvb3RSZW5kZXJlciB8fCAhZG9jdW1lbnQoKS0+d3JpdGluZ01vZGVTZXRPbkRvY3Vt ZW50RWxlbWVudCgpKSkgewogICAgICAgICAgICAgdmlld1N0eWxlLT5zZXRXcml0aW5nTW9kZShz dHlsZSgpLT53cml0aW5nTW9kZSgpKTsKICAgICAgICAgICAgIGlmIChpc0JvZHlSZW5kZXJlcikK ICAgICAgICAgICAgICAgICBkb2N1bWVudCgpLT5kb2N1bWVudEVsZW1lbnQoKS0+cmVuZGVyZXIo KS0+c3R5bGUoKS0+c2V0V3JpdGluZ01vZGUoc3R5bGUoKS0+d3JpdGluZ01vZGUoKSk7CisgICAg ICAgICAgICBzZXROZWVkc0xheW91dEFuZFByZWZXaWR0aHNSZWNhbGMoKTsKICAgICAgICAgfQot ICAgICAgICBzZXROZWVkc0xheW91dEFuZFByZWZXaWR0aHNSZWNhbGMoKTsKICAgICB9CiB9CiAK