50079 2010-11-25 07:15:14 -0800 [Qt] Remove empty ScrollView::platformInit/platformDestroy 2010-11-26 08:19:55 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 kling rhodovan.u-szeged abarth eric webkit.review.bot oldest_to_newest 313755 0 kling 2010-11-25 07:15:14 -0800 The implementations of ScrollView::platformInit() and ScrollView::platformDestroy() in ScrollViewQt.cpp are empty. We should remove them and just use the empty ones in ScrollView.cpp. 314015 1 74939 rhodovan.u-szeged 2010-11-26 07:31:06 -0800 Created attachment 74939 Patch 314017 2 rhodovan.u-szeged 2010-11-26 07:38:10 -0800 This is landed in <http://trac.webkit.org/changeset/72761> Closing bug. 314024 3 74939 kbalazs 2010-11-26 08:04:19 -0800 Comment on attachment 74939 Patch Clearing flags 314029 4 webkit.review.bot 2010-11-26 08:19:55 -0800 http://trac.webkit.org/changeset/72761 might have broken GTK Linux 64-bit Debug The following tests are not passing: editing/selection/extend-by-character-002.html 74939 2010-11-26 07:31:06 -0800 2010-11-26 08:04:19 -0800 Patch scrollView.patch text/plain 1655 rhodovan.u-szeged SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3Mjc2MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMTEtMjYgIFJlbmF0YSBIb2RvdmFuICA8cmVuaUBpbmYudS1z emVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW1F0XSBSZW1vdmUgZW1wdHkgU2Nyb2xsVmlldzo6cGxhdGZvcm1Jbml0L3BsYXRmb3JtRGVz dHJveQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTAw NzkKKworICAgICAgICBObyBuZXcgdGVzdCBpcyBuZWVkZWQuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9TY3JvbGxWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbFZpZXc6OndoZWVsRXZl bnQpOgorICAgICAgICAqIHBsYXRmb3JtL3F0L1Njcm9sbFZpZXdRdC5jcHA6CisKIDIwMTAtMTEt MjYgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTm90 IHJldmlld2VkLiBGaXhpbmcgaW5zcGVjdG9yIHRlc3RzLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9y bS9TY3JvbGxWaWV3LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZp ZXcuY3BwCShyZXZpc2lvbiA3Mjc1OSkKKysrIFdlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTEwMTUsNyArMTAxNSw3IEBAIHZvaWQgU2Nyb2xsVmlldzo6 cmVtb3ZlUGFuU2Nyb2xsSWNvbigpCiAgICAgaG9zdFdpbmRvdygpLT5pbnZhbGlkYXRlQ29udGVu dHNBbmRXaW5kb3coSW50UmVjdChtX3BhblNjcm9sbEljb25Qb2ludCwgSW50U2l6ZShwYW5JY29u U2l6ZUxlbmd0aCwgcGFuSWNvblNpemVMZW5ndGgpKSwgdHJ1ZSAvKmltbWVkaWF0ZSovKTsKIH0K IAotI2lmICFQTEFURk9STShXWCkgJiYgIVBMQVRGT1JNKEdUSykgJiYgIVBMQVRGT1JNKFFUKSAm JiAhUExBVEZPUk0oRUZMKQorI2lmICFQTEFURk9STShXWCkgJiYgIVBMQVRGT1JNKEdUSykgJiYg IVBMQVRGT1JNKEVGTCkKIAogdm9pZCBTY3JvbGxWaWV3OjpwbGF0Zm9ybUluaXQoKQogewpJbmRl eDogV2ViQ29yZS9wbGF0Zm9ybS9xdC9TY3JvbGxWaWV3UXQuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvcGxhdGZvcm0vcXQvU2Nyb2xsVmlld1F0LmNwcAkocmV2aXNpb24gNzI3NTkpCisrKyBX ZWJDb3JlL3BsYXRmb3JtL3F0L1Njcm9sbFZpZXdRdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM0 LDE0ICszNCw2IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotdm9pZCBTY3JvbGxWaWV3Ojpw bGF0Zm9ybUluaXQoKQotewotfQotCi12b2lkIFNjcm9sbFZpZXc6OnBsYXRmb3JtRGVzdHJveSgp Ci17Ci19Ci0KIHZvaWQgU2Nyb2xsVmlldzo6cGxhdGZvcm1BZGRDaGlsZChXaWRnZXQqKQogewog fQo=