50076 2010-11-25 06:54:39 -0800 Web Inspector: LayoutTest/inspector/extnesions.html is flaky 2010-11-26 05:03:50 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 caseq caseq apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 313742 0 caseq 2010-11-25 06:54:39 -0800 extension_testExtensionWatchSidebarExpression() sometimes dumps an empty sidebar pane, here's how it happens: 1. The test requests result of expression evaluated on inspected page to be rendered in sidebar pane 2. ExtensionWatchSidebarPane evaluates expression in page 3. When expression is evaluated, ExtensionWatchSidebarPane creates ObjectPropertiesSection, adds the result object and expands it the secion 4. ExtensionWatchSidebarPane dispatches a notification to client (test extension) on sidebar being updated. 5. ObjectPropertiesSection retrieves list of remote object properties in the inspected page (4) happens asynchronously WRT (5), so test extension may dump an empty sidebar before remote properties list arrives. 313750 1 74874 caseq 2010-11-25 07:04:36 -0800 Created attachment 74874 patch 313751 2 74874 pfeldman 2010-11-25 07:06:48 -0800 Comment on attachment 74874 patch View in context: https://bugs.webkit.org/attachment.cgi?id=74874&action=review > LayoutTests/inspector/extensions.html:63 > + webInspector.inspectedWindow.eval("", bind(extension_dumpSidebarContent, null, nextTest)); Please use runAfterPendingDispatches. 313756 3 74875 caseq 2010-11-25 07:18:55 -0800 Created attachment 74875 patch 313968 4 caseq 2010-11-26 05:03:50 -0800 Manually committed r72755: http://trac.webkit.org/changeset/72755 74874 2010-11-25 07:04:36 -0800 2010-11-25 07:18:55 -0800 patch sidebar-test-flakiness text/plain 1512 caseq ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAwMzQzYjBiLi44N2ExZmI5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMTEt MjUgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBMYXlvdXRU ZXN0L2luc3BlY3Rvci9leHRuZXNpb25zLmh0bWwgaXMgZmxha3kKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUwMDc2CisKKyAgICAgICAgKiBpbnNwZWN0 b3IvZXh0ZW5zaW9ucy5odG1sOgorCiAyMDEwLTExLTI0ICBZdXRhIEtpdGFtdXJhICA8eXV0YWtA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbnQgVGFtdXJhLgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2V4dGVuc2lvbnMuaHRtbCBiL0xheW91dFRlc3Rz L2luc3BlY3Rvci9leHRlbnNpb25zLmh0bWwKaW5kZXggMGVlMjkxOS4uMTg4NGRkZiAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2V4dGVuc2lvbnMuaHRtbAorKysgYi9MYXlvdXRU ZXN0cy9pbnNwZWN0b3IvZXh0ZW5zaW9ucy5odG1sCkBAIC01NSw3ICs1NSwxNCBAQCBmdW5jdGlv biBleHRlbnNpb25fdGVzdEV4dGVuc2lvbldhdGNoU2lkZWJhckV4cHJlc3Npb24obmV4dFRlc3Qp CiB7CiAgICAgZnVuY3Rpb24gb25TaWRlYmFyQ3JlYXRlZChzaWRlYmFyKQogICAgIHsKLSAgICAg ICAgc2lkZWJhci5vblVwZGF0ZWQuYWRkTGlzdGVuZXIoYmluZChleHRlbnNpb25fZHVtcFNpZGVi YXJDb250ZW50LCB0aGlzLCBuZXh0VGVzdCkpOworICAgICAgICBmdW5jdGlvbiBvblVwZGF0ZWQo KQorICAgICAgICB7CisgICAgICAgICAgICAvLyBPbmNlIHRoZSBleHByZXNzaW9uIGlzIGV2YWx1 YXRlZCBhbmQgd2UgYWRkIGEgcmVtb3RlIG9iamVjdCB0byBPYmplY3RQcm9wZXJ0aWVzU2VjdGlv biwKKyAgICAgICAgICAgIC8vIHRoZSBsYXR0ZXIgcmVxdWVzdHMgb2JqZWN0IHByb3BlcnRpZXMg ZnJvbSB0aGUgcGFnZS4gU28gbWFrZSBhbm90aGVyIHJvdW5kdHJpcCB0byBwYWdlCisgICAgICAg ICAgICAvLyB0byBtYWtlIHN1cmUgdGhlIHJlbW90ZSBwcm9wZXJ0aWVzIGhhdmUgYXJyaXZlZCBi eSB0aGUgdGltZSB3ZSBkaXNwbGF5IHRoZW0uCisgICAgICAgICAgICB3ZWJJbnNwZWN0b3IuaW5z cGVjdGVkV2luZG93LmV2YWwoIiIsIGJpbmQoZXh0ZW5zaW9uX2R1bXBTaWRlYmFyQ29udGVudCwg bnVsbCwgbmV4dFRlc3QpKTsKKyAgICAgICAgfQorICAgICAgICBzaWRlYmFyLm9uVXBkYXRlZC5h ZGRMaXN0ZW5lcihvblVwZGF0ZWQpOwogICAgICAgICBmdW5jdGlvbiBleHByZXNzaW9uKCkKICAg ICAgICAgewogICAgICAgICAgICAgcmV0dXJuIHsK 74875 2010-11-25 07:18:55 -0800 2010-11-25 09:28:09 -0800 patch sidebar-test-flakiness text/plain 1566 caseq ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAwMzQzYjBiLi41OTYyZjQ0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMTEt MjUgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBMYXlvdXRU ZXN0L2luc3BlY3Rvci9leHRuZXNpb25zLmh0bWwgaXMgZmxha3kKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUwMDc2CisKKyAgICAgICAgKiBpbnNwZWN0 b3IvZXh0ZW5zaW9ucy10ZXN0LmpzOgorICAgICAgICAoaW5pdGlhbGl6ZV9FeHRlbnNpb25zVGVz dC5kdW1wU2lkZWJhckNvbnRlbnQpOgorCiAyMDEwLTExLTI0ICBZdXRhIEtpdGFtdXJhICA8eXV0 YWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbnQgVGFtdXJhLgpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2V4dGVuc2lvbnMtdGVzdC5qcyBiL0xheW91 dFRlc3RzL2luc3BlY3Rvci9leHRlbnNpb25zLXRlc3QuanMKaW5kZXggNzljODQ4ZC4uYWU1Zjlm YSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2V4dGVuc2lvbnMtdGVzdC5qcwor KysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvZXh0ZW5zaW9ucy10ZXN0LmpzCkBAIC00OCwxMyAr NDgsMTUgQEAgZnVuY3Rpb24gZXh0ZW5zaW9uT3V0cHV0KG1lc3NhZ2UpCiB9CiBJbnNwZWN0b3JU ZXN0LmRpc3BhdGNoT25NZXNzYWdlKCJvdXRwdXQiLCBleHRlbnNpb25PdXRwdXQsIHRydWUpOwog Ci1mdW5jdGlvbiBkdW1wU2lkZWJhckNvbnRlbnQoKQorZnVuY3Rpb24gZHVtcFNpZGViYXJDb250 ZW50KG1lc3NhZ2UsIHBvcnQpCiB7CiAgICAgdmFyIHNpZGViYXJQYW5lcyA9IFdlYkluc3BlY3Rv ci5wYW5lbHMuZWxlbWVudHMuc2lkZWJhclBhbmVzOwogICAgIC8vIHRoZSBzaWRlYmFyIG9mIGlu dGVyZXN0IGlzIHByZXN1bWVkIHRvIGFsd2F5cyBiZSBsYXN0LgogICAgIHZhciBzaWRlYmFyID0g c2lkZWJhclBhbmVzW09iamVjdC5rZXlzKHNpZGViYXJQYW5lcykucG9wKCldOwotICAgIEluc3Bl Y3RvclRlc3QuYWRkUmVzdWx0KCJTaWRlYmFyIGNvbnRlbnQ6ICIgKyBzaWRlYmFyLmJvZHlFbGVt ZW50LnRleHRDb250ZW50KTsKLSAgICByZXR1cm4gdHJ1ZTsKKyAgICBJbnNwZWN0b3JUZXN0LnJ1 bkFmdGVyUGVuZGluZ0Rpc3BhdGNoZXMoZnVuY3Rpb24oKSB7CisgICAgICAgIEluc3BlY3RvclRl c3QuYWRkUmVzdWx0KCJTaWRlYmFyIGNvbnRlbnQ6ICIgKyBzaWRlYmFyLmJvZHlFbGVtZW50LnRl eHRDb250ZW50KTsKKyAgICAgICAgcG9ydC5wb3N0TWVzc2FnZSgiIik7CisgICAgfSk7CiB9CiBJ bnNwZWN0b3JUZXN0LmRpc3BhdGNoT25NZXNzYWdlKCJkdW1wLXNpZGViYXItY29udGVudCIsIGR1 bXBTaWRlYmFyQ29udGVudCwgdHJ1ZSk7CiAK