50069 2010-11-25 04:56:05 -0800 MathML: code cleaning needed in MathMLInlineContainerElement.cpp 2010-11-26 10:01:24 -0800 1 1 1 Unclassified WebKit MathML 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED P3 Normal --- 0 sausset webkit-unassigned alex commit-queue dbates oldest_to_newest 313700 0 sausset 2010-11-25 04:56:05 -0800 remove unnecessary namespace & style adjustments 313704 1 74859 sausset 2010-11-25 05:01:12 -0800 Created attachment 74859 Patch 313844 2 74859 dbates 2010-11-25 12:45:17 -0800 Comment on attachment 74859 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=74859&action=review Thank you for cleaning this up. I have some minor nits. > WebCore/ChangeLog:6 > + Remove unnecessary namespace & style adjustments > + https://bugs.webkit.org/show_bug.cgi?id=50069 Disregarding the name/date, Reviewed by, and changed files lines, the formatting convention of a change log entry is bug title; bug URL; then bug description. And the bug description should be a full sentence. So, the change log for this patch should have the form: ... MathML: code cleaning needed in MathMLInlineContainerElement.cpp https://bugs.webkit.org/show_bug.cgi?id=50069 Remove unnecessary namespace & style adjustments. ... See <http://webkit.org/coding/contributing.html#changelogs> as well as the referenced example <http://trac.webkit.org/changeset/43259>. > WebCore/mathml/MathMLInlineContainerElement.cpp:82 > return new (arena) RenderMathMLBlock(this); Please un-indent this line of code so that it left-aligns with respect to the line "if (hasLocalName(mfencedTag))". 313922 3 74907 sausset 2010-11-26 01:39:38 -0800 Created attachment 74907 Revised patch I just modified the log entry and removed the unnecessary tabulation. 314051 4 commit-queue 2010-11-26 09:24:22 -0800 The commit-queue encountered the following flaky tests while processing attachment 74907: java/lc3/JSObject/ToObject-001.html fast/profiler/throw-exception-from-eval.html Please file bugs against the tests. These tests were authored by ap@webkit.org, kmccullough@apple.com, oliver@apple.com, and timothy@apple.com. The commit-queue is continuing to process your patch. 314054 5 74907 commit-queue 2010-11-26 10:01:18 -0800 Comment on attachment 74907 Revised patch Clearing flags on attachment: 74907 Committed r72773: <http://trac.webkit.org/changeset/72773> 314055 6 commit-queue 2010-11-26 10:01:24 -0800 All reviewed patches have been landed. Closing bug. 74859 2010-11-25 05:01:12 -0800 2010-11-26 01:39:38 -0800 Patch MathML_MathMLName.patch text/plain 2625 sausset SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MjcyNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMTEtMjUgIEZyYW7Dp29pcyBTYXVzc2V0ICA8c2F1c3NldEBn bWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgUmVtb3ZlIHVubmVjZXNzYXJ5IG5hbWVzcGFjZSAmIHN0eWxlIGFkanVzdG1lbnRzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MDA2OQorCisgICAg ICAgICogbWF0aG1sL01hdGhNTElubGluZUNvbnRhaW5lckVsZW1lbnQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6TWF0aE1MSW5saW5lQ29udGFpbmVyRWxlbWVudDo6Y3JlYXRlUmVuZGVyZXIpOgor CiAyMDEwLTExLTI1ICBIYW5zIFdlbm5ib3JnICA8aGFuc0BjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgSmVyZW15IE9ybG93LgpJbmRleDogV2ViQ29yZS9tYXRobWwvTWF0aE1M SW5saW5lQ29udGFpbmVyRWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9tYXRobWwv TWF0aE1MSW5saW5lQ29udGFpbmVyRWxlbWVudC5jcHAJKHJldmlzaW9uIDcyNjQ4KQorKysgV2Vi Q29yZS9tYXRobWwvTWF0aE1MSW5saW5lQ29udGFpbmVyRWxlbWVudC5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTU2LDI5ICs1NiwyOSBAQCBQYXNzUmVmUHRyPE1hdGhNTElubGluZUNvbnRhaW5lckVs ZW1lbnQ+CiAKIFJlbmRlck9iamVjdCogTWF0aE1MSW5saW5lQ29udGFpbmVyRWxlbWVudDo6Y3Jl YXRlUmVuZGVyZXIoUmVuZGVyQXJlbmEqIGFyZW5hLCBSZW5kZXJTdHlsZSopCiB7Ci0gICAgaWYg KGhhc0xvY2FsTmFtZShNYXRoTUxOYW1lczo6bXJvd1RhZykpCisgICAgaWYgKGhhc0xvY2FsTmFt ZShtcm93VGFnKSkKICAgICAgICAgcmV0dXJuIG5ldyAoYXJlbmEpIFJlbmRlck1hdGhNTFJvdyh0 aGlzKTsKLSAgICBlbHNlIGlmIChoYXNMb2NhbE5hbWUoTWF0aE1MTmFtZXM6Om1zdWJUYWcpKQor ICAgIGlmIChoYXNMb2NhbE5hbWUobXN1YlRhZykpCiAgICAgICAgIHJldHVybiBuZXcgKGFyZW5h KSBSZW5kZXJNYXRoTUxTdWJTdXAodGhpcyk7Ci0gICAgZWxzZSBpZiAoaGFzTG9jYWxOYW1lKE1h dGhNTE5hbWVzOjptc3VwVGFnKSkKKyAgICBpZiAoaGFzTG9jYWxOYW1lKG1zdXBUYWcpKQogICAg ICAgICByZXR1cm4gbmV3IChhcmVuYSkgUmVuZGVyTWF0aE1MU3ViU3VwKHRoaXMpOwotICAgIGVs c2UgaWYgKGhhc0xvY2FsTmFtZShNYXRoTUxOYW1lczo6bXN1YnN1cFRhZykpCisgICAgaWYgKGhh c0xvY2FsTmFtZShtc3Vic3VwVGFnKSkKICAgICAgICAgcmV0dXJuIG5ldyAoYXJlbmEpIFJlbmRl ck1hdGhNTFN1YlN1cCh0aGlzKTsKLSAgICBlbHNlIGlmIChoYXNMb2NhbE5hbWUoTWF0aE1MTmFt ZXM6Om1vdmVyVGFnKSkKKyAgICBpZiAoaGFzTG9jYWxOYW1lKG1vdmVyVGFnKSkKICAgICAgICAg cmV0dXJuIG5ldyAoYXJlbmEpIFJlbmRlck1hdGhNTFVuZGVyT3Zlcih0aGlzKTsKLSAgICBlbHNl IGlmIChoYXNMb2NhbE5hbWUoTWF0aE1MTmFtZXM6Om11bmRlclRhZykpCisgICAgaWYgKGhhc0xv Y2FsTmFtZShtdW5kZXJUYWcpKQogICAgICAgICByZXR1cm4gbmV3IChhcmVuYSkgUmVuZGVyTWF0 aE1MVW5kZXJPdmVyKHRoaXMpOwotICAgIGVsc2UgaWYgKGhhc0xvY2FsTmFtZShNYXRoTUxOYW1l czo6bXVuZGVyb3ZlclRhZykpCisgICAgaWYgKGhhc0xvY2FsTmFtZShtdW5kZXJvdmVyVGFnKSkK ICAgICAgICAgcmV0dXJuIG5ldyAoYXJlbmEpIFJlbmRlck1hdGhNTFVuZGVyT3Zlcih0aGlzKTsK LSAgICBlbHNlIGlmIChoYXNMb2NhbE5hbWUoTWF0aE1MTmFtZXM6Om1mcmFjVGFnKSkKKyAgICBp ZiAoaGFzTG9jYWxOYW1lKG1mcmFjVGFnKSkKICAgICAgICAgcmV0dXJuIG5ldyAoYXJlbmEpIFJl bmRlck1hdGhNTEZyYWN0aW9uKHRoaXMpOwotICAgIGVsc2UgaWYgKGhhc0xvY2FsTmFtZShNYXRo TUxOYW1lczo6bXNxcnRUYWcpKQorICAgIGlmIChoYXNMb2NhbE5hbWUobXNxcnRUYWcpKQogICAg ICAgICByZXR1cm4gbmV3IChhcmVuYSkgUmVuZGVyTWF0aE1MU3F1YXJlUm9vdCh0aGlzKTsKLSAg ICBlbHNlIGlmIChoYXNMb2NhbE5hbWUoTWF0aE1MTmFtZXM6Om1yb290VGFnKSkKKyAgICBpZiAo aGFzTG9jYWxOYW1lKG1yb290VGFnKSkKICAgICAgICAgcmV0dXJuIG5ldyAoYXJlbmEpIFJlbmRl ck1hdGhNTFJvb3QodGhpcyk7Ci0gICAgZWxzZSBpZiAoaGFzTG9jYWxOYW1lKE1hdGhNTE5hbWVz OjptZmVuY2VkVGFnKSkKKyAgICBpZiAoaGFzTG9jYWxOYW1lKG1mZW5jZWRUYWcpKQogICAgICAg ICByZXR1cm4gbmV3IChhcmVuYSkgUmVuZGVyTWF0aE1MRmVuY2VkKHRoaXMpOwotICAgIGVsc2UK KwogICAgICAgICByZXR1cm4gbmV3IChhcmVuYSkgUmVuZGVyTWF0aE1MQmxvY2sodGhpcyk7CiB9 CiAK 74907 2010-11-26 01:39:38 -0800 2010-11-26 10:01:18 -0800 Revised patch MathML_MathMLName.patch text/plain 2762 sausset SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MjcyNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMTEtMjYgIEZyYW7Dp29pcyBTYXVzc2V0ICA8c2F1c3NldEBn bWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgTWF0aE1MOiBjb2RlIGNsZWFuaW5nIG5lZWRlZCBpbiBNYXRoTUxJbmxpbmVDb250YWluZXJF bGVtZW50LmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NTAwNjkKKworICAgICAgICBVbm5lY2Vzc2FyeSBuYW1lc3BhY2Ugd2FzIHJlbW92ZWQgYW5k IHN0eWxlIHdhcyBhZGp1c3RlZC4KKworICAgICAgICAqIG1hdGhtbC9NYXRoTUxJbmxpbmVDb250 YWluZXJFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1hdGhNTElubGluZUNvbnRhaW5l ckVsZW1lbnQ6OmNyZWF0ZVJlbmRlcmVyKToKKwogMjAxMC0xMS0yNSAgSGFucyBXZW5uYm9yZyAg PGhhbnNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEplcmVteSBPcmxvdy4K SW5kZXg6IFdlYkNvcmUvbWF0aG1sL01hdGhNTElubGluZUNvbnRhaW5lckVsZW1lbnQuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvbWF0aG1sL01hdGhNTElubGluZUNvbnRhaW5lckVsZW1lbnQu Y3BwCShyZXZpc2lvbiA3MjY0OCkKKysrIFdlYkNvcmUvbWF0aG1sL01hdGhNTElubGluZUNvbnRh aW5lckVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NiwzMCArNTYsMzAgQEAgUGFzc1Jl ZlB0cjxNYXRoTUxJbmxpbmVDb250YWluZXJFbGVtZW50PgogCiBSZW5kZXJPYmplY3QqIE1hdGhN TElubGluZUNvbnRhaW5lckVsZW1lbnQ6OmNyZWF0ZVJlbmRlcmVyKFJlbmRlckFyZW5hKiBhcmVu YSwgUmVuZGVyU3R5bGUqKQogewotICAgIGlmIChoYXNMb2NhbE5hbWUoTWF0aE1MTmFtZXM6Om1y b3dUYWcpKQorICAgIGlmIChoYXNMb2NhbE5hbWUobXJvd1RhZykpCiAgICAgICAgIHJldHVybiBu ZXcgKGFyZW5hKSBSZW5kZXJNYXRoTUxSb3codGhpcyk7Ci0gICAgZWxzZSBpZiAoaGFzTG9jYWxO YW1lKE1hdGhNTE5hbWVzOjptc3ViVGFnKSkKKyAgICBpZiAoaGFzTG9jYWxOYW1lKG1zdWJUYWcp KQogICAgICAgICByZXR1cm4gbmV3IChhcmVuYSkgUmVuZGVyTWF0aE1MU3ViU3VwKHRoaXMpOwot ICAgIGVsc2UgaWYgKGhhc0xvY2FsTmFtZShNYXRoTUxOYW1lczo6bXN1cFRhZykpCisgICAgaWYg KGhhc0xvY2FsTmFtZShtc3VwVGFnKSkKICAgICAgICAgcmV0dXJuIG5ldyAoYXJlbmEpIFJlbmRl ck1hdGhNTFN1YlN1cCh0aGlzKTsKLSAgICBlbHNlIGlmIChoYXNMb2NhbE5hbWUoTWF0aE1MTmFt ZXM6Om1zdWJzdXBUYWcpKQorICAgIGlmIChoYXNMb2NhbE5hbWUobXN1YnN1cFRhZykpCiAgICAg ICAgIHJldHVybiBuZXcgKGFyZW5hKSBSZW5kZXJNYXRoTUxTdWJTdXAodGhpcyk7Ci0gICAgZWxz ZSBpZiAoaGFzTG9jYWxOYW1lKE1hdGhNTE5hbWVzOjptb3ZlclRhZykpCisgICAgaWYgKGhhc0xv Y2FsTmFtZShtb3ZlclRhZykpCiAgICAgICAgIHJldHVybiBuZXcgKGFyZW5hKSBSZW5kZXJNYXRo TUxVbmRlck92ZXIodGhpcyk7Ci0gICAgZWxzZSBpZiAoaGFzTG9jYWxOYW1lKE1hdGhNTE5hbWVz OjptdW5kZXJUYWcpKQorICAgIGlmIChoYXNMb2NhbE5hbWUobXVuZGVyVGFnKSkKICAgICAgICAg cmV0dXJuIG5ldyAoYXJlbmEpIFJlbmRlck1hdGhNTFVuZGVyT3Zlcih0aGlzKTsKLSAgICBlbHNl IGlmIChoYXNMb2NhbE5hbWUoTWF0aE1MTmFtZXM6Om11bmRlcm92ZXJUYWcpKQorICAgIGlmICho YXNMb2NhbE5hbWUobXVuZGVyb3ZlclRhZykpCiAgICAgICAgIHJldHVybiBuZXcgKGFyZW5hKSBS ZW5kZXJNYXRoTUxVbmRlck92ZXIodGhpcyk7Ci0gICAgZWxzZSBpZiAoaGFzTG9jYWxOYW1lKE1h dGhNTE5hbWVzOjptZnJhY1RhZykpCisgICAgaWYgKGhhc0xvY2FsTmFtZShtZnJhY1RhZykpCiAg ICAgICAgIHJldHVybiBuZXcgKGFyZW5hKSBSZW5kZXJNYXRoTUxGcmFjdGlvbih0aGlzKTsKLSAg ICBlbHNlIGlmIChoYXNMb2NhbE5hbWUoTWF0aE1MTmFtZXM6Om1zcXJ0VGFnKSkKKyAgICBpZiAo aGFzTG9jYWxOYW1lKG1zcXJ0VGFnKSkKICAgICAgICAgcmV0dXJuIG5ldyAoYXJlbmEpIFJlbmRl ck1hdGhNTFNxdWFyZVJvb3QodGhpcyk7Ci0gICAgZWxzZSBpZiAoaGFzTG9jYWxOYW1lKE1hdGhN TE5hbWVzOjptcm9vdFRhZykpCisgICAgaWYgKGhhc0xvY2FsTmFtZShtcm9vdFRhZykpCiAgICAg ICAgIHJldHVybiBuZXcgKGFyZW5hKSBSZW5kZXJNYXRoTUxSb290KHRoaXMpOwotICAgIGVsc2Ug aWYgKGhhc0xvY2FsTmFtZShNYXRoTUxOYW1lczo6bWZlbmNlZFRhZykpCisgICAgaWYgKGhhc0xv Y2FsTmFtZShtZmVuY2VkVGFnKSkKICAgICAgICAgcmV0dXJuIG5ldyAoYXJlbmEpIFJlbmRlck1h dGhNTEZlbmNlZCh0aGlzKTsKLSAgICBlbHNlCi0gICAgICAgIHJldHVybiBuZXcgKGFyZW5hKSBS ZW5kZXJNYXRoTUxCbG9jayh0aGlzKTsKKworICAgIHJldHVybiBuZXcgKGFyZW5hKSBSZW5kZXJN YXRoTUxCbG9jayh0aGlzKTsKIH0KIAogfQo=