50067 2010-11-25 04:11:32 -0800 [GStreamer] faster elements linking 2010-12-07 13:40:03 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned slomo oldest_to_newest 313686 0 pnormand 2010-11-25 04:11:32 -0800 If we build with GStreamer >= 0.10.30 we should use the gst_element_link_pads_full() API instead of gst_element_link{,_many} and perform less checks for caps negotiation and hierarchy. 313690 1 74855 pnormand 2010-11-25 04:19:24 -0800 Created attachment 74855 proposed patch 318412 2 pnormand 2010-12-07 13:40:03 -0800 Committed r73457: <http://trac.webkit.org/changeset/73457> 74855 2010-11-25 04:19:24 -0800 2010-12-07 13:33:50 -0800 proposed patch proposed-patch.patch text/plain 4518 pnormand RnJvbSAwZjE1ZTg2OTIzM2EwYTk4Yzc5MTc1ODRmODg1OGU0NzgyOGIzNzcwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUaHUsIDI1IE5vdiAyMDEwIDEzOjE2OjA1ICswMTAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgfCAgIDE1ICsrKysrKysrKysrKysrKwogLi4uL2dyYXBoaWNzL2dzdHJl YW1lci9HU3RyZWFtZXJHV29ybGQuY3BwICAgICAgICAgfCAgICA5ICsrKysrKysrLQogLi4uL2dz dHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwICAgICAgfCAgIDE2ICsrKysr KysrKysrKysrKysKIDMgZmlsZXMgY2hhbmdlZCwgMzkgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9n CmluZGV4IGYwOTgxYTAuLmI3ZTc1Y2QgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisr KyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAgQEAKIDIwMTAtMTEtMjUgIFBoaWxp cHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHU3RyZWFtZXJdIGZhc3RlciBlbGVtZW50cyBs aW5raW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01 MDA2NworCisgICAgICAgIFBlcmZvcm0gbGVzcyBjaGVja3MgZHVyaW5nIEdTdHJlYW1lciBlbGVt ZW50cyBsaW5raW5nIGlmIGJ1aWxkaW5nCisgICAgICAgIGFnYWluc3QgR1N0cmVhbWVyID49IDAu MTAuMzAuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvR1N0cmVhbWVy R1dvcmxkLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdTdHJlYW1lckdXb3JsZDo6ZW50ZXJGdWxs c2NyZWVuKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5 ZXJQcml2YXRlR1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJp dmF0ZUdTdHJlYW1lcjo6Y3JlYXRlR1NUUGxheUJpbik6CisKKzIwMTAtMTEtMjUgIFBoaWxpcHBl IE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCiAgICAgICAgIFJ1YmJlci1zdGFtcGVk IGJ5IFhhbiBMb3Blei4KIAogICAgICAgICBnX3NpZ25hbF9hY2N1bXVsYXRvcl9maXJzdF93aW5z IHdhcyBpbnRyb2R1Y2VkIGluIGdsaWIgMi4yNy4xIHNvCmRpZmYgLS1naXQgYS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9HU3RyZWFtZXJHV29ybGQuY3BwIGIvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvR1N0cmVhbWVyR1dvcmxkLmNwcAppbmRleCBiMThi Zjg0Li5lOGM4N2FjIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJl YW1lci9HU3RyZWFtZXJHV29ybGQuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Z3N0cmVhbWVyL0dTdHJlYW1lckdXb3JsZC5jcHAKQEAgLTkxLDkgKzkxLDE2IEBAIGJvb2wgR1N0 cmVhbWVyR1dvcmxkOjplbnRlckZ1bGxzY3JlZW4oKQogCiAgICAgZ19vYmplY3Rfc2V0KHZhbHZl LCAiZHJvcC1wcm9iYWJpbGl0eSIsIDEuMCwgTlVMTCk7CiAKLSAgICAvLyBBZGQgYW5kIGxpbmsg YSBxdWV1ZSwgZmZtcGVnY29sb3JzcGFjZSBhbmQgc2luayBpbiB0aGUgYmluLgorICAgIC8vIEFk ZCBhbmQgbGluayBhIHF1ZXVlLCBmZm1wZWdjb2xvcnNwYWNlLCB2aWRlb3NjYWxlIGFuZCBzaW5r IGluIHRoZSBiaW4uCiAgICAgZ3N0X2Jpbl9hZGRfbWFueShHU1RfQklOKHZpZGVvU2luay5nZXQo KSksIHBsYXRmb3JtVmlkZW9TaW5rLCB2aWRlb1NjYWxlLCBjb2xvcnNwYWNlLCBxdWV1ZSwgTlVM TCk7CisjaWYgR1NUX0NIRUNLX1ZFUlNJT04oMCwgMTAsIDMwKQorICAgIC8vIEZhc3RlciBlbGVt ZW50cyBsaW5raW5nLCBpZiBwb3NzaWJsZS4KKyAgICBnc3RfZWxlbWVudF9saW5rX3BhZHNfZnVs bChxdWV1ZSwgInNyYyIsIGNvbG9yc3BhY2UsICJzaW5rIiwgR1NUX1BBRF9MSU5LX0NIRUNLX05P VEhJTkcpOworICAgIGdzdF9lbGVtZW50X2xpbmtfcGFkc19mdWxsKGNvbG9yc3BhY2UsICJzcmMi LCB2aWRlb1NjYWxlLCAic2luayIsIEdTVF9QQURfTElOS19DSEVDS19OT1RISU5HKTsKKyAgICBn c3RfZWxlbWVudF9saW5rX3BhZHNfZnVsbCh2aWRlb1NjYWxlLCAic3JjIiwgcGxhdGZvcm1WaWRl b1NpbmssICJzaW5rIiwgR1NUX1BBRF9MSU5LX0NIRUNLX05PVEhJTkcpOworI2Vsc2UKICAgICBn c3RfZWxlbWVudF9saW5rX21hbnkocXVldWUsIGNvbG9yc3BhY2UsIHZpZGVvU2NhbGUsIHBsYXRm b3JtVmlkZW9TaW5rLCBOVUxMKTsKKyNlbmRpZgogCiAgICAgLy8gTGluayBhIG5ldyBzcmMgcGFk IGZyb20gdGVlIHRvIHF1ZXVlLgogICAgIEdzdFBhZCogc3JjUGFkID0gZ3N0X2VsZW1lbnRfZ2V0 X3JlcXVlc3RfcGFkKHRlZSwgInNyYyVkIik7CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwIGIvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVh bWVyLmNwcAppbmRleCBkYjE2NThiLi4wNGJjMmE0IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCisr KyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0 ZUdTdHJlYW1lci5jcHAKQEAgLTE0MzcsMTYgKzE0MzcsMzIgQEAgdm9pZCBNZWRpYVBsYXllclBy aXZhdGVHU3RyZWFtZXI6OmNyZWF0ZUdTVFBsYXlCaW4oKQogICAgICAgICBpZiAoZ19vYmplY3Rf Y2xhc3NfZmluZF9wcm9wZXJ0eShHX09CSkVDVF9HRVRfQ0xBU1MobV9mcHNTaW5rKSwgInZpZGVv LXNpbmsiKSkgewogICAgICAgICAgICAgZ19vYmplY3Rfc2V0KG1fZnBzU2luaywgInZpZGVvLXNp bmsiLCBtX3dlYmtpdFZpZGVvU2luaywgTlVMTCk7CiAgICAgICAgICAgICBnc3RfYmluX2FkZChH U1RfQklOKG1fdmlkZW9TaW5rQmluKSwgbV9mcHNTaW5rKTsKKyNpZiBHU1RfQ0hFQ0tfVkVSU0lP TigwLCAxMCwgMzApCisgICAgICAgICAgICAvLyBGYXN0ZXIgZWxlbWVudHMgbGlua2luZywgaWYg cG9zc2libGUuCisgICAgICAgICAgICBnc3RfZWxlbWVudF9saW5rX3BhZHNfZnVsbChxdWV1ZSwg InNyYyIsIG1fZnBzU2luaywgInNpbmsiLCBHU1RfUEFEX0xJTktfQ0hFQ0tfTk9USElORyk7Cisj ZWxzZQogICAgICAgICAgICAgZ3N0X2VsZW1lbnRfbGluayhxdWV1ZSwgbV9mcHNTaW5rKTsKKyNl bmRpZgogICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgbV9mcHNTaW5rID0gMDsKICAgICAg ICAgICAgIGdzdF9iaW5fYWRkKEdTVF9CSU4obV92aWRlb1NpbmtCaW4pLCBtX3dlYmtpdFZpZGVv U2luayk7CisjaWYgR1NUX0NIRUNLX1ZFUlNJT04oMCwgMTAsIDMwKQorICAgICAgICAgICAgLy8g RmFzdGVyIGVsZW1lbnRzIGxpbmtpbmcsIGlmIHBvc3NpYmxlLgorICAgICAgICAgICAgZ3N0X2Vs ZW1lbnRfbGlua19wYWRzX2Z1bGwocXVldWUsICJzcmMiLCBtX3dlYmtpdFZpZGVvU2luaywgInNp bmsiLCBHU1RfUEFEX0xJTktfQ0hFQ0tfTk9USElORyk7CisjZWxzZQogICAgICAgICAgICAgZ3N0 X2VsZW1lbnRfbGluayhxdWV1ZSwgbV93ZWJraXRWaWRlb1NpbmspOworI2VuZGlmCiAgICAgICAg ICAgICBMT0dfVkVSQk9TRShNZWRpYSwgIkNhbid0IGRpc3BsYXkgRlBTIHN0YXRpc3RpY3MsIHlv dSBuZWVkIGdzdC1wbHVnaW5zLWJhZCA+PSAwLjEwLjE4Iik7CiAgICAgICAgIH0KICAgICB9IGVs c2UgewogICAgICAgICBnc3RfYmluX2FkZChHU1RfQklOKG1fdmlkZW9TaW5rQmluKSwgbV93ZWJr aXRWaWRlb1NpbmspOworI2lmIEdTVF9DSEVDS19WRVJTSU9OKDAsIDEwLCAzMCkKKyAgICAgICAg Ly8gRmFzdGVyIGVsZW1lbnRzIGxpbmtpbmcsIGlmIHBvc3NpYmxlLgorICAgICAgICBnc3RfZWxl bWVudF9saW5rX3BhZHNfZnVsbChxdWV1ZSwgInNyYyIsIGlkZW50aXR5LCAic2luayIsIEdTVF9Q QURfTElOS19DSEVDS19OT1RISU5HKTsKKyAgICAgICAgZ3N0X2VsZW1lbnRfbGlua19wYWRzX2Z1 bGwoaWRlbnRpdHksICJzcmMiLCBtX3dlYmtpdFZpZGVvU2luaywgInNpbmsiLCBHU1RfUEFEX0xJ TktfQ0hFQ0tfTk9USElORyk7CisjZWxzZQogICAgICAgICBnc3RfZWxlbWVudF9saW5rX21hbnko cXVldWUsIGlkZW50aXR5LCBtX3dlYmtpdFZpZGVvU2luaywgTlVMTCk7CisjZW5kaWYKICAgICB9 CiAKICAgICAvLyBBZGQgYSBnaG9zdHBhZCB0byB0aGUgYmluIHNvIGl0IGNhbiBwcm94eSB0byB0 ZWUuCi0tIAoxLjcuMy4y