50066 2010-11-25 04:11:28 -0800 Web Inspector: reuse code for recreating resource views. 2010-11-25 05:56:42 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman abarth apavlov bweinstein eric joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 313685 0 pfeldman 2010-11-25 04:11:28 -0800 Patch to follow. 313687 1 74854 pfeldman 2010-11-25 04:13:17 -0800 Created attachment 74854 [PATCH] Proposed change. 313713 2 pfeldman 2010-11-25 05:22:21 -0800 M WebCore/ChangeLog M WebCore/inspector/front-end/NetworkItemView.js M WebCore/inspector/front-end/NetworkPanel.js M WebCore/inspector/front-end/ResourceManager.js M WebCore/inspector/front-end/ResourcesPanel.js Committed r72725 313723 3 webkit.review.bot 2010-11-25 05:56:42 -0800 http://trac.webkit.org/changeset/72725 might have broken GTK Linux 32-bit Release The following tests are not passing: inspector/extensions.html 74854 2010-11-25 04:13:17 -0800 2010-11-25 05:20:37 -0800 [PATCH] Proposed change. recreate_view text/plain 7199 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZmNjNzRhYi4uZGJhMWY4MiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMC0xMS0yNSAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiByZXVzZSBjb2RlIGZvciByZWNyZWF0 aW5nIHJlc291cmNlIHZpZXdzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NTAwNjYKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvTmV0d29y a0l0ZW1WaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLk5ldHdvcmtJdGVtVmlldyk6Cisg ICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9OZXR3b3JrUGFuZWwuanM6CisgICAgICAgIChX ZWJJbnNwZWN0b3IuTmV0d29ya1BhbmVsLnByb3RvdHlwZS5yZWZyZXNoUmVzb3VyY2UpOgorICAg ICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvUmVzb3VyY2VNYW5hZ2VyLmpzOgorICAgICAgICAo V2ViSW5zcGVjdG9yLlJlc291cmNlTWFuYWdlci5yZXNvdXJjZVZpZXdUeXBlTWF0Y2hlc1Jlc291 cmNlKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5SZXNvdXJjZU1hbmFnZXIucmVzb3VyY2VWaWV3 Rm9yUmVzb3VyY2UpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlJlc291cmNlTWFuYWdlci5yZWNy ZWF0ZVJlc291cmNlVmlldyk6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJj ZXNQYW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5GcmFtZVJlc291cmNlVHJlZUVsZW1l bnQucHJvdG90eXBlLl9jb250ZW50Q2hhbmdlZCk6CisKIDIwMTAtMTEtMjQgIFBhdmVsIEZlbGRt YW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgWXVyeSBT ZW1pa2hhdHNreS4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9OZXR3 b3JrSXRlbVZpZXcuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvTmV0d29ya0l0ZW1W aWV3LmpzCmluZGV4IDM2Nzk2NzYuLjkyN2U4NDAgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9OZXR3b3JrSXRlbVZpZXcuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL05ldHdvcmtJdGVtVmlldy5qcwpAQCAtMzUsMTUgKzM1LDE2IEBAIFdlYkluc3Bl Y3Rvci5OZXR3b3JrSXRlbVZpZXcgPSBmdW5jdGlvbihyZXNvdXJjZSkKICAgICB0aGlzLmVsZW1l bnQuYWRkU3R5bGVDbGFzcygibmV0d29yay1pdGVtLXZpZXciKTsKIAogICAgIHRoaXMuX2hlYWRl cnNWaWV3ID0gbmV3IFdlYkluc3BlY3Rvci5SZXNvdXJjZUhlYWRlcnNWaWV3KHJlc291cmNlKTsK LSAgICB0aGlzLl9jb250ZW50VmlldyA9IFdlYkluc3BlY3Rvci5SZXNvdXJjZU1hbmFnZXIucmVz b3VyY2VWaWV3Rm9yUmVzb3VyY2UocmVzb3VyY2UpOworICAgIC8vIERvIG5vdCBzdG9yZSByZWZl cmVuY2UgdG8gY29udGVudCB2aWV3IC0gaXQgY2FuIGJlIHJlY3JlYXRlZC4KKyAgICB2YXIgY29u dGVudFZpZXcgPSBXZWJJbnNwZWN0b3IuUmVzb3VyY2VNYW5hZ2VyLnJlc291cmNlVmlld0ZvclJl c291cmNlKHJlc291cmNlKTsKICAgICB0aGlzLl9jb29raWVzVmlldyA9IG5ldyBXZWJJbnNwZWN0 b3IuUmVzb3VyY2VDb29raWVzVmlldyhyZXNvdXJjZSk7CiAKICAgICB0aGlzLl90YWJiZWRQYW5l ID0gbmV3IFdlYkluc3BlY3Rvci5UYWJiZWRQYW5lKHRoaXMuZWxlbWVudCk7CiAgICAgdGhpcy5f dGFiYmVkUGFuZS5hcHBlbmRUYWIoImhlYWRlcnMiLCBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkhl YWRlcnMiKSwgdGhpcy5faGVhZGVyc1ZpZXcpOwotICAgIGlmICh0aGlzLl9jb250ZW50Vmlldy5o YXNDb250ZW50KCkpIHsKKyAgICBpZiAoY29udGVudFZpZXcuaGFzQ29udGVudCgpKSB7CiAgICAg ICAgIC8vIFJldXNpbmcgdGhpcyB2aWV3LCBzbyBoaWRlIGl0IGF0IGZpcnN0LgotICAgICAgICB0 aGlzLl9jb250ZW50Vmlldy52aXNpYmxlID0gZmFsc2U7Ci0gICAgICAgIHRoaXMuX3RhYmJlZFBh bmUuYXBwZW5kVGFiKCJjb250ZW50IiwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJDb250ZW50Iiks IHRoaXMuX2NvbnRlbnRWaWV3KTsKKyAgICAgICAgY29udGVudFZpZXcudmlzaWJsZSA9IGZhbHNl OworICAgICAgICB0aGlzLl90YWJiZWRQYW5lLmFwcGVuZFRhYigiY29udGVudCIsIFdlYkluc3Bl Y3Rvci5VSVN0cmluZygiQ29udGVudCIpLCBjb250ZW50Vmlldyk7CiAgICAgfQogICAgIHRoaXMu X3RhYmJlZFBhbmUuYXBwZW5kVGFiKCJjb29raWVzIiwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJD b29raWVzIiksIHRoaXMuX2Nvb2tpZXNWaWV3KTsKIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL05ldHdvcmtQYW5lbC5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9OZXR3b3JrUGFuZWwuanMKaW5kZXggODRkZTU0OC4uNzUzNTBjYSAxMDA2NDQKLS0tIGEv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL05ldHdvcmtQYW5lbC5qcworKysgYi9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvTmV0d29ya1BhbmVsLmpzCkBAIC03OTAsMjcgKzc5MCwyMCBA QCBXZWJJbnNwZWN0b3IuTmV0d29ya1BhbmVsLnByb3RvdHlwZSA9IHsKIAogICAgICAgICB0aGlz Ll9zdGFsZVJlc291cmNlcy5wdXNoKHJlc291cmNlKTsKICAgICAgICAgdGhpcy5fc2NoZWR1bGVS ZWZyZXNoKCk7Ci0KLSAgICAgICAgaWYgKCFyZXNvdXJjZSB8fCAhcmVzb3VyY2UuX3Jlc291cmNl c1ZpZXcpCisgICAgICAgIAorICAgICAgICBpZiAoIXJlc291cmNlKQogICAgICAgICAgICAgcmV0 dXJuOwogCi0gICAgICAgIGlmIChXZWJJbnNwZWN0b3IuUmVzb3VyY2VNYW5hZ2VyLnJlc291cmNl Vmlld1R5cGVNYXRjaGVzUmVzb3VyY2UocmVzb3VyY2UsIHJlc291cmNlLl9yZXNvdXJjZXNWaWV3 KSkKKyAgICAgICAgdmFyIG9sZFZpZXcgPSBXZWJJbnNwZWN0b3IuUmVzb3VyY2VNYW5hZ2VyLmV4 aXN0aW5nUmVzb3VyY2VWaWV3Rm9yUmVzb3VyY2UocmVzb3VyY2UpOworICAgICAgICBpZiAoIW9s ZFZpZXcpCiAgICAgICAgICAgICByZXR1cm47CiAKLSAgICAgICAgdmFyIG5ld1ZpZXcgPSBXZWJJ bnNwZWN0b3IuUmVzb3VyY2VNYW5hZ2VyLmNyZWF0ZVJlc291cmNlVmlldyhyZXNvdXJjZSk7Ci0K LSAgICAgICAgdmFyIG9sZFZpZXcgPSByZXNvdXJjZS5fcmVzb3VyY2VzVmlldzsKLSAgICAgICAg dmFyIG9sZFZpZXdQYXJlbnROb2RlID0gb2xkVmlldy52aXNpYmxlID8gb2xkVmlldy5lbGVtZW50 LnBhcmVudE5vZGUgOiBudWxsOwotCi0gICAgICAgIHJlc291cmNlLl9yZXNvdXJjZXNWaWV3LmRl dGFjaCgpOwotICAgICAgICBkZWxldGUgcmVzb3VyY2UuX3Jlc291cmNlc1ZpZXc7Ci0KLSAgICAg ICAgcmVzb3VyY2UuX3Jlc291cmNlc1ZpZXcgPSBuZXdWaWV3OwotCi0gICAgICAgIGlmIChvbGRW aWV3UGFyZW50Tm9kZSkKLSAgICAgICAgICAgIG5ld1ZpZXcuc2hvdyhvbGRWaWV3UGFyZW50Tm9k ZSk7CisgICAgICAgIGlmIChXZWJJbnNwZWN0b3IuUmVzb3VyY2VNYW5hZ2VyLnJlc291cmNlVmll d1R5cGVNYXRjaGVzUmVzb3VyY2UocmVzb3VyY2UpKQorICAgICAgICAgICAgcmV0dXJuOwogCi0g ICAgICAgIFdlYkluc3BlY3Rvci5wYW5lbHMuc2NyaXB0cy52aWV3UmVjcmVhdGVkKG9sZFZpZXcs IG5ld1ZpZXcpOworICAgICAgICB2YXIgbmV3VmlldyA9IFdlYkluc3BlY3Rvci5SZXNvdXJjZU1h bmFnZXIucmVjcmVhdGVSZXNvdXJjZVZpZXcocmVzb3VyY2UpOworICAgICAgICBpZiAodGhpcy52 aXNpYmxlVmlldyA9PT0gb2xkVmlldykKKyAgICAgICAgICAgIHRoaXMudmlzaWJsZVZpZXcgPSBu ZXdWaWV3OwogICAgIH0sCiAKICAgICBjYW5TaG93U291cmNlTGluZTogZnVuY3Rpb24odXJsLCBs aW5lKQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlTWFu YWdlci5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZU1hbmFnZXIuanMK aW5kZXggZmEyMzc2NC4uNTUxNDdkNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL1Jlc291cmNlTWFuYWdlci5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvUmVzb3VyY2VNYW5hZ2VyLmpzCkBAIC00NDUsOCArNDQ1LDkgQEAgV2ViSW5zcGVjdG9yLlJl c291cmNlTWFuYWdlci5jcmVhdGVSZXNvdXJjZVZpZXcgPSBmdW5jdGlvbihyZXNvdXJjZSkKICAg ICB9CiB9CiAKLVdlYkluc3BlY3Rvci5SZXNvdXJjZU1hbmFnZXIucmVzb3VyY2VWaWV3VHlwZU1h dGNoZXNSZXNvdXJjZSA9IGZ1bmN0aW9uKHJlc291cmNlLCByZXNvdXJjZVZpZXcpCitXZWJJbnNw ZWN0b3IuUmVzb3VyY2VNYW5hZ2VyLnJlc291cmNlVmlld1R5cGVNYXRjaGVzUmVzb3VyY2UgPSBm dW5jdGlvbihyZXNvdXJjZSkKIHsKKyAgICB2YXIgcmVzb3VyY2VWaWV3ID0gcmVzb3VyY2UuX3Jl c291cmNlc1ZpZXc7CiAgICAgc3dpdGNoIChyZXNvdXJjZS5jYXRlZ29yeSkgewogICAgIGNhc2Ug V2ViSW5zcGVjdG9yLnJlc291cmNlQ2F0ZWdvcmllcy5kb2N1bWVudHM6CiAgICAgY2FzZSBXZWJJ bnNwZWN0b3IucmVzb3VyY2VDYXRlZ29yaWVzLnN0eWxlc2hlZXRzOgpAQCAtNDcxLDYgKzQ3Miwy OCBAQCBXZWJJbnNwZWN0b3IuUmVzb3VyY2VNYW5hZ2VyLnJlc291cmNlVmlld0ZvclJlc291cmNl ID0gZnVuY3Rpb24ocmVzb3VyY2UpCiAgICAgcmV0dXJuIHJlc291cmNlLl9yZXNvdXJjZXNWaWV3 OwogfQogCitXZWJJbnNwZWN0b3IuUmVzb3VyY2VNYW5hZ2VyLnJlY3JlYXRlUmVzb3VyY2VWaWV3 ID0gZnVuY3Rpb24ocmVzb3VyY2UpCit7CisgICAgdmFyIG5ld1ZpZXcgPSBXZWJJbnNwZWN0b3Iu UmVzb3VyY2VNYW5hZ2VyLmNyZWF0ZVJlc291cmNlVmlldyhyZXNvdXJjZSk7CisKKyAgICB2YXIg b2xkVmlldyA9IHJlc291cmNlLl9yZXNvdXJjZXNWaWV3OworICAgIHZhciBvbGRWaWV3UGFyZW50 Tm9kZSA9IG9sZFZpZXcudmlzaWJsZSA/IG9sZFZpZXcuZWxlbWVudC5wYXJlbnROb2RlIDogbnVs bDsKKyAgICB2YXIgc2Nyb2xsVG9wID0gb2xkVmlldy5zY3JvbGxUb3A7CisKKyAgICByZXNvdXJj ZS5fcmVzb3VyY2VzVmlldy5kZXRhY2goKTsKKyAgICBkZWxldGUgcmVzb3VyY2UuX3Jlc291cmNl c1ZpZXc7CisKKyAgICByZXNvdXJjZS5fcmVzb3VyY2VzVmlldyA9IG5ld1ZpZXc7CisKKyAgICBp ZiAob2xkVmlld1BhcmVudE5vZGUpCisgICAgICAgIG5ld1ZpZXcuc2hvdyhvbGRWaWV3UGFyZW50 Tm9kZSk7CisgICAgaWYgKHNjcm9sbFRvcCkKKyAgICAgICAgbmV3Vmlldy5zY3JvbGxUb3AgPSBz Y3JvbGxUb3A7CisKKyAgICBXZWJJbnNwZWN0b3IucGFuZWxzLnNjcmlwdHMudmlld1JlY3JlYXRl ZChvbGRWaWV3LCBuZXdWaWV3KTsKKyAgICByZXR1cm4gbmV3VmlldzsKK30KKwogV2ViSW5zcGVj dG9yLlJlc291cmNlTWFuYWdlci5leGlzdGluZ1Jlc291cmNlVmlld0ZvclJlc291cmNlID0gZnVu Y3Rpb24ocmVzb3VyY2UpCiB7CiAgICAgaWYgKCFyZXNvdXJjZSkKZGlmZiAtLWdpdCBhL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZXNQYW5lbC5qcyBiL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9SZXNvdXJjZXNQYW5lbC5qcwppbmRleCBhYTAxZWY4Li5hMTk0ZjUzIDEw MDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUmVzb3VyY2VzUGFuZWwuanMK KysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlc1BhbmVsLmpzCkBAIC0x MDcwLDIzICsxMDcwLDEyIEBAIFdlYkluc3BlY3Rvci5GcmFtZVJlc291cmNlVHJlZUVsZW1lbnQu cHJvdG90eXBlID0gewogICAgICAgICAgICAgcmV2aXNpb25SZXNvdXJjZS5zZXRJbml0aWFsQ29u dGVudChldmVudC5kYXRhLm9sZENvbnRlbnQpOwogICAgICAgICB0aGlzLmluc2VydENoaWxkKG5l dyBXZWJJbnNwZWN0b3IuUmVzb3VyY2VSZXZpc2lvblRyZWVFbGVtZW50KHRoaXMuX3N0b3JhZ2VQ YW5lbCwgcmV2aXNpb25SZXNvdXJjZSwgZXZlbnQuZGF0YS5vbGRDb250ZW50VGltZXN0YW1wKSwg MCk7CiAKLSAgICAgICAgdmFyIG9sZFZpZXcgPSB0aGlzLl9yZXNvdXJjZS5fcmVzb3VyY2VzVmll dzsKKyAgICAgICAgCisgICAgICAgIHZhciBvbGRWaWV3ID0gV2ViSW5zcGVjdG9yLlJlc291cmNl TWFuYWdlci5leGlzdGluZ1Jlc291cmNlVmlld0ZvclJlc291cmNlKHRoaXMuX3Jlc291cmNlKTsK ICAgICAgICAgaWYgKG9sZFZpZXcpIHsKLSAgICAgICAgICAgIHZhciBzY3JvbGxUb3AgPSBvbGRW aWV3LnNjcm9sbFRvcDsKLSAgICAgICAgICAgIHZhciBuZXdWaWV3ID0gV2ViSW5zcGVjdG9yLlJl c291cmNlTWFuYWdlci5jcmVhdGVSZXNvdXJjZVZpZXcodGhpcy5fcmVzb3VyY2UpOwotICAgICAg ICAgICAgdmFyIG9sZFZpZXdQYXJlbnROb2RlID0gb2xkVmlldy52aXNpYmxlID8gb2xkVmlldy5l bGVtZW50LnBhcmVudE5vZGUgOiBudWxsOwotCi0gICAgICAgICAgICB0aGlzLl9yZXNvdXJjZS5f cmVzb3VyY2VzVmlldy5kZXRhY2goKTsKLSAgICAgICAgICAgIGRlbGV0ZSB0aGlzLl9yZXNvdXJj ZS5fcmVzb3VyY2VzVmlldzsKLSAgICAgICAgICAgIHRoaXMuX3Jlc291cmNlLl9yZXNvdXJjZXNW aWV3ID0gbmV3VmlldzsKLQotICAgICAgICAgICAgaWYgKG9sZFZpZXdQYXJlbnROb2RlKQotICAg ICAgICAgICAgICAgIG5ld1ZpZXcuc2hvdyhvbGRWaWV3UGFyZW50Tm9kZSk7Ci0KKyAgICAgICAg ICAgIHZhciBuZXdWaWV3ID0gV2ViSW5zcGVjdG9yLlJlc291cmNlTWFuYWdlci5yZWNyZWF0ZVJl c291cmNlVmlldyh0aGlzLl9yZXNvdXJjZSk7CiAgICAgICAgICAgICBpZiAob2xkVmlldyA9PT0g dGhpcy5fc3RvcmFnZVBhbmVsLnZpc2libGVWaWV3KQogICAgICAgICAgICAgICAgIHRoaXMuX3N0 b3JhZ2VQYW5lbC52aXNpYmxlVmlldyA9IG5ld1ZpZXc7Ci0gICAgICAgICAgICBpZiAoc2Nyb2xs VG9wKQotICAgICAgICAgICAgICAgIG5ld1ZpZXcuc2Nyb2xsVG9wID0gc2Nyb2xsVG9wOwogICAg ICAgICB9CiAgICAgfQogfQo=