50028 2010-11-24 08:57:13 -0800 Simplify directoryName in FileSystemWin.cpp 2010-11-29 09:53:18 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 paroga paroga aroben buildbot commit-queue oldest_to_newest 313320 0 paroga 2010-11-24 08:57:13 -0800 see patch 313323 1 74765 paroga 2010-11-24 09:01:49 -0800 Created attachment 74765 Patch 313341 2 buildbot 2010-11-24 09:32:16 -0800 Attachment 74765 did not build on win: Build output: http://queues.webkit.org/results/6296043 313347 3 74772 paroga 2010-11-24 09:38:36 -0800 Created attachment 74772 Patch 314400 4 74772 aroben 2010-11-29 07:34:12 -0800 Comment on attachment 74772 Patch Seems like eventually we should switch to using ::PathRemoveFileSpecW. 314404 5 paroga 2010-11-29 07:40:46 -0800 (In reply to comment #4) > (From update of attachment 74772 [details]) > Seems like eventually we should switch to using ::PathRemoveFileSpecW. PathRemoveFileSpecW wants to work in a buffer. So we would need to copy the path first into the buffer and then out of if. I like the current version more, but I can change if you like the other one more. 314407 6 aroben 2010-11-29 07:47:22 -0800 (In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 74772 [details] [details]) > > Seems like eventually we should switch to using ::PathRemoveFileSpecW. > PathRemoveFileSpecW wants to work in a buffer. So we would need to copy the path first into the buffer and then out of if. I like the current version more, but I can change if you like the other one more. I think if we used StringBuffer or Vector<UniChar> we could get away with only a single copy, which is probably even better than the current implementation. But making this change I think would warrant a separate patch. 314408 7 paroga 2010-11-29 07:50:05 -0800 (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > (From update of attachment 74772 [details] [details] [details]) > > > Seems like eventually we should switch to using ::PathRemoveFileSpecW. > > PathRemoveFileSpecW wants to work in a buffer. So we would need to copy the path first into the buffer and then out of if. I like the current version more, but I can change if you like the other one more. > > I think if we used StringBuffer or Vector<UniChar> we could get away with only a single copy, which is probably even better than the current implementation. But making this change I think would warrant a separate patch. OK, I'll create a new patch in the next days. 314418 8 74772 commit-queue 2010-11-29 08:14:16 -0800 Comment on attachment 74772 Patch Rejecting patch 74772 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 2 Last 500 characters of output: g/RenderDataGrid.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 CompileC /Projects/CommitQueue/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/RenderLayer.o /Projects/CommitQueue/WebCore/rendering/RenderLayer.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 CompileC /Projects/CommitQueue/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/Frame.o /Projects/CommitQueue/WebCore/page/Frame.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2 (6 failures) Full output: http://queues.webkit.org/results/6387099 314469 9 commit-queue 2010-11-29 09:36:02 -0800 The commit-queue encountered the following flaky tests while processing attachment 74772: fast/workers/storage/use-same-database-in-page-and-workers.html inspector/timeline-event-dispatch.html Please file bugs against the tests. These tests were authored by beidson@apple.com, dumi@chromium.org, and yurys@chromium.org. The commit-queue is continuing to process your patch. 314475 10 74772 commit-queue 2010-11-29 09:53:11 -0800 Comment on attachment 74772 Patch Clearing flags on attachment: 74772 Committed r72808: <http://trac.webkit.org/changeset/72808> 314476 11 commit-queue 2010-11-29 09:53:18 -0800 All reviewed patches have been landed. Closing bug. 74765 2010-11-24 09:01:49 -0800 2010-11-24 09:38:36 -0800 Patch bug-50028.patch text/plain 1132 paroga ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MzgxYmMzMS4uNTYyOTEwNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0xMS0yNCAgUGF0cmljayBHYW5z dGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBTaW1wbGlmeSBkaXJlY3RvcnlOYW1lIGluIEZpbGVTeXN0ZW1X aW4uY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01 MDAyOAorCisgICAgICAgICogcGxhdGZvcm0vd2luL0ZpbGVTeXN0ZW1XaW4uY3BwOgorICAgICAg ICAoV2ViQ29yZTo6ZGlyZWN0b3J5TmFtZSk6CisKIDIwMTAtMTEtMjQgIFNoZXJpZmYgQm90ICA8 d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxp bmcgb3V0IHI3MjQ5OS4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vd2luL0ZpbGVTeXN0 ZW1XaW4uY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS93aW4vRmlsZVN5c3RlbVdpbi5jcHAKaW5kZXgg Y2VmNzE5Ni4uYWYzMGQwOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS93aW4vRmlsZVN5 c3RlbVdpbi5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS93aW4vRmlsZVN5c3RlbVdpbi5jcHAK QEAgLTEzNCwxMCArMTM0LDcgQEAgU3RyaW5nIHBhdGhHZXRGaWxlTmFtZShjb25zdCBTdHJpbmcm IHBhdGgpCiAKIFN0cmluZyBkaXJlY3RvcnlOYW1lKGNvbnN0IFN0cmluZyYgcGF0aCkKIHsKLSAg ICBTdHJpbmcgZmlsZU5hbWUgPSBwYXRoR2V0RmlsZU5hbWUocGF0aCk7Ci0gICAgU3RyaW5nIGRp ck5hbWUgPSBTdHJpbmcocGF0aCk7Ci0gICAgZGlyTmFtZS50cnVuY2F0ZShkaXJOYW1lLmxlbmd0 aCgpIC0gcGF0aEdldEZpbGVOYW1lKHBhdGgpLmxlbmd0aCgpKTsKLSAgICByZXR1cm4gZGlyTmFt ZTsKKyAgICByZXR1cm4gcGF0aC5sZWZ0KHBhdGgubGVndGgoKSAtIHBhdGhHZXRGaWxlTmFtZShw YXRoKS5sZW5ndGgoKSk7CiB9CiAKIHN0YXRpYyBTdHJpbmcgYnVuZGxlTmFtZSgpCg== 74772 2010-11-24 09:38:36 -0800 2010-11-29 09:53:11 -0800 Patch bug-50028.patch text/plain 1133 paroga ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MzgxYmMzMS4uNTYyOTEwNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0xMS0yNCAgUGF0cmljayBHYW5z dGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBTaW1wbGlmeSBkaXJlY3RvcnlOYW1lIGluIEZpbGVTeXN0ZW1X aW4uY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01 MDAyOAorCisgICAgICAgICogcGxhdGZvcm0vd2luL0ZpbGVTeXN0ZW1XaW4uY3BwOgorICAgICAg ICAoV2ViQ29yZTo6ZGlyZWN0b3J5TmFtZSk6CisKIDIwMTAtMTEtMjQgIFNoZXJpZmYgQm90ICA8 d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxp bmcgb3V0IHI3MjQ5OS4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vd2luL0ZpbGVTeXN0 ZW1XaW4uY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS93aW4vRmlsZVN5c3RlbVdpbi5jcHAKaW5kZXgg Y2VmNzE5Ni4uYWYzMGQwOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS93aW4vRmlsZVN5 c3RlbVdpbi5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS93aW4vRmlsZVN5c3RlbVdpbi5jcHAK QEAgLTEzNCwxMCArMTM0LDcgQEAgU3RyaW5nIHBhdGhHZXRGaWxlTmFtZShjb25zdCBTdHJpbmcm IHBhdGgpCiAKIFN0cmluZyBkaXJlY3RvcnlOYW1lKGNvbnN0IFN0cmluZyYgcGF0aCkKIHsKLSAg ICBTdHJpbmcgZmlsZU5hbWUgPSBwYXRoR2V0RmlsZU5hbWUocGF0aCk7Ci0gICAgU3RyaW5nIGRp ck5hbWUgPSBTdHJpbmcocGF0aCk7Ci0gICAgZGlyTmFtZS50cnVuY2F0ZShkaXJOYW1lLmxlbmd0 aCgpIC0gcGF0aEdldEZpbGVOYW1lKHBhdGgpLmxlbmd0aCgpKTsKLSAgICByZXR1cm4gZGlyTmFt ZTsKKyAgICByZXR1cm4gcGF0aC5sZWZ0KHBhdGgubGVuZ3RoKCkgLSBwYXRoR2V0RmlsZU5hbWUo cGF0aCkubGVuZ3RoKCkpOwogfQogCiBzdGF0aWMgU3RyaW5nIGJ1bmRsZU5hbWUoKQo=