50016 2010-11-24 04:46:47 -0800 Potential crash in JavaClassV8.cpp 2010-11-25 10:36:40 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 benm benm commit-queue steveblock oldest_to_newest 313230 0 benm 2010-11-24 04:46:47 -0800 We can early out in the JavaClassV8 constructor if the JVM is unable to load the class. However this leaves m_name uninitialised which is then used in a call to free() in the destructor. Patch to follow. 313722 1 74865 benm 2010-11-25 05:56:22 -0800 Created attachment 74865 Patch. 313725 2 74866 benm 2010-11-25 05:57:53 -0800 Created attachment 74866 Patch (no tabs). 313748 3 74866 steveblock 2010-11-25 07:02:13 -0800 Comment on attachment 74866 Patch (no tabs). r=me 313795 4 commit-queue 2010-11-25 09:03:42 -0800 The commit-queue encountered the following flaky tests while processing attachment 74866: compositing/iframes/overlapped-nested-iframes.html inspector/elements-panel-xhtml-structure.xhtml Please file bugs against the tests. These tests were authored by apavlov@chromium.org, pfeldman@chromium.org, and simon.fraser@apple.com. The commit-queue is continuing to process your patch. 313822 5 74866 commit-queue 2010-11-25 10:36:35 -0800 Comment on attachment 74866 Patch (no tabs). Clearing flags on attachment: 74866 Committed r72740: <http://trac.webkit.org/changeset/72740> 313823 6 commit-queue 2010-11-25 10:36:40 -0800 All reviewed patches have been landed. Closing bug. 74865 2010-11-25 05:56:22 -0800 2010-11-25 05:57:53 -0800 Patch. 50016.txt text/plain 2291 benm SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MjcyNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTAtMTEtMjUgIEJlbiBNdXJkb2NoICA8YmVubUBnb29nbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBvdGVu dGlhbCBjcmFzaCBpbiBKYXZhQ2xhc3NWOC5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTUwMDE2CisKKyAgICAgICAgSXQgaXMgcG9zc2libGUgdGhh dCB3ZSBhdHRlbXB0IHRvIGZyZWUgdW5pbml0aWFsaXNlZAorICAgICAgICBtZW1vcnkgaW4gdGhl IEphdmFDbGFzcyBkZXN0cmN0b3Igd2hlbiB1c2luZyBWOCBpbiB0aGUKKyAgICAgICAgY2FzZSB0 aGF0IHRoZSBKVk0gY291bGQgbm90IGZpbmQgdGhlIGNsYXNzIGluIHRoZSBjb25zdHJ1Y3Rvci4K KworCUl0IHR1cm5zIG91dCB0aGF0IHRoZSB0cm91Ymxlc29tZSBtX25hbWUgaXMgbm90IGFjdXRh bGx5CisJdXNlZCBhbnl3aGVyZSwgc28gd2UgcmVtb3ZlIGl0IGluIHRoaXMgcGF0Y2guCisKKyAg ICAgICAgTm8gbmV3IHRlc3RzLCBqdXN0IHJlbW92aW5nIGRlYWQgY29kZS4KKworICAgICAgICAq IGJyaWRnZS9qbmkvdjgvSmF2YUNsYXNzVjguY3BwOiBSZW1vdmUgdW51c2VkIG1fbmFtZS4KKyAg ICAgICAgKiBicmlkZ2Uvam5pL3Y4L0phdmFDbGFzc1Y4Lmg6IERpdHRvLgorCiAyMDEwLTExLTI1 ICBIYW5zIFdlbm5ib3JnICA8aGFuc0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgSmVyZW15IE9ybG93LgpJbmRleDogV2ViQ29yZS9icmlkZ2Uvam5pL3Y4L0phdmFDbGFzc1Y4 LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JyaWRnZS9qbmkvdjgvSmF2YUNsYXNzVjguY3Bw CShyZXZpc2lvbiA3MjcyNCkKKysrIFdlYkNvcmUvYnJpZGdlL2puaS92OC9KYXZhQ2xhc3NWOC5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTI2LDcgKzI2LDYgQEAKICNpbmNsdWRlICJjb25maWcuaCIK ICNpbmNsdWRlICJKYXZhQ2xhc3NWOC5oIgogCi0KIHVzaW5nIG5hbWVzcGFjZSBKU0M6OkJpbmRp bmdzOwogCiBKYXZhQ2xhc3M6OkphdmFDbGFzcyhqb2JqZWN0IGFuSW5zdGFuY2UpCkBAIC0zOCwx MSArMzcsNiBAQCBKYXZhQ2xhc3M6OkphdmFDbGFzcyhqb2JqZWN0IGFuSW5zdGFuY2UpCiAgICAg ICAgIHJldHVybjsKICAgICB9CiAKLSAgICBqc3RyaW5nIGNsYXNzTmFtZSA9IHN0YXRpY19jYXN0 PGpzdHJpbmc+KGNhbGxKTklNZXRob2Q8am9iamVjdD4oYUNsYXNzLCAiZ2V0TmFtZSIsICIoKUxq YXZhL2xhbmcvU3RyaW5nOyIpKTsKLSAgICBjb25zdCBjaGFyKiBjbGFzc05hbWVDID0gZ2V0Q2hh cmFjdGVyc0Zyb21KU3RyaW5nKGNsYXNzTmFtZSk7Ci0gICAgbV9uYW1lID0gc3RyZHVwKGNsYXNz TmFtZUMpOwotICAgIHJlbGVhc2VDaGFyYWN0ZXJzRm9ySlN0cmluZyhjbGFzc05hbWUsIGNsYXNz TmFtZUMpOwotCiAgICAgaW50IGk7CiAgICAgSk5JRW52KiBlbnYgPSBnZXRKTklFbnYoKTsKIApA QCAtODIsOCArNzYsNiBAQCBKYXZhQ2xhc3M6OkphdmFDbGFzcyhqb2JqZWN0IGFuSW5zdGFuY2Up CiAKIEphdmFDbGFzczo6fkphdmFDbGFzcygpCiB7Ci0gICAgZnJlZShjb25zdF9jYXN0PGNoYXIq PihtX25hbWUpKTsKLQogICAgIGRlbGV0ZUFsbFZhbHVlcyhtX2ZpZWxkcyk7CiAgICAgbV9maWVs ZHMuY2xlYXIoKTsKIApJbmRleDogV2ViQ29yZS9icmlkZ2Uvam5pL3Y4L0phdmFDbGFzc1Y4LmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViQ29yZS9icmlkZ2Uvam5pL3Y4L0phdmFDbGFzc1Y4LmgJKHJldmlz aW9uIDcyNzI0KQorKysgV2ViQ29yZS9icmlkZ2Uvam5pL3Y4L0phdmFDbGFzc1Y4LmgJKHdvcmtp bmcgY29weSkKQEAgLTQ5LDcgKzQ5LDYgQEAgcHVibGljOgogICAgIEphdmFGaWVsZCogZmllbGRO YW1lZChjb25zdCBjaGFyKiBuYW1lKSBjb25zdDsKIAogcHJpdmF0ZToKLSAgICBjb25zdCBjaGFy KiBtX25hbWU7CiAgICAgTWV0aG9kTGlzdE1hcCBtX21ldGhvZHM7CiAgICAgRmllbGRNYXAgbV9m aWVsZHM7CiB9Owo= 74866 2010-11-25 05:57:53 -0800 2010-11-25 10:36:35 -0800 Patch (no tabs). 50016.txt text/plain 2305 benm SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MjcyNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTAtMTEtMjUgIEJlbiBNdXJkb2NoICA8YmVubUBnb29nbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBvdGVu dGlhbCBjcmFzaCBpbiBKYXZhQ2xhc3NWOC5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTUwMDE2CisKKyAgICAgICAgSXQgaXMgcG9zc2libGUgdGhh dCB3ZSBhdHRlbXB0IHRvIGZyZWUgdW5pbml0aWFsaXNlZAorICAgICAgICBtZW1vcnkgaW4gdGhl IEphdmFDbGFzcyBkZXN0cmN0b3Igd2hlbiB1c2luZyBWOCBpbiB0aGUKKyAgICAgICAgY2FzZSB0 aGF0IHRoZSBKVk0gY291bGQgbm90IGZpbmQgdGhlIGNsYXNzIGluIHRoZSBjb25zdHJ1Y3Rvci4K KworICAgICAgICBJdCB0dXJucyBvdXQgdGhhdCB0aGUgdHJvdWJsZXNvbWUgbV9uYW1lIGlzIG5v dCBhY3V0YWxseQorICAgICAgICB1c2VkIGFueXdoZXJlLCBzbyB3ZSByZW1vdmUgaXQgaW4gdGhp cyBwYXRjaC4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGp1c3QgcmVtb3ZpbmcgZGVhZCBjb2Rl LgorCisgICAgICAgICogYnJpZGdlL2puaS92OC9KYXZhQ2xhc3NWOC5jcHA6IFJlbW92ZSB1bnVz ZWQgbV9uYW1lLgorICAgICAgICAqIGJyaWRnZS9qbmkvdjgvSmF2YUNsYXNzVjguaDogRGl0dG8u CisKIDIwMTAtMTEtMjUgIEhhbnMgV2VubmJvcmcgIDxoYW5zQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBSZXZpZXdlZCBieSBKZXJlbXkgT3Jsb3cuCkluZGV4OiBXZWJDb3JlL2JyaWRnZS9qbmkv djgvSmF2YUNsYXNzVjguY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYnJpZGdlL2puaS92OC9K YXZhQ2xhc3NWOC5jcHAJKHJldmlzaW9uIDcyNzI0KQorKysgV2ViQ29yZS9icmlkZ2Uvam5pL3Y4 L0phdmFDbGFzc1Y4LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjYsNyArMjYsNiBAQAogI2luY2x1 ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIkphdmFDbGFzc1Y4LmgiCiAKLQogdXNpbmcgbmFtZXNw YWNlIEpTQzo6QmluZGluZ3M7CiAKIEphdmFDbGFzczo6SmF2YUNsYXNzKGpvYmplY3QgYW5JbnN0 YW5jZSkKQEAgLTM4LDExICszNyw2IEBAIEphdmFDbGFzczo6SmF2YUNsYXNzKGpvYmplY3QgYW5J bnN0YW5jZSkKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAotICAgIGpzdHJpbmcgY2xhc3NOYW1l ID0gc3RhdGljX2Nhc3Q8anN0cmluZz4oY2FsbEpOSU1ldGhvZDxqb2JqZWN0PihhQ2xhc3MsICJn ZXROYW1lIiwgIigpTGphdmEvbGFuZy9TdHJpbmc7IikpOwotICAgIGNvbnN0IGNoYXIqIGNsYXNz TmFtZUMgPSBnZXRDaGFyYWN0ZXJzRnJvbUpTdHJpbmcoY2xhc3NOYW1lKTsKLSAgICBtX25hbWUg PSBzdHJkdXAoY2xhc3NOYW1lQyk7Ci0gICAgcmVsZWFzZUNoYXJhY3RlcnNGb3JKU3RyaW5nKGNs YXNzTmFtZSwgY2xhc3NOYW1lQyk7Ci0KICAgICBpbnQgaTsKICAgICBKTklFbnYqIGVudiA9IGdl dEpOSUVudigpOwogCkBAIC04Miw4ICs3Niw2IEBAIEphdmFDbGFzczo6SmF2YUNsYXNzKGpvYmpl Y3QgYW5JbnN0YW5jZSkKIAogSmF2YUNsYXNzOjp+SmF2YUNsYXNzKCkKIHsKLSAgICBmcmVlKGNv bnN0X2Nhc3Q8Y2hhcio+KG1fbmFtZSkpOwotCiAgICAgZGVsZXRlQWxsVmFsdWVzKG1fZmllbGRz KTsKICAgICBtX2ZpZWxkcy5jbGVhcigpOwogCkluZGV4OiBXZWJDb3JlL2JyaWRnZS9qbmkvdjgv SmF2YUNsYXNzVjguaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JyaWRnZS9qbmkvdjgvSmF2YUNs YXNzVjguaAkocmV2aXNpb24gNzI3MjQpCisrKyBXZWJDb3JlL2JyaWRnZS9qbmkvdjgvSmF2YUNs YXNzVjguaAkod29ya2luZyBjb3B5KQpAQCAtNDksNyArNDksNiBAQCBwdWJsaWM6CiAgICAgSmF2 YUZpZWxkKiBmaWVsZE5hbWVkKGNvbnN0IGNoYXIqIG5hbWUpIGNvbnN0OwogCiBwcml2YXRlOgot ICAgIGNvbnN0IGNoYXIqIG1fbmFtZTsKICAgICBNZXRob2RMaXN0TWFwIG1fbWV0aG9kczsKICAg ICBGaWVsZE1hcCBtX2ZpZWxkczsKIH07Cg==