50012 2010-11-24 04:05:43 -0800 Moving cursor down in table cycles at the end of a row 2011-02-03 11:33:28 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) All All RESOLVED FIXED HasReduction P2 Normal --- 1 jochen webkit-unassigned darin enrica kalman leviw leviw mitz rniwa oldest_to_newest 313209 0 jochen 2010-11-24 04:05:43 -0800 When you try to move with the cursor through an editable table, the cursor jumps to the beginning at the end of a row. See attached layout test. 313217 1 74745 jochen 2010-11-24 04:14:52 -0800 Created attachment 74745 layout test demonstrating the problem If you try to go with e.g. page down over a part of html that contains a table, webkit will go into an endless loop in SelectionController::modify (in the for loop around line 777) 313220 2 jochen 2010-11-24 04:23:49 -0800 Adding a few interested parties (according to svn blame on the files I suspect to be affected). Apologies if I'm mistaken 313226 3 jochen 2010-11-24 04:30:17 -0800 note that the test doesn't work outside of LayoutTests/editing/selection/ However, you can just place the cursor on the beginning of the last line and repeatedly hit cursor down to see the problem 343512 4 rniwa 2011-02-01 13:54:37 -0800 (In reply to comment #1) > Created an attachment (id=74745) [details] > layout test demonstrating the problem > > If you try to go with e.g. page down over a part of html that contains a table, webkit will go into an endless loop in SelectionController::modify (in the for loop around line 777) I don't understand what you mean by the endless loop. Do you mean that pressing down key will keep moving cursor between two positions? Or that WebKit falls into an infinite loop and does not respond? 343521 5 leviw 2011-02-01 14:02:36 -0800 It actually returns to whichever position you start it in on that line. Placing the caret in the middle will jump between the middle and end. I was just taking a look at this code for 25757 so I'm happy to find the root cause. 343523 6 jochen 2011-02-01 14:04:39 -0800 (In reply to comment #4) > (In reply to comment #1) > > Created an attachment (id=74745) [details] [details] > > layout test demonstrating the problem > > > > If you try to go with e.g. page down over a part of html that contains a table, webkit will go into an endless loop in SelectionController::modify (in the for loop around line 777) > > I don't understand what you mean by the endless loop. Do you mean that pressing down key will keep moving cursor between two positions? Or that WebKit falls into an infinite loop and does not respond? I discovered the issue while using page-down to scroll through an reply to an html mail in gmail. In that case, WebKit falls into an infinite loop and does not respond. After adding some debug output, I figured out that the current editing position was inside a table and WebKit got stuck in SelectionController::modify (the for loop in line 845-860. The layout test demonstrates the underlying issue. When you press down at the end of the table, you should stay at the end. Instead, you jump again to the beginning of the table. That's what's causing the endless loop IMO. 343532 7 rniwa 2011-02-01 14:15:43 -0800 This is a bug in nextLinePosition in visible_units.cpp. It's a hard bug to fix though. 344316 8 80981 leviw 2011-02-02 15:35:23 -0800 Created attachment 80981 Patch 344319 9 leviw 2011-02-02 15:41:28 -0800 (In reply to comment #8) > Created an attachment (id=80981) [details] > Patch The code improperly descended back into the same leaf node because the anchor node the last position used wasn't in a leaf position. In nextLeafWithSameEditability, when there's no child node at the provided offset, it should traverse to the last descendant before finding the next leaf node, or it can regress like in this example. Also, I had to update the offset in your layout test to correspond with the actual final offset. 344333 10 80981 rniwa 2011-02-02 15:53:12 -0800 Comment on attachment 80981 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=80981&action=review Ah great! I had imagined this would have been much harder to fix. Good job fixing it. r- for stylistic issues. > Source/WebCore/ChangeLog:7 > + Please explain what caused the bug and how you fixed it. You can almost copy & paste your comment #c9. > Source/WebCore/editing/visible_units.cpp:589 > while (n) { > if (editable == n->isContentEditable()) > return n; It's sad that this while loop is identical to that of the function below yet we don't share code. Is there anyway we can share code? > LayoutTests/ChangeLog:7 > + Please explain what kind of test you're adding, etc... > LayoutTests/ChangeLog:9 > + * editing/selection/move-by-line-006-expected.txt: Added. > + * editing/selection/move-by-line-006.html: Added. It would be nice if the test name reflected what the test is about rather than just having a number 006. > LayoutTests/editing/selection/move-by-line-006.html:1 > +<html> Missing <!DOCTYPE html> > LayoutTests/editing/selection/move-by-line-006.html:17 > + <script src=../editing.js language="JavaScript" type="text/JavaScript" ></script> > + <script> > + function test() > + { > + if (window.layoutTestController) > + layoutTestController.dumpAsText(); > + > + var target = document.getElementById("target"); > + getSelection().setBaseAndExtent(target.firstChild, 0, target.firstChild, 0); > + for (var i=0; i<2; i++) > + moveSelectionForwardByLineCommand(); > + > + document.getElementById("result").innerText = getSelection().baseOffset == 6 ? "PASS" : "FAIL"; > + } > + </script> We don't normally indent tags like this. And I don't think we need to wait until load event. You can just run all of them when the parser inserts the script element into the document if you moved the script element after table. If you do that, then you can just use document.write to print PASS/FAIL instead of having a #result paragraph. Also, no space between i and 2, and no need to specify type and language in the script tag. > LayoutTests/editing/selection/move-by-line-006.html:21 > + <p> > + Test for <i><a href="http://bugs.webkit.org/show_bug.cgi?id=50012">http://bugs.webkit.org/show_bug.cgi?id=50012</a> Ditto about indentation. 344343 11 leviw 2011-02-02 15:57:29 -0800 > Please explain what caused the bug and how you fixed it. You can almost copy & paste your comment #c9. I put the short description after the function name but I can throw in more if you'd like ;) + * editing/visible_units.cpp: + (WebCore::nextLeafWithSameEditability): + Properly avoid descending back into the original leaf node. I'll clean up the layout test. I simply grabbed it from the bug. 344353 12 rniwa 2011-02-02 16:04:58 -0800 (In reply to comment #11) > I put the short description after the function name but I can throw in more if you'd like ;) > > + * editing/visible_units.cpp: > + (WebCore::nextLeafWithSameEditability): > + Properly avoid descending back into the original leaf node. I think we normally start the comment immediately after : and a space as in: (WebCore::nextLeafWithSameEditability): Properly avoid descending back into the original leaf node. 344412 13 81005 leviw 2011-02-02 16:51:48 -0800 Created attachment 81005 Patch 344421 14 81005 rniwa 2011-02-02 16:56:57 -0800 Comment on attachment 81005 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=81005&action=review I'd say r+ but please address the following comments before landing this patch. > Source/WebCore/ChangeLog:11 > + Avoids a caret cycling issue with certain content (e.g. tables) found at the very > + end of a document due to a bug in nextLeafWithSameEditability. Description should appear before tests. > LayoutTests/editing/selection/move-by-line-cycles-in-table.html:1 > +<html> Please put <!DOCTYPE html> > LayoutTests/editing/selection/move-by-line-cycles-in-table.html:3 > + <script src=../editing.js language="JavaScript" type="text/JavaScript" ></script> Please remove the indentation, and language/type attributes. They just clutter the test. Also, you can move this into body right before another script element. That way, you can get rid of head. > LayoutTests/editing/selection/move-by-line-cycles-in-table.html:12 > +<script language="JavaScript" type="text/JavaScript"> Ditto about language and type attributes. > LayoutTests/editing/selection/move-by-line-cycles-in-table.html:14 > + layoutTestController.dumpAsText(); We should probably give two or four spaces instead of one to be consistent with the rest of tests. > LayoutTests/editing/selection/move-by-line-cycles-in-table.html:19 > + moveSelectionForwardByLineCommand(); Ditto about the spaces. > LayoutTests/editing/selection/move-by-line-cycles-in-table.html:21 > +document.write(getSelection().baseOffset == 4 ? "PASS" : "FAIL"); It'll be nice if you printed getSelection().baseOffset in the case of FAIL so that it's easier to diagnose the problem if the test failed on bots. 344879 15 leviw 2011-02-03 11:33:28 -0800 Committed r77521: <http://trac.webkit.org/changeset/77521> 74745 2010-11-24 04:14:52 -0800 2010-11-24 04:14:52 -0800 layout test demonstrating the problem move-by-line-006.html text/html 1041 jochen PGh0bWw+CjxoZWFkPgogICAgPHNjcmlwdCBzcmM9Li4vZWRpdGluZy5qcyBsYW5ndWFnZT0iSmF2 YVNjcmlwdCIgdHlwZT0idGV4dC9KYXZhU2NyaXB0IiA+PC9zY3JpcHQ+CiAgICA8c2NyaXB0Pgog ICAgICAgIGZ1bmN0aW9uIHRlc3QoKQogICAgICAgIHsKICAgICAgICAgICAgaWYgKHdpbmRvdy5s YXlvdXRUZXN0Q29udHJvbGxlcikKICAgICAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVy LmR1bXBBc1RleHQoKTsKCiAgICAgICAgICAgIHZhciB0YXJnZXQgPSBkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgidGFyZ2V0Iik7CiAgICAgICAgICAgIGdldFNlbGVjdGlvbigpLnNldEJhc2VBbmRF eHRlbnQodGFyZ2V0LmZpcnN0Q2hpbGQsIDAsIHRhcmdldC5maXJzdENoaWxkLCAwKTsKICAgICAg ICAgICAgZm9yICh2YXIgaT0wOyBpPDI7IGkrKykKICAgICAgICAgICAgICAgIG1vdmVTZWxlY3Rp b25Gb3J3YXJkQnlMaW5lQ29tbWFuZCgpOwoKICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoInJlc3VsdCIpLmlubmVyVGV4dCA9IGdldFNlbGVjdGlvbigpLmJhc2VPZmZzZXQgPT0g NCA/ICJQQVNTIiA6ICJGQUlMIjsKICAgICAgICB9CiAgICA8L3NjcmlwdD4KPC9oZWFkPgo8Ym9k eSBvbmxvYWQ9InRlc3QoKSIgc3R5bGU9Ii13ZWJraXQtdXNlci1tb2RpZnk6IHJlYWQtd3JpdGUi PgogICAgPHA+CiAgICAgICAgVGVzdCBmb3IgPGk+PGEgaHJlZj0iaHR0cDovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTAwMTIiPmh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTUwMDEyPC9hPgogICAgICAgIE1vdmluZyBjdXJzb3IgZG93biBpbiB0YWJsZSBj eWNsZXMgYXQgdGhlIGVuZCBvZiBhIHJvdzwvaT4KICAgIDwvcD4KICAgIDxwIGlkPSJyZXN1bHQi PgogICAgICAgIFRlc3QgZGlkIG5vdCBydW4KICAgIDwvcD4KICAgIDx0YWJsZT48dHI+PHRkIGlk PSJ0YXJnZXQiPkN1cnNvciBzaG91bGQgYmUgYXQgdGhlIGVuZDwvdGQ+PC90cj48L3RhYmxlPgo8 L2JvZHk+CjwvaHRtbD4K 80981 2011-02-02 15:35:23 -0800 2011-02-02 16:51:45 -0800 Patch bug-50012-20110202153522.patch text/plain 3825 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc3NDE0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDItMDIgIExldmkgV2Vp bnRyYXViICA8bGV2aXdAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE1vdmluZyBjdXJzb3IgZG93biBpbiB0YWJsZSBjeWNsZXMg YXQgdGhlIGVuZCBvZiBhIHJvdworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NTAwMTIKKworICAgICAgICBUZXN0OiBlZGl0aW5nL3NlbGVjdGlvbi9tb3Zl LWJ5LWxpbmUtMDA2Lmh0bWwKKworICAgICAgICAqIGVkaXRpbmcvdmlzaWJsZV91bml0cy5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpuZXh0TGVhZldpdGhTYW1lRWRpdGFiaWxpdHkpOgorICAgICAg ICBQcm9wZXJseSBhdm9pZCBkZXNjZW5kaW5nIGJhY2sgaW50byB0aGUgb3JpZ2luYWwgbGVhZiBu b2RlLgorCiAyMDExLTAyLTAyICBLZW5uZXRoIFJ1c3NlbGwgIDxrYnJAZ29vZ2xlLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBKYW1lcyBSb2JpbnNvbi4KSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L2VkaXRpbmcvdmlzaWJsZV91bml0cy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv ZWRpdGluZy92aXNpYmxlX3VuaXRzLmNwcAkocmV2aXNpb24gNzcyOTEpCisrKyBTb3VyY2UvV2Vi Q29yZS9lZGl0aW5nL3Zpc2libGVfdW5pdHMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01ODMsNyAr NTgzLDcgQEAgc3RhdGljIE5vZGUqIG5leHRMZWFmV2l0aFNhbWVFZGl0YWJpbGl0eQogICAgIGJv b2wgZWRpdGFibGUgPSBub2RlLT5pc0NvbnRlbnRFZGl0YWJsZSgpOwogICAgIEFTU0VSVChvZmZz ZXQgPj0gMCk7CiAgICAgTm9kZSogY2hpbGQgPSBub2RlLT5jaGlsZE5vZGUob2Zmc2V0KTsKLSAg ICBOb2RlKiBuID0gY2hpbGQgPyBjaGlsZC0+bmV4dExlYWZOb2RlKCkgOiBub2RlLT5uZXh0TGVh Zk5vZGUoKTsKKyAgICBOb2RlKiBuID0gY2hpbGQgPyBjaGlsZC0+bmV4dExlYWZOb2RlKCkgOiBu b2RlLT5sYXN0RGVzY2VuZGFudCgpLT5uZXh0TGVhZk5vZGUoKTsKICAgICB3aGlsZSAobikgewog ICAgICAgICBpZiAoZWRpdGFibGUgPT0gbi0+aXNDb250ZW50RWRpdGFibGUoKSkKICAgICAgICAg ICAgIHJldHVybiBuOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNzc0MTQpCisrKyBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMS0wMi0wMiAgTGV2 aSBXZWludHJhdWIgIDxsZXZpd0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTW92aW5nIGN1cnNvciBkb3duIGluIHRhYmxlIGN5 Y2xlcyBhdCB0aGUgZW5kIG9mIGEgcm93CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD01MDAxMgorCisgICAgICAgICogZWRpdGluZy9zZWxlY3Rpb24vbW92 ZS1ieS1saW5lLTAwNi1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGVkaXRpbmcvc2Vs ZWN0aW9uL21vdmUtYnktbGluZS0wMDYuaHRtbDogQWRkZWQuCisKIDIwMTEtMDItMDIgIEtlbm5l dGggUnVzc2VsbCAgPGtickBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEphbWVz IFJvYmluc29uLgpJbmRleDogTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vbW92ZS1ieS1s aW5lLTAwNi1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZWRpdGluZy9z ZWxlY3Rpb24vbW92ZS1ieS1saW5lLTAwNi1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBM YXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9tb3ZlLWJ5LWxpbmUtMDA2LWV4cGVjdGVkLnR4 dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw1IEBACitUZXN0IGZvciBodHRwOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MDAxMiBNb3ZpbmcgY3Vyc29yIGRvd24gaW4gdGFibGUg Y3ljbGVzIGF0IHRoZSBlbmQgb2YgYSByb3cKKworUEFTUworCitDdXJzb3Igc2hvdWxkIGJlIGF0 IHRoZSBlbmQKSW5kZXg6IExheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL21vdmUtYnktbGlu ZS0wMDYuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9t b3ZlLWJ5LWxpbmUtMDA2Lmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9lZGl0aW5n L3NlbGVjdGlvbi9tb3ZlLWJ5LWxpbmUtMDA2Lmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEs MzAgQEAKKzxodG1sPgorPGhlYWQ+CisgICAgPHNjcmlwdCBzcmM9Li4vZWRpdGluZy5qcyBsYW5n dWFnZT0iSmF2YVNjcmlwdCIgdHlwZT0idGV4dC9KYXZhU2NyaXB0IiA+PC9zY3JpcHQ+CisgICAg PHNjcmlwdD4KKyAgICAgICAgZnVuY3Rpb24gdGVzdCgpCisgICAgICAgIHsKKyAgICAgICAgICAg IGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgICAgICAgICAgbGF5b3V0 VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworCisgICAgICAgICAgICB2YXIgdGFyZ2V0ID0g ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRhcmdldCIpOworICAgICAgICAgICAgZ2V0U2VsZWN0 aW9uKCkuc2V0QmFzZUFuZEV4dGVudCh0YXJnZXQuZmlyc3RDaGlsZCwgMCwgdGFyZ2V0LmZpcnN0 Q2hpbGQsIDApOworICAgICAgICAgICAgZm9yICh2YXIgaT0wOyBpPDI7IGkrKykKKyAgICAgICAg ICAgICAgICBtb3ZlU2VsZWN0aW9uRm9yd2FyZEJ5TGluZUNvbW1hbmQoKTsKKworICAgICAgICAg ICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInJlc3VsdCIpLmlubmVyVGV4dCA9IGdldFNlbGVj dGlvbigpLmJhc2VPZmZzZXQgPT0gNiA/ICJQQVNTIiA6ICJGQUlMIjsKKyAgICAgICAgfQorICAg IDwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkgb25sb2FkPSJ0ZXN0KCkiIHN0eWxlPSItd2Via2l0 LXVzZXItbW9kaWZ5OiByZWFkLXdyaXRlIj4KKyAgICA8cD4KKyAgICAgICAgVGVzdCBmb3IgPGk+ PGEgaHJlZj0iaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTAwMTIiPmh0 dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUwMDEyPC9hPgorICAgICAgICBN b3ZpbmcgY3Vyc29yIGRvd24gaW4gdGFibGUgY3ljbGVzIGF0IHRoZSBlbmQgb2YgYSByb3c8L2k+ CisgICAgPC9wPgorICAgIDxwIGlkPSJyZXN1bHQiPgorICAgICAgICBUZXN0IGRpZCBub3QgcnVu CisgICAgPC9wPgorICAgIDx0YWJsZSBpZD0idGFibGUiPjx0cj48dGQgaWQ9InRhcmdldCI+Q3Vy c29yIHNob3VsZCBiZSBhdCB0aGUgZW5kPC90ZD48L3RyPjwvdGFibGU+Cis8L2JvZHk+Cis8L2h0 bWw+CisK 81005 2011-02-02 16:51:48 -0800 2011-02-02 16:56:57 -0800 Patch bug-50012-20110202165147.patch text/plain 4009 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc3NDE0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDItMDIgIExldmkgV2Vp bnRyYXViICA8bGV2aXdAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE1vdmluZyBjdXJzb3IgZG93biBpbiB0YWJsZSBjeWNsZXMg YXQgdGhlIGVuZCBvZiBhIHJvdworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NTAwMTIKKworICAgICAgICBUZXN0OiBlZGl0aW5nL3NlbGVjdGlvbi9tb3Zl LWJ5LWxpbmUtY3ljbGVzLWluLXRhYmxlLmh0bWwKKworICAgICAgICBBdm9pZHMgYSBjYXJldCBj eWNsaW5nIGlzc3VlIHdpdGggY2VydGFpbiBjb250ZW50IChlLmcuIHRhYmxlcykgZm91bmQgYXQg dGhlIHZlcnkKKyAgICAgICAgZW5kIG9mIGEgZG9jdW1lbnQgZHVlIHRvIGEgYnVnIGluIG5leHRM ZWFmV2l0aFNhbWVFZGl0YWJpbGl0eS4KKworICAgICAgICAqIGVkaXRpbmcvdmlzaWJsZV91bml0 cy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpuZXh0TGVhZldpdGhTYW1lRWRpdGFiaWxpdHkpOiBQ cm9wZXJseSBhdm9pZCBkZXNjZW5kaW5nIGJhY2sgaW50byB0aGUKKyAgICAgICAgb3JpZ2luYWwg bGVhZiBub2RlLgorCiAyMDExLTAyLTAyICBLZW5uZXRoIFJ1c3NlbGwgIDxrYnJAZ29vZ2xlLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBKYW1lcyBSb2JpbnNvbi4KSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL2VkaXRpbmcvdmlzaWJsZV91bml0cy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvZWRpdGluZy92aXNpYmxlX3VuaXRzLmNwcAkocmV2aXNpb24gNzcyOTEpCisrKyBTb3Vy Y2UvV2ViQ29yZS9lZGl0aW5nL3Zpc2libGVfdW5pdHMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01 ODMsNyArNTgzLDcgQEAgc3RhdGljIE5vZGUqIG5leHRMZWFmV2l0aFNhbWVFZGl0YWJpbGl0eQog ICAgIGJvb2wgZWRpdGFibGUgPSBub2RlLT5pc0NvbnRlbnRFZGl0YWJsZSgpOwogICAgIEFTU0VS VChvZmZzZXQgPj0gMCk7CiAgICAgTm9kZSogY2hpbGQgPSBub2RlLT5jaGlsZE5vZGUob2Zmc2V0 KTsKLSAgICBOb2RlKiBuID0gY2hpbGQgPyBjaGlsZC0+bmV4dExlYWZOb2RlKCkgOiBub2RlLT5u ZXh0TGVhZk5vZGUoKTsKKyAgICBOb2RlKiBuID0gY2hpbGQgPyBjaGlsZC0+bmV4dExlYWZOb2Rl KCkgOiBub2RlLT5sYXN0RGVzY2VuZGFudCgpLT5uZXh0TGVhZk5vZGUoKTsKICAgICB3aGlsZSAo bikgewogICAgICAgICBpZiAoZWRpdGFibGUgPT0gbi0+aXNDb250ZW50RWRpdGFibGUoKSkKICAg ICAgICAgICAgIHJldHVybiBuOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNzc0MTQpCisrKyBMYXlvdXRU ZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0wMi0w MiAgTGV2aSBXZWludHJhdWIgIDxsZXZpd0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTW92aW5nIGN1cnNvciBkb3duIGluIHRh YmxlIGN5Y2xlcyBhdCB0aGUgZW5kIG9mIGEgcm93CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MDAxMgorICAgICAgICAKKyAgICAgICAgVGVzdHMgZG93 bndhcmQgY2FyZXQtbmF2aWdhdGlvbiBmb3IgdGFibGVzIGF0IHRoZSBlbmQgb2YgYSBkb2N1bWVu dC4KKworICAgICAgICAqIGVkaXRpbmcvc2VsZWN0aW9uL21vdmUtYnktbGluZS1jeWNsZXMtaW4t dGFibGUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBlZGl0aW5nL3NlbGVjdGlvbi9t b3ZlLWJ5LWxpbmUtY3ljbGVzLWluLXRhYmxlLmh0bWw6IEFkZGVkLgorCiAyMDExLTAyLTAyICBL ZW5uZXRoIFJ1c3NlbGwgIDxrYnJAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBK YW1lcyBSb2JpbnNvbi4KSW5kZXg6IExheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL21vdmUt YnktbGluZS1jeWNsZXMtaW4tdGFibGUtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL21vdmUtYnktbGluZS1jeWNsZXMtaW4tdGFibGUtZXhw ZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24v bW92ZS1ieS1saW5lLWN5Y2xlcy1pbi10YWJsZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBA IC0wLDAgKzEsNCBAQAorVGVzdCBmb3IgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NTAwMTIgTW92aW5nIGN1cnNvciBkb3duIGluIHRhYmxlIGN5Y2xlcyBhdCB0aGUgZW5k IG9mIGEgcm93CisKK0N1cnNvciBzaG91bGQgYmUgYXQgdGhlIGVuZAorUEFTUwpJbmRleDogTGF5 b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vbW92ZS1ieS1saW5lLWN5Y2xlcy1pbi10YWJsZS5o dG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL21vdmUtYnkt bGluZS1jeWNsZXMtaW4tdGFibGUuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Vk aXRpbmcvc2VsZWN0aW9uL21vdmUtYnktbGluZS1jeWNsZXMtaW4tdGFibGUuaHRtbAkocmV2aXNp b24gMCkKQEAgLTAsMCArMSwyNiBAQAorPGh0bWw+Cis8aGVhZD4KKyAgPHNjcmlwdCBzcmM9Li4v ZWRpdGluZy5qcyBsYW5ndWFnZT0iSmF2YVNjcmlwdCIgdHlwZT0idGV4dC9KYXZhU2NyaXB0IiA+ PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBzdHlsZT0iLXdlYmtpdC11c2VyLW1vZGlmeTogcmVh ZC13cml0ZSI+Cis8cD4KKyBUZXN0IGZvciA8aT48YSBocmVmPSJodHRwOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD01MDAxMiI+aHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NTAwMTI8L2E+CisgTW92aW5nIGN1cnNvciBkb3duIGluIHRhYmxlIGN5Y2xlcyBh dCB0aGUgZW5kIG9mIGEgcm93PC9pPgorPC9wPgorPHRhYmxlIGlkPSJ0YWJsZSI+PHRyPjx0ZCBp ZD0idGFyZ2V0Ij5DdXJzb3Igc2hvdWxkIGJlIGF0IHRoZSBlbmQ8L3RkPjwvdHI+PC90YWJsZT4K KzxkaXYgc3R5bGU9Ii13ZWJraXQtdXNlci1tb2RpZnk6IHJlYWQtb25seSI+Cis8c2NyaXB0IGxh bmd1YWdlPSJKYXZhU2NyaXB0IiB0eXBlPSJ0ZXh0L0phdmFTY3JpcHQiPgoraWYgKHdpbmRvdy5s YXlvdXRUZXN0Q29udHJvbGxlcikKKyBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7 CisKK3ZhciB0YXJnZXQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGFyZ2V0Iik7CitnZXRT ZWxlY3Rpb24oKS5zZXRCYXNlQW5kRXh0ZW50KHRhcmdldC5maXJzdENoaWxkLCAwLCB0YXJnZXQu Zmlyc3RDaGlsZCwgMCk7Citmb3IgKHZhciBpPTA7IGkgPCAyOyBpKyspCisgbW92ZVNlbGVjdGlv bkZvcndhcmRCeUxpbmVDb21tYW5kKCk7CisKK2RvY3VtZW50LndyaXRlKGdldFNlbGVjdGlvbigp LmJhc2VPZmZzZXQgPT0gNCA/ICJQQVNTIiA6ICJGQUlMIik7Cis8L3NjcmlwdD4KKzwvZGl2Pgor PC9ib2R5PgorPC9odG1sPgorCg==