50010 2010-11-24 02:13:03 -0800 REGRESSION(r72650): breaks focus in scenes focus item other than graphicswebiview (Requested by tronical_ on #webkit). 2010-11-24 02:24:25 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 43169 1 webkit.review.bot webkit.review.bot commit-queue kenneth oldest_to_newest 313182 0 webkit.review.bot 2010-11-24 02:13:03 -0800 http://trac.webkit.org/changeset/72650 broke the build: breaks focus in scenes focus item other than graphicswebiview (Requested by tronical_ on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 313183 1 74735 webkit.review.bot 2010-11-24 02:13:24 -0800 Created attachment 74735 ROLLOUT of r72650 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID --ignore-builders where ATTACHMENT_ID is the ID of this attachment. 313187 2 74735 commit-queue 2010-11-24 02:24:20 -0800 Comment on attachment 74735 ROLLOUT of r72650 Clearing flags on attachment: 74735 Committed r72653: <http://trac.webkit.org/changeset/72653> 313188 3 commit-queue 2010-11-24 02:24:25 -0800 All reviewed patches have been landed. Closing bug. 74735 2010-11-24 02:13:24 -0800 2010-11-24 02:24:20 -0800 ROLLOUT of r72650 bug-50010-20101124101319.patch text/plain 5604 webkit.review.bot ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcWdyYXBoaWNzd2Vidmlldy5jcHAgYi9XZWJLaXQv cXQvQXBpL3FncmFwaGljc3dlYnZpZXcuY3BwCmluZGV4IGY5NGFlMGUyYmU0YTFkODdmMzEyNDM1 OWIwMTYxNjRiNmRjODRmZWIuLmM4NDM4ZjNmN2ExYWY0YjdjNGNhN2UxZjIwM2M3ODNkY2NhYjYy ODMgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9BcGkvcWdyYXBoaWNzd2Vidmlldy5jcHAKKysrIGIv V2ViS2l0L3F0L0FwaS9xZ3JhcGhpY3N3ZWJ2aWV3LmNwcApAQCAtNTMsOCArNTMsNyBAQCBwdWJs aWM6CiAgICAgUUdyYXBoaWNzV2ViVmlld1ByaXZhdGUoUUdyYXBoaWNzV2ViVmlldyogcGFyZW50 KQogICAgICAgICA6IHEocGFyZW50KQogICAgICAgICAsIHBhZ2UoMCkKLSAgICAgICAgLCByZXNp emVzVG9Db250ZW50cyhmYWxzZSkKLSAgICAgICAgLCBjdXJyZW50U2NlbmUoMCkge30KKyAgICAg ICAgLCByZXNpemVzVG9Db250ZW50cyhmYWxzZSkge30KIAogICAgIHZpcnR1YWwgflFHcmFwaGlj c1dlYlZpZXdQcml2YXRlKCk7CiAKQEAgLTc2LDcgKzc1LDYgQEAgcHVibGljOgogICAgIFFHcmFw aGljc1dlYlZpZXcqIHE7CiAgICAgUVdlYlBhZ2UqIHBhZ2U7CiAgICAgYm9vbCByZXNpemVzVG9D b250ZW50czsKLSAgICBRR3JhcGhpY3NTY2VuZSogY3VycmVudFNjZW5lOwogCiAgICAgUUdyYXBo aWNzSXRlbU92ZXJsYXkqIG92ZXJsYXkoKSBjb25zdAogICAgIHsKQEAgLTI1NCwxMSArMjUyLDYg QEAgUUdyYXBoaWNzV2ViVmlldzo6UUdyYXBoaWNzV2ViVmlldyhRR3JhcGhpY3NJdGVtKiBwYXJl bnQpCiAjaWYgRU5BQkxFKFRJTEVEX0JBQ0tJTkdfU1RPUkUpCiAgICAgUU9iamVjdDo6Y29ubmVj dCh0aGlzLCBTSUdOQUwoc2NhbGVDaGFuZ2VkKCkpLCB0aGlzLCBTTE9UKF9xX3NjYWxlQ2hhbmdl ZCgpKSk7CiAjZW5kaWYKLQotICAgIGlmIChzY2VuZSgpKSB7Ci0gICAgICAgIGQtPmN1cnJlbnRT Y2VuZSA9IHNjZW5lKCk7Ci0gICAgICAgIGQtPmN1cnJlbnRTY2VuZS0+aW5zdGFsbEV2ZW50Rmls dGVyKHRoaXMpOwotICAgIH0KIH0KIAogLyohCkBAIC0zMTUsMjAgKzMwOCw2IEBAIHZvaWQgUUdy YXBoaWNzV2ViVmlldzo6cGFpbnQoUVBhaW50ZXIqIHBhaW50ZXIsIGNvbnN0IFFTdHlsZU9wdGlv bkdyYXBoaWNzSXRlbSoKIAogLyohIFxyZWltcAogKi8KLWJvb2wgUUdyYXBoaWNzV2ViVmlldzo6 ZXZlbnRGaWx0ZXIoUU9iamVjdCogb2JqZWN0LCBRRXZlbnQqIGV2ZW50KQotewotICAgIGlmIChv YmplY3QgPT0gZC0+Y3VycmVudFNjZW5lCi0gICAgICAgICYmIChldmVudC0+dHlwZSgpID09IFFF dmVudDo6Rm9jdXNJbgotICAgICAgICAgICAgfHwgZXZlbnQtPnR5cGUoKSA9PSBRRXZlbnQ6OkZv Y3VzT3V0KSkgewotICAgICAgICBRRm9jdXNFdmVudCogZm9jdXNFdmVudCA9IHN0YXRpY19jYXN0 PFFGb2N1c0V2ZW50Kj4oZXZlbnQpOwotICAgICAgICBpZiAoZm9jdXNFdmVudC0+cmVhc29uKCkg PT0gUXQ6OkFjdGl2ZVdpbmRvd0ZvY3VzUmVhc29uKQotICAgICAgICAgICAgZC0+cGFnZS0+ZXZl bnQoZXZlbnQpOwotICAgIH0KLSAgICByZXR1cm4gZmFsc2U7Ci19Ci0KLS8qISBccmVpbXAKLSov CiBib29sIFFHcmFwaGljc1dlYlZpZXc6OnNjZW5lRXZlbnQoUUV2ZW50KiBldmVudCkKIHsKICAg ICAvLyBSZS1pbXBsZW1lbnRlZCBpbiBvcmRlciB0byBhbGxvd3MgZml4aW5nIGV2ZW50LXJlbGF0 ZWQgYnVncyBpbiBwYXRjaCByZWxlYXNlcy4KQEAgLTM2MywxNCArMzQyLDYgQEAgUVZhcmlhbnQg UUdyYXBoaWNzV2ViVmlldzo6aXRlbUNoYW5nZShHcmFwaGljc0l0ZW1DaGFuZ2UgY2hhbmdlLCBj b25zdCBRVmFyaWFudCYKICAgICAgICAgICAgIFFBcHBsaWNhdGlvbjo6c2VuZEV2ZW50KHRoaXMs ICZldmVudCk7CiAgICAgICAgICAgICByZXR1cm4gdmFsdWU7CiAgICAgICAgIH0KLSAgICBjYXNl IEl0ZW1TY2VuZUhhc0NoYW5nZWQ6IHsKLSAgICAgICAgICAgIFFHcmFwaGljc1NjZW5lKiBuZXdT Y2VuZSA9IHFWYXJpYW50VmFsdWU8UUdyYXBoaWNzU2NlbmUqPih2YWx1ZSk7Ci0gICAgICAgICAg ICBpZiAoZC0+Y3VycmVudFNjZW5lKQotICAgICAgICAgICAgICAgIGQtPmN1cnJlbnRTY2VuZS0+ cmVtb3ZlRXZlbnRGaWx0ZXIodGhpcyk7Ci0gICAgICAgICAgICBkLT5jdXJyZW50U2NlbmUgPSBu ZXdTY2VuZTsKLSAgICAgICAgICAgIGlmIChkLT5jdXJyZW50U2NlbmUpCi0gICAgICAgICAgICAg ICAgZC0+Y3VycmVudFNjZW5lLT5pbnN0YWxsRXZlbnRGaWx0ZXIodGhpcyk7Ci0gICAgICAgIH0K ICAgICBkZWZhdWx0OgogICAgICAgICBicmVhazsKICAgICB9CmRpZmYgLS1naXQgYS9XZWJLaXQv cXQvQXBpL3FncmFwaGljc3dlYnZpZXcuaCBiL1dlYktpdC9xdC9BcGkvcWdyYXBoaWNzd2Vidmll dy5oCmluZGV4IGE0ODRlOWUxMTBhMGJjYTg0YjY2M2VhMWUyYTE0MDU1OGUwNzg4YmMuLjg2MjBh YzU2MWZlZGViODc3NTk0MTBmYzBmNzUxY2FiNWYwMWUxZTMgMTAwNjQ0Ci0tLSBhL1dlYktpdC9x dC9BcGkvcWdyYXBoaWNzd2Vidmlldy5oCisrKyBiL1dlYktpdC9xdC9BcGkvcWdyYXBoaWNzd2Vi dmlldy5oCkBAIC0xNDAsOCArMTQwLDYgQEAgcHJvdGVjdGVkOgogCiAgICAgdmlydHVhbCBib29s IHNjZW5lRXZlbnQoUUV2ZW50Kik7CiAKLSAgICB2aXJ0dWFsIGJvb2wgZXZlbnRGaWx0ZXIoUU9i amVjdCosIFFFdmVudCopOwotCiBwcml2YXRlOgogICAgIFFfUFJJVkFURV9TTE9UKGQsIHZvaWQg X3FfZG9Mb2FkRmluaXNoZWQoYm9vbCBzdWNjZXNzKSkKICNpZiAhZGVmaW5lZChRVF9OT19JTSkg JiYgKGRlZmluZWQoUV9XU19YMTEpIHx8IGRlZmluZWQoUV9XU19RV1MpIHx8IGRlZmluZWQoUV9P U19TWU1CSUFOKSkKZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQv Q2hhbmdlTG9nCmluZGV4IDJmZTIzOGNmNDBjNWUwNzcxMWRjMDcxYmIzODVhOGI4OTIxOGExZDUu LjMyZGY5ZDJlZDQ1MGZhZWM4OWYxYzdjOGZlNDdiYjMzMWVlYjM1YzUgMTAwNjQ0Ci0tLSBhL1dl YktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDEwLTExLTI0ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNv bT4KKworICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByNzI2NTAuCisgICAgICAgIGh0 dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzcyNjUwCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MDAxMAorCisgICAgICAgIGJyZWFrcyBmb2N1 cyBpbiBzY2VuZXMgZm9jdXMgaXRlbSBvdGhlciB0aGFuIGdyYXBoaWNzd2ViaXZpZXcKKyAgICAg ICAgKFJlcXVlc3RlZCBieSB0cm9uaWNhbF8gb24gI3dlYmtpdCkuCisKKyAgICAgICAgKiBBcGkv cWdyYXBoaWNzd2Vidmlldy5jcHA6CisgICAgICAgIChRR3JhcGhpY3NXZWJWaWV3UHJpdmF0ZTo6 UUdyYXBoaWNzV2ViVmlld1ByaXZhdGUpOgorICAgICAgICAoUUdyYXBoaWNzV2ViVmlldzo6UUdy YXBoaWNzV2ViVmlldyk6CisgICAgICAgIChRR3JhcGhpY3NXZWJWaWV3OjppdGVtQ2hhbmdlKToK KyAgICAgICAgKiBBcGkvcWdyYXBoaWNzd2Vidmlldy5oOgorICAgICAgICAqIHRlc3RzL3FncmFw aGljc3dlYnZpZXcvdHN0X3FncmFwaGljc3dlYnZpZXcuY3BwOgorCiAyMDEwLTExLTI0ICBKYW4g RXJpayBIYW5zc2VuICA8amhhbnNzZW5Ac2VuY2hhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4KZGlmZiAtLWdpdCBhL1dlYktpdC9xdC90ZXN0 cy9xZ3JhcGhpY3N3ZWJ2aWV3L3RzdF9xZ3JhcGhpY3N3ZWJ2aWV3LmNwcCBiL1dlYktpdC9xdC90 ZXN0cy9xZ3JhcGhpY3N3ZWJ2aWV3L3RzdF9xZ3JhcGhpY3N3ZWJ2aWV3LmNwcAppbmRleCAyODRl ZmQyOTU4ZGYwNGExMWZmZDlhZWM4YjU5ZWM3OWYzNWYzYmIwLi4wOWEyMWUxNjY5Y2ZlZGI5MTY4 OWRmYWNjOGZkZTk0YzZlNzFmNmNlIDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvdGVzdHMvcWdyYXBo aWNzd2Vidmlldy90c3RfcWdyYXBoaWNzd2Vidmlldy5jcHAKKysrIGIvV2ViS2l0L3F0L3Rlc3Rz L3FncmFwaGljc3dlYnZpZXcvdHN0X3FncmFwaGljc3dlYnZpZXcuY3BwCkBAIC0zNiw3ICszNiw2 IEBAIHByaXZhdGUgc2xvdHM6CiAgICAgdm9pZCBmb2N1c0lucHV0VHlwZXMoKTsKICAgICB2b2lk IGNyYXNoT25TZXRTY2FsZUJlZm9yZVNldFVybCgpOwogICAgIHZvaWQgd2lkZ2V0c1JlbmRlcmlu Z1Rocm91Z2hDYWNoZSgpOwotICAgIHZvaWQgcmVjZWl2ZXNGb2N1c0luT25TaG93KCk7CiB9Owog CiB2b2lkIHRzdF9RR3JhcGhpY3NXZWJWaWV3OjpxZ3JhcGhpY3N3ZWJ2aWV3KCkKQEAgLTI2MCw1 OCArMjU5LDYgQEAgdm9pZCB0c3RfUUdyYXBoaWNzV2ViVmlldzo6Zm9jdXNJbnB1dFR5cGVzKCkK ICAgICBkZWxldGUgdmlldzsKIH0KIAotY2xhc3MgRm9jdXNQYWdlIDogcHVibGljIFFXZWJQYWdl IHsKLXB1YmxpYzoKLSAgICBGb2N1c1BhZ2UoUU9iamVjdCogcGFyZW50ID0gMCk7Ci0KLSAgICBi b29sIGdvdEZvY3VzKCkgY29uc3Q7Ci0KLXByb3RlY3RlZDoKLSAgICBib29sIGV2ZW50KFFFdmVu dCogZSk7Ci0KLXByaXZhdGU6Ci0gICAgYm9vbCBtX2ZvY3VzOwotfTsKLQotRm9jdXNQYWdlOjpG b2N1c1BhZ2UoUU9iamVjdCAqcGFyZW50KQotICAgIDogUVdlYlBhZ2UocGFyZW50KSwgbV9mb2N1 cyhmYWxzZSkKLXsKLX0KLQotYm9vbCBGb2N1c1BhZ2U6OmV2ZW50KFFFdmVudCAqZSkKLXsKLSAg ICBpZiAoZS0+dHlwZSgpID09IFFFdmVudDo6Rm9jdXNJbikKLSAgICAgICAgbV9mb2N1cyA9IHRy dWU7Ci0gICAgcmV0dXJuIFFXZWJQYWdlOjpldmVudChlKTsKLX0KLQotYm9vbCBGb2N1c1BhZ2U6 OmdvdEZvY3VzKCkgY29uc3QKLXsKLSAgICByZXR1cm4gbV9mb2N1czsKLX0KLQotdm9pZCB0c3Rf UUdyYXBoaWNzV2ViVmlldzo6cmVjZWl2ZXNGb2N1c0luT25TaG93KCkKLXsKLSAgICBRR3JhcGhp Y3NXZWJWaWV3IHdlYlZpZXc7Ci0gICAgd2ViVmlldy5zZXRIdG1sKCI8Ym9keT48aW5wdXQgdHlw ZT10ZXh0IGF1dG9mb2N1cz1hdXRvZm9jdXM+PC9pbnB1dD48L2JvZHk+Iik7Ci0gICAgRm9jdXNQ YWdlIHBhZ2U7Ci0gICAgd2ViVmlldy5zZXRQYWdlKCZwYWdlKTsKLQotICAgIGZvciAoaW50IGkg PSAwOyBpIDwgMzsgKytpKSB7Ci0gICAgICAgIFFHcmFwaGljc1ZpZXcgdmlldzsKLSAgICAgICAg UUdyYXBoaWNzU2NlbmUqIHNjZW5lID0gbmV3IFFHcmFwaGljc1NjZW5lKCZ2aWV3KTsKLSAgICAg ICAgdmlldy5zZXRTY2VuZShzY2VuZSk7Ci0gICAgICAgIHNjZW5lLT5hZGRJdGVtKCZ3ZWJWaWV3 KTsKLSAgICAgICAgdmlldy5zZXRHZW9tZXRyeShRUmVjdCgwLCAwLCA1MDAsIDUwMCkpOwotCi0g ICAgICAgIHZpZXcuc2hvdygpOwotICAgICAgICBRVGVzdDo6cVdhaXRGb3JXaW5kb3dTaG93bigm dmlldyk7Ci0KLSAgICAgICAgUVZFUklGWShwYWdlLmdvdEZvY3VzKCkpOwotCi0gICAgICAgIHNj ZW5lLT5yZW1vdmVJdGVtKCZ3ZWJWaWV3KTsKLSAgICB9Ci19CiAKIAogUVRFU1RfTUFJTih0c3Rf UUdyYXBoaWNzV2ViVmlldykK