50007 2010-11-24 00:35:43 -0800 Auto-clamping values doesn't work for <input type="range" step="any" /> 2010-11-24 22:04:52 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC All RESOLVED WONTFIX P2 Normal --- 0 dmikurube webkit-unassigned tkent oldest_to_newest 313160 0 dmikurube 2010-11-24 00:35:43 -0800 How to reproduce: 1. <input type="range" step="any" id="range" min="0" max="300" /> 2. document.getElementById("range").value = 199 Expected : document.getElementById("range").value should be 198. document.getElementById("range").stepMismatch() should be false correctly. Actual: document.getElementById("range").value is 199. document.getElementById("range").stepMismatch() is false. (As RangeInputType::stepMismatch() is hard-coded.) But it is not step-matching. Facts: 1. A value in <input type="range" /> must be clamped for steps. Never stepMismatch() == true. 2. stepUp() for <input type="range" step="any" /> assumes step="'(1/100 of the value range)" in the current implementation. (See the comment below (*)) (*) WebCore/html/RangeInputType.cpp : // FIXME: We can't use stepUp() for the step value "any". So, we increase // or decrease the value by 1/100 of the value range. Is it reasonable? Though 1 and 2, input.value can be set with a step-mismatched value in case of step="any". 313197 1 74736 dmikurube 2010-11-24 03:18:44 -0800 Created attachment 74736 Patch 313570 2 tkent 2010-11-24 18:06:04 -0800 > 1. <input type="range" step="any" id="range" min="0" max="300" /> > 2. document.getElementById("range").value = 199 > > Expected : > document.getElementById("range").value should be 198. > document.getElementById("range").stepMismatch() should be false correctly. No. This range input should accept any value in 0-300 because of step=any. 1/100 step behavior is just for keyboard operation. 313580 3 dmikurube 2010-11-24 18:19:13 -0800 (In reply to comment #2) Thanks. Ok, so what should happen when : 1. <input type="range" step="any" id="range" min="0" max="300" /> 2. document.getElementById("range").value = 199 3. sendKey('Up') for id="range" ? Is it should be 202? 313584 4 tkent 2010-11-24 18:23:18 -0800 (In reply to comment #3) > (In reply to comment #2) > > Thanks. Ok, so what should happen when : > 1. <input type="range" step="any" id="range" min="0" max="300" /> > 2. document.getElementById("range").value = 199 > 3. sendKey('Up') for id="range" > ? > > Is it should be 202? I think so. The value should increase by 1/100 of the value range. 313608 5 dmikurube 2010-11-24 21:50:31 -0800 (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > > Thanks. Ok, so what should happen when : > > 1. <input type="range" step="any" id="range" min="0" max="300" /> > > 2. document.getElementById("range").value = 199 > > 3. sendKey('Up') for id="range" > > ? > > > > Is it should be 202? > > I think so. The value should increase by 1/100 of the value range. Thanks. So closing this bug. 313611 6 74736 tkent 2010-11-24 22:00:25 -0800 Comment on attachment 74736 Patch Clearing the review flag. 313612 7 dmikurube 2010-11-24 22:04:52 -0800 (In reply to comment #6) > (From update of attachment 74736 [details]) > Clearing the review flag. I forgot it. Thank you. 74736 2010-11-24 03:18:44 -0800 2010-11-24 22:00:25 -0800 Patch bug-50007-20101124201846.patch text/plain 12335 dmikurube ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhZTMwNDdjMmQwNTY3NzZkNTgzYzAyZTE4MDBlZDg1Y2RiNDQ1OGNjLi5mZmUzYjQ3 ZTQwZDljYTIwOGMwYzkwNmZiYzg3ZjcyOGVkN2E1MDExIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTAtMTEtMjQgIERhaSBNaWt1cnViZSAgPGRtaWt1cnViZUBnb29nbGUuY29tPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEF1dG8tY2xhbXBpbmcg dmFsdWVzIGRvbid0IHdvcmsgZm9yIDxpbnB1dCB0eXBlPSJyYW5nZSIgc3RlcD0iYW55IiAvPgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTAwMDcKKwor ICAgICAgICAqIGZhc3QvZm9ybXMvcmFuZ2UtY2xhbXAtZm9yLXN0ZXAtYW55LWV4cGVjdGVkLnR4 dDogQWRkZWQuCisgICAgICAgICogZmFzdC9mb3Jtcy9yYW5nZS1jbGFtcC1mb3Itc3RlcC1hbnku aHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC9mb3Jtcy9zY3JpcHQtdGVzdHMvcmFuZ2UtY2xh bXAtZm9yLXN0ZXAtYW55LmpzOiBBZGRlZC4KKwogMjAxMC0xMS0xOCAgRGF2aWQgTGV2aW4gIDxs ZXZpbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBNaXNjIHRlc3QgdXBkYXRl cyAobW9zdCBSdWJ5KS4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvcmFuZ2Ut Y2xhbXAtZm9yLXN0ZXAtYW55LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMv cmFuZ2UtY2xhbXAtZm9yLXN0ZXAtYW55LWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4xYWE5Zjdk ZjZmY2I3MjM1ZDQxYjMzZjA0NDAxNjg3Mjg2NGE0ZmM0Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5 b3V0VGVzdHMvZmFzdC9mb3Jtcy9yYW5nZS1jbGFtcC1mb3Itc3RlcC1hbnktZXhwZWN0ZWQudHh0 CkBAIC0wLDAgKzEsMTEgQEAKK1Rlc3QgZm9yIHN0ZXA9YW55IG9mIDxpbnB1dCB0eXBlPXJhbmdl PgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2Vz LCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBpbnB1dC52YWx1ZSBpcyAi MTk4IgorCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUK KwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9yYW5nZS1jbGFtcC1mb3Itc3Rl cC1hbnkuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvcmFuZ2UtY2xhbXAtZm9yLXN0ZXAt YW55Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMC4uNTEyNWI3YjNiYmI2MzU1ZTk1ZDQ3OGE5OTZlZTczYTUxZGFl MmM2NgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvcmFuZ2UtY2xh bXAtZm9yLXN0ZXAtYW55Lmh0bWwKQEAgLTAsMCArMSwxMyBAQAorPCFET0NUWVBFIEhUTUwgUFVC TElDICItLy9JRVRGLy9EVEQgSFRNTC8vRU4iPgorPGh0bWw+Cis8aGVhZD4KKzxsaW5rIHJlbD0i c3R5bGVzaGVldCIgaHJlZj0iLi4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5j c3MiPgorPHNjcmlwdCBzcmM9Ii4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpz Ij48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+Cis8 ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQgc3JjPSJzY3JpcHQtdGVzdHMvcmFuZ2Ut Y2xhbXAtZm9yLXN0ZXAtYW55LmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9mYXN0 L2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1s PgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zY3JpcHQtdGVzdHMvcmFuZ2Ut Y2xhbXAtZm9yLXN0ZXAtYW55LmpzIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zY3JpcHQtdGVz dHMvcmFuZ2UtY2xhbXAtZm9yLXN0ZXAtYW55LmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmMzYzM1MmMzMTQ5MGNj OWY2MTcxMTNjMTdmNjgwNGFkYmM0ZDQ3ZGIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L2Zvcm1zL3NjcmlwdC10ZXN0cy9yYW5nZS1jbGFtcC1mb3Itc3RlcC1hbnkuanMKQEAg LTAsMCArMSwxNiBAQAorZGVzY3JpcHRpb24oIlRlc3QgZm9yIHN0ZXA9YW55IG9mICZsdDtpbnB1 dCB0eXBlPXJhbmdlJmd0OyIpOworCit2YXIgcGFyZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVu dCgnZGl2Jyk7Citkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKHBhcmVudCk7CitwYXJlbnQuaW5u ZXJIVE1MID0gJzxpbnB1dCB0eXBlPXJhbmdlIGlkPXJhbmdlIG1pbj0wIG1heD0xMDAgdmFsdWU9 NTA+JzsKKwordmFyIGlucHV0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3JhbmdlJyk7CisK K2lucHV0LnN0ZXAgPSAnYW55JzsKK2lucHV0Lm1pbiA9ICcwJzsKK2lucHV0Lm1heCA9ICczMDAn OworaW5wdXQudmFsdWVBc051bWJlciA9IDE5OTsKK3Nob3VsZEJlKCdpbnB1dC52YWx1ZScsICci MTk4IicpOworCitkZWJ1ZygnJyk7Cit2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsKZGlm ZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWQx YzNjMzYxNTZlMjdlZjA1MGZkNTM5OWE4YzFhZDI3YjEyNWFhNS4uYzkyYzE5Y2ViYTkxM2M1YzMy MzU0ODE3NTQ3NmJhNDQ1YTA2MTc5NSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysr IGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyOSBAQAorMjAxMC0xMS0yNCAgRGFpIE1p a3VydWJlICA8ZG1pa3VydWJlQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQXV0by1jbGFtcGluZyB2YWx1ZXMgZG9uJ3Qgd29yayBm b3IgPGlucHV0IHR5cGU9InJhbmdlIiBzdGVwPSJhbnkiIC8+CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MDAwNworCisgICAgICAgIFRlc3Q6IGZhc3Qv Zm9ybXMvcmFuZ2UtY2xhbXAtZm9yLXN0ZXAtYW55Lmh0bWwKKworICAgICAgICAqIGh0bWwvSFRN TElucHV0RWxlbWVudC5jcHA6IE1vZGlmaWVkIHRvIGhhbmRsZSBkZWNpbWFsIHBsYWNlcworICAg ICAgICAoV2ViQ29yZTo6SFRNTElucHV0RWxlbWVudDo6bWluaW11bVdpdGhEZWNpbWFsUGxhY2Vz KToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxJbnB1dEVsZW1lbnQ6Om1heGltdW1XaXRoRGVjaW1h bFBsYWNlcyk6CisgICAgICAgICogaHRtbC9IVE1MSW5wdXRFbGVtZW50Lmg6CisgICAgICAgICog aHRtbC9JbnB1dFR5cGUuY3BwOiBNb2RpZmllZCB0byBoYW5kbGUgZGVjaW1hbCBwbGFjY2VzCisg ICAgICAgIChXZWJDb3JlOjpJbnB1dFR5cGU6Om1pbmltdW1XaXRoRGVjaW1hbFBsYWNlcyk6Cisg ICAgICAgIChXZWJDb3JlOjpJbnB1dFR5cGU6Om1heGltdW1XaXRoRGVjaW1hbFBsYWNlcyk6Cisg ICAgICAgICogaHRtbC9JbnB1dFR5cGUuaDoKKyAgICAgICAgKiBodG1sL1JhbmdlSW5wdXRUeXBl LmNwcDogTW9kaWZpZWQgdG8gaGFuZGxlIGRlY2ltYWwgcGxhY2VzCisgICAgICAgIChXZWJDb3Jl OjpSYW5nZUlucHV0VHlwZTo6bWluaW11bVdpdGhEZWNpbWFsUGxhY2VzKToKKyAgICAgICAgKFdl YkNvcmU6OlJhbmdlSW5wdXRUeXBlOjptYXhpbXVtV2l0aERlY2ltYWxQbGFjZXMpOgorICAgICAg ICAqIGh0bWwvUmFuZ2VJbnB1dFR5cGUuaDoKKyAgICAgICAgKiBodG1sL1N0ZXBSYW5nZS5jcHA6 IE1vZGlmaWVkIHRvIGNsYW1wIHN0ZXBzIGZvciBzdGVwPSJhbnkiCisgICAgICAgIChXZWJDb3Jl OjpTdGVwUmFuZ2U6OlN0ZXBSYW5nZSk6CisgICAgICAgIChXZWJDb3JlOjpTdGVwUmFuZ2U6OmNs YW1wVmFsdWUpOgorICAgICAgICAqIGh0bWwvU3RlcFJhbmdlLmg6CisKIDIwMTAtMTEtMTggIEdh dmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IE9saXZlciBIdW50LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVs ZW1lbnQuY3BwIGIvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCmluZGV4IGFmNGU3 ZDA1NDgyMTcxMTBlMzk3YzNiYzRhMWZlY2Y3NzY3YjU4MDkuLjIyYTAyOWQwOGFhOTE2MDI1Mjlj OTM0NmY2MDZkZmMyZGY4YzQzOTEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRF bGVtZW50LmNwcAorKysgYi9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAKQEAgLTIz NiwxMSArMjM2LDIxIEBAIGRvdWJsZSBIVE1MSW5wdXRFbGVtZW50OjptaW5pbXVtKCkgY29uc3QK ICAgICByZXR1cm4gbV9pbnB1dFR5cGUtPm1pbmltdW0oKTsKIH0KIAorZG91YmxlIEhUTUxJbnB1 dEVsZW1lbnQ6Om1pbmltdW1XaXRoRGVjaW1hbFBsYWNlcyh1bnNpZ25lZCAqZGVjaW1hbFBsYWNl cykgY29uc3QKK3sKKyAgICByZXR1cm4gbV9pbnB1dFR5cGUtPm1pbmltdW1XaXRoRGVjaW1hbFBs YWNlcyhkZWNpbWFsUGxhY2VzKTsKK30KKwogZG91YmxlIEhUTUxJbnB1dEVsZW1lbnQ6Om1heGlt dW0oKSBjb25zdAogewogICAgIHJldHVybiBtX2lucHV0VHlwZS0+bWF4aW11bSgpOwogfQogCitk b3VibGUgSFRNTElucHV0RWxlbWVudDo6bWF4aW11bVdpdGhEZWNpbWFsUGxhY2VzKHVuc2lnbmVk ICpkZWNpbWFsUGxhY2VzKSBjb25zdAoreworICAgIHJldHVybiBtX2lucHV0VHlwZS0+bWF4aW11 bVdpdGhEZWNpbWFsUGxhY2VzKGRlY2ltYWxQbGFjZXMpOworfQorCiBib29sIEhUTUxJbnB1dEVs ZW1lbnQ6OnN0ZXBNaXNtYXRjaChjb25zdCBTdHJpbmcmIHZhbHVlKSBjb25zdAogewogICAgIGRv dWJsZSBzdGVwOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuaCBi L1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmgKaW5kZXggOTg4NDExN2I4MTFjY2ExOWVl MDc0N2IwNWQwNWI4ZmNlMDIyYjUxYi4uZGZmNmE3NDE0ZWEyMGZkYWIzN2NhZDZlYjA1ZTYzZGI4 ZmFjNTkwMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuaAorKysg Yi9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5oCkBAIC01OSw5ICs1OSwxMSBAQCBwdWJs aWM6CiAgICAgYm9vbCByYW5nZU92ZXJmbG93KGNvbnN0IFN0cmluZyYpIGNvbnN0OwogICAgIC8v IFJldHVybnMgdGhlIG1pbmltdW0gdmFsdWUgZm9yIHR5cGU9ZGF0ZSwgbnVtYmVyLCBvciByYW5n ZS4gIERvbid0IGNhbGwgdGhpcyBmb3Igb3RoZXIgdHlwZXMuCiAgICAgZG91YmxlIG1pbmltdW0o KSBjb25zdDsKKyAgICBkb3VibGUgbWluaW11bVdpdGhEZWNpbWFsUGxhY2VzKHVuc2lnbmVkKikg Y29uc3Q7CiAgICAgLy8gUmV0dXJucyB0aGUgbWF4aW11bSB2YWx1ZSBmb3IgdHlwZT1kYXRlLCBu dW1iZXIsIG9yIHJhbmdlLiAgRG9uJ3QgY2FsbCB0aGlzIGZvciBvdGhlciB0eXBlcy4KICAgICAv LyBUaGlzIGFsd2F5cyByZXR1cm5zIGEgdmFsdWUgd2hpY2ggaXMgPj0gbWluaW11bSgpLgogICAg IGRvdWJsZSBtYXhpbXVtKCkgY29uc3Q7CisgICAgZG91YmxlIG1heGltdW1XaXRoRGVjaW1hbFBs YWNlcyh1bnNpZ25lZCopIGNvbnN0OwogICAgIC8vIFNldHMgdGhlICJhbGxvd2VkIHZhbHVlIHN0 ZXAiIGRlZmluZWQgaW4gdGhlIEhUTUwgc3BlYyB0byB0aGUgc3BlY2lmaWVkIGRvdWJsZSBwb2lu dGVyLgogICAgIC8vIFJldHVybnMgZmFsc2UgaWYgdGhlcmUgaXMgbm8gImFsbG93ZWQgdmFsdWUg c3RlcC4iCiAgICAgYm9vbCBnZXRBbGxvd2VkVmFsdWVTdGVwKGRvdWJsZSopIGNvbnN0OwpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9odG1sL0lucHV0VHlwZS5jcHAgYi9XZWJDb3JlL2h0bWwvSW5wdXRU eXBlLmNwcAppbmRleCA2ZGQwMDJjNGYyYWZkMTUxZWQ0MmJiOGUzMzBlMWY1MjI0ZDgzMmMyLi4x Nzk5OGU4Y2I3ZWVmYzMwMGIwODM0NTdjNjAyYjhhZTQ1YWQyOWFhIDEwMDY0NAotLS0gYS9XZWJD b3JlL2h0bWwvSW5wdXRUeXBlLmNwcAorKysgYi9XZWJDb3JlL2h0bWwvSW5wdXRUeXBlLmNwcApA QCAtMjE5LDEyICsyMTksMjYgQEAgZG91YmxlIElucHV0VHlwZTo6bWluaW11bSgpIGNvbnN0CiAg ICAgcmV0dXJuIDA7CiB9CiAKK2RvdWJsZSBJbnB1dFR5cGU6Om1pbmltdW1XaXRoRGVjaW1hbFBs YWNlcyh1bnNpZ25lZCogZGVjaW1hbFBsYWNlcykgY29uc3QKK3sKKyAgICBpZiAoZGVjaW1hbFBs YWNlcykKKyAgICAgICAgKmRlY2ltYWxQbGFjZXMgPSAwOworICAgIHJldHVybiBtaW5pbXVtKCk7 Cit9CisKIGRvdWJsZSBJbnB1dFR5cGU6Om1heGltdW0oKSBjb25zdAogewogICAgIEFTU0VSVF9O T1RfUkVBQ0hFRCgpOwogICAgIHJldHVybiAwOwogfQogCitkb3VibGUgSW5wdXRUeXBlOjptYXhp bXVtV2l0aERlY2ltYWxQbGFjZXModW5zaWduZWQqIGRlY2ltYWxQbGFjZXMpIGNvbnN0Cit7Cisg ICAgaWYgKGRlY2ltYWxQbGFjZXMpCisgICAgICAgICpkZWNpbWFsUGxhY2VzID0gMDsKKyAgICBy ZXR1cm4gbWF4aW11bSgpOworfQorCiBib29sIElucHV0VHlwZTo6c3RlcE1pc21hdGNoKGNvbnN0 IFN0cmluZyYsIGRvdWJsZSkgY29uc3QKIHsKICAgICAvLyBOb24tc3VwcG9ydGVkIHR5cGVzIHNo b3VsZCBiZSByZWplY3RlZCBieSBIVE1MSW5wdXRFbGVtZW50OjpnZXRBbGxvd2VkVmFsdWVTdGVw KCkuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwvSW5wdXRUeXBlLmggYi9XZWJDb3JlL2h0bWwv SW5wdXRUeXBlLmgKaW5kZXggZjFhNWI2ZGNhMGY3ZmFlMjMwMjllOGMyNjk0OWRhYTIyMmQ3M2Ix YS4uN2QyZDkxZmQ4MGVlOGYyZGU4ZWI5MDBkZTI3NGNmNWZiNGUxMGVmMCAxMDA2NDQKLS0tIGEv V2ViQ29yZS9odG1sL0lucHV0VHlwZS5oCisrKyBiL1dlYkNvcmUvaHRtbC9JbnB1dFR5cGUuaApA QCAtOTAsNyArOTAsOSBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBib29sIHJhbmdlVW5kZXJmbG93 KGNvbnN0IFN0cmluZyYpIGNvbnN0OwogICAgIHZpcnR1YWwgYm9vbCByYW5nZU92ZXJmbG93KGNv bnN0IFN0cmluZyYpIGNvbnN0OwogICAgIHZpcnR1YWwgZG91YmxlIG1pbmltdW0oKSBjb25zdDsK KyAgICB2aXJ0dWFsIGRvdWJsZSBtaW5pbXVtV2l0aERlY2ltYWxQbGFjZXModW5zaWduZWQqKSBj b25zdDsKICAgICB2aXJ0dWFsIGRvdWJsZSBtYXhpbXVtKCkgY29uc3Q7CisgICAgdmlydHVhbCBk b3VibGUgbWF4aW11bVdpdGhEZWNpbWFsUGxhY2VzKHVuc2lnbmVkKikgY29uc3Q7CiAgICAgdmly dHVhbCBib29sIHN0ZXBNaXNtYXRjaChjb25zdCBTdHJpbmcmLCBkb3VibGUpIGNvbnN0OwogICAg IHZpcnR1YWwgZG91YmxlIHN0ZXBCYXNlKCkgY29uc3Q7CiAgICAgdmlydHVhbCBkb3VibGUgc3Rl cEJhc2VXaXRoRGVjaW1hbFBsYWNlcyh1bnNpZ25lZCopIGNvbnN0OwpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9odG1sL1JhbmdlSW5wdXRUeXBlLmNwcCBiL1dlYkNvcmUvaHRtbC9SYW5nZUlucHV0VHlw ZS5jcHAKaW5kZXggYWQ0N2YxNGNiMTRhOWQ4ODkxMmZjZGE2MmM4Zjk3Zjg4YWQzYmMxYy4uMTlj ODkyYTVkYmE4MThhMDYyNWE5NzgxNGYxMzJhNWQ3OTAxYzUwNyAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9odG1sL1JhbmdlSW5wdXRUeXBlLmNwcAorKysgYi9XZWJDb3JlL2h0bWwvUmFuZ2VJbnB1dFR5 cGUuY3BwCkBAIC05NCw2ICs5NCwxMSBAQCBkb3VibGUgUmFuZ2VJbnB1dFR5cGU6Om1pbmltdW0o KSBjb25zdAogICAgIHJldHVybiBwYXJzZVRvRG91YmxlKGVsZW1lbnQoKS0+ZmFzdEdldEF0dHJp YnV0ZShtaW5BdHRyKSwgcmFuZ2VEZWZhdWx0TWluaW11bSk7CiB9CiAKK2RvdWJsZSBSYW5nZUlu cHV0VHlwZTo6bWluaW11bVdpdGhEZWNpbWFsUGxhY2VzKHVuc2lnbmVkICpkZWNpbWFsUGxhY2Vz KSBjb25zdAoreworICAgIHJldHVybiBwYXJzZVRvRG91YmxlV2l0aERlY2ltYWxQbGFjZXMoZWxl bWVudCgpLT5mYXN0R2V0QXR0cmlidXRlKG1pbkF0dHIpLCByYW5nZURlZmF1bHRNaW5pbXVtLCBk ZWNpbWFsUGxhY2VzKTsKK30KKwogZG91YmxlIFJhbmdlSW5wdXRUeXBlOjptYXhpbXVtKCkgY29u c3QKIHsKICAgICBkb3VibGUgbWF4ID0gcGFyc2VUb0RvdWJsZShlbGVtZW50KCktPmZhc3RHZXRB dHRyaWJ1dGUobWF4QXR0ciksIHJhbmdlRGVmYXVsdE1heGltdW0pOwpAQCAtMTA1LDYgKzExMCwy MSBAQCBkb3VibGUgUmFuZ2VJbnB1dFR5cGU6Om1heGltdW0oKSBjb25zdAogICAgIHJldHVybiBt YXg7CiB9CiAKK2RvdWJsZSBSYW5nZUlucHV0VHlwZTo6bWF4aW11bVdpdGhEZWNpbWFsUGxhY2Vz KHVuc2lnbmVkICpkZWNpbWFsUGxhY2VzKSBjb25zdAoreworICAgIGRvdWJsZSBtYXggPSBwYXJz ZVRvRG91YmxlV2l0aERlY2ltYWxQbGFjZXMoZWxlbWVudCgpLT5mYXN0R2V0QXR0cmlidXRlKG1h eEF0dHIpLCByYW5nZURlZmF1bHRNYXhpbXVtLCBkZWNpbWFsUGxhY2VzKTsKKyAgICAvLyBBIHJl bWVkeSBmb3IgdGhlIGluY29uc2lzdGVudCBtaW4vbWF4IHZhbHVlcy4KKyAgICAvLyBTZXRzIHRo ZSBtYXhpbXVtIHRvIHRoZSBkZWZhdWx0IG9yIHRoZSBtaW5pbXVtIHZhbHVlLgorICAgIHVuc2ln bmVkIG1pbkRlY2ltYWxQbGFjZXMgPSAwOworICAgIGRvdWJsZSBtaW4gPSBtaW5pbXVtV2l0aERl Y2ltYWxQbGFjZXMoJm1pbkRlY2ltYWxQbGFjZXMpOworICAgIGlmIChtYXggPCBtaW4pIHsKKyAg ICAgICAgbWF4ID0gc3RkOjptYXgobWluLCByYW5nZURlZmF1bHRNYXhpbXVtKTsKKyAgICAgICAg aWYgKGRlY2ltYWxQbGFjZXMpCisgICAgICAgICAgICAqZGVjaW1hbFBsYWNlcyA9IG1pbkRlY2lt YWxQbGFjZXM7CisgICAgfQorICAgIHJldHVybiBtYXg7Cit9CisKIGJvb2wgUmFuZ2VJbnB1dFR5 cGU6OnN0ZXBNaXNtYXRjaChjb25zdCBTdHJpbmcmLCBkb3VibGUpIGNvbnN0CiB7CiAgICAgLy8g c3RlcE1pc21hdGNoIGRvZXNuJ3Qgb2NjdXIgZm9yIHR5cGU9cmFuZ2UuIFJlbmRlclNsaWRlciBn dWFyYW50ZWVzIHRoZQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9odG1sL1JhbmdlSW5wdXRUeXBlLmgg Yi9XZWJDb3JlL2h0bWwvUmFuZ2VJbnB1dFR5cGUuaAppbmRleCBjMmJiYjBmYzFkMTMyYjBmNzli NWQ3MTRjZGI1MTVkZDljZTMxNWExLi45N2M4ZjU5YmRkZmExODVlNjUwM2E2NTllOWY5Yzg3ZmRj MzkxNGVkIDEwMDY0NAotLS0gYS9XZWJDb3JlL2h0bWwvUmFuZ2VJbnB1dFR5cGUuaAorKysgYi9X ZWJDb3JlL2h0bWwvUmFuZ2VJbnB1dFR5cGUuaApAQCAtNDgsNyArNDgsOSBAQCBwcml2YXRlOgog ICAgIHZpcnR1YWwgYm9vbCByYW5nZVVuZGVyZmxvdyhjb25zdCBTdHJpbmcmKSBjb25zdDsKICAg ICB2aXJ0dWFsIGJvb2wgcmFuZ2VPdmVyZmxvdyhjb25zdCBTdHJpbmcmKSBjb25zdDsKICAgICB2 aXJ0dWFsIGRvdWJsZSBtaW5pbXVtKCkgY29uc3Q7CisgICAgdmlydHVhbCBkb3VibGUgbWluaW11 bVdpdGhEZWNpbWFsUGxhY2VzKHVuc2lnbmVkKikgY29uc3Q7CiAgICAgdmlydHVhbCBkb3VibGUg bWF4aW11bSgpIGNvbnN0OworICAgIHZpcnR1YWwgZG91YmxlIG1heGltdW1XaXRoRGVjaW1hbFBs YWNlcyh1bnNpZ25lZCopIGNvbnN0OwogICAgIHZpcnR1YWwgYm9vbCBzdGVwTWlzbWF0Y2goY29u c3QgU3RyaW5nJiwgZG91YmxlKSBjb25zdDsKICAgICB2aXJ0dWFsIGRvdWJsZSBzdGVwQmFzZSgp IGNvbnN0OwogICAgIHZpcnR1YWwgZG91YmxlIGRlZmF1bHRTdGVwKCkgY29uc3Q7CmRpZmYgLS1n aXQgYS9XZWJDb3JlL2h0bWwvU3RlcFJhbmdlLmNwcCBiL1dlYkNvcmUvaHRtbC9TdGVwUmFuZ2Uu Y3BwCmluZGV4IDY4YjBlYmQzNzZmZTg1OTY0ZWVhMTUzZjNmMTM0MWZmMzQ1NjVmN2EuLmZkM2I3 ZWVmYmZiNTgwYTEwM2Y5N2FiMzU4NWM0MjJiMDY1ZWI1ZmUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv aHRtbC9TdGVwUmFuZ2UuY3BwCisrKyBiL1dlYkNvcmUvaHRtbC9TdGVwUmFuZ2UuY3BwCkBAIC0z NSwxNCArMzUsMTggQEAgdXNpbmcgbmFtZXNwYWNlIEhUTUxOYW1lczsKIAogU3RlcFJhbmdlOjpT dGVwUmFuZ2UoY29uc3QgSFRNTElucHV0RWxlbWVudCogZWxlbWVudCkKIHsKKyAgICBtYXhpbXVt ID0gZWxlbWVudC0+bWF4aW11bVdpdGhEZWNpbWFsUGxhY2VzKCZtYXhpbXVtRGVjaW1hbFBsYWNl cyk7CisgICAgbWluaW11bSA9IGVsZW1lbnQtPm1pbmltdW1XaXRoRGVjaW1hbFBsYWNlcygmbWlu aW11bURlY2ltYWxQbGFjZXMpOworCiAgICAgaWYgKGVsZW1lbnQtPmhhc0F0dHJpYnV0ZShwcmVj aXNpb25BdHRyKSkgewogICAgICAgICBzdGVwID0gMS4wOworICAgICAgICBzdGVwRGVjaW1hbFBs YWNlcyA9IDA7CiAgICAgICAgIGhhc1N0ZXAgPSAhZXF1YWxJZ25vcmluZ0Nhc2UoZWxlbWVudC0+ Z2V0QXR0cmlidXRlKHByZWNpc2lvbkF0dHIpLCAiZmxvYXQiKTsKKyAgICB9IGVsc2UgaWYgKGVx dWFsSWdub3JpbmdDYXNlKGVsZW1lbnQtPmZhc3RHZXRBdHRyaWJ1dGUoc3RlcEF0dHIpLCAiYW55 IikpIHsKKyAgICAgICAgc3RlcCA9IChtYXhpbXVtIC0gbWluaW11bSkgLyAxMDA7CisgICAgICAg IHN0ZXBEZWNpbWFsUGxhY2VzID0gc3RkOjptYXgobWluaW11bURlY2ltYWxQbGFjZXMsIG1heGlt dW1EZWNpbWFsUGxhY2VzKSArIDI7CiAgICAgfSBlbHNlCi0gICAgICAgIGhhc1N0ZXAgPSBlbGVt ZW50LT5nZXRBbGxvd2VkVmFsdWVTdGVwKCZzdGVwKTsKLQotICAgIG1heGltdW0gPSBlbGVtZW50 LT5tYXhpbXVtKCk7Ci0gICAgbWluaW11bSA9IGVsZW1lbnQtPm1pbmltdW0oKTsKKyAgICAgICAg aGFzU3RlcCA9IGVsZW1lbnQtPmdldEFsbG93ZWRWYWx1ZVN0ZXBXaXRoRGVjaW1hbFBsYWNlcygm c3RlcCwgJnN0ZXBEZWNpbWFsUGxhY2VzKTsKIH0KIAogZG91YmxlIFN0ZXBSYW5nZTo6Y2xhbXBW YWx1ZShkb3VibGUgdmFsdWUpCkBAIC01MCw4ICs1NCw5IEBAIGRvdWJsZSBTdGVwUmFuZ2U6OmNs YW1wVmFsdWUoZG91YmxlIHZhbHVlKQogICAgIGRvdWJsZSBjbGFtcGVkVmFsdWUgPSBtYXgobWlu aW11bSwgbWluKHZhbHVlLCBtYXhpbXVtKSk7CiAgICAgaWYgKCFoYXNTdGVwKQogICAgICAgICBy ZXR1cm4gY2xhbXBlZFZhbHVlOworICAgIGRvdWJsZSBzY2FsZSA9IHBvdygxMC4wLCBzdGF0aWNf Y2FzdDxkb3VibGU+KHN0ZDo6bWF4KHN0ZXBEZWNpbWFsUGxhY2VzLCBtaW5pbXVtRGVjaW1hbFBs YWNlcykpKTsKICAgICAvLyBSb3VuZHMgY2xhbXBlZFZhbHVlIHRvIG1pbmltdW0gKyBOICogc3Rl cC4KLSAgICBjbGFtcGVkVmFsdWUgPSBtaW5pbXVtICsgcm91bmQoKGNsYW1wZWRWYWx1ZSAtIG1p bmltdW0pIC8gc3RlcCkgKiBzdGVwOworICAgIGNsYW1wZWRWYWx1ZSA9IHJvdW5kKChtaW5pbXVt ICsgcm91bmQoKGNsYW1wZWRWYWx1ZSAtIG1pbmltdW0pIC8gc3RlcCkgKiBzdGVwKSAqIHNjYWxl KSAvIHNjYWxlOwogICAgIGlmIChjbGFtcGVkVmFsdWUgPiBtYXhpbXVtKQogICAgICAgIGNsYW1w ZWRWYWx1ZSAtPSBzdGVwOwogICAgIEFTU0VSVChjbGFtcGVkVmFsdWUgPj0gbWluaW11bSk7CmRp ZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwvU3RlcFJhbmdlLmggYi9XZWJDb3JlL2h0bWwvU3RlcFJh bmdlLmgKaW5kZXggY2UwNDRlYTQ5NDZhOTFiNDRjZGUwM2UzNzYwYWI2NzRmNTg3NDJmNi4uZmE3 NDU3YjI1MTJmYTkwOTE1ZDI4MTZlODU1Y2Q3YTU3MmQ2YWYyYiAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9odG1sL1N0ZXBSYW5nZS5oCisrKyBiL1dlYkNvcmUvaHRtbC9TdGVwUmFuZ2UuaApAQCAtMzIs OCArMzIsMTEgQEAgY2xhc3MgU3RlcFJhbmdlIDogcHVibGljIE5vbmNvcHlhYmxlIHsKIHB1Ymxp YzoKICAgICBib29sIGhhc1N0ZXA7CiAgICAgZG91YmxlIHN0ZXA7CisgICAgdW5zaWduZWQgc3Rl cERlY2ltYWxQbGFjZXM7CiAgICAgZG91YmxlIG1pbmltdW07CisgICAgdW5zaWduZWQgbWluaW11 bURlY2ltYWxQbGFjZXM7CiAgICAgZG91YmxlIG1heGltdW07IC8vIG1heGltdW0gbXVzdCBiZSA+ PSBtaW5pbXVtLgorICAgIHVuc2lnbmVkIG1heGltdW1EZWNpbWFsUGxhY2VzOwogCiAgICAgZXhw bGljaXQgU3RlcFJhbmdlKGNvbnN0IEhUTUxJbnB1dEVsZW1lbnQqKTsKICAgICBkb3VibGUgY2xh bXBWYWx1ZShkb3VibGUgdmFsdWUpOwo=