50002 2010-11-23 20:52:30 -0800 DRT should not generate pixel output for text/plain tests 2010-11-24 11:46:08 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mihaip mihaip commit-queue levin oldest_to_newest 313119 0 mihaip 2010-11-23 20:52:30 -0800 DRT should not generate pixel output for text/plain tests 313120 1 74721 mihaip 2010-11-23 20:55:25 -0800 Created attachment 74721 Patch 313121 2 74721 levin 2010-11-23 21:02:16 -0800 Comment on attachment 74721 Patch It feels like this change should also delete the pixel results for the one test that will now no longer use them. 313122 3 mihaip 2010-11-23 21:07:09 -0800 (In reply to comment #2) > (From update of attachment 74721 [details]) > It feels like this change should also delete the pixel results for the one test that will now no longer use them. We didn't have any pixel results for http/tests/slow-utf8-text.pl, that's how I noticed this discrepancy in the first place (I'm working on updating the Mac baselines for Snow Leopard, so I've been running all tests through the Mac port's DRT with pixel tests enabled, which the bots don't do). Will wait for the EWS to process this patch before landing it, since I made the Windows and GTK changes blindly locally. 313405 4 commit-queue 2010-11-24 11:18:35 -0800 The commit-queue encountered the following flaky tests while processing attachment 74721: fast/history/history-subframe-with-name.html compositing/iframes/overlapped-nested-iframes.html Please file bugs against the tests. These tests were authored by mihaip@chromium.org and simon.fraser@apple.com. The commit-queue is continuing to process your patch. 313414 5 74721 commit-queue 2010-11-24 11:46:03 -0800 Comment on attachment 74721 Patch Clearing flags on attachment: 74721 Committed r72694: <http://trac.webkit.org/changeset/72694> 313415 6 commit-queue 2010-11-24 11:46:08 -0800 All reviewed patches have been landed. Closing bug. 74721 2010-11-23 20:55:25 -0800 2010-11-24 11:46:03 -0800 Patch bug-50002-20101123205523.patch text/plain 4508 mihaip ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA2YTU2Zjc5M2I4MzE4YWRiZjZiZjFkNmIyN2E5ZGQ3YzAzY2UwMTAzLi42ZGVhNDUz ZDk0Y2QzY2U0MDM3MDhmYmMwY2EyNTI5MmVmZDZjMjdkIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAK KzIwMTAtMTEtMjMgIE1paGFpIFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRFJUIHNob3VsZCBu b3QgZ2VuZXJhdGUgcGl4ZWwgb3V0cHV0IGZvciB0ZXh0L3BsYWluIHRlc3RzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MDAwMgorICAgICAgICAKKyAg ICAgICAgTW9kaWZ5IE1hYywgV2luZG93cyBhbmQgR1RLIERSVCBpbXBsZW1lbnRhdGlvbnMgdG8g ZGlzYWJsZSBwaXhlbCBvdXRwdXQKKyAgICAgICAgd2hlbiBlbmNvdW50ZXJpbmcgYSB0ZXh0L3Bs YWluIHJlc3BvbnNlICh0aGUgQ2hyb21pdW0gb25lIGFscmVhZHkgZG9lcworICAgICAgICB0aGlz LCBhbmQgbm9uZSBvZiB0aGUgb3RoZXIgcG9ydHMgc3BlY2lhbC1jYXNlIHRleHQvcGxhaW4gb3V0 cHV0IGluCisgICAgICAgIHRoZSBmaXJzdCBwbGFjZSkuCisKKyAgICAgICAgKiBEdW1wUmVuZGVy VHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3BwOgorICAgICAgICAoZHVtcCk6CisgICAgICAgICog RHVtcFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlLm1tOgorICAgICAgICAoZHVtcCk6Cisg ICAgICAgICogRHVtcFJlbmRlclRyZWUvd2luL0R1bXBSZW5kZXJUcmVlLmNwcDoKKyAgICAgICAg KGR1bXApOgorCiAyMDEwLTExLTIzICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRvbnkgQ2hhbmcuCmRpZmYgLS1naXQgYS9XZWJLaXRU b29scy9EdW1wUmVuZGVyVHJlZS9ndGsvRHVtcFJlbmRlclRyZWUuY3BwIGIvV2ViS2l0VG9vbHMv RHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcAppbmRleCBiY2I1ZDZiMGRmOWVm OTZjNzlhMTM4OTI5ODQ4ZTFjMjhiMmQ4NGQzLi4wOGU0ODU2YTViZjE1MjExZGM5N2ZhZjQ5NmRj MjhkOGM2ZWIyODcwIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsv RHVtcFJlbmRlclRyZWUuY3BwCisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9E dW1wUmVuZGVyVHJlZS5jcHAKQEAgLTQ5NCwyMCArNDk0LDE2IEBAIHZvaWQgZHVtcCgpCiB7CiAg ICAgaW52YWxpZGF0ZUFueVByZXZpb3VzV2FpdFRvRHVtcFdhdGNoZG9nKCk7CiAKLSAgICBib29s IGR1bXBBc1RleHQgPSBnTGF5b3V0VGVzdENvbnRyb2xsZXItPmR1bXBBc1RleHQoKTsKICAgICBp ZiAoZHVtcFRyZWUpIHsKICAgICAgICAgY2hhciogcmVzdWx0ID0gMDsKICAgICAgICAgZ2NoYXIq IHJlc3BvbnNlTWltZVR5cGUgPSB3ZWJraXRfd2ViX2ZyYW1lX2dldF9yZXNwb25zZV9taW1lX3R5 cGUobWFpbkZyYW1lKTsKIAotICAgICAgICBkdW1wQXNUZXh0ID0gZ19zdHJfZXF1YWwocmVzcG9u c2VNaW1lVHlwZSwgInRleHQvcGxhaW4iKTsKKyAgICAgICAgaWYgKGdfc3RyX2VxdWFsKHJlc3Bv bnNlTWltZVR5cGUsICJ0ZXh0L3BsYWluIikpIHsKKyAgICAgICAgICAgIGdMYXlvdXRUZXN0Q29u dHJvbGxlci0+c2V0RHVtcEFzVGV4dCh0cnVlKTsgICAgICAgIAorICAgICAgICAgICAgZ0xheW91 dFRlc3RDb250cm9sbGVyLT5zZXRHZW5lcmF0ZVBpeGVsUmVzdWx0cyhmYWxzZSk7CisgICAgICAg IH0KICAgICAgICAgZ19mcmVlKHJlc3BvbnNlTWltZVR5cGUpOwogCi0gICAgICAgIC8vIFRlc3Qg Y2FuIHJlcXVlc3QgY29udHJvbGxlciB0byBiZSBkdW1wZWQgYXMgdGV4dCBldmVuCi0gICAgICAg IC8vIHdoaWxlIHRlc3QncyByZXNwb25zZSBtaW1lIHR5cGUgaXMgbm90IHRleHQvcGxhaW4uCi0g ICAgICAgIC8vIE92ZXJyaWRpbmcgdGhpcyBiZWhhdmlvciB3aXRoIGR1bXBBc1RleHQgYmVpbmcg ZmFsc2UgaXMgYSBiYWQgaWRlYS4KLSAgICAgICAgaWYgKGR1bXBBc1RleHQpCi0gICAgICAgICAg ICBnTGF5b3V0VGVzdENvbnRyb2xsZXItPnNldER1bXBBc1RleHQoZHVtcEFzVGV4dCk7Ci0KICAg ICAgICAgaWYgKGdMYXlvdXRUZXN0Q29udHJvbGxlci0+ZHVtcEFzVGV4dCgpKQogICAgICAgICAg ICAgcmVzdWx0ID0gZHVtcEZyYW1lc0FzVGV4dChtYWluRnJhbWUpOwogICAgICAgICBlbHNlIHsK ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9EdW1wUmVuZGVyVHJl ZS5tbSBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9EdW1wUmVuZGVyVHJlZS5tbQpp bmRleCA2OGI0YzJiMWQ0MDVmOTY1OGNmYzMwN2E2MTU5MjdhZjU4NTk5YWQ3Li5jMDhhZWU1ZjFm MDA5MDdkYzAyN2Y2ZmMyYjY3ZjllMzZmZDEyN2Y3IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9E dW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRyZWUubW0KKysrIGIvV2ViS2l0VG9vbHMvRHVt cFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlLm1tCkBAIC05MDcsMTQgKzkwNywxNSBAQCB2 b2lkIGR1bXAoKQogewogICAgIGludmFsaWRhdGVBbnlQcmV2aW91c1dhaXRUb0R1bXBXYXRjaGRv ZygpOwogCi0gICAgYm9vbCBkdW1wQXNUZXh0ID0gZ0xheW91dFRlc3RDb250cm9sbGVyLT5kdW1w QXNUZXh0KCk7CiAgICAgaWYgKGR1bXBUcmVlKSB7CiAgICAgICAgIE5TU3RyaW5nICpyZXN1bHRT dHJpbmcgPSBuaWw7CiAgICAgICAgIE5TRGF0YSAqcmVzdWx0RGF0YSA9IG5pbDsKICAgICAgICAg TlNTdHJpbmcgKnJlc3VsdE1pbWVUeXBlID0gQCJ0ZXh0L3BsYWluIjsKIAotICAgICAgICBkdW1w QXNUZXh0IHw9IFtbW21haW5GcmFtZSBkYXRhU291cmNlXSBfcmVzcG9uc2VNSU1FVHlwZV0gaXNF cXVhbFRvU3RyaW5nOkAidGV4dC9wbGFpbiJdOwotICAgICAgICBnTGF5b3V0VGVzdENvbnRyb2xs ZXItPnNldER1bXBBc1RleHQoZHVtcEFzVGV4dCk7CisgICAgICAgIGlmIChbW1ttYWluRnJhbWUg ZGF0YVNvdXJjZV0gX3Jlc3BvbnNlTUlNRVR5cGVdIGlzRXF1YWxUb1N0cmluZzpAInRleHQvcGxh aW4iXSkgeworICAgICAgICAgICAgZ0xheW91dFRlc3RDb250cm9sbGVyLT5zZXREdW1wQXNUZXh0 KHRydWUpOworICAgICAgICAgICAgZ0xheW91dFRlc3RDb250cm9sbGVyLT5zZXRHZW5lcmF0ZVBp eGVsUmVzdWx0cyhmYWxzZSk7CisgICAgICAgIH0KICAgICAgICAgaWYgKGdMYXlvdXRUZXN0Q29u dHJvbGxlci0+ZHVtcEFzVGV4dCgpKSB7CiAgICAgICAgICAgICByZXN1bHRTdHJpbmcgPSBkdW1w RnJhbWVzQXNUZXh0KG1haW5GcmFtZSk7CiAgICAgICAgIH0gZWxzZSBpZiAoZ0xheW91dFRlc3RD b250cm9sbGVyLT5kdW1wQXNQREYoKSkgewpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvRHVtcFJl bmRlclRyZWUvd2luL0R1bXBSZW5kZXJUcmVlLmNwcCBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJU cmVlL3dpbi9EdW1wUmVuZGVyVHJlZS5jcHAKaW5kZXggM2U2ZTE5MTM3NDZmNTk5MTg2YjRkYWZh OGFjMWQ4NDcyOTNiNTBiOS4uYTgwMjhjNWNiODNjN2JhN2E2NzQyMTY5YWZjYTQ3ZDliMzlmODA2 ZSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvd2luL0R1bXBSZW5kZXJU cmVlLmNwcAorKysgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS93aW4vRHVtcFJlbmRlclRy ZWUuY3BwCkBAIC02NzEsOCArNjcxLDEwIEBAIHZvaWQgZHVtcCgpCiAgICAgICAgIENPTVB0cjxJ V2ViVVJMUmVzcG9uc2U+IHJlc3BvbnNlOwogICAgICAgICBpZiAoU1VDQ0VFREVEKGRhdGFTb3Vy Y2UtPnJlc3BvbnNlKCZyZXNwb25zZSkpICYmIHJlc3BvbnNlKSB7CiAgICAgICAgICAgICBCU1RS IG1pbWVUeXBlOwotICAgICAgICAgICAgaWYgKFNVQ0NFRURFRChyZXNwb25zZS0+TUlNRVR5cGUo Jm1pbWVUeXBlKSkpCi0gICAgICAgICAgICAgICAgOjpnTGF5b3V0VGVzdENvbnRyb2xsZXItPnNl dER1bXBBc1RleHQoOjpnTGF5b3V0VGVzdENvbnRyb2xsZXItPmR1bXBBc1RleHQoKSB8ICFfdGNz Y21wKG1pbWVUeXBlLCBURVhUKCJ0ZXh0L3BsYWluIikpKTsKKyAgICAgICAgICAgIGlmIChTVUND RUVERUQocmVzcG9uc2UtPk1JTUVUeXBlKCZtaW1lVHlwZSkpICYmICFfdGNzY21wKG1pbWVUeXBl LCBURVhUKCJ0ZXh0L3BsYWluIikpKSB7CisgICAgICAgICAgICAgICAgOjpnTGF5b3V0VGVzdENv bnRyb2xsZXItPnNldER1bXBBc1RleHQodHJ1ZSk7CisgICAgICAgICAgICAgICAgOjpnTGF5b3V0 VGVzdENvbnRyb2xsZXItPnNldEdlbmVyYXRlUGl4ZWxSZXN1bHRzKGZhbHNlKTsKKyAgICAgICAg ICAgIH0KICAgICAgICAgICAgIFN5c0ZyZWVTdHJpbmcobWltZVR5cGUpOwogICAgICAgICB9CiAg ICAgfQo=