50000 2010-11-23 18:25:13 -0800 [Qt] Remove redundant JAVASCRIPTCORE_JIT variable 2012-10-09 00:23:00 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 laszlo.gombos webkit-unassigned abecsi benjamin hausmann jturcotte kling ossy rafael.lobo vestbo webkit.review.bot oldest_to_newest 313104 0 laszlo.gombos 2010-11-23 18:25:13 -0800 I find JAVASCRIPTCORE_JIT build option redundant as we have a standard ENABLE_X variable for it which works quite well. I propose to remove it. 313106 1 74715 laszlo.gombos 2010-11-23 18:31:47 -0800 Created attachment 74715 proposed patch 313179 2 kling 2010-11-24 02:07:10 -0800 JAVASCRIPTCORE_JIT is used by the Qt build system, we need to make some changes on that side too if we're removing this. 313218 3 ossy 2010-11-24 04:18:27 -0800 (In reply to comment #2) > JAVASCRIPTCORE_JIT is used by the Qt build system, we need to make some changes on that side too if we're removing this. Good point. We don't want to break building trunk WebKit inside Qt, so we shouldn't land it now. I propose to fix it in Qt and after the new Qt release land this fix. 727922 4 laszlo.gombos 2012-09-25 13:46:00 -0700 There might be an opportunity to fix this in Qt5 if there is an interest. Simon, what do you think ? 728255 5 74715 hausmann 2012-09-26 00:04:25 -0700 Comment on attachment 74715 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=74715&action=review > WebKit.pri:90 > - contains(JAVASCRIPTCORE_JIT,yes): error("'JAVASCRIPTCORE_JIT=yes' not supported with valgrind") > + contains(DEFINES, ENABLE_JIT=1): error("'ENABLE_JIT=1' not supported with valgrind, setting ENABLE_JIT=0") This check is not correct, with --smc-check=all-non-file valgrind appears to work just fine. > common.pri:-4 > -contains(JAVASCRIPTCORE_JIT,yes): DEFINES+=ENABLE_JIT=1 > -contains(JAVASCRIPTCORE_JIT,no): DEFINES+=ENABLE_JIT=0 Yeah, let's get rid of this variable. I believe we've already removed the corresponding "configure option" from qt's configure. 737058 6 167612 laszlo.gombos 2012-10-08 14:33:33 -0700 Created attachment 167612 proposed patch As Simon indicated valgrind might work with JIT enabled. Potentially in valgrind.prf the following line would make more sense -DEFINES += ENABLE_JIT=0 +enable?(jit): DEFINES += ENABLE_JIT=0 I am happy to make that change or perhaps it could be in a follow-up patch. 737477 7 167612 webkit.review.bot 2012-10-09 00:22:56 -0700 Comment on attachment 167612 proposed patch Clearing flags on attachment: 167612 Committed r130728: <http://trac.webkit.org/changeset/130728> 737478 8 webkit.review.bot 2012-10-09 00:23:00 -0700 All reviewed patches have been landed. Closing bug. 74715 2010-11-23 18:31:47 -0800 2012-10-08 14:33:33 -0700 proposed patch 50000.patch text/plain 1483 laszlo.gombos ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA1NTY1MDYzLi42N2MzODQ1 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTAtMTEtMjMgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gUmVt b3ZlIHJlZHVuZGFudCBKQVZBU0NSSVBUQ09SRV9KSVQgdmFyaWFibGUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUwMDAwCisKKyAgICAgICAgVXNlIEVO QUJMRV9KSVQgaW5zdGVhZC4KKworICAgICAgICAqIFdlYktpdC5wcmk6CisgICAgICAgICogY29t bW9uLnByaToKKwogMjAxMC0xMS0xOSAgTWloYWkgUGFycGFyaXRhICA8bWloYWlwQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBBZGQgcmVjZW50IHVwc3RyZWFtIENocm9taXVtIGRlcGVuZGVuY2ll cyB0byAuZ2l0aWdub3JlLgpkaWZmIC0tZ2l0IGEvV2ViS2l0LnByaSBiL1dlYktpdC5wcmkKaW5k ZXggZmUxMzg3Mi4uNTJiYWIxZSAxMDA2NDQKLS0tIGEvV2ViS2l0LnByaQorKysgYi9XZWJLaXQu cHJpCkBAIC04NywxMiArODcsMTEgQEAgc3ltYmlhbiB7CiB9CiAKIHZhbGdyaW5kIHsKLSAgICBj b250YWlucyhKQVZBU0NSSVBUQ09SRV9KSVQseWVzKTogZXJyb3IoIidKQVZBU0NSSVBUQ09SRV9K SVQ9eWVzJyBub3Qgc3VwcG9ydGVkIHdpdGggdmFsZ3JpbmQiKQorICAgIGNvbnRhaW5zKERFRklO RVMsIEVOQUJMRV9KSVQ9MSk6IGVycm9yKCInRU5BQkxFX0pJVD0xJyBub3Qgc3VwcG9ydGVkIHdp dGggdmFsZ3JpbmQsIHNldHRpbmcgRU5BQkxFX0pJVD0wIikKICAgICBRTUFLRV9DWFhGTEFHUyAr PSAtZwogICAgIFFNQUtFX0xGTEFHUyArPSAtZwogICAgIERFRklORVMgKz0gVVNFX1NZU1RFTV9N QUxMT0MKICAgICBERUZJTkVTICs9IEVOQUJMRV9KSVQ9MAotICAgIEpBVkFTQ1JJUFRDT1JFX0pJ VCA9IG5vCiB9CiAKICMjIyMjIERlZmF1bHRzIGZvciBzb21lIG1vYmlsZSBwbGF0Zm9ybXMKZGlm ZiAtLWdpdCBhL2NvbW1vbi5wcmkgYi9jb21tb24ucHJpCmluZGV4IGM5ODQzYmIuLjk0YjU4MGYg MTAwNjQ0Ci0tLSBhL2NvbW1vbi5wcmkKKysrIGIvY29tbW9uLnByaQpAQCAtMSw4ICsxLDUgQEAK ICMgY29tbW9uIHByb2plY3QgaW5jbHVkZSBmaWxlIGZvciBKYXZhU2NyaXB0Q29yZSBhbmQgV2Vi Q29yZQogCi1jb250YWlucyhKQVZBU0NSSVBUQ09SRV9KSVQseWVzKTogREVGSU5FUys9RU5BQkxF X0pJVD0xCi1jb250YWlucyhKQVZBU0NSSVBUQ09SRV9KSVQsbm8pOiBERUZJTkVTKz1FTkFCTEVf SklUPTAKLQogbGludXgtZysrIHsKICFpc0VtcHR5KCQkKFNCT1hfRFBLR19JTlNUX0FSQ0gpKTpl eGlzdHMoL3Vzci9iaW4vbGQuZ29sZCkgewogICAgIG1lc3NhZ2UoVXNpbmcgZ29sZCBsaW5rZXIp Cg== 167612 2012-10-08 14:33:33 -0700 2012-10-09 00:22:56 -0700 proposed patch 50000.patch text/plain 1153 laszlo.gombos SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEzMDY3MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDEyLTEwLTA4ICBMYXN6bG8gR29tYm9zICA8bC5nb21ib3NAc2Ftc3VuZy5j b20+CisKKyAgICAgICAgW1F0XSBSZW1vdmUgcmVkdW5kYW50IEpBVkFTQ1JJUFRDT1JFX0pJVCB2 YXJpYWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NTAwMDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBV c2UgRU5BQkxFX0pJVCBpbnN0ZWFkLgorCisgICAgICAgICogcW1ha2UvbWtzcGVjcy9mZWF0dXJl cy92YWxncmluZC5wcmY6CisKIDIwMTItMTAtMDggIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNh bXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxdW0RSVF0gU3dpdGNoIGRlZmF1bHQgYmFja2luZyBz dG9yZSB0byBzaW5nbGUKSW5kZXg6IFRvb2xzL3FtYWtlL21rc3BlY3MvZmVhdHVyZXMvdmFsZ3Jp bmQucHJmCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL3FtYWtlL21rc3BlY3MvZmVhdHVyZXMvdmFsZ3Jp bmQucHJmCShyZXZpc2lvbiAxMzA2NDQpCisrKyBUb29scy9xbWFrZS9ta3NwZWNzL2ZlYXR1cmVz L3ZhbGdyaW5kLnByZgkod29ya2luZyBjb3B5KQpAQCAtNSw4ICs1LDYgQEAKICMgU2VlICdUb29s cy9xbWFrZS9SRUFETUUnIGZvciBhbiBvdmVydmlldyBvZiB0aGUgYnVpbGQgc3lzdGVtCiAjIC0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0KIAotY29udGFpbnMoSkFWQVNDUklQVENPUkVfSklULHllcyk6IGVycm9yKCInSkFW QVNDUklQVENPUkVfSklUPXllcycgbm90IHN1cHBvcnRlZCB3aXRoIHZhbGdyaW5kIikKLQogUU1B S0VfQ1hYRkxBR1MgKz0gLWcKIFFNQUtFX0xGTEFHUyArPSAtZwogREVGSU5FUyArPSBVU0VfU1lT VEVNX01BTExPQz0xCg==