49975 2010-11-23 07:58:29 -0800 Make build-webkit --minimal build with ENABLE_INSPECTOR=0 2010-11-24 09:07:36 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 49942 49973 1 abecsi abecsi commit-queue ossy oldest_to_newest 312845 0 abecsi 2010-11-23 07:58:29 -0800 ENABLE_INSPECTOR=0 builds are frequently broken. Make it possible for the minimal bot to check the inspector guards. 313312 1 74762 abecsi 2010-11-24 08:33:42 -0800 Created attachment 74762 proposed patch 313313 2 74762 ossy 2010-11-24 08:34:53 -0800 Comment on attachment 74762 proposed patch Great fix, thx. 313315 3 abecsi 2010-11-24 08:36:55 -0800 (In reply to comment #2) > (From update of attachment 74762 [details]) > Great fix, thx. This probably needs a clean build on the minimal bot. 313327 4 74762 commit-queue 2010-11-24 09:07:30 -0800 Comment on attachment 74762 proposed patch Clearing flags on attachment: 74762 Committed r72676: <http://trac.webkit.org/changeset/72676> 313328 5 commit-queue 2010-11-24 09:07:36 -0800 All reviewed patches have been landed. Closing bug. 74762 2010-11-24 08:33:42 -0800 2010-11-24 09:07:30 -0800 proposed patch 0001-Make-build-webkit-minimal-build-with-ENABLE_INSPECTO.patch text/plain 3294 abecsi RnJvbSBiZjczN2M5NmU4NGFlMjJiYTA2ZGUxYjM0NDQyMDJiYTcyYzZlMTI4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbmRyYXMgQmVjc2kgPGFiZWNzaUBpbmYudS1zemVnZWQuaHU+ CkRhdGU6IFdlZCwgMjQgTm92IDIwMTAgMTc6MzI6MTggKzAxMDAKU3ViamVjdDogW1BBVENIXSBN YWtlIGJ1aWxkLXdlYmtpdCAtLW1pbmltYWwgYnVpbGQgd2l0aCBFTkFCTEVfSU5TUEVDVE9SPTAK Ci0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgfCAgIDEyICsrKysrKysrKysr KwogV2ViQ29yZS9mZWF0dXJlcy5wcmkgICAgICAgICAgICAgfCAgICAxICsKIFdlYktpdFRvb2xz L0NoYW5nZUxvZyAgICAgICAgICAgIHwgICAxMCArKysrKysrKysrCiBXZWJLaXRUb29scy9TY3Jp cHRzL2J1aWxkLXdlYmtpdCB8ICAgIDQgKysrKwogNCBmaWxlcyBjaGFuZ2VkLCAyNyBpbnNlcnRp b25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIv V2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmRhMzk3My4uMzlmZTAxNSAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNyBAQAog MjAxMC0xMS0yNCAgQW5kcmFzIEJlY3NpICA8YWJlY3NpQGluZi51LXN6ZWdlZC5odT4KIAorICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIGJ1aWxkLXdl YmtpdCAtLW1pbmltYWwgYnVpbGQgd2l0aCBFTkFCTEVfSU5TUEVDVE9SPTAuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTk3NQorCisgICAgICAgIE5v IG5ldyB0ZXN0cyBuZWVkZWQuCisKKyAgICAgICAgKiBmZWF0dXJlcy5wcmk6IE1ha2UgdGhlIFF0 IGJ1aWxkc3lzdGVtIGF3YXJlCisgICAgICAgIHRoYXQgdGhlIGluc3BlY3RvciBpcyBlbmFibGVk IGJ5IGRlZmF1bHQuCisKKzIwMTAtMTEtMjQgIEFuZHJhcyBCZWNzaSAgPGFiZWNzaUBpbmYudS1z emVnZWQuaHU+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5z ZW4uCiAKICAgICAgICAgTWFrZSBXZWJLaXQyIGNvbXBpbGUgd2l0aCAhRU5BQkxFKElOU1BFQ1RP UikuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2ZlYXR1cmVzLnByaSBiL1dlYkNvcmUvZmVhdHVyZXMu cHJpCmluZGV4IDIwNzZjMDQuLjNlZDFkYTEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvZmVhdHVyZXMu cHJpCisrKyBiL1dlYkNvcmUvZmVhdHVyZXMucHJpCkBAIC03MCw2ICs3MCw3IEBAIGNvbnRhaW5z KERFRklORVMsIEVOQUJMRV9TSU5HTEVfVEhSRUFERUQ9MSkgewogIWNvbnRhaW5zKERFRklORVMs IEVOQUJMRV9OT1RJRklDQVRJT05TPS4pOiBERUZJTkVTICs9IEVOQUJMRV9OT1RJRklDQVRJT05T PTEKICFjb250YWlucyhERUZJTkVTLCBFTkFCTEVfSU1BR0VfUkVTSVpFUj0uKTogREVGSU5FUyAr PSBFTkFCTEVfSU1BR0VfUkVTSVpFUj0wCiAhY29udGFpbnMoREVGSU5FUywgRU5BQkxFX0lOUFVU X1NQRUVDSD0uKTogREVGSU5FUyArPSBFTkFCTEVfSU5QVVRfU1BFRUNIPTAKKyFjb250YWlucyhE RUZJTkVTLCBFTkFCTEVfSU5TUEVDVE9SPS4pOiBERUZJTkVTICs9IEVOQUJMRV9JTlNQRUNUT1I9 MQogIWNvbnRhaW5zKERFRklORVMsIEVOQUJMRV8zRF9SRU5ERVJJTkc9Lik6IERFRklORVMgKz0g RU5BQkxFXzNEX1JFTkRFUklORz0xCiAKICMgU1ZHIHN1cHBvcnQKZGlmZiAtLWdpdCBhL1dlYktp dFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxvZwppbmRleCA2YTU2Zjc5Li44 NzZlMDUzIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9v bHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMTEtMjQgIEFuZHJhcyBCZWNzaSAg PGFiZWNzaUBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTWFrZSBidWlsZC13ZWJraXQgLS1taW5pbWFsIGJ1aWxkIHdpdGgg RU5BQkxFX0lOU1BFQ1RPUj0wCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD00OTk3NQorCisgICAgICAgICogU2NyaXB0cy9idWlsZC13ZWJraXQ6IEFkZCBF TkFCTEVfSU5TUEVDVE9SIGRlZmluZSB0byBmZWF0dXJlcywKKyAgICAgICAgdG8gZW5hYmxlIHRo ZSBzY3JpcHQgdG8gZGVmaW5lIGl0IDAgaW4gY2FzZSBvZiBhIG1pbmltYWwgYnVpbGQuCisKIDIw MTAtMTEtMjMgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgVG9ueSBDaGFuZy4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMv YnVpbGQtd2Via2l0IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKaW5kZXggZDk1 MzRmOC4uODAwZTYxMCAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9idWlsZC13ZWJr aXQKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKQEAgLTEwMCw2ICsxMDAs NyBAQCBteSAoCiAgICAgJHZpZGVvU3VwcG9ydCwKICAgICAkd2Nzc1N1cHBvcnQsCiAgICAgJHdl YkF1ZGlvU3VwcG9ydCwKKyAgICAkd2ViSW5zcGVjdG9yU3VwcG9ydCwKICAgICAkd2ViU29ja2V0 c1N1cHBvcnQsCiAgICAgJHdlYlRpbWluZ1N1cHBvcnQsCiAgICAgJHdtbFN1cHBvcnQsCkBAIC0x NzYsNiArMTc3LDkgQEAgbXkgQGZlYXR1cmVzID0gKAogICAgIHsgb3B0aW9uID0+ICJpbnB1dC1z cGVlY2giLCBkZXNjID0+ICJTcGVlY2ggSW5wdXQgQVBJIHN1cHBvcnQiLAogICAgICAgZGVmaW5l ID0+ICJFTkFCTEVfSU5QVVRfU1BFRUNIIiwgZGVmYXVsdCA9PiAwLCB2YWx1ZSA9PiBcJGlucHV0 U3BlZWNoU3VwcG9ydCB9LAogCisgICAgeyBvcHRpb24gPT4gImluc3BlY3RvciIsIGRlc2MgPT4g IlRvZ2dsZSBXZWIgSW5zcGVjdG9yIHN1cHBvcnQiLAorICAgICAgZGVmaW5lID0+ICJFTkFCTEVf SU5TUEVDVE9SIiwgZGVmYXVsdCA9PiAxLCB2YWx1ZSA9PiBcJHdlYkluc3BlY3RvclN1cHBvcnQg fSwKKwogICAgIHsgb3B0aW9uID0+ICJqYXZhc2NyaXB0LWRlYnVnZ2VyIiwgZGVzYyA9PiAiVG9n Z2xlIEphdmFTY3JpcHQgRGVidWdnZXIvUHJvZmlsZXIgc3VwcG9ydCIsCiAgICAgICBkZWZpbmUg PT4gIkVOQUJMRV9KQVZBU0NSSVBUX0RFQlVHR0VSIiwgZGVmYXVsdCA9PiAxLCB2YWx1ZSA9PiBc JGphdmFTY3JpcHREZWJ1Z2dlclN1cHBvcnQgfSwKIAotLSAKMS43LjMuMgoK