49957 2010-11-22 20:34:40 -0800 [Qt] screenIsMonochrome() is broken 2010-12-15 13:00:37 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 kling rhodovan.u-szeged commit-queue oldest_to_newest 312682 0 kling 2010-11-22 20:34:40 -0800 Our current implementation of screenIsMonochrome() checks if a QWidget's QPaintDevice::numColors() is < 2. This is incorrect, for a monochrome device it will be == 2, since you get the number of possible colors, not the number of bits per color value. Also, QPaintDevice::numColors() has been deprecated by QPaintDevice::colorCount() 322639 1 76655 kling 2010-12-15 09:46:50 -0800 Created attachment 76655 Proposed patch 322730 2 76655 tonikitoo 2010-12-15 12:00:58 -0800 Comment on attachment 76655 Proposed patch numcolor is deprecated ok, but why == instead of <? :) 322769 3 76655 commit-queue 2010-12-15 13:00:32 -0800 Comment on attachment 76655 Proposed patch Clearing flags on attachment: 76655 Committed r74137: <http://trac.webkit.org/changeset/74137> 322770 4 commit-queue 2010-12-15 13:00:37 -0800 All reviewed patches have been landed. Closing bug. 76655 2010-12-15 09:46:50 -0800 2010-12-15 13:00:32 -0800 Proposed patch bug-49957.diff text/plain 1037 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YzBkYjcxNS4uYTUzNTRmOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0xMi0xNSAgQW5kcmVhcyBLbGlu ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gc2NyZWVuSXNNb25vY2hyb21lKCkgaXMgYnJva2Vu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTk1Nwor CisgICAgICAgICogcGxhdGZvcm0vcXQvUGxhdGZvcm1TY3JlZW5RdC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpzY3JlZW5Jc01vbm9jaHJvbWUpOgorCiAyMDEwLTEyLTE0ICBNYXJpbyBTYW5jaGV6 IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBYYW4g TG9wZXouCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL3F0L1BsYXRmb3JtU2NyZWVuUXQu Y3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9xdC9QbGF0Zm9ybVNjcmVlblF0LmNwcAppbmRleCBkYjM0 ZTIxLi40ZGI4YmQxIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL3F0L1BsYXRmb3JtU2Ny ZWVuUXQuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vcXQvUGxhdGZvcm1TY3JlZW5RdC5jcHAK QEAgLTg2LDcgKzg2LDcgQEAgaW50IHNjcmVlbkRlcHRoUGVyQ29tcG9uZW50KFdpZGdldCogdykK IAogYm9vbCBzY3JlZW5Jc01vbm9jaHJvbWUoV2lkZ2V0KiB3KQogewotICAgIHJldHVybiBRQXBw bGljYXRpb246OmRlc2t0b3AoKS0+c2NyZWVuKHNjcmVlbk51bWJlcih3KSktPm51bUNvbG9ycygp IDwgMjsKKyAgICByZXR1cm4gUUFwcGxpY2F0aW9uOjpkZXNrdG9wKCktPnNjcmVlbihzY3JlZW5O dW1iZXIodykpLT5jb2xvckNvdW50KCkgPT0gMjsKIH0KIAogRmxvYXRSZWN0IHNjcmVlblJlY3Qo V2lkZ2V0KiB3KQo=