49942 2010-11-22 15:18:05 -0800 [Qt] Fix compilation with !ENABLE(INSPECTOR) 2010-11-23 07:58:29 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 49975 1 laszlo.gombos webkit-unassigned abecsi benjamin commit-queue hausmann kling ossy oldest_to_newest 312552 0 laszlo.gombos 2010-11-22 15:18:05 -0800 Following r71981 this is a build fix for QtWebKit. Note that there was some work for WebKit2 regarding this configuration (r72091, r72092). 312558 1 74604 laszlo.gombos 2010-11-22 15:24:41 -0800 Created attachment 74604 proposed patch Goal was to minimize the number of guards at this time to help maintenance. This does not address WebKit2 configuration for QtWebKit. 312800 2 commit-queue 2010-11-23 06:06:48 -0800 The commit-queue encountered the following flaky tests while processing attachment 74604: fast/profiler/throw-exception-from-eval.html fast/workers/storage/use-same-database-in-page-and-workers.html Please file bugs against the tests. These tests were authored by dumi@chromium.org, kmccullough@apple.com, oliver@apple.com, and timothy@apple.com. The commit-queue is continuing to process your patch. 312832 3 commit-queue 2010-11-23 07:31:40 -0800 The commit-queue encountered the following flaky tests while processing attachment 74604: http/tests/loading/basic-auth-resend-wrong-credentials.html Please file bugs against the tests. These tests were authored by beidson@apple.com. The commit-queue is continuing to process your patch. 312833 4 74604 commit-queue 2010-11-23 07:33:42 -0800 Comment on attachment 74604 proposed patch Clearing flags on attachment: 74604 Committed r72606: <http://trac.webkit.org/changeset/72606> 312834 5 commit-queue 2010-11-23 07:33:48 -0800 All reviewed patches have been landed. Closing bug. 74604 2010-11-22 15:24:41 -0800 2010-11-23 07:33:42 -0800 proposed patch 49942.patch text/plain 4205 laszlo.gombos SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNzI1NjcpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMTEtMjIgIExhc3psbyBHb21ib3MgIDxsYXN6bG8u MS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFtRdF0gRml4IGNvbXBpbGF0aW9uIHdpdGggIUVOQUJMRShJTlNQRUNUT1Ip CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTk0Mgor CisgICAgICAgIEFkZCBFTkFCTEUoSU5TUEVDVE9SKSB0byB0aGUgUXQgc3BlY2lmaWMgZmlsZXMg Zm9sbG93aW5nIHI3MTk4MS4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0luc3BlY3RvckNs aWVudFF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckNsaWVudFF0OjppbnNwZWN0 b3JEZXN0cm95ZWQpOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yQ2xpZW50UXQ6Om9wZW5J bnNwZWN0b3JGcm9udGVuZCk6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JDbGllbnRRdDo6 c2VuZE1lc3NhZ2VUb0Zyb250ZW5kKToKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9JbnNwZWN0 b3JTZXJ2ZXJRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JTZXJ2ZXJSZXF1ZXN0 SGFuZGxlclF0Ojp3ZWJTb2NrZXRSZWFkeVJlYWQpOgorCiAyMDEwLTExLTIyICBKYW4gRXJpayBI YW5zc2VuICA8amhhbnNzZW5Ac2VuY2hhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5u ZXRoIFJvaGRlIENocmlzdGlhbnNlbi4KSW5kZXg6IFdlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9J bnNwZWN0b3JDbGllbnRRdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L1dlYkNvcmVTdXBw b3J0L0luc3BlY3RvckNsaWVudFF0LmNwcAkocmV2aXNpb24gNzI1MzEpCisrKyBXZWJLaXQvcXQv V2ViQ29yZVN1cHBvcnQvSW5zcGVjdG9yQ2xpZW50UXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x MjUsNiArMTI1LDcgQEAgSW5zcGVjdG9yQ2xpZW50UXQ6Okluc3BlY3RvckNsaWVudFF0KFFXZQog CiB2b2lkIEluc3BlY3RvckNsaWVudFF0OjppbnNwZWN0b3JEZXN0cm95ZWQoKQogeworI2lmIEVO QUJMRShJTlNQRUNUT1IpCiAgICAgaWYgKG1fZnJvbnRlbmRDbGllbnQpCiAgICAgICAgIG1fZnJv bnRlbmRDbGllbnQtPmluc3BlY3RvckNsaWVudERlc3Ryb3llZCgpOwogCkBAIC0xMzMsMTEgKzEz NCwxMyBAQCB2b2lkIEluc3BlY3RvckNsaWVudFF0OjppbnNwZWN0b3JEZXN0cm95CiAgICAgICAg IHdlYkluc3BlY3RvclNlcnZlci0+dW5yZWdpc3RlckNsaWVudCh0aGlzKTsKIAogICAgIGRlbGV0 ZSB0aGlzOworI2VuZGlmCiB9CiAKICAgICAKIHZvaWQgSW5zcGVjdG9yQ2xpZW50UXQ6Om9wZW5J bnNwZWN0b3JGcm9udGVuZChXZWJDb3JlOjpJbnNwZWN0b3JDb250cm9sbGVyKiBpbnNwZWN0b3JD b250cm9sbGVyKQogeworI2lmIEVOQUJMRShJTlNQRUNUT1IpCiAjaWYgVVNFKFY4KQogICAgIGVu c3VyZURlYnVnZ2VyU2NyaXB0TG9hZGVkKCk7CiAjZW5kaWYKQEAgLTE3NCw2ICsxNzcsNyBAQCB2 b2lkIEluc3BlY3RvckNsaWVudFF0OjpvcGVuSW5zcGVjdG9yRnJvCiAgICAgbV9mcm9udGVuZENs aWVudCA9IG5ldyBJbnNwZWN0b3JGcm9udGVuZENsaWVudFF0KG1faW5zcGVjdGVkV2ViUGFnZSwg aW5zcGVjdG9yVmlldywgdGhpcyk7CiAgICAgaW5zcGVjdG9yVmlldy0+cGFnZSgpLT5kLT5wYWdl LT5pbnNwZWN0b3JDb250cm9sbGVyKCktPnNldEluc3BlY3RvckZyb250ZW5kQ2xpZW50KG1fZnJv bnRlbmRDbGllbnQpOwogICAgIG1fZnJvbnRlbmRXZWJQYWdlID0gaW5zcGVjdG9yUGFnZTsKKyNl bmRpZgogfQogCiB2b2lkIEluc3BlY3RvckNsaWVudFF0OjpyZWxlYXNlRnJvbnRlbmRQYWdlKCkK QEAgLTI1NSw2ICsyNTksNyBAQCB2b2lkIEluc3BlY3RvckNsaWVudFF0OjpzdG9yZVNldHRpbmco Y29uCiAKIGJvb2wgSW5zcGVjdG9yQ2xpZW50UXQ6OnNlbmRNZXNzYWdlVG9Gcm9udGVuZChjb25z dCBTdHJpbmcmIG1lc3NhZ2UpCiB7CisjaWYgRU5BQkxFKElOU1BFQ1RPUikKICAgICBpZiAobV9p bnNwZWN0ZWRXZWJQYWdlLT5kLT5pbnNwZWN0b3ItPmQtPnJlbW90ZUZyb250ZW5kKSB7CiAgICAg ICAgIFJlbW90ZUZyb250ZW5kQ2hhbm5lbCogc2Vzc2lvbiA9IHFvYmplY3RfY2FzdDxSZW1vdGVG cm9udGVuZENoYW5uZWwqPihtX2luc3BlY3RlZFdlYlBhZ2UtPmQtPmluc3BlY3Rvci0+ZC0+cmVt b3RlRnJvbnRlbmQpOwogICAgICAgICBpZiAoc2Vzc2lvbikKQEAgLTI2Niw2ICsyNzEsOSBAQCBi b29sIEluc3BlY3RvckNsaWVudFF0OjpzZW5kTWVzc2FnZVRvRnJvCiAKICAgICBQYWdlKiBmcm9u dGVuZFBhZ2UgPSBRV2ViUGFnZVByaXZhdGU6OmNvcmUobV9mcm9udGVuZFdlYlBhZ2UpOwogICAg IHJldHVybiBkb0Rpc3BhdGNoTWVzc2FnZU9uRnJvbnRlbmRQYWdlKGZyb250ZW5kUGFnZSwgbWVz c2FnZSk7CisjZWxzZQorICAgIHJldHVybiBmYWxzZTsKKyNlbmRpZgogfQogCiBzdGF0aWMgU3Ry aW5nIHZhcmlhbnRUb1NldHRpbmcoY29uc3QgUVZhcmlhbnQmIHF2YXJpYW50KQpAQCAtMjkxLDYg KzI5OSw3IEBAIHN0YXRpYyBRVmFyaWFudCBzZXR0aW5nVG9WYXJpYW50KGNvbnN0IFMKICAgICBy ZXR1cm4gcmV0VmFsOwogfQogCisjaWYgRU5BQkxFKElOU1BFQ1RPUikKIEluc3BlY3RvckZyb250 ZW5kQ2xpZW50UXQ6Okluc3BlY3RvckZyb250ZW5kQ2xpZW50UXQoUVdlYlBhZ2UqIGluc3BlY3Rl ZFdlYlBhZ2UsIFBhc3NPd25QdHI8UVdlYlZpZXc+IGluc3BlY3RvclZpZXcsIEluc3BlY3RvckNs aWVudFF0KiBpbnNwZWN0b3JDbGllbnQpCiAgICAgOiBJbnNwZWN0b3JGcm9udGVuZENsaWVudExv Y2FsKGluc3BlY3RlZFdlYlBhZ2UtPmQtPnBhZ2UtPmluc3BlY3RvckNvbnRyb2xsZXIoKSwgaW5z cGVjdG9yVmlldy0+cGFnZSgpLT5kLT5wYWdlKSAKICAgICAsIG1faW5zcGVjdGVkV2ViUGFnZShp bnNwZWN0ZWRXZWJQYWdlKQpAQCAtMzk3LDcgKzQwNiw3IEBAIHZvaWQgSW5zcGVjdG9yRnJvbnRl bmRDbGllbnRRdDo6aW5zcGVjdG8KICAgICBtX2luc3BlY3RvckNsaWVudCA9IDA7CiAgICAgbV9p bnNwZWN0ZWRXZWJQYWdlID0gMDsKIH0KLQorI2VuZGlmCiB9CiAKICNpbmNsdWRlICJJbnNwZWN0 b3JDbGllbnRRdC5tb2MiCkluZGV4OiBXZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvSW5zcGVjdG9y U2VydmVyUXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9JbnNw ZWN0b3JTZXJ2ZXJRdC5jcHAJKHJldmlzaW9uIDcyNTMxKQorKysgV2ViS2l0L3F0L1dlYkNvcmVT dXBwb3J0L0luc3BlY3RvclNlcnZlclF0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzYwLDEwICsz NjAsMTIgQEAgdm9pZCBJbnNwZWN0b3JTZXJ2ZXJSZXF1ZXN0SGFuZGxlclF0Ojp3ZQogCiAgICAg ICAgIFFCeXRlQXJyYXkgcGF5bG9hZCA9IG1fZGF0YS5taWQoMSwgbGVuZ3RoKTsKIAorI2lmIEVO QUJMRShJTlNQRUNUT1IpCiAgICAgICAgIGlmIChtX2luc3BlY3RvckNsaWVudCkgewogICAgICAg ICAgIEluc3BlY3RvckNvbnRyb2xsZXIqIGluc3BlY3RvckNvbnRyb2xsZXIgPSBtX2luc3BlY3Rv ckNsaWVudC0+bV9pbnNwZWN0ZWRXZWJQYWdlLT5kLT5wYWdlLT5pbnNwZWN0b3JDb250cm9sbGVy KCk7CiAgICAgICAgICAgaW5zcGVjdG9yQ29udHJvbGxlci0+aW5zcGVjdG9yQmFja2VuZERpc3Bh dGNoZXIoKS0+ZGlzcGF0Y2goUVN0cmluZzo6ZnJvbVV0ZjgocGF5bG9hZCkpOwogICAgICAgICB9 CisjZW5kaWYKIAogICAgICAgICAvLyBSZW1vdmUgdGhpcyBXZWJTb2NrZXQgbWVzc2FnZSBmcm9t IG1fZGF0YSAocGF5bG9hZCwgc3RhcnQtb2YtZnJhbWUgYnl0ZSwgZW5kLW9mLWZyYW1lIGJ5dGUp LgogICAgICAgICBtX2RhdGEgPSBtX2RhdGEubWlkKGxlbmd0aCArIDIpOwo=