49937 2010-11-22 13:46:20 -0800 [chromium] we should not create an external popup menu for empty selects 2010-11-22 22:47:13 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 jcivelli webkit-unassigned commit-queue fishd levin oldest_to_newest 312492 0 jcivelli 2010-11-22 13:46:20 -0800 When clicking a select with no items, we should not create an external popup as there is nothing to show and it ends up causing a crasher in Chromium. 312497 1 74593 jcivelli 2010-11-22 13:51:38 -0800 Created attachment 74593 Patch 312504 2 levin 2010-11-22 14:00:08 -0800 For any onlookers, the test is here: http://codereview.chromium.org/5275001/ 312709 3 74593 commit-queue 2010-11-22 22:47:07 -0800 Comment on attachment 74593 Patch Clearing flags on attachment: 74593 Committed r72586: <http://trac.webkit.org/changeset/72586> 312710 4 commit-queue 2010-11-22 22:47:13 -0800 All reviewed patches have been landed. Closing bug. 74593 2010-11-22 13:51:38 -0800 2010-11-22 22:47:07 -0800 Patch bug-49937-20101122135137.patch text/plain 1305 jcivelli ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDI5ZDE5OWM5Y2RkM2ViZDExOTQwNWQxMTYyMmMzYTM0ZGFiNTc1MjIu LjYyNmU2NDQxZjZhYWUyN2EwMWFiMzk0YWQ0NDA2MDg4NTRhNzUyNDggMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDEzIEBACisyMDEwLTExLTIyICBKYXkgQ2l2ZWxsaSAgPGpjaXZlbGxpQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBEb24ndCBjcmVhdGUgYW4gZXh0ZXJuYWwgcG9wdXAgbWVudSB3aGVuIHRoZXJlIGFyZSBubyBp dGVtcyB0byBzaG93LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NDk5MzcKKworICAgICAgICAqIHNyYy9FeHRlcm5hbFBvcHVwTWVudS5jcHA6CisgICAg ICAgIChXZWJLaXQ6OkV4dGVybmFsUG9wdXBNZW51OjpzaG93KToKKwogMjAxMC0xMS0yMiAgUGF2 ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBOb3QgcmV2aWV3 ZWQuIFBhcnRpYWxseSByb2xsIG91dCByNzIyODIuCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21p dW0vc3JjL0V4dGVybmFsUG9wdXBNZW51LmNwcCBiL1dlYktpdC9jaHJvbWl1bS9zcmMvRXh0ZXJu YWxQb3B1cE1lbnUuY3BwCmluZGV4IDBmMjA4ZmIwZjg4NTRiNTIwY2VjZGE5MDM2MzA1ZDRmNTAy OTI1MDcuLmY3Zjk4NjI0NDc1Njg0YjkyODk3ZTgyZTc1MzdhNDZmZjJhMGE4NTYgMTAwNjQ0Ci0t LSBhL1dlYktpdC9jaHJvbWl1bS9zcmMvRXh0ZXJuYWxQb3B1cE1lbnUuY3BwCisrKyBiL1dlYktp dC9jaHJvbWl1bS9zcmMvRXh0ZXJuYWxQb3B1cE1lbnUuY3BwCkBAIC02NSw2ICs2NSw4IEBAIHZv aWQgRXh0ZXJuYWxQb3B1cE1lbnU6OnNob3coY29uc3QgSW50UmVjdCYgcmVjdCwgRnJhbWVWaWV3 KiB2LCBpbnQgaW5kZXgpCiAKICAgICBXZWJQb3B1cE1lbnVJbmZvIGluZm87CiAgICAgZ2V0UG9w dXBNZW51SW5mbygmaW5mbyk7CisgICAgaWYgKGluZm8uaXRlbXMuaXNFbXB0eSgpKQorICAgICAg ICByZXR1cm47CiAgICAgbV93ZWJFeHRlcm5hbFBvcHVwTWVudSA9CiAgICAgICAgIG1fd2ViVmll d0NsaWVudC0+Y3JlYXRlRXh0ZXJuYWxQb3B1cE1lbnUoaW5mbywgdGhpcyk7CiAgICAgbV93ZWJF eHRlcm5hbFBvcHVwTWVudS0+c2hvdyh2LT5jb250ZW50c1RvV2luZG93KHJlY3QpKTsK