<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>49927</bug_id>
          
          <creation_ts>2010-11-22 11:12:40 -0800</creation_ts>
          <short_desc>[GTK] Windowless plugins gets broken key input event (at least in Flash)</short_desc>
          <delta_ts>2010-11-24 20:31:40 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc>http://people.collabora.co.uk/~nicolas/public/flash/window-less-editor.html</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Nicolas Dufresne">nicolas</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>commit-queue</cc>
    
    <cc>eric</cc>
    
    <cc>mrobinson</cc>
    
    <cc>webkit.review.bot</cc>
    
    <cc>xan.lopez</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>312419</commentid>
    <comment_count>0</comment_count>
    <who name="Nicolas Dufresne">nicolas</who>
    <bug_when>2010-11-22 11:12:40 -0800</bug_when>
    <thetext>Visiting this test site:

http://people.collabora.co.uk/~nicolas/public/flash/window-less-editor.html

with any WebKitGTK based browers shows that key event are not correctly sent to the plugin. As an example typing J result in / being received.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>312564</commentid>
    <comment_count>1</comment_count>
      <attachid>74606</attachid>
    <who name="Nicolas Dufresne">nicolas</who>
    <bug_when>2010-11-22 15:35:39 -0800</bug_when>
    <thetext>Created attachment 74606
Windowless plugins gets broken key input

When converting the GdkEvent to XEvent we need to send the
hardware_keycode as XEvent::keycode. Instead we where sending
the GdkEvent::keyval.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>312883</commentid>
    <comment_count>2</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2010-11-23 09:04:35 -0800</bug_when>
    <thetext>In TestNetscapePlugin there are some pretty glaring NOTIMPLEMENTED lines for keyDown and keyUp events for X11 plugins. Perhaps implementing these and providing a test (or updating results) might prevent bugs like this in the future. Do you mind checking whether or not it&apos;s feasible to do that in this patch?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>313047</commentid>
    <comment_count>3</comment_count>
    <who name="Xan Lopez">xan.lopez</who>
    <bug_when>2010-11-23 15:38:16 -0800</bug_when>
    <thetext>(In reply to comment #1)
&gt; Created an attachment (id=74606) [details]
&gt; Windowless plugins gets broken key input
&gt; 
&gt; When converting the GdkEvent to XEvent we need to send the
&gt; hardware_keycode as XEvent::keycode. Instead we where sending
&gt; the GdkEvent::keyval.

I think we might be missing something, because the original code was also sending bogus values and when we changed it to the current one we started to get correct results in the layout tests. At the very least we should have an explanation of why this is the right thing to do and a test for it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>313048</commentid>
    <comment_count>4</comment_count>
      <attachid>74606</attachid>
    <who name="Xan Lopez">xan.lopez</who>
    <bug_when>2010-11-23 15:39:20 -0800</bug_when>
    <thetext>Comment on attachment 74606
Windowless plugins gets broken key input

r- for lack of test.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>313057</commentid>
    <comment_count>5</comment_count>
    <who name="Nicolas Dufresne">nicolas</who>
    <bug_when>2010-11-23 15:59:51 -0800</bug_when>
    <thetext>(In reply to comment #2)
&gt; In TestNetscapePlugin there are some pretty glaring NOTIMPLEMENTED lines for keyDown and keyUp events for X11 plugins. Perhaps implementing these and providing a test (or updating results) might prevent bugs like this in the future. Do you mind checking whether or not it&apos;s feasible to do that in this patch?

Yeah, I&apos;m working on this now. Just for testing, I&apos;ve hardcoded the keycode to 0 and all the test passed because of the NOTIMPLEMENTED mark. It&apos;s very easy to implement correctly, but then I discovered that there is other bug in the test code (seems to be in the EventSender.cpp).

Obviously this has been changed multiple time without ever being tested ;)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>313061</commentid>
    <comment_count>6</comment_count>
    <who name="Nicolas Dufresne">nicolas</who>
    <bug_when>2010-11-23 16:09:23 -0800</bug_when>
    <thetext>(In reply to comment #3)
&gt; I think we might be missing something, because the original code was also sending bogus values and when we changed it to the current one we started to get correct results in the layout tests. At the very least we should have an explanation of why this is the right thing to do and a test for it.

As said, any change to this line have zero effect on the LayoutTests, you might be confusing with the effect of the other changes found in http://trac.webkit.org/changeset/66827.

But one thing is sure, you can&apos;t put a keysym into the keycode field of XEvent.
And if you look at the GTK code you&apos;ll see that hardware_keycode is the original XEvent::keycode.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>313066</commentid>
    <comment_count>7</comment_count>
    <who name="Xan Lopez">xan.lopez</who>
    <bug_when>2010-11-23 16:14:59 -0800</bug_when>
    <thetext>(In reply to comment #6)
&gt; As said, any change to this line have zero effect on the LayoutTests, you might be confusing with the effect of the other changes found in http://trac.webkit.org/changeset/66827.
&gt; 
&gt; But one thing is sure, you can&apos;t put a keysym into the keycode field of XEvent.
&gt; And if you look at the GTK code you&apos;ll see that hardware_keycode is the original XEvent::keycode.

plugins/keyboard-events.html fails here with your patch in exactly the same way that used to fail before 66827.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>313075</commentid>
    <comment_count>8</comment_count>
    <who name="Xan Lopez">xan.lopez</who>
    <bug_when>2010-11-23 16:24:13 -0800</bug_when>
    <thetext>(In reply to comment #7)
&gt; (In reply to comment #6)
&gt; &gt; As said, any change to this line have zero effect on the LayoutTests, you might be confusing with the effect of the other changes found in http://trac.webkit.org/changeset/66827.
&gt; &gt; 
&gt; &gt; But one thing is sure, you can&apos;t put a keysym into the keycode field of XEvent.
&gt; &gt; And if you look at the GTK code you&apos;ll see that hardware_keycode is the original XEvent::keycode.
&gt; 
&gt; plugins/keyboard-events.html fails here with your patch in exactly the same way that used to fail before 66827.

If you are not seeing this I guess it might somehow be system specific (perhaps differences in layouts?), but for sure that&apos;s the only part of the patch that could make any difference wrt this. If hardware_keycode is the actual hardware key pressed and the keyval already shows at least a translation layer depending on the layout it would make sense there are differences between machines, but then IMHO the test should be ideally changed to take this into account.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>313089</commentid>
    <comment_count>9</comment_count>
    <who name="Nicolas Dufresne">nicolas</who>
    <bug_when>2010-11-23 17:20:41 -0800</bug_when>
    <thetext>I don&apos;t know what&apos;s wrong with my build, but now I get the same test failure has Xan (while I&apos;m pretty sure it&apos;s a false negative). Here&apos;s the explanation:

The event-&gt;keyval is exactly like the X11 keysym. One important thing to know about those keysym is that they match the ASCII code of basic keys like a, b and c.

Currently we where sending the plugin an XEvent with keycode set to the keysym. Then, in the test plugin, we where printing the XEvent keycode just like if it was a char. As the keysym value is the character we wanted to print, the test pass (false positive).

Will upload a new patch soon ...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>313093</commentid>
    <comment_count>10</comment_count>
      <attachid>74710</attachid>
    <who name="Nicolas Dufresne">nicolas</who>
    <bug_when>2010-11-23 17:34:53 -0800</bug_when>
    <thetext>Created attachment 74710
Also Fix test plugin

This version of the patch also fix the test plugin not to assume that a keycode is a valid ASCII code. This should get the test to work again.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>313207</commentid>
    <comment_count>11</comment_count>
    <who name="Xan Lopez">xan.lopez</who>
    <bug_when>2010-11-24 04:04:34 -0800</bug_when>
    <thetext>(In reply to comment #10)
&gt; Created an attachment (id=74710) [details]
&gt; Also Fix test plugin
&gt; 
&gt; This version of the patch also fix the test plugin not to assume that a keycode is a valid ASCII code. This should get the test to work again.

This seems sensible, but why was it working in the other ports?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>313279</commentid>
    <comment_count>12</comment_count>
      <attachid>74710</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2010-11-24 07:09:48 -0800</bug_when>
    <thetext>Comment on attachment 74710
Also Fix test plugin

View in context: https://bugs.webkit.org/attachment.cgi?id=74710&amp;action=review

Just a couple nits.

&gt; WebKitTools/DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:266
&gt; +keycode_to_char(XKeyEvent *event)

I think this should be called keyEventToChar since it actually takes an XKeyEvent and not a keycode. Also, new code should follow WebKit style (event though the rest of the file doesn&apos;t).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>313307</commentid>
    <comment_count>13</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2010-11-24 08:11:39 -0800</bug_when>
    <thetext>Nicolas, can you build a Qt build to verify that this test doesn&apos;t fail with your change?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>313504</commentid>
    <comment_count>14</comment_count>
    <who name="Nicolas Dufresne">nicolas</who>
    <bug_when>2010-11-24 15:50:38 -0800</bug_when>
    <thetext>(In reply to comment #13)
&gt; Nicolas, can you build a Qt build to verify that this test doesn&apos;t fail with your change?

Run the test and it indeed break Qt test. After investigation, they have code that runs only in the DRT that bogusly fix the test. I mention that to Andreas Kling and he told me not to care about it, that we should push the changes, he will fix it afterward.

I&apos;ll send a new patch fixing the naming error you found soon.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>313563</commentid>
    <comment_count>15</comment_count>
      <attachid>74820</attachid>
    <who name="Nicolas Dufresne">nicolas</who>
    <bug_when>2010-11-24 17:52:00 -0800</bug_when>
    <thetext>Created attachment 74820
Fixed function naming

Same patch with the naming fix mentions before.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>313569</commentid>
    <comment_count>16</comment_count>
      <attachid>74820</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2010-11-24 18:02:41 -0800</bug_when>
    <thetext>Comment on attachment 74820
Fixed function naming

View in context: https://bugs.webkit.org/attachment.cgi?id=74820&amp;action=review

Looks really good, though there are still a couple small style issues. Sorry that I was not explicit about them before.

&gt; WebKitTools/DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:266
&gt; +static char
&gt; +keyEventToChar(XKeyEvent *event)

This should be one line and the asterisk should be next to the type name here.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>313575</commentid>
    <comment_count>17</comment_count>
      <attachid>74824</attachid>
    <who name="Nicolas Dufresne">nicolas</who>
    <bug_when>2010-11-24 18:12:20 -0800</bug_when>
    <thetext>Created attachment 74824
Fix function implementation style

I must say, it&apos;s very hard to notice those errors when all the surrounding code is consistently doing differently ;) Hopefully this is the one.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>313576</commentid>
    <comment_count>18</comment_count>
      <attachid>74824</attachid>
    <who name="Nicolas Dufresne">nicolas</who>
    <bug_when>2010-11-24 18:13:00 -0800</bug_when>
    <thetext>Comment on attachment 74824
Fix function implementation style

Manipulation error, sorry</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>313577</commentid>
    <comment_count>19</comment_count>
      <attachid>74825</attachid>
    <who name="Nicolas Dufresne">nicolas</who>
    <bug_when>2010-11-24 18:14:02 -0800</bug_when>
    <thetext>Created attachment 74825
Fix remaining style issues

Hopefully this is the last one.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>313581</commentid>
    <comment_count>20</comment_count>
      <attachid>74825</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2010-11-24 18:19:37 -0800</bug_when>
    <thetext>Comment on attachment 74825
Fix remaining style issues

Great! Thanks.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>313591</commentid>
    <comment_count>21</comment_count>
      <attachid>74825</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-11-24 19:18:40 -0800</bug_when>
    <thetext>Comment on attachment 74825
Fix remaining style issues

Clearing flags on attachment: 74825

Committed r72717: &lt;http://trac.webkit.org/changeset/72717&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>313592</commentid>
    <comment_count>22</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-11-24 19:18:46 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>313594</commentid>
    <comment_count>23</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2010-11-24 19:47:40 -0800</bug_when>
    <thetext>http://trac.webkit.org/changeset/72717 might have broken Qt Linux Release
The following tests are not passing:
plugins/keyboard-events.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>313597</commentid>
    <comment_count>24</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2010-11-24 20:31:40 -0800</bug_when>
    <thetext>As we expected this is failing on Qt. I will skip the test and open a bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>74606</attachid>
            <date>2010-11-22 15:35:39 -0800</date>
            <delta_ts>2010-11-23 17:35:17 -0800</delta_ts>
            <desc>Windowless plugins gets broken key input</desc>
            <filename>0001-GTK-Windowless-plugins-gets-broken-key-input.patch</filename>
            <type>text/plain</type>
            <size>2108</size>
            <attacher name="Nicolas Dufresne">nicolas</attacher>
            
              <data encoding="base64">RnJvbSBlMjRmMWQ2NDg2NzcxZDc2YzJjMjdmMjk0ZTlmODQ3NmJkOWQ4ZTkxIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBOaWNvbGFzIER1ZnJlc25lIDxuaWNvbGFzLmR1ZnJlc25lQGNv
bGxhYm9yYS5jby51az4KRGF0ZTogTW9uLCAyMiBOb3YgMjAxMCAxNToyODo1MSAtMDgwMApTdWJq
ZWN0OiBbUEFUQ0hdIFtHVEtdIFdpbmRvd2xlc3MgcGx1Z2lucyBnZXRzIGJyb2tlbiBrZXkgaW5w
dXQKCmh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTkyNwoKV2hlbiBj
b252ZXJ0aW5nIHRoZSBHZGtFdmVudCB0byBYRXZlbnQgd2UgbmVlZCB0byBzZW5kIHRoZQpoYXJk
d2FyZV9rZXljb2RlIGFzIFhFdmVudDo6a2V5Y29kZS4gSW5zdGVhZCB3ZSB3aGVyZSBzZW5kaW5n
CnRoZSBHZGtFdmVudDo6a2V5dmFsLgoKKiBwbHVnaW5zL2d0ay9QbHVnaW5WaWV3R3RrLmNwcDoK
KFdlYkNvcmU6OlBsdWdpblZpZXc6OmhhbmRsZUtleWJvYXJkRXZlbnQpOgotLS0KIFdlYkNvcmUv
Q2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgfCAgIDE0ICsrKysrKysrKysrKysrCiBXZWJD
b3JlL3BsdWdpbnMvZ3RrL1BsdWdpblZpZXdHdGsuY3BwIHwgICAgMiArLQogMiBmaWxlcyBjaGFu
Z2VkLCAxNSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNv
cmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDllNjZiYy4uN2UyMDYyNSAx
MDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAg
LTEsMyArMSwxNyBAQAorMjAxMC0xMS0yMiAgTmljb2xhcyBEdWZyZXNuZSAgPG5pY29sYXMuZHVm
cmVzbmVAY29sbGFib3JhLmNvLnVrPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q
UyEpLgorCisgICAgICAgIFtHVEtdIFdpbmRvd2xlc3MgcGx1Z2lucyBnZXRzIGJyb2tlbiBrZXkg
aW5wdXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ5
OTI3CisKKyAgICAgICAgV2hlbiBjb252ZXJ0aW5nIHRoZSBHZGtFdmVudCB0byBYRXZlbnQgd2Ug
bmVlZCB0byBzZW5kIHRoZQorICAgICAgICBoYXJkd2FyZV9rZXljb2RlIGFzIFhFdmVudDo6a2V5
Y29kZS4gSW5zdGVhZCB3ZSB3aGVyZSBzZW5kaW5nCisgICAgICAgIHRoZSBHZGtFdmVudDo6a2V5
dmFsLgorCisgICAgICAgICogcGx1Z2lucy9ndGsvUGx1Z2luVmlld0d0ay5jcHA6CisgICAgICAg
IChXZWJDb3JlOjpQbHVnaW5WaWV3OjpoYW5kbGVLZXlib2FyZEV2ZW50KToKKwogMjAxMC0xMS0x
NSAgQmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg
RGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsdWdpbnMvZ3RrL1BsdWdpblZpZXdH
dGsuY3BwIGIvV2ViQ29yZS9wbHVnaW5zL2d0ay9QbHVnaW5WaWV3R3RrLmNwcAppbmRleCA2NjA4
ZjZjLi4zNWY4ZWUyIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsdWdpbnMvZ3RrL1BsdWdpblZpZXdH
dGsuY3BwCisrKyBiL1dlYkNvcmUvcGx1Z2lucy9ndGsvUGx1Z2luVmlld0d0ay5jcHAKQEAgLTI4
Miw3ICsyODIsNyBAQCB2b2lkIFBsdWdpblZpZXc6OmhhbmRsZUtleWJvYXJkRXZlbnQoS2V5Ym9h
cmRFdmVudCogZXZlbnQpCiAgICAgeEV2ZW50LnhrZXkuc3Vid2luZG93ID0gMDsgLy8gd2UgaGF2
ZSBubyBjaGlsZCB3aW5kb3cKICAgICB4RXZlbnQueGtleS50aW1lID0gZXZlbnQtPnRpbWVTdGFt
cCgpOwogICAgIHhFdmVudC54a2V5LnN0YXRlID0gZ2RrRXZlbnQtPnN0YXRlOyAvLyBHZGtNb2Rp
ZmllclR5cGUgbWlycm9ycyB4bGliIHN0YXRlIG1hc2tzCi0gICAgeEV2ZW50LnhrZXkua2V5Y29k
ZSA9IGdka0V2ZW50LT5rZXl2YWw7CisgICAgeEV2ZW50LnhrZXkua2V5Y29kZSA9IGdka0V2ZW50
LT5oYXJkd2FyZV9rZXljb2RlOwogICAgIHhFdmVudC54a2V5LnNhbWVfc2NyZWVuID0gdHJ1ZTsK
IAogICAgIC8vIE5PVEU6IEFzIHRoZSBYRXZlbnRzIHNlbnQgdG8gdGhlIHBsdWctaW4gYXJlIHN5
bnRoZXNpemVkIGFuZCB0aGVyZSBpcyBub3QgYSBuYXRpdmUgd2luZG93Ci0tIAoxLjcuMy4yCgo=
</data>
<flag name="review"
          id="65251"
          type_id="1"
          status="-"
          setter="xan.lopez"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>74710</attachid>
            <date>2010-11-23 17:34:53 -0800</date>
            <delta_ts>2010-11-24 17:52:00 -0800</delta_ts>
            <desc>Also Fix test plugin</desc>
            <filename>0001-GTK-Windowless-plugins-gets-broken-key-input.patch</filename>
            <type>text/plain</type>
            <size>5019</size>
            <attacher name="Nicolas Dufresne">nicolas</attacher>
            
              <data encoding="base64">RnJvbSA5MDU3MjZlNGJiMzdjOTQ1YmFlNDY5YWZlOWQ2OWNkNTFiZDA5ODFkIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBOaWNvbGFzIER1ZnJlc25lIDxuaWNvbGFzLmR1ZnJlc25lQGNv
bGxhYm9yYS5jby51az4KRGF0ZTogTW9uLCAyMiBOb3YgMjAxMCAxNToyODo1MSAtMDgwMApTdWJq
ZWN0OiBbUEFUQ0hdIFtHVEtdIFdpbmRvd2xlc3MgcGx1Z2lucyBnZXRzIGJyb2tlbiBrZXkgaW5w
dXQKCmh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTkyNwoKV2hlbiBj
b252ZXJ0aW5nIHRoZSBHZGtFdmVudCB0byBYRXZlbnQgd2UgbmVlZCB0byBzZW5kIHRoZQpoYXJk
d2FyZV9rZXljb2RlIGFzIFhFdmVudDo6a2V5Y29kZS4gSW5zdGVhZCB3ZSB3aGVyZSBzZW5kaW5n
CnRoZSBHZGtFdmVudDo6a2V5dmFsLiBUaGlzIGlzIGFscmVhZHkgdGVzdGVkIGJ5CnBsdWdpbnMv
a2V5Ym9hcmQtZXZlbnRzLmh0bWwsIGJ1dCBhIGJ1ZyBpbiB0aGUgdGVzdCBwbHVnaW4gd2FzCnJl
c3VsdGluZyBpbiBmYWxzZSBwb3NpdGl2ZS4KCiogcGx1Z2lucy9ndGsvUGx1Z2luVmlld0d0ay5j
cHA6CihXZWJDb3JlOjpQbHVnaW5WaWV3OjpoYW5kbGVLZXlib2FyZEV2ZW50KToKCkNvbnZlcnQg
dGhlIFhFdmVudDo6a2V5Y29kZSB0byBBU0NJSSBiZWZvcmUgcHJpbnRpbmcgaXQuIE5vdApkb2lu
ZyB0aGlzIHdhcyBjYXVzaW5nIGZhbHNlIHBvc2l0aXZlIGluCnBsdWdpbnMva2V5Ym9hcmQtZXZl
bnRzLmh0bWwuCgoqIER1bXBSZW5kZXJUcmVlL3VuaXgvVGVzdE5ldHNjYXBlUGx1Z2luL1Rlc3RO
ZXRzY2FwZVBsdWdpbi5jcHA6CihrZXljb2RlX3RvX2NoYXIpOgogICh3ZWJraXRfdGVzdF9wbHVn
aW5faGFuZGxlX2V2ZW50KToKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICB8ICAgMTYgKysrKysrKysrKysrKysrKwogV2ViQ29yZS9wbHVnaW5z
L2d0ay9QbHVnaW5WaWV3R3RrLmNwcCAgICAgICAgICAgICAgfCAgICAyICstCiBXZWJLaXRUb29s
cy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTUgKysrKysrKysr
KysrKysrCiAuLi4vdW5peC9UZXN0TmV0c2NhcGVQbHVnaW4vVGVzdE5ldHNjYXBlUGx1Z2luLmNw
cCB8ICAgMTMgKysrKysrKysrKystLQogNCBmaWxlcyBjaGFuZ2VkLCA0MyBpbnNlcnRpb25zKCsp
LCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29y
ZS9DaGFuZ2VMb2cKaW5kZXggMDllNjZiYy4uMTgwZWU5YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9D
aGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0x
MS0yMiAgTmljb2xhcyBEdWZyZXNuZSAgPG5pY29sYXMuZHVmcmVzbmVAY29sbGFib3JhLmNvLnVr
PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtd
IFdpbmRvd2xlc3MgcGx1Z2lucyBnZXRzIGJyb2tlbiBrZXkgaW5wdXQKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ5OTI3CisKKyAgICAgICAgV2hlbiBj
b252ZXJ0aW5nIHRoZSBHZGtFdmVudCB0byBYRXZlbnQgd2UgbmVlZCB0byBzZW5kIHRoZQorICAg
ICAgICBoYXJkd2FyZV9rZXljb2RlIGFzIFhFdmVudDo6a2V5Y29kZS4gSW5zdGVhZCB3ZSB3aGVy
ZSBzZW5kaW5nCisgICAgICAgIHRoZSBHZGtFdmVudDo6a2V5dmFsLiBUaGlzIGlzIGFscmVhZHkg
dGVzdGVkIGJ5CisgICAgICAgIHBsdWdpbnMva2V5Ym9hcmQtZXZlbnRzLmh0bWwsIGJ1dCBhIGJ1
ZyBpbiB0aGUgdGVzdCBwbHVnaW4gd2FzCisgICAgICAgIHJlc3VsdGluZyBpbiBmYWxzZSBwb3Np
dGl2ZS4KKworICAgICAgICAqIHBsdWdpbnMvZ3RrL1BsdWdpblZpZXdHdGsuY3BwOgorICAgICAg
ICAoV2ViQ29yZTo6UGx1Z2luVmlldzo6aGFuZGxlS2V5Ym9hcmRFdmVudCk6CisKIDIwMTAtMTEt
MTUgIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5
IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbHVnaW5zL2d0ay9QbHVnaW5WaWV3
R3RrLmNwcCBiL1dlYkNvcmUvcGx1Z2lucy9ndGsvUGx1Z2luVmlld0d0ay5jcHAKaW5kZXggNjYw
OGY2Yy4uMzVmOGVlMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbHVnaW5zL2d0ay9QbHVnaW5WaWV3
R3RrLmNwcAorKysgYi9XZWJDb3JlL3BsdWdpbnMvZ3RrL1BsdWdpblZpZXdHdGsuY3BwCkBAIC0y
ODIsNyArMjgyLDcgQEAgdm9pZCBQbHVnaW5WaWV3OjpoYW5kbGVLZXlib2FyZEV2ZW50KEtleWJv
YXJkRXZlbnQqIGV2ZW50KQogICAgIHhFdmVudC54a2V5LnN1YndpbmRvdyA9IDA7IC8vIHdlIGhh
dmUgbm8gY2hpbGQgd2luZG93CiAgICAgeEV2ZW50LnhrZXkudGltZSA9IGV2ZW50LT50aW1lU3Rh
bXAoKTsKICAgICB4RXZlbnQueGtleS5zdGF0ZSA9IGdka0V2ZW50LT5zdGF0ZTsgLy8gR2RrTW9k
aWZpZXJUeXBlIG1pcnJvcnMgeGxpYiBzdGF0ZSBtYXNrcwotICAgIHhFdmVudC54a2V5LmtleWNv
ZGUgPSBnZGtFdmVudC0+a2V5dmFsOworICAgIHhFdmVudC54a2V5LmtleWNvZGUgPSBnZGtFdmVu
dC0+aGFyZHdhcmVfa2V5Y29kZTsKICAgICB4RXZlbnQueGtleS5zYW1lX3NjcmVlbiA9IHRydWU7
CiAKICAgICAvLyBOT1RFOiBBcyB0aGUgWEV2ZW50cyBzZW50IHRvIHRoZSBwbHVnLWluIGFyZSBz
eW50aGVzaXplZCBhbmQgdGhlcmUgaXMgbm90IGEgbmF0aXZlIHdpbmRvdwpkaWZmIC0tZ2l0IGEv
V2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmluZGV4IGQzMTY3
MTcuLjMzOGJkMjMgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZworKysgYi9XZWJL
aXRUb29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0xMS0yMyAgTmljb2xhcyBE
dWZyZXNuZSAgPG5pY29sYXMuZHVmcmVzbmVAY29sbGFib3JhLmNvLnVrPgorCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIFdpbmRvd2xlc3MgcGx1
Z2lucyBnZXRzIGJyb2tlbiBrZXkgaW5wdXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTQ5OTI3CisKKyAgICAgICAgQ29udmVydCB0aGUgWEV2ZW50Ojpr
ZXljb2RlIHRvIEFTQ0lJIGJlZm9yZSBwcmludGluZyBpdC4gTm90CisgICAgICAgIGRvaW5nIHRo
aXMgd2FzIGNhdXNpbmcgZmFsc2UgcG9zaXRpdmUgaW4gCisgICAgICAgIHBsdWdpbnMva2V5Ym9h
cmQtZXZlbnRzLmh0bWwuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS91bml4L1Rlc3ROZXRz
Y2FwZVBsdWdpbi9UZXN0TmV0c2NhcGVQbHVnaW4uY3BwOgorICAgICAgICAoa2V5Y29kZV90b19j
aGFyKToKKyAgICAgICAgKHdlYmtpdF90ZXN0X3BsdWdpbl9oYW5kbGVfZXZlbnQpOgorCiAyMDEw
LTExLTE1ICBBbmRyYXMgQmVjc2kgIDxhYmVjc2lAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZp
ZXdlZCBieSBBbmRyZWFzIEtsaW5nLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRl
clRyZWUvdW5peC9UZXN0TmV0c2NhcGVQbHVnaW4vVGVzdE5ldHNjYXBlUGx1Z2luLmNwcCBiL1dl
YktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3VuaXgvVGVzdE5ldHNjYXBlUGx1Z2luL1Rlc3ROZXRz
Y2FwZVBsdWdpbi5jcHAKaW5kZXggNzU1ZmJhMC4uYzRiNWYyNiAxMDA2NDQKLS0tIGEvV2ViS2l0
VG9vbHMvRHVtcFJlbmRlclRyZWUvdW5peC9UZXN0TmV0c2NhcGVQbHVnaW4vVGVzdE5ldHNjYXBl
UGx1Z2luLmNwcAorKysgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS91bml4L1Rlc3ROZXRz
Y2FwZVBsdWdpbi9UZXN0TmV0c2NhcGVQbHVnaW4uY3BwCkBAIC0zOCw2ICszOCw3IEBACiAjaW5j
bHVkZSA8c3RyaW5nLmg+CiAjaW5jbHVkZSA8c3RkbGliLmg+CiAjaW5jbHVkZSA8WDExL1hsaWIu
aD4KKyNpbmNsdWRlIDxYMTEvWHV0aWwuaD4KICNpbmNsdWRlIDxzdHJpbmc+CiAKIHVzaW5nIG5h
bWVzcGFjZSBzdGQ7CkBAIC0yNjEsNiArMjYyLDE0IEBAIHdlYmtpdF90ZXN0X3BsdWdpbl9wcmlu
dChOUFAgLyppbnN0YW5jZSovLCBOUFByaW50KiAvKnBsYXRmb3JtUHJpbnQqLykKIHsKIH0KIAor
c3RhdGljIGNoYXIKK2tleWNvZGVfdG9fY2hhcihYS2V5RXZlbnQgKmV2ZW50KQoreworICAgIGNo
YXIgYyA9ICcgJzsKKyAgICBYTG9va3VwU3RyaW5nKGV2ZW50LCAmYywgc2l6ZW9mKGMpLCAwLCAw
KTsKKyAgICByZXR1cm4gYzsKK30KKwogc3RhdGljIGludDE2X3QKIHdlYmtpdF90ZXN0X3BsdWdp
bl9oYW5kbGVfZXZlbnQoTlBQIGluc3RhbmNlLCB2b2lkKiBldmVudCkKIHsKQEAgLTI3OCwxMCAr
Mjg3LDEwIEBAIHdlYmtpdF90ZXN0X3BsdWdpbl9oYW5kbGVfZXZlbnQoTlBQIGluc3RhbmNlLCB2
b2lkKiBldmVudCkKICAgICAgICAgICAgIHBsdWdpbkxvZyhpbnN0YW5jZSwgIm1vdXNlRG93biBh
dCAoJWQsICVkKSIsIGV2dC0+eGJ1dHRvbi54LCBldnQtPnhidXR0b24ueSk7CiAgICAgICAgICAg
ICBicmVhazsKICAgICAgICAgY2FzZSBLZXlSZWxlYXNlOgotICAgICAgICAgICAgcGx1Z2luTG9n
KGluc3RhbmNlLCAia2V5VXAgJyVjJyIsIGV2dC0+eGtleS5rZXljb2RlKTsKKyAgICAgICAgICAg
IHBsdWdpbkxvZyhpbnN0YW5jZSwgImtleVVwICclYyciLCBrZXljb2RlX3RvX2NoYXIoJmV2dC0+
eGtleSkpOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2UgS2V5UHJlc3M6Ci0gICAg
ICAgICAgICBwbHVnaW5Mb2coaW5zdGFuY2UsICJrZXlEb3duICclYyciLCBldnQtPnhrZXkua2V5
Y29kZSk7CisgICAgICAgICAgICBwbHVnaW5Mb2coaW5zdGFuY2UsICJrZXlEb3duICclYyciLCBr
ZXljb2RlX3RvX2NoYXIoJmV2dC0+eGtleSkpOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAg
IGNhc2UgTW90aW9uTm90aWZ5OgogICAgICAgICBjYXNlIEVudGVyTm90aWZ5OgotLSAKMS43LjMu
MgoK
</data>
<flag name="review"
          id="65380"
          type_id="1"
          status="-"
          setter="mrobinson"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>74820</attachid>
            <date>2010-11-24 17:52:00 -0800</date>
            <delta_ts>2010-11-24 18:12:20 -0800</delta_ts>
            <desc>Fixed function naming</desc>
            <filename>0001-GTK-Windowless-plugins-gets-broken-key-input.patch</filename>
            <type>text/plain</type>
            <size>5016</size>
            <attacher name="Nicolas Dufresne">nicolas</attacher>
            
              <data encoding="base64">RnJvbSA5YWIxMjBhMzRjOThjMTdkZmUzZDVjODY5ZGZkMGM2YTRkOWNhODhkIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBOaWNvbGFzIER1ZnJlc25lIDxuaWNvbGFzLmR1ZnJlc25lQGNv
bGxhYm9yYS5jby51az4KRGF0ZTogTW9uLCAyMiBOb3YgMjAxMCAxNToyODo1MSAtMDgwMApTdWJq
ZWN0OiBbUEFUQ0hdIFtHVEtdIFdpbmRvd2xlc3MgcGx1Z2lucyBnZXRzIGJyb2tlbiBrZXkgaW5w
dXQKCmh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTkyNwoKV2hlbiBj
b252ZXJ0aW5nIHRoZSBHZGtFdmVudCB0byBYRXZlbnQgd2UgbmVlZCB0byBzZW5kIHRoZQpoYXJk
d2FyZV9rZXljb2RlIGFzIFhFdmVudDo6a2V5Y29kZS4gSW5zdGVhZCB3ZSB3aGVyZSBzZW5kaW5n
CnRoZSBHZGtFdmVudDo6a2V5dmFsLiBUaGlzIGlzIGFscmVhZHkgdGVzdGVkIGJ5CnBsdWdpbnMv
a2V5Ym9hcmQtZXZlbnRzLmh0bWwsIGJ1dCBhIGJ1ZyBpbiB0aGUgdGVzdCBwbHVnaW4gd2FzCnJl
c3VsdGluZyBpbiBmYWxzZSBwb3NpdGl2ZS4KCiogcGx1Z2lucy9ndGsvUGx1Z2luVmlld0d0ay5j
cHA6CihXZWJDb3JlOjpQbHVnaW5WaWV3OjpoYW5kbGVLZXlib2FyZEV2ZW50KToKCkNvbnZlcnQg
dGhlIFhFdmVudDo6a2V5Y29kZSB0byBBU0NJSSBiZWZvcmUgcHJpbnRpbmcgaXQuIE5vdApkb2lu
ZyB0aGlzIHdhcyBjYXVzaW5nIGZhbHNlIHBvc2l0aXZlIGluCnBsdWdpbnMva2V5Ym9hcmQtZXZl
bnRzLmh0bWwuCgoqIER1bXBSZW5kZXJUcmVlL3VuaXgvVGVzdE5ldHNjYXBlUGx1Z2luL1Rlc3RO
ZXRzY2FwZVBsdWdpbi5jcHA6CihrZXljb2RlX3RvX2NoYXIpOgogICh3ZWJraXRfdGVzdF9wbHVn
aW5faGFuZGxlX2V2ZW50KToKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICB8ICAgMTYgKysrKysrKysrKysrKysrKwogV2ViQ29yZS9wbHVnaW5z
L2d0ay9QbHVnaW5WaWV3R3RrLmNwcCAgICAgICAgICAgICAgfCAgICAyICstCiBXZWJLaXRUb29s
cy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTUgKysrKysrKysr
KysrKysrCiAuLi4vdW5peC9UZXN0TmV0c2NhcGVQbHVnaW4vVGVzdE5ldHNjYXBlUGx1Z2luLmNw
cCB8ICAgMTMgKysrKysrKysrKystLQogNCBmaWxlcyBjaGFuZ2VkLCA0MyBpbnNlcnRpb25zKCsp
LCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29y
ZS9DaGFuZ2VMb2cKaW5kZXggMDllNjZiYy4uMTgwZWU5YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9D
aGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0x
MS0yMiAgTmljb2xhcyBEdWZyZXNuZSAgPG5pY29sYXMuZHVmcmVzbmVAY29sbGFib3JhLmNvLnVr
PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtd
IFdpbmRvd2xlc3MgcGx1Z2lucyBnZXRzIGJyb2tlbiBrZXkgaW5wdXQKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ5OTI3CisKKyAgICAgICAgV2hlbiBj
b252ZXJ0aW5nIHRoZSBHZGtFdmVudCB0byBYRXZlbnQgd2UgbmVlZCB0byBzZW5kIHRoZQorICAg
ICAgICBoYXJkd2FyZV9rZXljb2RlIGFzIFhFdmVudDo6a2V5Y29kZS4gSW5zdGVhZCB3ZSB3aGVy
ZSBzZW5kaW5nCisgICAgICAgIHRoZSBHZGtFdmVudDo6a2V5dmFsLiBUaGlzIGlzIGFscmVhZHkg
dGVzdGVkIGJ5CisgICAgICAgIHBsdWdpbnMva2V5Ym9hcmQtZXZlbnRzLmh0bWwsIGJ1dCBhIGJ1
ZyBpbiB0aGUgdGVzdCBwbHVnaW4gd2FzCisgICAgICAgIHJlc3VsdGluZyBpbiBmYWxzZSBwb3Np
dGl2ZS4KKworICAgICAgICAqIHBsdWdpbnMvZ3RrL1BsdWdpblZpZXdHdGsuY3BwOgorICAgICAg
ICAoV2ViQ29yZTo6UGx1Z2luVmlldzo6aGFuZGxlS2V5Ym9hcmRFdmVudCk6CisKIDIwMTAtMTEt
MTUgIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5
IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbHVnaW5zL2d0ay9QbHVnaW5WaWV3
R3RrLmNwcCBiL1dlYkNvcmUvcGx1Z2lucy9ndGsvUGx1Z2luVmlld0d0ay5jcHAKaW5kZXggNjYw
OGY2Yy4uMzVmOGVlMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbHVnaW5zL2d0ay9QbHVnaW5WaWV3
R3RrLmNwcAorKysgYi9XZWJDb3JlL3BsdWdpbnMvZ3RrL1BsdWdpblZpZXdHdGsuY3BwCkBAIC0y
ODIsNyArMjgyLDcgQEAgdm9pZCBQbHVnaW5WaWV3OjpoYW5kbGVLZXlib2FyZEV2ZW50KEtleWJv
YXJkRXZlbnQqIGV2ZW50KQogICAgIHhFdmVudC54a2V5LnN1YndpbmRvdyA9IDA7IC8vIHdlIGhh
dmUgbm8gY2hpbGQgd2luZG93CiAgICAgeEV2ZW50LnhrZXkudGltZSA9IGV2ZW50LT50aW1lU3Rh
bXAoKTsKICAgICB4RXZlbnQueGtleS5zdGF0ZSA9IGdka0V2ZW50LT5zdGF0ZTsgLy8gR2RrTW9k
aWZpZXJUeXBlIG1pcnJvcnMgeGxpYiBzdGF0ZSBtYXNrcwotICAgIHhFdmVudC54a2V5LmtleWNv
ZGUgPSBnZGtFdmVudC0+a2V5dmFsOworICAgIHhFdmVudC54a2V5LmtleWNvZGUgPSBnZGtFdmVu
dC0+aGFyZHdhcmVfa2V5Y29kZTsKICAgICB4RXZlbnQueGtleS5zYW1lX3NjcmVlbiA9IHRydWU7
CiAKICAgICAvLyBOT1RFOiBBcyB0aGUgWEV2ZW50cyBzZW50IHRvIHRoZSBwbHVnLWluIGFyZSBz
eW50aGVzaXplZCBhbmQgdGhlcmUgaXMgbm90IGEgbmF0aXZlIHdpbmRvdwpkaWZmIC0tZ2l0IGEv
V2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmluZGV4IGQzMTY3
MTcuLjMzOGJkMjMgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZworKysgYi9XZWJL
aXRUb29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0xMS0yMyAgTmljb2xhcyBE
dWZyZXNuZSAgPG5pY29sYXMuZHVmcmVzbmVAY29sbGFib3JhLmNvLnVrPgorCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIFdpbmRvd2xlc3MgcGx1
Z2lucyBnZXRzIGJyb2tlbiBrZXkgaW5wdXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTQ5OTI3CisKKyAgICAgICAgQ29udmVydCB0aGUgWEV2ZW50Ojpr
ZXljb2RlIHRvIEFTQ0lJIGJlZm9yZSBwcmludGluZyBpdC4gTm90CisgICAgICAgIGRvaW5nIHRo
aXMgd2FzIGNhdXNpbmcgZmFsc2UgcG9zaXRpdmUgaW4gCisgICAgICAgIHBsdWdpbnMva2V5Ym9h
cmQtZXZlbnRzLmh0bWwuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS91bml4L1Rlc3ROZXRz
Y2FwZVBsdWdpbi9UZXN0TmV0c2NhcGVQbHVnaW4uY3BwOgorICAgICAgICAoa2V5Y29kZV90b19j
aGFyKToKKyAgICAgICAgKHdlYmtpdF90ZXN0X3BsdWdpbl9oYW5kbGVfZXZlbnQpOgorCiAyMDEw
LTExLTE1ICBBbmRyYXMgQmVjc2kgIDxhYmVjc2lAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZp
ZXdlZCBieSBBbmRyZWFzIEtsaW5nLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRl
clRyZWUvdW5peC9UZXN0TmV0c2NhcGVQbHVnaW4vVGVzdE5ldHNjYXBlUGx1Z2luLmNwcCBiL1dl
YktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3VuaXgvVGVzdE5ldHNjYXBlUGx1Z2luL1Rlc3ROZXRz
Y2FwZVBsdWdpbi5jcHAKaW5kZXggNzU1ZmJhMC4uOThmYzhkYyAxMDA2NDQKLS0tIGEvV2ViS2l0
VG9vbHMvRHVtcFJlbmRlclRyZWUvdW5peC9UZXN0TmV0c2NhcGVQbHVnaW4vVGVzdE5ldHNjYXBl
UGx1Z2luLmNwcAorKysgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS91bml4L1Rlc3ROZXRz
Y2FwZVBsdWdpbi9UZXN0TmV0c2NhcGVQbHVnaW4uY3BwCkBAIC0zOCw2ICszOCw3IEBACiAjaW5j
bHVkZSA8c3RyaW5nLmg+CiAjaW5jbHVkZSA8c3RkbGliLmg+CiAjaW5jbHVkZSA8WDExL1hsaWIu
aD4KKyNpbmNsdWRlIDxYMTEvWHV0aWwuaD4KICNpbmNsdWRlIDxzdHJpbmc+CiAKIHVzaW5nIG5h
bWVzcGFjZSBzdGQ7CkBAIC0yNjEsNiArMjYyLDE0IEBAIHdlYmtpdF90ZXN0X3BsdWdpbl9wcmlu
dChOUFAgLyppbnN0YW5jZSovLCBOUFByaW50KiAvKnBsYXRmb3JtUHJpbnQqLykKIHsKIH0KIAor
c3RhdGljIGNoYXIKK2tleUV2ZW50VG9DaGFyKFhLZXlFdmVudCAqZXZlbnQpCit7CisgICAgY2hh
ciBjID0gJyAnOworICAgIFhMb29rdXBTdHJpbmcoZXZlbnQsICZjLCBzaXplb2YoYyksIDAsIDAp
OworICAgIHJldHVybiBjOworfQorCiBzdGF0aWMgaW50MTZfdAogd2Via2l0X3Rlc3RfcGx1Z2lu
X2hhbmRsZV9ldmVudChOUFAgaW5zdGFuY2UsIHZvaWQqIGV2ZW50KQogewpAQCAtMjc4LDEwICsy
ODcsMTAgQEAgd2Via2l0X3Rlc3RfcGx1Z2luX2hhbmRsZV9ldmVudChOUFAgaW5zdGFuY2UsIHZv
aWQqIGV2ZW50KQogICAgICAgICAgICAgcGx1Z2luTG9nKGluc3RhbmNlLCAibW91c2VEb3duIGF0
ICglZCwgJWQpIiwgZXZ0LT54YnV0dG9uLngsIGV2dC0+eGJ1dHRvbi55KTsKICAgICAgICAgICAg
IGJyZWFrOwogICAgICAgICBjYXNlIEtleVJlbGVhc2U6Ci0gICAgICAgICAgICBwbHVnaW5Mb2co
aW5zdGFuY2UsICJrZXlVcCAnJWMnIiwgZXZ0LT54a2V5LmtleWNvZGUpOworICAgICAgICAgICAg
cGx1Z2luTG9nKGluc3RhbmNlLCAia2V5VXAgJyVjJyIsIGtleUV2ZW50VG9DaGFyKCZldnQtPnhr
ZXkpKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIEtleVByZXNzOgotICAgICAg
ICAgICAgcGx1Z2luTG9nKGluc3RhbmNlLCAia2V5RG93biAnJWMnIiwgZXZ0LT54a2V5LmtleWNv
ZGUpOworICAgICAgICAgICAgcGx1Z2luTG9nKGluc3RhbmNlLCAia2V5RG93biAnJWMnIiwga2V5
RXZlbnRUb0NoYXIoJmV2dC0+eGtleSkpOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNh
c2UgTW90aW9uTm90aWZ5OgogICAgICAgICBjYXNlIEVudGVyTm90aWZ5OgotLSAKMS43LjMuMgoK
</data>
<flag name="review"
          id="65520"
          type_id="1"
          status="-"
          setter="mrobinson"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="0"
              isprivate="0"
          >
            <attachid>74824</attachid>
            <date>2010-11-24 18:12:20 -0800</date>
            <delta_ts>2010-11-24 18:13:15 -0800</delta_ts>
            <desc>Fix function implementation style</desc>
            <filename>0001-GTK-Windowless-plugins-gets-broken-key-input.patch</filename>
            <type>text/plain</type>
            <size>5016</size>
            <attacher name="Nicolas Dufresne">nicolas</attacher>
            
              <data encoding="base64">RnJvbSA5YWIxMjBhMzRjOThjMTdkZmUzZDVjODY5ZGZkMGM2YTRkOWNhODhkIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBOaWNvbGFzIER1ZnJlc25lIDxuaWNvbGFzLmR1ZnJlc25lQGNv
bGxhYm9yYS5jby51az4KRGF0ZTogTW9uLCAyMiBOb3YgMjAxMCAxNToyODo1MSAtMDgwMApTdWJq
ZWN0OiBbUEFUQ0hdIFtHVEtdIFdpbmRvd2xlc3MgcGx1Z2lucyBnZXRzIGJyb2tlbiBrZXkgaW5w
dXQKCmh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTkyNwoKV2hlbiBj
b252ZXJ0aW5nIHRoZSBHZGtFdmVudCB0byBYRXZlbnQgd2UgbmVlZCB0byBzZW5kIHRoZQpoYXJk
d2FyZV9rZXljb2RlIGFzIFhFdmVudDo6a2V5Y29kZS4gSW5zdGVhZCB3ZSB3aGVyZSBzZW5kaW5n
CnRoZSBHZGtFdmVudDo6a2V5dmFsLiBUaGlzIGlzIGFscmVhZHkgdGVzdGVkIGJ5CnBsdWdpbnMv
a2V5Ym9hcmQtZXZlbnRzLmh0bWwsIGJ1dCBhIGJ1ZyBpbiB0aGUgdGVzdCBwbHVnaW4gd2FzCnJl
c3VsdGluZyBpbiBmYWxzZSBwb3NpdGl2ZS4KCiogcGx1Z2lucy9ndGsvUGx1Z2luVmlld0d0ay5j
cHA6CihXZWJDb3JlOjpQbHVnaW5WaWV3OjpoYW5kbGVLZXlib2FyZEV2ZW50KToKCkNvbnZlcnQg
dGhlIFhFdmVudDo6a2V5Y29kZSB0byBBU0NJSSBiZWZvcmUgcHJpbnRpbmcgaXQuIE5vdApkb2lu
ZyB0aGlzIHdhcyBjYXVzaW5nIGZhbHNlIHBvc2l0aXZlIGluCnBsdWdpbnMva2V5Ym9hcmQtZXZl
bnRzLmh0bWwuCgoqIER1bXBSZW5kZXJUcmVlL3VuaXgvVGVzdE5ldHNjYXBlUGx1Z2luL1Rlc3RO
ZXRzY2FwZVBsdWdpbi5jcHA6CihrZXljb2RlX3RvX2NoYXIpOgogICh3ZWJraXRfdGVzdF9wbHVn
aW5faGFuZGxlX2V2ZW50KToKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICB8ICAgMTYgKysrKysrKysrKysrKysrKwogV2ViQ29yZS9wbHVnaW5z
L2d0ay9QbHVnaW5WaWV3R3RrLmNwcCAgICAgICAgICAgICAgfCAgICAyICstCiBXZWJLaXRUb29s
cy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTUgKysrKysrKysr
KysrKysrCiAuLi4vdW5peC9UZXN0TmV0c2NhcGVQbHVnaW4vVGVzdE5ldHNjYXBlUGx1Z2luLmNw
cCB8ICAgMTMgKysrKysrKysrKystLQogNCBmaWxlcyBjaGFuZ2VkLCA0MyBpbnNlcnRpb25zKCsp
LCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29y
ZS9DaGFuZ2VMb2cKaW5kZXggMDllNjZiYy4uMTgwZWU5YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9D
aGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0x
MS0yMiAgTmljb2xhcyBEdWZyZXNuZSAgPG5pY29sYXMuZHVmcmVzbmVAY29sbGFib3JhLmNvLnVr
PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtd
IFdpbmRvd2xlc3MgcGx1Z2lucyBnZXRzIGJyb2tlbiBrZXkgaW5wdXQKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ5OTI3CisKKyAgICAgICAgV2hlbiBj
b252ZXJ0aW5nIHRoZSBHZGtFdmVudCB0byBYRXZlbnQgd2UgbmVlZCB0byBzZW5kIHRoZQorICAg
ICAgICBoYXJkd2FyZV9rZXljb2RlIGFzIFhFdmVudDo6a2V5Y29kZS4gSW5zdGVhZCB3ZSB3aGVy
ZSBzZW5kaW5nCisgICAgICAgIHRoZSBHZGtFdmVudDo6a2V5dmFsLiBUaGlzIGlzIGFscmVhZHkg
dGVzdGVkIGJ5CisgICAgICAgIHBsdWdpbnMva2V5Ym9hcmQtZXZlbnRzLmh0bWwsIGJ1dCBhIGJ1
ZyBpbiB0aGUgdGVzdCBwbHVnaW4gd2FzCisgICAgICAgIHJlc3VsdGluZyBpbiBmYWxzZSBwb3Np
dGl2ZS4KKworICAgICAgICAqIHBsdWdpbnMvZ3RrL1BsdWdpblZpZXdHdGsuY3BwOgorICAgICAg
ICAoV2ViQ29yZTo6UGx1Z2luVmlldzo6aGFuZGxlS2V5Ym9hcmRFdmVudCk6CisKIDIwMTAtMTEt
MTUgIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5
IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbHVnaW5zL2d0ay9QbHVnaW5WaWV3
R3RrLmNwcCBiL1dlYkNvcmUvcGx1Z2lucy9ndGsvUGx1Z2luVmlld0d0ay5jcHAKaW5kZXggNjYw
OGY2Yy4uMzVmOGVlMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbHVnaW5zL2d0ay9QbHVnaW5WaWV3
R3RrLmNwcAorKysgYi9XZWJDb3JlL3BsdWdpbnMvZ3RrL1BsdWdpblZpZXdHdGsuY3BwCkBAIC0y
ODIsNyArMjgyLDcgQEAgdm9pZCBQbHVnaW5WaWV3OjpoYW5kbGVLZXlib2FyZEV2ZW50KEtleWJv
YXJkRXZlbnQqIGV2ZW50KQogICAgIHhFdmVudC54a2V5LnN1YndpbmRvdyA9IDA7IC8vIHdlIGhh
dmUgbm8gY2hpbGQgd2luZG93CiAgICAgeEV2ZW50LnhrZXkudGltZSA9IGV2ZW50LT50aW1lU3Rh
bXAoKTsKICAgICB4RXZlbnQueGtleS5zdGF0ZSA9IGdka0V2ZW50LT5zdGF0ZTsgLy8gR2RrTW9k
aWZpZXJUeXBlIG1pcnJvcnMgeGxpYiBzdGF0ZSBtYXNrcwotICAgIHhFdmVudC54a2V5LmtleWNv
ZGUgPSBnZGtFdmVudC0+a2V5dmFsOworICAgIHhFdmVudC54a2V5LmtleWNvZGUgPSBnZGtFdmVu
dC0+aGFyZHdhcmVfa2V5Y29kZTsKICAgICB4RXZlbnQueGtleS5zYW1lX3NjcmVlbiA9IHRydWU7
CiAKICAgICAvLyBOT1RFOiBBcyB0aGUgWEV2ZW50cyBzZW50IHRvIHRoZSBwbHVnLWluIGFyZSBz
eW50aGVzaXplZCBhbmQgdGhlcmUgaXMgbm90IGEgbmF0aXZlIHdpbmRvdwpkaWZmIC0tZ2l0IGEv
V2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmluZGV4IGQzMTY3
MTcuLjMzOGJkMjMgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZworKysgYi9XZWJL
aXRUb29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0xMS0yMyAgTmljb2xhcyBE
dWZyZXNuZSAgPG5pY29sYXMuZHVmcmVzbmVAY29sbGFib3JhLmNvLnVrPgorCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIFdpbmRvd2xlc3MgcGx1
Z2lucyBnZXRzIGJyb2tlbiBrZXkgaW5wdXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTQ5OTI3CisKKyAgICAgICAgQ29udmVydCB0aGUgWEV2ZW50Ojpr
ZXljb2RlIHRvIEFTQ0lJIGJlZm9yZSBwcmludGluZyBpdC4gTm90CisgICAgICAgIGRvaW5nIHRo
aXMgd2FzIGNhdXNpbmcgZmFsc2UgcG9zaXRpdmUgaW4gCisgICAgICAgIHBsdWdpbnMva2V5Ym9h
cmQtZXZlbnRzLmh0bWwuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS91bml4L1Rlc3ROZXRz
Y2FwZVBsdWdpbi9UZXN0TmV0c2NhcGVQbHVnaW4uY3BwOgorICAgICAgICAoa2V5Y29kZV90b19j
aGFyKToKKyAgICAgICAgKHdlYmtpdF90ZXN0X3BsdWdpbl9oYW5kbGVfZXZlbnQpOgorCiAyMDEw
LTExLTE1ICBBbmRyYXMgQmVjc2kgIDxhYmVjc2lAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZp
ZXdlZCBieSBBbmRyZWFzIEtsaW5nLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRl
clRyZWUvdW5peC9UZXN0TmV0c2NhcGVQbHVnaW4vVGVzdE5ldHNjYXBlUGx1Z2luLmNwcCBiL1dl
YktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3VuaXgvVGVzdE5ldHNjYXBlUGx1Z2luL1Rlc3ROZXRz
Y2FwZVBsdWdpbi5jcHAKaW5kZXggNzU1ZmJhMC4uOThmYzhkYyAxMDA2NDQKLS0tIGEvV2ViS2l0
VG9vbHMvRHVtcFJlbmRlclRyZWUvdW5peC9UZXN0TmV0c2NhcGVQbHVnaW4vVGVzdE5ldHNjYXBl
UGx1Z2luLmNwcAorKysgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS91bml4L1Rlc3ROZXRz
Y2FwZVBsdWdpbi9UZXN0TmV0c2NhcGVQbHVnaW4uY3BwCkBAIC0zOCw2ICszOCw3IEBACiAjaW5j
bHVkZSA8c3RyaW5nLmg+CiAjaW5jbHVkZSA8c3RkbGliLmg+CiAjaW5jbHVkZSA8WDExL1hsaWIu
aD4KKyNpbmNsdWRlIDxYMTEvWHV0aWwuaD4KICNpbmNsdWRlIDxzdHJpbmc+CiAKIHVzaW5nIG5h
bWVzcGFjZSBzdGQ7CkBAIC0yNjEsNiArMjYyLDE0IEBAIHdlYmtpdF90ZXN0X3BsdWdpbl9wcmlu
dChOUFAgLyppbnN0YW5jZSovLCBOUFByaW50KiAvKnBsYXRmb3JtUHJpbnQqLykKIHsKIH0KIAor
c3RhdGljIGNoYXIKK2tleUV2ZW50VG9DaGFyKFhLZXlFdmVudCAqZXZlbnQpCit7CisgICAgY2hh
ciBjID0gJyAnOworICAgIFhMb29rdXBTdHJpbmcoZXZlbnQsICZjLCBzaXplb2YoYyksIDAsIDAp
OworICAgIHJldHVybiBjOworfQorCiBzdGF0aWMgaW50MTZfdAogd2Via2l0X3Rlc3RfcGx1Z2lu
X2hhbmRsZV9ldmVudChOUFAgaW5zdGFuY2UsIHZvaWQqIGV2ZW50KQogewpAQCAtMjc4LDEwICsy
ODcsMTAgQEAgd2Via2l0X3Rlc3RfcGx1Z2luX2hhbmRsZV9ldmVudChOUFAgaW5zdGFuY2UsIHZv
aWQqIGV2ZW50KQogICAgICAgICAgICAgcGx1Z2luTG9nKGluc3RhbmNlLCAibW91c2VEb3duIGF0
ICglZCwgJWQpIiwgZXZ0LT54YnV0dG9uLngsIGV2dC0+eGJ1dHRvbi55KTsKICAgICAgICAgICAg
IGJyZWFrOwogICAgICAgICBjYXNlIEtleVJlbGVhc2U6Ci0gICAgICAgICAgICBwbHVnaW5Mb2co
aW5zdGFuY2UsICJrZXlVcCAnJWMnIiwgZXZ0LT54a2V5LmtleWNvZGUpOworICAgICAgICAgICAg
cGx1Z2luTG9nKGluc3RhbmNlLCAia2V5VXAgJyVjJyIsIGtleUV2ZW50VG9DaGFyKCZldnQtPnhr
ZXkpKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIEtleVByZXNzOgotICAgICAg
ICAgICAgcGx1Z2luTG9nKGluc3RhbmNlLCAia2V5RG93biAnJWMnIiwgZXZ0LT54a2V5LmtleWNv
ZGUpOworICAgICAgICAgICAgcGx1Z2luTG9nKGluc3RhbmNlLCAia2V5RG93biAnJWMnIiwga2V5
RXZlbnRUb0NoYXIoJmV2dC0+eGtleSkpOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNh
c2UgTW90aW9uTm90aWZ5OgogICAgICAgICBjYXNlIEVudGVyTm90aWZ5OgotLSAKMS43LjMuMgoK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>74825</attachid>
            <date>2010-11-24 18:14:02 -0800</date>
            <delta_ts>2010-11-24 19:18:40 -0800</delta_ts>
            <desc>Fix remaining style issues</desc>
            <filename>0001-GTK-Windowless-plugins-gets-broken-key-input.patch</filename>
            <type>text/plain</type>
            <size>5014</size>
            <attacher name="Nicolas Dufresne">nicolas</attacher>
            
              <data encoding="base64">RnJvbSAyODU1ZTk3YTg2Y2JhMDEyNWU3NjZmZWM1ZjhjMGIyMjlmNThmODkyIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBOaWNvbGFzIER1ZnJlc25lIDxuaWNvbGFzLmR1ZnJlc25lQGNv
bGxhYm9yYS5jby51az4KRGF0ZTogTW9uLCAyMiBOb3YgMjAxMCAxNToyODo1MSAtMDgwMApTdWJq
ZWN0OiBbUEFUQ0hdIFtHVEtdIFdpbmRvd2xlc3MgcGx1Z2lucyBnZXRzIGJyb2tlbiBrZXkgaW5w
dXQKCmh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTkyNwoKV2hlbiBj
b252ZXJ0aW5nIHRoZSBHZGtFdmVudCB0byBYRXZlbnQgd2UgbmVlZCB0byBzZW5kIHRoZQpoYXJk
d2FyZV9rZXljb2RlIGFzIFhFdmVudDo6a2V5Y29kZS4gSW5zdGVhZCB3ZSB3aGVyZSBzZW5kaW5n
CnRoZSBHZGtFdmVudDo6a2V5dmFsLiBUaGlzIGlzIGFscmVhZHkgdGVzdGVkIGJ5CnBsdWdpbnMv
a2V5Ym9hcmQtZXZlbnRzLmh0bWwsIGJ1dCBhIGJ1ZyBpbiB0aGUgdGVzdCBwbHVnaW4gd2FzCnJl
c3VsdGluZyBpbiBmYWxzZSBwb3NpdGl2ZS4KCiogcGx1Z2lucy9ndGsvUGx1Z2luVmlld0d0ay5j
cHA6CihXZWJDb3JlOjpQbHVnaW5WaWV3OjpoYW5kbGVLZXlib2FyZEV2ZW50KToKCkNvbnZlcnQg
dGhlIFhFdmVudDo6a2V5Y29kZSB0byBBU0NJSSBiZWZvcmUgcHJpbnRpbmcgaXQuIE5vdApkb2lu
ZyB0aGlzIHdhcyBjYXVzaW5nIGZhbHNlIHBvc2l0aXZlIGluCnBsdWdpbnMva2V5Ym9hcmQtZXZl
bnRzLmh0bWwuCgoqIER1bXBSZW5kZXJUcmVlL3VuaXgvVGVzdE5ldHNjYXBlUGx1Z2luL1Rlc3RO
ZXRzY2FwZVBsdWdpbi5jcHA6CihrZXljb2RlX3RvX2NoYXIpOgogICh3ZWJraXRfdGVzdF9wbHVn
aW5faGFuZGxlX2V2ZW50KToKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICB8ICAgMTYgKysrKysrKysrKysrKysrKwogV2ViQ29yZS9wbHVnaW5z
L2d0ay9QbHVnaW5WaWV3R3RrLmNwcCAgICAgICAgICAgICAgfCAgICAyICstCiBXZWJLaXRUb29s
cy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTUgKysrKysrKysr
KysrKysrCiAuLi4vdW5peC9UZXN0TmV0c2NhcGVQbHVnaW4vVGVzdE5ldHNjYXBlUGx1Z2luLmNw
cCB8ICAgMTIgKysrKysrKysrKy0tCiA0IGZpbGVzIGNoYW5nZWQsIDQyIGluc2VydGlvbnMoKyks
IDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3Jl
L0NoYW5nZUxvZwppbmRleCAwOWU2NmJjLi4xODBlZTliIDEwMDY0NAotLS0gYS9XZWJDb3JlL0No
YW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEwLTEx
LTIyICBOaWNvbGFzIER1ZnJlc25lICA8bmljb2xhcy5kdWZyZXNuZUBjb2xsYWJvcmEuY28udWs+
CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10g
V2luZG93bGVzcyBwbHVnaW5zIGdldHMgYnJva2VuIGtleSBpbnB1dAorICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDk5MjcKKworICAgICAgICBXaGVuIGNv
bnZlcnRpbmcgdGhlIEdka0V2ZW50IHRvIFhFdmVudCB3ZSBuZWVkIHRvIHNlbmQgdGhlCisgICAg
ICAgIGhhcmR3YXJlX2tleWNvZGUgYXMgWEV2ZW50OjprZXljb2RlLiBJbnN0ZWFkIHdlIHdoZXJl
IHNlbmRpbmcKKyAgICAgICAgdGhlIEdka0V2ZW50OjprZXl2YWwuIFRoaXMgaXMgYWxyZWFkeSB0
ZXN0ZWQgYnkKKyAgICAgICAgcGx1Z2lucy9rZXlib2FyZC1ldmVudHMuaHRtbCwgYnV0IGEgYnVn
IGluIHRoZSB0ZXN0IHBsdWdpbiB3YXMKKyAgICAgICAgcmVzdWx0aW5nIGluIGZhbHNlIHBvc2l0
aXZlLgorCisgICAgICAgICogcGx1Z2lucy9ndGsvUGx1Z2luVmlld0d0ay5jcHA6CisgICAgICAg
IChXZWJDb3JlOjpQbHVnaW5WaWV3OjpoYW5kbGVLZXlib2FyZEV2ZW50KToKKwogMjAxMC0xMS0x
NSAgQmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg
RGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsdWdpbnMvZ3RrL1BsdWdpblZpZXdH
dGsuY3BwIGIvV2ViQ29yZS9wbHVnaW5zL2d0ay9QbHVnaW5WaWV3R3RrLmNwcAppbmRleCA2NjA4
ZjZjLi4zNWY4ZWUyIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsdWdpbnMvZ3RrL1BsdWdpblZpZXdH
dGsuY3BwCisrKyBiL1dlYkNvcmUvcGx1Z2lucy9ndGsvUGx1Z2luVmlld0d0ay5jcHAKQEAgLTI4
Miw3ICsyODIsNyBAQCB2b2lkIFBsdWdpblZpZXc6OmhhbmRsZUtleWJvYXJkRXZlbnQoS2V5Ym9h
cmRFdmVudCogZXZlbnQpCiAgICAgeEV2ZW50LnhrZXkuc3Vid2luZG93ID0gMDsgLy8gd2UgaGF2
ZSBubyBjaGlsZCB3aW5kb3cKICAgICB4RXZlbnQueGtleS50aW1lID0gZXZlbnQtPnRpbWVTdGFt
cCgpOwogICAgIHhFdmVudC54a2V5LnN0YXRlID0gZ2RrRXZlbnQtPnN0YXRlOyAvLyBHZGtNb2Rp
ZmllclR5cGUgbWlycm9ycyB4bGliIHN0YXRlIG1hc2tzCi0gICAgeEV2ZW50LnhrZXkua2V5Y29k
ZSA9IGdka0V2ZW50LT5rZXl2YWw7CisgICAgeEV2ZW50LnhrZXkua2V5Y29kZSA9IGdka0V2ZW50
LT5oYXJkd2FyZV9rZXljb2RlOwogICAgIHhFdmVudC54a2V5LnNhbWVfc2NyZWVuID0gdHJ1ZTsK
IAogICAgIC8vIE5PVEU6IEFzIHRoZSBYRXZlbnRzIHNlbnQgdG8gdGhlIHBsdWctaW4gYXJlIHN5
bnRoZXNpemVkIGFuZCB0aGVyZSBpcyBub3QgYSBuYXRpdmUgd2luZG93CmRpZmYgLS1naXQgYS9X
ZWJLaXRUb29scy9DaGFuZ2VMb2cgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKaW5kZXggZDMxNjcx
Ny4uMzM4YmQyMyAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCisrKyBiL1dlYktp
dFRvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEwLTExLTIzICBOaWNvbGFzIER1
ZnJlc25lICA8bmljb2xhcy5kdWZyZXNuZUBjb2xsYWJvcmEuY28udWs+CisKKyAgICAgICAgUmV2
aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gV2luZG93bGVzcyBwbHVn
aW5zIGdldHMgYnJva2VuIGtleSBpbnB1dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y
Zy9zaG93X2J1Zy5jZ2k/aWQ9NDk5MjcKKworICAgICAgICBDb252ZXJ0IHRoZSBYRXZlbnQ6Omtl
eWNvZGUgdG8gQVNDSUkgYmVmb3JlIHByaW50aW5nIGl0LiBOb3QKKyAgICAgICAgZG9pbmcgdGhp
cyB3YXMgY2F1c2luZyBmYWxzZSBwb3NpdGl2ZSBpbiAKKyAgICAgICAgcGx1Z2lucy9rZXlib2Fy
ZC1ldmVudHMuaHRtbC4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL3VuaXgvVGVzdE5ldHNj
YXBlUGx1Z2luL1Rlc3ROZXRzY2FwZVBsdWdpbi5jcHA6CisgICAgICAgIChrZXljb2RlX3RvX2No
YXIpOgorICAgICAgICAod2Via2l0X3Rlc3RfcGx1Z2luX2hhbmRsZV9ldmVudCk6CisKIDIwMTAt
MTEtMTUgIEFuZHJhcyBCZWNzaSAgPGFiZWNzaUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmll
d2VkIGJ5IEFuZHJlYXMgS2xpbmcuCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9EdW1wUmVuZGVy
VHJlZS91bml4L1Rlc3ROZXRzY2FwZVBsdWdpbi9UZXN0TmV0c2NhcGVQbHVnaW4uY3BwIGIvV2Vi
S2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvdW5peC9UZXN0TmV0c2NhcGVQbHVnaW4vVGVzdE5ldHNj
YXBlUGx1Z2luLmNwcAppbmRleCA3NTVmYmEwLi5hNGY3ZjA0IDEwMDY0NAotLS0gYS9XZWJLaXRU
b29scy9EdW1wUmVuZGVyVHJlZS91bml4L1Rlc3ROZXRzY2FwZVBsdWdpbi9UZXN0TmV0c2NhcGVQ
bHVnaW4uY3BwCisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3VuaXgvVGVzdE5ldHNj
YXBlUGx1Z2luL1Rlc3ROZXRzY2FwZVBsdWdpbi5jcHAKQEAgLTM4LDYgKzM4LDcgQEAKICNpbmNs
dWRlIDxzdHJpbmcuaD4KICNpbmNsdWRlIDxzdGRsaWIuaD4KICNpbmNsdWRlIDxYMTEvWGxpYi5o
PgorI2luY2x1ZGUgPFgxMS9YdXRpbC5oPgogI2luY2x1ZGUgPHN0cmluZz4KIAogdXNpbmcgbmFt
ZXNwYWNlIHN0ZDsKQEAgLTI2MSw2ICsyNjIsMTMgQEAgd2Via2l0X3Rlc3RfcGx1Z2luX3ByaW50
KE5QUCAvKmluc3RhbmNlKi8sIE5QUHJpbnQqIC8qcGxhdGZvcm1QcmludCovKQogewogfQogCitz
dGF0aWMgY2hhciBrZXlFdmVudFRvQ2hhcihYS2V5RXZlbnQqIGV2ZW50KQoreworICAgIGNoYXIg
YyA9ICcgJzsKKyAgICBYTG9va3VwU3RyaW5nKGV2ZW50LCAmYywgc2l6ZW9mKGMpLCAwLCAwKTsK
KyAgICByZXR1cm4gYzsKK30KKwogc3RhdGljIGludDE2X3QKIHdlYmtpdF90ZXN0X3BsdWdpbl9o
YW5kbGVfZXZlbnQoTlBQIGluc3RhbmNlLCB2b2lkKiBldmVudCkKIHsKQEAgLTI3OCwxMCArMjg2
LDEwIEBAIHdlYmtpdF90ZXN0X3BsdWdpbl9oYW5kbGVfZXZlbnQoTlBQIGluc3RhbmNlLCB2b2lk
KiBldmVudCkKICAgICAgICAgICAgIHBsdWdpbkxvZyhpbnN0YW5jZSwgIm1vdXNlRG93biBhdCAo
JWQsICVkKSIsIGV2dC0+eGJ1dHRvbi54LCBldnQtPnhidXR0b24ueSk7CiAgICAgICAgICAgICBi
cmVhazsKICAgICAgICAgY2FzZSBLZXlSZWxlYXNlOgotICAgICAgICAgICAgcGx1Z2luTG9nKGlu
c3RhbmNlLCAia2V5VXAgJyVjJyIsIGV2dC0+eGtleS5rZXljb2RlKTsKKyAgICAgICAgICAgIHBs
dWdpbkxvZyhpbnN0YW5jZSwgImtleVVwICclYyciLCBrZXlFdmVudFRvQ2hhcigmZXZ0LT54a2V5
KSk7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgY2FzZSBLZXlQcmVzczoKLSAgICAgICAg
ICAgIHBsdWdpbkxvZyhpbnN0YW5jZSwgImtleURvd24gJyVjJyIsIGV2dC0+eGtleS5rZXljb2Rl
KTsKKyAgICAgICAgICAgIHBsdWdpbkxvZyhpbnN0YW5jZSwgImtleURvd24gJyVjJyIsIGtleUV2
ZW50VG9DaGFyKCZldnQtPnhrZXkpKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNl
IE1vdGlvbk5vdGlmeToKICAgICAgICAgY2FzZSBFbnRlck5vdGlmeToKLS0gCjEuNy4zLjIKCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>