49925 2010-11-22 10:36:35 -0800 Simplify makeprop.pl 2010-11-24 07:52:19 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 49922 1 paroga paroga abecsi commit-queue ossy oldest_to_newest 312404 0 paroga 2010-11-22 10:36:35 -0800 see patch 312409 1 74573 paroga 2010-11-22 10:45:37 -0800 Created attachment 74573 Patch 312776 2 abecsi 2010-11-23 05:13:59 -0800 LGTM, thanks for doing this! Ossy, could you review, please? 312778 3 abecsi 2010-11-23 05:17:08 -0800 Sorry, there is no explicit dependency. 312783 4 paroga 2010-11-23 05:21:53 -0800 (In reply to comment #3) > Sorry, there is no explicit dependency. Not sure. IMHO CSSPropertyNames.cpp needs HashTools.h to compile, but if a buildsystem realy needs it, it would fail too at the moment. So bug 49922 will "fix" this missing dependency. ;-) 312788 5 abecsi 2010-11-23 05:33:57 -0800 (In reply to comment #4) > (In reply to comment #3) > > Sorry, there is no explicit dependency. > Not sure. IMHO CSSPropertyNames.cpp needs HashTools.h to compile, but if a buildsystem realy needs it, it would fail too at the moment. So bug 49922 will "fix" this missing dependency. ;-) Actually the file still exists in the EWS' build tree because of the incremental build, that's why it builds currently and it will still exist after the other patch, so this could cause troubles without a clean build. And also, please remove the dependency to CSSPropertyNamesHash.h from GNUmakefile.am: ./WebCore/GNUmakefile.am:97: DerivedSources/WebCore/CSSPropertyNamesHash.h \ ./WebCore/GNUmakefile.am:4554:DerivedSources/WebCore/CSSPropertyNamesHash.h: DerivedSources/WebCore/CSSPropertyNames.cpp 312789 6 abecsi 2010-11-23 05:36:23 -0800 > And also, please remove the dependency to CSSPropertyNamesHash.h from GNUmakefile.am. Ah, you did it, sorry. 312793 7 paroga 2010-11-23 05:46:44 -0800 (In reply to comment #5) > Actually the file still exists in the EWS' build tree because of the incremental build, that's why it builds currently and it will still exist after the other patch, so this could cause troubles without a clean build. AFAIK all buildsystem generate all files before they compile, so that's not a real problem IMHO. But that the files still exists in the DerivedSources directory is a general problem with incremental builds :-(. (In reply to comment #6) > > And also, please remove the dependency to CSSPropertyNamesHash.h from GNUmakefile.am. > > Ah, you did it, sorry. Yes ;-) 313275 8 74573 commit-queue 2010-11-24 06:58:44 -0800 Comment on attachment 74573 Patch Rejecting patch 74573 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 1 ERROR: Working directory has local commits, pass --force-clean to continue. Full output: http://queues.webkit.org/results/6299043 313298 9 74573 commit-queue 2010-11-24 07:52:14 -0800 Comment on attachment 74573 Patch Clearing flags on attachment: 74573 Committed r72672: <http://trac.webkit.org/changeset/72672> 313299 10 commit-queue 2010-11-24 07:52:19 -0800 All reviewed patches have been landed. Closing bug. 74573 2010-11-22 10:45:37 -0800 2010-11-24 07:52:14 -0800 Patch bug-49925.patch text/plain 4322 paroga ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODcyMTQ0My4uZDkwMjE4MyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0xMS0yMiAgUGF0cmljayBHYW5z dGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBTaW1wbGlmeSBtYWtlcHJvcC5wbAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDk5MjUKKworICAgICAgICBEb24ndCBn ZW5lcmF0ZSBDU1NQcm9wZXJ0eU5hbWVzSGFzaC5oLgorICAgICAgICBJbnN0ZWFkIGdlbmVyYXRl IENTU1Byb3BlcnR5TmFtZXMgZGlyZWN0bHkuCisKKyAgICAgICAgKiBHTlVtYWtlZmlsZS5hbTog UmVtb3ZlZCBydWxlIGZvciBDU1NQcm9wZXJ0eU5hbWVzSGFzaC5oLgorICAgICAgICAqIGNzcy9t YWtlcHJvcC5wbDoKKwogMjAxMC0xMS0yMSAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Vi a2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBDc2FiYSBPc3p0cm9nb27DoWMuCmRpZmYg LS1naXQgYS9XZWJDb3JlL0dOVW1ha2VmaWxlLmFtIGIvV2ViQ29yZS9HTlVtYWtlZmlsZS5hbQpp bmRleCBlNWZlMmE3Li5iNTlhZWMxIDEwMDY0NAotLS0gYS9XZWJDb3JlL0dOVW1ha2VmaWxlLmFt CisrKyBiL1dlYkNvcmUvR05VbWFrZWZpbGUuYW0KQEAgLTk0LDcgKzk0LDYgQEAgd2ViY29yZV9i dWlsdF9zb3VyY2VzICs9IFwKIAlEZXJpdmVkU291cmNlcy9XZWJDb3JlL0NTU0dyYW1tYXIuaCBc CiAJRGVyaXZlZFNvdXJjZXMvV2ViQ29yZS9DU1NQcm9wZXJ0eU5hbWVzLmggXAogCURlcml2ZWRT b3VyY2VzL1dlYkNvcmUvQ1NTUHJvcGVydHlOYW1lcy5jcHAgXAotCURlcml2ZWRTb3VyY2VzL1dl YkNvcmUvQ1NTUHJvcGVydHlOYW1lc0hhc2guaCBcCiAJRGVyaXZlZFNvdXJjZXMvV2ViQ29yZS9D U1NWYWx1ZUtleXdvcmRzLmggXAogCURlcml2ZWRTb3VyY2VzL1dlYkNvcmUvQ1NTVmFsdWVLZXl3 b3Jkcy5jcHAgXAogCURlcml2ZWRTb3VyY2VzL1dlYkNvcmUvQ1NTVmFsdWVLZXl3b3Jkc0hhc2gu aCBcCkBAIC00NTI0LDcgKzQ1MjMsNiBAQCBGRUFUVVJFX0RFRklORVMgKz0gRU5BQkxFX0JMT0I9 MQogd2ViY29yZV9jcHBmbGFncyArPSAtREVOQUJMRV9CTE9CPTEKIGVuZGlmICAjIEVORCBFTkFC TEVfQkxPQgogCi1EZXJpdmVkU291cmNlcy9XZWJDb3JlL0NTU1Byb3BlcnR5TmFtZXNIYXNoLmg6 IERlcml2ZWRTb3VyY2VzL1dlYkNvcmUvQ1NTUHJvcGVydHlOYW1lcy5jcHAKIERlcml2ZWRTb3Vy Y2VzL1dlYkNvcmUvQ1NTUHJvcGVydHlOYW1lcy5jcHA6IERlcml2ZWRTb3VyY2VzL1dlYkNvcmUv Q1NTUHJvcGVydHlOYW1lcy5oCiBEZXJpdmVkU291cmNlcy9XZWJDb3JlL0NTU1Byb3BlcnR5TmFt ZXMuaDogJChXRUJDT1JFX0NTU19QUk9QRVJUWV9OQU1FUykgJChXZWJDb3JlKS9jc3MvbWFrZXBy b3AucGwKIAlpZiBzb3J0ICQoV0VCQ09SRV9DU1NfUFJPUEVSVFlfTkFNRVMpIHwgdW5pcSAtZCB8 IGdyZXAgLUUgJ15bXiNdJzsgdGhlbiBlY2hvICdEdXBsaWNhdGUgdmFsdWUhJzsgZXhpdCAxOyBm aQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9jc3MvbWFrZXByb3AucGwgYi9XZWJDb3JlL2Nzcy9tYWtl cHJvcC5wbAppbmRleCA2NGY1YTZiLi5kMzk0NzM5IDEwMDY0NAotLS0gYS9XZWJDb3JlL2Nzcy9t YWtlcHJvcC5wbAorKysgYi9XZWJDb3JlL2Nzcy9tYWtlcHJvcC5wbApAQCAtMzksNiArMzksMTAg QEAgcHJpbnQgR1BFUkYgPDwgIkVPRiI7CiAlewogLyogVGhpcyBmaWxlIGlzIGF1dG9tYXRpY2Fs bHkgZ2VuZXJhdGVkIGZyb20gQ1NTUHJvcGVydHlOYW1lcy5pbiBieSBtYWtlcHJvcCwgZG8gbm90 IGVkaXQgKi8KICNpbmNsdWRlIFwiQ1NTUHJvcGVydHlOYW1lcy5oXCIKKyNpbmNsdWRlIFwiSGFz aFRvb2xzLmhcIgorI2luY2x1ZGUgPHN0cmluZy5oPgorCituYW1lc3BhY2UgV2ViQ29yZSB7CiAl fQogJXN0cnVjdC10eXBlCiBzdHJ1Y3QgUHJvcGVydHk7CkBAIC01MSw3ICs1NSw2IEBAIHN0cnVj dCBQcm9wZXJ0eTsKICVkZWZpbmUgbG9va3VwLWZ1bmN0aW9uLW5hbWUgZmluZFByb3BlcnR5SW1w bAogJWRlZmluZSBoYXNoLWZ1bmN0aW9uLW5hbWUgcHJvcGVyeV9oYXNoX2Z1bmN0aW9uCiAlZGVm aW5lIHdvcmQtYXJyYXktbmFtZSBwcm9wZXJ0eV93b3JkbGlzdAotJWluY2x1ZGVzCiAlZW51bQog JSUKIEVPRgpAQCAtNjEsOCArNjQsMjYgQEAgZm9yZWFjaCBteSAkbmFtZSAoQG5hbWVzKSB7CiAg ICRpZCA9fiBzLyheW14tXSl8LSguKS91YygkMXx8JDIpL2dlOwogICBwcmludCBHUEVSRiAkbmFt ZSAuICIsIENTU1Byb3BlcnR5IiAuICRpZCAuICJcbiI7CiB9Ci1wcmludCBHUEVSRiAiJSVcbiI7 Ci1jbG9zZSBHUEVSRjsKKworcHJpbnQgR1BFUkY8PCAiRU9GIjsKKyUlCitjb25zdCBQcm9wZXJ0 eSogZmluZFByb3BlcnR5KHJlZ2lzdGVyIGNvbnN0IGNoYXIqIHN0ciwgcmVnaXN0ZXIgdW5zaWdu ZWQgaW50IGxlbikKK3sKKyAgICByZXR1cm4gQ1NTUHJvcGVydHlOYW1lc0hhc2g6OmZpbmRQcm9w ZXJ0eUltcGwoc3RyLCBsZW4pOworfQorCitjb25zdCBjaGFyKiBnZXRQcm9wZXJ0eU5hbWUoQ1NT UHJvcGVydHlJRCBpZCkKK3sKKyAgICBpZiAoaWQgPCBmaXJzdENTU1Byb3BlcnR5KQorICAgICAg ICByZXR1cm4gMDsKKyAgICBpbnQgaW5kZXggPSBpZCAtIGZpcnN0Q1NTUHJvcGVydHk7CisgICAg aWYgKGluZGV4ID49IG51bUNTU1Byb3BlcnRpZXMpCisgICAgICAgIHJldHVybiAwOworICAgIHJl dHVybiBwcm9wZXJ0eU5hbWVTdHJpbmdzW2luZGV4XTsKK30KKworfSAvLyBuYW1lc3BhY2UgV2Vi Q29yZQorRU9GCiAKIG9wZW4gSEVBREVSLCAiPkNTU1Byb3BlcnR5TmFtZXMuaCIgfHwgZGllICJD b3VsZCBub3Qgb3BlbiBDU1NQcm9wZXJ0eU5hbWVzLmggZm9yIHdyaXRpbmciOwogcHJpbnQgSEVB REVSIDw8ICJFT0YiOwpAQCAtMTE2LDQ2ICsxMzcsNCBAQCBFT0YKIAogY2xvc2UgSEVBREVSOwog Ci1zeXN0ZW0oImdwZXJmIC0ta2V5LXBvc2l0aW9ucz1cIipcIiAtRCAtbiAtcyAyIENTU1Byb3Bl cnR5TmFtZXMuZ3BlcmYgPiBDU1NQcm9wZXJ0eU5hbWVzSGFzaC5oIikgPT0gMCB8fCBkaWUgImNh bGxpbmcgZ3BlcmYgZmFpbGVkOiAkPyI7Ci0KLW9wZW4gQywgIj4+Q1NTUHJvcGVydHlOYW1lc0hh c2guaCIgfHwgZGllICJDb3VsZCBub3Qgb3BlbiBDU1NQcm9wZXJ0eU5hbWVzSGFzaC5oIGZvciB3 cml0aW5nIjsKLXByaW50IEMgPDwgIkVPRiI7Ci0KLUVPRgotCi1jbG9zZSBDOwotCi1teSAkcHJv cGVydHlOYW1lc0ltcGwgPSAiQ1NTUHJvcGVydHlOYW1lcy5jcHAiOwotCi1vcGVuIFBST1BFUlRZ TkFNRVMsICI+JHByb3BlcnR5TmFtZXNJbXBsIiB8fCBkaWUgIkNvdWxkIG5vdCBvcGVuICRwcm9w ZXJ0eU5hbWVzSW1wbCBmb3Igd3JpdGluZyI7Ci1wcmludCBQUk9QRVJUWU5BTUVTIDw8ICJFT0Yi OwotLyogVGhpcyBmaWxlIGlzIGF1dG9tYXRpY2FsbHkgZ2VuZXJhdGVkIGJ5IG1ha2UtaGFzaC10 b29scy5wbCwgZG8gbm90IGVkaXQgKi8KLQotCi0jaW5jbHVkZSAiQ1NTUHJvcGVydHlOYW1lcy5o IgotI2luY2x1ZGUgIkhhc2hUb29scy5oIgotCi1uYW1lc3BhY2UgV2ViQ29yZSB7Ci0jaW5jbHVk ZSAiQ1NTUHJvcGVydHlOYW1lc0hhc2guaCIKLQotY29uc3QgUHJvcGVydHkqIGZpbmRQcm9wZXJ0 eSAocmVnaXN0ZXIgY29uc3QgY2hhciogc3RyLCByZWdpc3RlciB1bnNpZ25lZCBpbnQgbGVuKQot ewotICAgIHJldHVybiBDU1NQcm9wZXJ0eU5hbWVzSGFzaDo6ZmluZFByb3BlcnR5SW1wbChzdHIs IGxlbik7Ci19Ci0KLWNvbnN0IGNoYXIqIGdldFByb3BlcnR5TmFtZShDU1NQcm9wZXJ0eUlEIGlk KQotewotICAgIGlmIChpZCA8IGZpcnN0Q1NTUHJvcGVydHkpCi0gICAgICAgIHJldHVybiAwOwot ICAgIGludCBpbmRleCA9IGlkIC0gZmlyc3RDU1NQcm9wZXJ0eTsKLSAgICBpZiAoaW5kZXggPj0g bnVtQ1NTUHJvcGVydGllcykKLSAgICAgICAgcmV0dXJuIDA7Ci0gICAgcmV0dXJuIHByb3BlcnR5 TmFtZVN0cmluZ3NbaW5kZXhdOwotfQotCi19IC8vIG5hbWVzcGFjZSBXZWJDb3JlCi0KLUVPRgot Ci1jbG9zZSBQUk9QRVJUWU5BTUVTOwotCitzeXN0ZW0oImdwZXJmIC0ta2V5LXBvc2l0aW9ucz1c IipcIiAtRCAtbiAtcyAyIENTU1Byb3BlcnR5TmFtZXMuZ3BlcmYgPiBDU1NQcm9wZXJ0eU5hbWVz LmNwcCIpID09IDAgfHwgZGllICJjYWxsaW5nIGdwZXJmIGZhaWxlZDogJD8iOwo=