<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>49924</bug_id>
          
          <creation_ts>2010-11-22 10:34:49 -0800</creation_ts>
          <short_desc>[NRWT] Opening png sometimes fails on Windows</short_desc>
          <delta_ts>2010-11-22 11:58:50 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Hayato Ito">hayato</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>dpranke</cc>
    
    <cc>tony</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>312402</commentid>
    <comment_count>0</comment_count>
    <who name="Hayato Ito">hayato</who>
    <bug_when>2010-11-22 10:34:49 -0800</bug_when>
    <thetext>On WebKit-Win build bot, new-run-webkit-tests sometimes fails.

http://build.chromium.org/p/chromium/builders/Webkit%20Win/builds/1912/steps/webkit_tests/logs/stdio

Traceback (most recent call last):
  File &quot;e:\b\build\slave\Webkit_Win\build\src\third_party\WebKit\WebKitTools\Scripts\new-run-webkit-tests&quot;, line 38, in &lt;module&gt;
    sys.exit(run_webkit_tests.main())
  File &quot;e:\b\build\slave\Webkit_Win\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\run_webkit_tests.py&quot;, line 1647, in main
    return run(port_obj, options, args)
  File &quot;e:\b\build\slave\Webkit_Win\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\run_webkit_tests.py&quot;, line 1346, in run
    num_unexpected_results = test_runner.run(result_summary)
  File &quot;e:\b\build\slave\Webkit_Win\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\run_webkit_tests.py&quot;, line 732, in run
    self._run_tests(self._test_files_list, result_summary))
  File &quot;e:\b\build\slave\Webkit_Win\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\run_webkit_tests.py&quot;, line 612, in _run_tests
    result_summary)
  File &quot;e:\b\build\slave\Webkit_Win\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\layout_package\dump_render_tree_thread.py&quot;, line 347, in _covered_run
    self._run(test_runner=None, result_summary=None)
  File &quot;e:\b\build\slave\Webkit_Win\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\layout_package\dump_render_tree_thread.py&quot;, line 439, in _run
    result = self._run_test_in_this_thread(test_input)
  File &quot;e:\b\build\slave\Webkit_Win\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\layout_package\dump_render_tree_thread.py&quot;, line 535, in _run_test_in_this_thread
    self._driver, self._name)
  File &quot;e:\b\build\slave\Webkit_Win\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\layout_package\dump_render_tree_thread.py&quot;, line 162, in _run_single_test
    test_output = driver.run_test(uri, test_input.timeout, image_hash_to_driver)
  File &quot;e:\b\build\slave\Webkit_Win\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\port\chromium.py&quot;, line 509, in run_test
    &apos;&apos;.join(output), self._output_image(), actual_checksum,
  File &quot;e:\b\build\slave\Webkit_Win\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\port\chromium.py&quot;, line 452, in _output_image
    with open(png_path, &apos;rb&apos;) as image_file:
IOError: [Errno 13] Permission denied: &apos;e:\\b\\build\\slave\\Webkit_Win\\build\\src\\webkit\\Release\\..\\../../layout-test-results\\png_result2.png&apos;
No handlers could be found for logger &quot;webkitpy.common.system&quot;
program finished with exit code 1
elapsedTime=469.283000</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>312405</commentid>
    <comment_count>1</comment_count>
      <attachid>74572</attachid>
    <who name="Hayato Ito">hayato</who>
    <bug_when>2010-11-22 10:38:53 -0800</bug_when>
    <thetext>Created attachment 74572
retry-opening</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>312413</commentid>
    <comment_count>2</comment_count>
      <attachid>74572</attachid>
    <who name="Tony Chang">tony</who>
    <bug_when>2010-11-22 10:47:57 -0800</bug_when>
    <thetext>Comment on attachment 74572
retry-opening

View in context: https://bugs.webkit.org/attachment.cgi?id=74572&amp;action=review

&gt; WebKitTools/Scripts/webkitpy/layout_tests/port/chromium.py:464
&gt; +            except IOError:

Can we catch the exact IO error using errno?

&gt; WebKitTools/Scripts/webkitpy/layout_tests/port/chromium.py:466
&gt; +                time.sleep(timeout_seconds / retry_num)
&gt; +                continue

I would probably try more frequently than every 500ms, maybe increase retry_num to 50?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>312437</commentid>
    <comment_count>3</comment_count>
      <attachid>74578</attachid>
    <who name="Hayato Ito">hayato</who>
    <bug_when>2010-11-22 11:41:00 -0800</bug_when>
    <thetext>Created attachment 74578
retry-opening-increase-retry_num-use-errno</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>312439</commentid>
    <comment_count>4</comment_count>
    <who name="Hayato Ito">hayato</who>
    <bug_when>2010-11-22 11:43:34 -0800</bug_when>
    <thetext>Thank you for the review.
I addressed your comments.

(In reply to comment #2)
&gt; (From update of attachment 74572 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=74572&amp;action=review
&gt; 
&gt; &gt; WebKitTools/Scripts/webkitpy/layout_tests/port/chromium.py:464
&gt; &gt; +            except IOError:
&gt; 
&gt; Can we catch the exact IO error using errno?

Nice point. Done.

&gt; 
&gt; &gt; WebKitTools/Scripts/webkitpy/layout_tests/port/chromium.py:466
&gt; &gt; +                time.sleep(timeout_seconds / retry_num)
&gt; &gt; +                continue
&gt; 
&gt; I would probably try more frequently than every 500ms, maybe increase retry_num to 50?

Done.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>312440</commentid>
    <comment_count>5</comment_count>
      <attachid>74578</attachid>
    <who name="Tony Chang">tony</who>
    <bug_when>2010-11-22 11:44:06 -0800</bug_when>
    <thetext>Comment on attachment 74578
retry-opening-increase-retry_num-use-errno

Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>312445</commentid>
    <comment_count>6</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2010-11-22 11:53:10 -0800</bug_when>
    <thetext>change LGTM as well.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>312447</commentid>
    <comment_count>7</comment_count>
      <attachid>74578</attachid>
    <who name="Hayato Ito">hayato</who>
    <bug_when>2010-11-22 11:58:41 -0800</bug_when>
    <thetext>Comment on attachment 74578
retry-opening-increase-retry_num-use-errno

Clearing flags on attachment: 74578

Committed r72547: &lt;http://trac.webkit.org/changeset/72547&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>312448</commentid>
    <comment_count>8</comment_count>
    <who name="Hayato Ito">hayato</who>
    <bug_when>2010-11-22 11:58:50 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>74572</attachid>
            <date>2010-11-22 10:38:53 -0800</date>
            <delta_ts>2010-11-22 11:40:54 -0800</delta_ts>
            <desc>retry-opening</desc>
            <filename>bug-49924-20101123033851.patch</filename>
            <type>text/plain</type>
            <size>2119</size>
            <attacher name="Hayato Ito">hayato</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv
ZwppbmRleCBlNjcxYWIwNDdiMWZmYWZmYTAyY2UyZjg4MTZkODUwNGMwMjRjMzgzLi41NmVjMWEy
NDE4M2M3OGNkYmU3NDJiZDlkM2NhNDU3NzYxMTdkNWIwIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s
cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK
KzIwMTAtMTEtMjIgIEhheWF0byBJdG8gIDxoYXlhdG9AY2hyb21pdW0ub3JnPgorCisgICAgICAg
IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtOUldUXSBSZXRyeSBhIGZl
dyB0aW1lcyBpbiByZWFkaW5nIGEgcG5nIGltYWdlIHRvIGF2b2lkIGEgcmFjZSBjb25kaXRpb24u
CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ5OTI0
CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVt
LnB5OgorCiAyMDEwLTExLTE5ICBLaW51a28gWWFzdWRhICA8a2ludWtvQGNocm9taXVtLm9yZz4K
IAogICAgICAgICBSZXZpZXdlZCBieSBPamFuIFZhZmFpLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9v
bHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bS5weSBiL1dlYktp
dFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW0ucHkKaW5k
ZXggMzE0OTI5MDk5YWMxMzZkMjg2MTJlM2NjZjc4MTcyMTkwZGY4ZmQzMi4uYTI3Njg3OWZiNDc1
NDE3MzgzY2I0OWJkMDYxNWU4MDBjNDM0OGUwZiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2Ny
aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bS5weQorKysgYi9XZWJLaXRU
b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtLnB5CkBAIC00
NTQsNiArNDU0LDE4IEBAIGNsYXNzIENocm9taXVtRHJpdmVyKGJhc2UuRHJpdmVyKToKICAgICAg
ICAgZWxzZToKICAgICAgICAgICAgIHJldHVybiBOb25lCiAKKyAgICBkZWYgX291dHB1dF9pbWFn
ZV93aXRoX3JldHJ5KHNlbGYpOgorICAgICAgICAjIFJldHJ5IGEgZmV3IG1vcmUgdGltZXMgYmVj
YXVzZSBvcGVuKCkgc29tZXRpbWVzIGZhaWxzIG9uIFdpbmRvd3MuCisgICAgICAgIHJldHJ5X251
bSA9IDEwCisgICAgICAgIHRpbWVvdXRfc2Vjb25kcyA9IDUuMAorICAgICAgICBmb3IgaSBpbiBy
YW5nZShyZXRyeV9udW0pOgorICAgICAgICAgICAgdHJ5OgorICAgICAgICAgICAgICAgIHJldHVy
biBzZWxmLl9vdXRwdXRfaW1hZ2UoKQorICAgICAgICAgICAgZXhjZXB0IElPRXJyb3I6CisgICAg
ICAgICAgICAgICAgdGltZS5zbGVlcCh0aW1lb3V0X3NlY29uZHMgLyByZXRyeV9udW0pCisgICAg
ICAgICAgICAgICAgY29udGludWUKKyAgICAgICAgcmV0dXJuIHNlbGYuX291dHB1dF9pbWFnZSgp
CisKICAgICBkZWYgcnVuX3Rlc3Qoc2VsZiwgdXJpLCB0aW1lb3V0bXMsIGNoZWNrc3VtKToKICAg
ICAgICAgb3V0cHV0ID0gW10KICAgICAgICAgZXJyb3IgPSBbXQpAQCAtNTA1LDkgKzUxNywxMCBA
QCBjbGFzcyBDaHJvbWl1bURyaXZlcihiYXNlLkRyaXZlcik6CiAKICAgICAgICAgICAgIChsaW5l
LCBjcmFzaCkgPSBzZWxmLl93cml0ZV9jb21tYW5kX2FuZF9yZWFkX2xpbmUoaW5wdXQ9Tm9uZSkK
IAorICAgICAgICBydW5fdGltZSA9IHRpbWUudGltZSgpIC0gc3RhcnRfdGltZQogICAgICAgICBy
ZXR1cm4gdGVzdF9vdXRwdXQuVGVzdE91dHB1dCgKLSAgICAgICAgICAgICcnLmpvaW4ob3V0cHV0
KSwgc2VsZi5fb3V0cHV0X2ltYWdlKCksIGFjdHVhbF9jaGVja3N1bSwKLSAgICAgICAgICAgIGNy
YXNoLCB0aW1lLnRpbWUoKSAtIHN0YXJ0X3RpbWUsIHRpbWVvdXQsICcnLmpvaW4oZXJyb3IpKQor
ICAgICAgICAgICAgJycuam9pbihvdXRwdXQpLCBzZWxmLl9vdXRwdXRfaW1hZ2Vfd2l0aF9yZXRy
eSgpLCBhY3R1YWxfY2hlY2tzdW0sCisgICAgICAgICAgICBjcmFzaCwgcnVuX3RpbWUsIHRpbWVv
dXQsICcnLmpvaW4oZXJyb3IpKQogCiAgICAgZGVmIHN0b3Aoc2VsZik6CiAgICAgICAgIGlmIHNl
bGYuX3Byb2M6Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>74578</attachid>
            <date>2010-11-22 11:41:00 -0800</date>
            <delta_ts>2010-11-22 11:58:41 -0800</delta_ts>
            <desc>retry-opening-increase-retry_num-use-errno</desc>
            <filename>bug-49924-20101123044057.patch</filename>
            <type>text/plain</type>
            <size>2383</size>
            <attacher name="Hayato Ito">hayato</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv
ZwppbmRleCBlNjcxYWIwNDdiMWZmYWZmYTAyY2UyZjg4MTZkODUwNGMwMjRjMzgzLi41NmVjMWEy
NDE4M2M3OGNkYmU3NDJiZDlkM2NhNDU3NzYxMTdkNWIwIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s
cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK
KzIwMTAtMTEtMjIgIEhheWF0byBJdG8gIDxoYXlhdG9AY2hyb21pdW0ub3JnPgorCisgICAgICAg
IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtOUldUXSBSZXRyeSBhIGZl
dyB0aW1lcyBpbiByZWFkaW5nIGEgcG5nIGltYWdlIHRvIGF2b2lkIGEgcmFjZSBjb25kaXRpb24u
CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ5OTI0
CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVt
LnB5OgorCiAyMDEwLTExLTE5ICBLaW51a28gWWFzdWRhICA8a2ludWtvQGNocm9taXVtLm9yZz4K
IAogICAgICAgICBSZXZpZXdlZCBieSBPamFuIFZhZmFpLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9v
bHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bS5weSBiL1dlYktp
dFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW0ucHkKaW5k
ZXggMzE0OTI5MDk5YWMxMzZkMjg2MTJlM2NjZjc4MTcyMTkwZGY4ZmQzMi4uNWJmYjhmZmIzYmRl
YjU2MWVkYjNjZTE4N2U3YTdhZTM2OGIwODhkZSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2Ny
aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bS5weQorKysgYi9XZWJLaXRU
b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtLnB5CkBAIC0z
Miw2ICszMiw3IEBACiBmcm9tIF9fZnV0dXJlX18gaW1wb3J0IHdpdGhfc3RhdGVtZW50CiAKIGlt
cG9ydCBjb2RlY3MKK2ltcG9ydCBlcnJubwogaW1wb3J0IGxvZ2dpbmcKIGltcG9ydCBvcwogaW1w
b3J0IHJlCkBAIC00NTQsNiArNDU1LDIxIEBAIGNsYXNzIENocm9taXVtRHJpdmVyKGJhc2UuRHJp
dmVyKToKICAgICAgICAgZWxzZToKICAgICAgICAgICAgIHJldHVybiBOb25lCiAKKyAgICBkZWYg
X291dHB1dF9pbWFnZV93aXRoX3JldHJ5KHNlbGYpOgorICAgICAgICAjIFJldHJ5IGEgZmV3IG1v
cmUgdGltZXMgYmVjYXVzZSBvcGVuKCkgc29tZXRpbWVzIGZhaWxzIG9uIFdpbmRvd3MsCisgICAg
ICAgICMgcmFpc2luZyAiSU9FcnJvcjogW0Vycm5vIDEzXSBQZXJtaXNzaW9uIGRlbmllZDoiCisg
ICAgICAgIHJldHJ5X251bSA9IDUwCisgICAgICAgIHRpbWVvdXRfc2Vjb25kcyA9IDUuMAorICAg
ICAgICBmb3IgaSBpbiByYW5nZShyZXRyeV9udW0pOgorICAgICAgICAgICAgdHJ5OgorICAgICAg
ICAgICAgICAgIHJldHVybiBzZWxmLl9vdXRwdXRfaW1hZ2UoKQorICAgICAgICAgICAgZXhjZXB0
IElPRXJyb3IsIGU6CisgICAgICAgICAgICAgICAgaWYgZS5lcnJubyA9PSBlcnJuby5FQUNDRVM6
CisgICAgICAgICAgICAgICAgICAgIHRpbWUuc2xlZXAodGltZW91dF9zZWNvbmRzIC8gcmV0cnlf
bnVtKQorICAgICAgICAgICAgICAgIGVsc2U6CisgICAgICAgICAgICAgICAgICAgIHJhaXNlIGUK
KyAgICAgICAgcmV0dXJuIHNlbGYuX291dHB1dF9pbWFnZSgpCisKICAgICBkZWYgcnVuX3Rlc3Qo
c2VsZiwgdXJpLCB0aW1lb3V0bXMsIGNoZWNrc3VtKToKICAgICAgICAgb3V0cHV0ID0gW10KICAg
ICAgICAgZXJyb3IgPSBbXQpAQCAtNTA1LDkgKzUyMSwxMCBAQCBjbGFzcyBDaHJvbWl1bURyaXZl
cihiYXNlLkRyaXZlcik6CiAKICAgICAgICAgICAgIChsaW5lLCBjcmFzaCkgPSBzZWxmLl93cml0
ZV9jb21tYW5kX2FuZF9yZWFkX2xpbmUoaW5wdXQ9Tm9uZSkKIAorICAgICAgICBydW5fdGltZSA9
IHRpbWUudGltZSgpIC0gc3RhcnRfdGltZQogICAgICAgICByZXR1cm4gdGVzdF9vdXRwdXQuVGVz
dE91dHB1dCgKLSAgICAgICAgICAgICcnLmpvaW4ob3V0cHV0KSwgc2VsZi5fb3V0cHV0X2ltYWdl
KCksIGFjdHVhbF9jaGVja3N1bSwKLSAgICAgICAgICAgIGNyYXNoLCB0aW1lLnRpbWUoKSAtIHN0
YXJ0X3RpbWUsIHRpbWVvdXQsICcnLmpvaW4oZXJyb3IpKQorICAgICAgICAgICAgJycuam9pbihv
dXRwdXQpLCBzZWxmLl9vdXRwdXRfaW1hZ2Vfd2l0aF9yZXRyeSgpLCBhY3R1YWxfY2hlY2tzdW0s
CisgICAgICAgICAgICBjcmFzaCwgcnVuX3RpbWUsIHRpbWVvdXQsICcnLmpvaW4oZXJyb3IpKQog
CiAgICAgZGVmIHN0b3Aoc2VsZik6CiAgICAgICAgIGlmIHNlbGYuX3Byb2M6Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>