49919 2010-11-22 09:35:57 -0800 [Qt] GraphicsContext: Clean up Qt/WebCore type conversion functions 2010-11-24 07:49:23 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 kling rhodovan.u-szeged oldest_to_newest 312381 0 kling 2010-11-22 09:35:57 -0800 There are a bunch of conversion functions between Qt and WebCore types at the top of GraphicsContext.cpp All cases should be handled in all functions, instead of having a qWarning() and returning some arbitrary "sane default". Also, Qt::MiterJoin shouldn't be used anywhere (it's currently impossibly returned by toQtLineJoin().) 313274 1 74755 rhodovan.u-szeged 2010-11-24 06:57:34 -0800 Created attachment 74755 Patch 313276 2 74755 kling 2010-11-24 06:58:56 -0800 Comment on attachment 74755 Patch LGTM 313296 3 kling 2010-11-24 07:49:23 -0800 Landed in <http://trac.webkit.org/changeset/72668> 74755 2010-11-24 06:57:34 -0800 2010-11-24 06:58:56 -0800 Patch webcoreVSqt.patch text/plain 2703 rhodovan.u-szeged SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MjY2NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjMgQEAKKzIwMTAtMTEtMjQgIFJlbmF0YSBIb2RvdmFuICA8cmVuaUBpbmYudS1z emVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW1F0XSBHcmFwaGljc0NvbnRleHQ6IENsZWFuIHVwIFF0L1dlYkNvcmUgdHlwZSBjb252ZXJz aW9uIGZ1bmN0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NDk5MTkKKworICAgICAgICBBZGQgQVNTRVJUX05PVF9SRUFDSEVEKCkgaWYgdGhlIGdp dmVuIFdlYkNvcmUgdHlwZSBkb2Vzbid0IGhhdmUgYW4gZXF1aXZhbGVudCB0eXBlIGluIFF0Lgor ICAgICAgICBBbHNvIGNoYW5nZSB0aGUgcmV0dXJuIHZhbHVlIG9mIHRvUXRMaW5lSm9pbigpIGZy b20gUXQ6Ok1pdGVySm9pbiB0byB0aGUgZGVmYXVsdCBRdDo6U3ZnTWl0ZXJKb2luLAorICAgICAg ICBiZWNhdXNlIHRoZSBwcmV2aW91cyBvbmUgZG9lc24ndCB3b3JrIGN1cnJlbnRseS4KKworICAg ICAgICBObyBuZXcgdGVzdCBpcyBuZWVkZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy9xdC9HcmFwaGljc0NvbnRleHRRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0Nv bnRleHQ6OnRvUXRDb21wb3NpdGlvbk1vZGUpOgorICAgICAgICAoV2ViQ29yZTo6dG9RdExpbmVD YXApOgorICAgICAgICAoV2ViQ29yZTo6dG9RdExpbmVKb2luKToKKyAgICAgICAgKFdlYkNvcmU6 OnRvUVBlblN0eWxlKToKKyAgICAgICAgKFdlYkNvcmU6OnRvUXRGaWxsUnVsZSk6CisKIDIwMTAt MTEtMjQgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgQ3NhYmEgT3N6dHJvZ29uw6FjLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHRRdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHRRdC5jcHAJKHJldmlzaW9uIDcyNjY0 KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHRRdC5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTEwNCw2ICsxMDQsOCBAQCBRUGFpbnRlcjo6Q29tcG9zaXRpb25N b2RlIEdyYXBoaWNzQ29udGV4CiAgICAgICAgIHJldHVybiBRUGFpbnRlcjo6Q29tcG9zaXRpb25N b2RlX1NvdXJjZU92ZXI7CiAgICAgY2FzZSBDb21wb3NpdGVQbHVzTGlnaHRlcjoKICAgICAgICAg cmV0dXJuIFFQYWludGVyOjpDb21wb3NpdGlvbk1vZGVfUGx1czsKKyAgICBkZWZhdWx0OgorICAg ICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAgICB9CiAKICAgICByZXR1cm4gUVBhaW50ZXI6 OkNvbXBvc2l0aW9uTW9kZV9Tb3VyY2VPdmVyOwpAQCAtMTE4LDYgKzEyMCw4IEBAIHN0YXRpYyBp bmxpbmUgUXQ6OlBlbkNhcFN0eWxlIHRvUXRMaW5lQ2EKICAgICAgICAgcmV0dXJuIFF0OjpSb3Vu ZENhcDsKICAgICBjYXNlIFNxdWFyZUNhcDoKICAgICAgICAgcmV0dXJuIFF0OjpTcXVhcmVDYXA7 CisgICAgZGVmYXVsdDoKKyAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgfQogCiAg ICAgcmV0dXJuIFF0OjpGbGF0Q2FwOwpAQCAtMTMyLDkgKzEzNiwxMSBAQCBzdGF0aWMgaW5saW5l IFF0OjpQZW5Kb2luU3R5bGUgdG9RdExpbmVKCiAgICAgICAgIHJldHVybiBRdDo6Um91bmRKb2lu OwogICAgIGNhc2UgQmV2ZWxKb2luOgogICAgICAgICByZXR1cm4gUXQ6OkJldmVsSm9pbjsKKyAg ICBkZWZhdWx0OgorICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAgICB9CiAKLSAgICBy ZXR1cm4gUXQ6Ok1pdGVySm9pbjsKKyAgICByZXR1cm4gUXQ6OlN2Z01pdGVySm9pbjsKIH0KIAog c3RhdGljIFF0OjpQZW5TdHlsZSB0b1FQZW5TdHlsZShTdHJva2VTdHlsZSBzdHlsZSkKQEAgLTE1 Miw4ICsxNTgsOSBAQCBzdGF0aWMgUXQ6OlBlblN0eWxlIHRvUVBlblN0eWxlKFN0cm9rZVN0CiAg ICAgY2FzZSBEYXNoZWRTdHJva2U6CiAgICAgICAgIHJldHVybiBRdDo6RGFzaExpbmU7CiAgICAg ICAgIGJyZWFrOworICAgIGRlZmF1bHQ6CisgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwog ICAgIH0KLSAgICBxV2FybmluZygiY291bGRuJ3QgcmVjb2duaXplIHRoZSBwZW4gc3R5bGUiKTsK ICAgICByZXR1cm4gUXQ6Ok5vUGVuOwogfQogCkBAIC0xNjQsOCArMTcxLDkgQEAgc3RhdGljIGlu bGluZSBRdDo6RmlsbFJ1bGUgdG9RdEZpbGxSdWxlKAogICAgICAgICByZXR1cm4gUXQ6Ok9kZEV2 ZW5GaWxsOwogICAgIGNhc2UgUlVMRV9OT05aRVJPOgogICAgICAgICByZXR1cm4gUXQ6OldpbmRp bmdGaWxsOworICAgIGRlZmF1bHQ6CisgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAg IH0KLSAgICBxRGVidWcoIlF0OiB1bnJlY29nbml6ZWQgd2luZCBydWxlISIpOwogICAgIHJldHVy biBRdDo6T2RkRXZlbkZpbGw7CiB9CiAK