49916 2010-11-22 09:24:27 -0800 [Qt] Leak with GraphicsContext::takeOwnershipOfPlatformContext() 2010-11-30 08:03:22 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 kling rhodovan.u-szeged oldest_to_newest 312376 0 kling 2010-11-22 09:24:27 -0800 The GraphicsContextPlatformPrivate destructor currently calls QPainter::end() before deleting the paint device. QPainter::device() will always return 0 after calling end(), so this code is leaking the device. 314356 1 75016 rhodovan.u-szeged 2010-11-29 04:43:02 -0800 Created attachment 75016 Patch 314970 2 rhodovan.u-szeged 2010-11-30 05:41:40 -0800 This is landed in <http://trac.webkit.org/changeset/72907>. 315053 3 75016 kbalazs 2010-11-30 07:58:23 -0800 Comment on attachment 75016 Patch Clearing flags. Please do not forget it next time! ;) 315058 4 rhodovan.u-szeged 2010-11-30 08:03:22 -0800 (In reply to comment #3) > (From update of attachment 75016 [details]) > Clearing flags. Please do not forget > it next time! ;) Thank you very much ;) 75016 2010-11-29 04:43:02 -0800 2010-11-30 07:58:23 -0800 Patch leakQtGC.patch text/plain 1315 rhodovan.u-szeged SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3Mjc4NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMTEtMjkgIFJlbmF0YSBIb2RvdmFuICA8cmVuaUBpbmYudS1z emVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW1F0XSBMZWFrIHdpdGggR3JhcGhpY3NDb250ZXh0Ojp0YWtlT3duZXJzaGlwT2ZQbGF0Zm9y bUNvbnRleHQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NDk5MTYKKworICAgICAgICBDaGFuZ2UgdGhlIG9yZGVyIG9mIGNhbGxpbmcgUVBhaW50ZXI6 OmRldmljZSgpIGFuZCBRUGFpbnRlcjo6ZW5kKCksIHNvIGRldmljZSgpIHdpbGwgcmV0dXJuIHdp dGggYSB2YWxpZCBkZXZpY2UuCisgICAgICAgIE5vIG5ldyB0ZXN0IGlzIG5lZWRlZC4KKworICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dFF0LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dFBsYXRmb3JtUHJpdmF0ZTo6fkdyYXBoaWNzQ29u dGV4dFBsYXRmb3JtUHJpdmF0ZSk6CisKIDIwMTAtMTEtMjYgIEFsZXhhbmRlciBQYXZsb3YgIDxh cGF2bG92QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFu LgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHRRdC5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0Nv bnRleHRRdC5jcHAJKHJldmlzaW9uIDcyNDc0KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9xdC9HcmFwaGljc0NvbnRleHRRdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI1MCw4ICsyNTAs OCBAQCBHcmFwaGljc0NvbnRleHRQbGF0Zm9ybVByaXZhdGU6On5HcmFwaGljCiAgICAgaWYgKCFw bGF0Zm9ybUNvbnRleHRJc093bmVkKQogICAgICAgICByZXR1cm47CiAKLSAgICBwYWludGVyLT5l bmQoKTsKICAgICBRUGFpbnREZXZpY2UqIGRldmljZSA9IHBhaW50ZXItPmRldmljZSgpOworICAg IHBhaW50ZXItPmVuZCgpOwogICAgIGRlbGV0ZSBwYWludGVyOwogICAgIGRlbGV0ZSBkZXZpY2U7 CiB9Cg==