49912 2010-11-22 08:50:31 -0800 [Qt] GraphicsContext::clip(path) should clip using winding fill 2010-12-02 04:42:51 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 kling rhodovan.u-szeged oldest_to_newest 312357 0 kling 2010-11-22 08:50:31 -0800 GraphicsContext::clip(path) should clip using winding fill, like all the other GraphicsContext implementations do. After this change, GraphicsContext::canvasClip(path) should be changed to simply call clip(path). 316081 1 75367 rhodovan.u-szeged 2010-12-02 04:21:39 -0800 Created attachment 75367 Patch 316082 2 75367 kling 2010-12-02 04:23:27 -0800 Comment on attachment 75367 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=75367&action=review r=me > WebCore/ChangeLog:8 > + GraphicsContext::clip(path) uses now winding fill and this function is called by s/uses now/now uses/ 316085 3 rhodovan.u-szeged 2010-12-02 04:42:29 -0800 This is landed in <http://trac.webkit.org/changeset/73123> Closing bug. 75367 2010-12-02 04:21:39 -0800 2010-12-02 04:42:51 -0800 Patch clipPath.patch text/plain 1763 rhodovan.u-szeged SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MzEyMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMTItMDIgIFJlbmF0YSBIb2RvdmFuICA8cmVuaUBpbmYudS1z emVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW1F0XSBHcmFwaGljc0NvbnRleHQ6OmNsaXAocGF0aCkgc2hvdWxkIGNsaXAgdXNpbmcgd2lu ZGluZyBmaWxsIAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NDk5MTIKKworICAgICAgICBHcmFwaGljc0NvbnRleHQ6OmNsaXAocGF0aCkgdXNlcyBub3cg d2luZGluZyBmaWxsIGFuZCB0aGlzIGZ1bmN0aW9uIGlzIGNhbGxlZCBieQorICAgICAgICBHcmFw aGljc0NvbnRleHQ6OmNhbnZhc0NsaXAocGF0aCkuCisKKyAgICAgICAgTm8gbmV3IHRlc3QgaXMg bmVlZGVkLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0 UXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0OjpjbGlwKToKKyAgICAg ICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDo6Y2FudmFzQ2xpcCk6CisKIDIwMTAtMTItMDEg IEFsZXhhbmRlciBQYXZsb3YgIDxhcGF2bG92QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBZdXJ5IFNlbWlraGF0c2t5LgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9xdC9HcmFwaGljc0NvbnRleHRRdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHRRdC5jcHAJKHJldmlzaW9uIDczMTIxKQorKysg V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHRRdC5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTExMzAsMTcgKzExMzAsMTQgQEAgdm9pZCBHcmFwaGljc0NvbnRleHQ6OmNs aXAoY29uc3QgUGF0aCYgcAogICAgIGlmIChwYWludGluZ0Rpc2FibGVkKCkpCiAgICAgICAgIHJl dHVybjsKIAotICAgIG1fZGF0YS0+cCgpLT5zZXRDbGlwUGF0aChwYXRoLnBsYXRmb3JtUGF0aCgp LCBRdDo6SW50ZXJzZWN0Q2xpcCk7CisgICAgUVBhaW50ZXJQYXRoIGNsaXBQYXRoID0gcGF0aC5w bGF0Zm9ybVBhdGgoKTsKKyAgICBjbGlwUGF0aC5zZXRGaWxsUnVsZShRdDo6V2luZGluZ0ZpbGwp OworICAgIG1fZGF0YS0+cCgpLT5zZXRDbGlwUGF0aChjbGlwUGF0aCwgUXQ6OkludGVyc2VjdENs aXApOwogfQogCiB2b2lkIEdyYXBoaWNzQ29udGV4dDo6Y2FudmFzQ2xpcChjb25zdCBQYXRoJiBw YXRoKQogewotICAgIGlmIChwYWludGluZ0Rpc2FibGVkKCkpCi0gICAgICAgIHJldHVybjsKLQot ICAgIFFQYWludGVyUGF0aCBjbGlwUGF0aCA9IHBhdGgucGxhdGZvcm1QYXRoKCk7Ci0gICAgY2xp cFBhdGguc2V0RmlsbFJ1bGUoUXQ6OldpbmRpbmdGaWxsKTsKLSAgICBtX2RhdGEtPnAoKS0+c2V0 Q2xpcFBhdGgoY2xpcFBhdGgsIFF0OjpJbnRlcnNlY3RDbGlwKTsKKyAgICBjbGlwKHBhdGgpOwog fQogCiB2b2lkIEdyYXBoaWNzQ29udGV4dDo6Y2xpcE91dChjb25zdCBQYXRoJiBwYXRoKQo=