49911 2010-11-22 08:02:00 -0800 Remove unimplemented (and untested) methods from IndexedDB 2010-11-23 03:14:38 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jorlow jorlow andreip commit-queue hans steveblock oldest_to_newest 312344 0 jorlow 2010-11-22 08:02:00 -0800 Remove unimplemented (and untested) methods from IndexedDB 312345 1 74556 jorlow 2010-11-22 08:03:29 -0800 Created attachment 74556 Patch 312346 2 jorlow 2010-11-22 08:04:19 -0800 These will be implemented properly soon, but until then we should remove them. .close(), for example, currently crashes in Chromium. 312506 3 andreip 2010-11-22 14:03:27 -0800 LGTM 312736 4 74556 commit-queue 2010-11-23 03:14:33 -0800 Comment on attachment 74556 Patch Clearing flags on attachment: 74556 Committed r72593: <http://trac.webkit.org/changeset/72593> 312737 5 commit-queue 2010-11-23 03:14:38 -0800 All reviewed patches have been landed. Closing bug. 74556 2010-11-22 08:03:29 -0800 2010-11-23 03:14:33 -0800 Patch bug-49911-20101122160327.patch text/plain 2298 jorlow ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODYxOWYyYzA3NWZmZDczYzRmOGJiNzY0NjdiYmM5OGEwYTM1OTUxMS4uOGNjOGQ4OTYzOWNlOTFi ZDRiMjU2YzAzNWI4MDVmNDJmNjhmNDE0ZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0xMS0yMiAgSmVy ZW15IE9ybG93ICA8am9ybG93QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgdW5pbXBsZW1lbnRlZCAoYW5kIHVudGVz dGVkKSBtZXRob2RzIGZyb20gSW5kZXhlZERCCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD00OTkxMQorCisgICAgICAgICogc3RvcmFnZS9JREJDdXJzb3Iu aWRsOgorICAgICAgICAqIHN0b3JhZ2UvSURCRGF0YWJhc2UuaWRsOgorCiAyMDEwLTExLTIyICBZ dXpvIEZ1amlzaGltYSAgPHl1em9AZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBE YW4gQmVybnN0ZWluLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9zdG9yYWdlL0lEQkN1cnNvci5pZGwg Yi9XZWJDb3JlL3N0b3JhZ2UvSURCQ3Vyc29yLmlkbAppbmRleCAwY2VmM2Y5Mzk1NTQ2ZTgwMDZm OTRiMTU4OWNiZjJhNjE5NjQ4YzU2Li4yZDI1MGQ1ZWEzMGNkOWNlMTQzM2FkZmE5OGRlNmMzZGMx ZmQyY2UwIDEwMDY0NAotLS0gYS9XZWJDb3JlL3N0b3JhZ2UvSURCQ3Vyc29yLmlkbAorKysgYi9X ZWJDb3JlL3N0b3JhZ2UvSURCQ3Vyc29yLmlkbApAQCAtMzcsMTEgKzM3LDEzIEBAIG1vZHVsZSBz dG9yYWdlIHsKICAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIElEQktleSBrZXk7CiAgICAgICAg IHJlYWRvbmx5IGF0dHJpYnV0ZSBJREJBbnkgdmFsdWU7CiAKLSAgICAgICAgW0NhbGxXaXRoPVNj cmlwdEV4ZWN1dGlvbkNvbnRleHRdIElEQlJlcXVlc3QgdXBkYXRlKGluIFNlcmlhbGl6ZWRTY3Jp cHRWYWx1ZSB2YWx1ZSkKLSAgICAgICAgICAgIHJhaXNlcyAoSURCRGF0YWJhc2VFeGNlcHRpb24p OworICAgICAgICAvLyBGSVhNRTogSW1wbGVtZW50LgorICAgICAgICAvL1tDYWxsV2l0aD1TY3Jp cHRFeGVjdXRpb25Db250ZXh0XSBJREJSZXF1ZXN0IHVwZGF0ZShpbiBTZXJpYWxpemVkU2NyaXB0 VmFsdWUgdmFsdWUpCisgICAgICAgIC8vICAgIHJhaXNlcyAoSURCRGF0YWJhc2VFeGNlcHRpb24p OwogICAgICAgICBbSW1wbGVtZW50YXRpb25GdW5jdGlvbj1jb250aW51ZUZ1bmN0aW9uXSB2b2lk IGNvbnRpbnVlKGluIFtPcHRpb25hbF0gSURCS2V5IGtleSkKICAgICAgICAgICAgIHJhaXNlcyAo SURCRGF0YWJhc2VFeGNlcHRpb24pOwotICAgICAgICBbQ2FsbFdpdGg9U2NyaXB0RXhlY3V0aW9u Q29udGV4dF0gSURCUmVxdWVzdCByZW1vdmUoKQotICAgICAgICAgICAgcmFpc2VzIChJREJEYXRh YmFzZUV4Y2VwdGlvbik7CisgICAgICAgIC8vIEZJWE1FOiBJbXBsZW1lbnQuCisgICAgICAgIC8v W0NhbGxXaXRoPVNjcmlwdEV4ZWN1dGlvbkNvbnRleHRdIElEQlJlcXVlc3QgcmVtb3ZlKCkKKyAg ICAgICAgLy8gICAgcmFpc2VzIChJREJEYXRhYmFzZUV4Y2VwdGlvbik7CiAgICAgfTsKIH0KZGlm ZiAtLWdpdCBhL1dlYkNvcmUvc3RvcmFnZS9JREJEYXRhYmFzZS5pZGwgYi9XZWJDb3JlL3N0b3Jh Z2UvSURCRGF0YWJhc2UuaWRsCmluZGV4IGI1MjljOWEwYTFhNGZmNmI5ODlmNThjMGRlMTUxMTBh YjliOGFmYmIuLjFhYjViMGI2MDFlNmE5NjMxMDdiNjdjNDVjMjcxMmQ5YmVjZDMwOTYgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvc3RvcmFnZS9JREJEYXRhYmFzZS5pZGwKKysrIGIvV2ViQ29yZS9zdG9y YWdlL0lEQkRhdGFiYXNlLmlkbApAQCAtNDAsNyArNDAsOCBAQCBtb2R1bGUgc3RvcmFnZSB7CiAg ICAgICAgICAgICByYWlzZXMgKElEQkRhdGFiYXNlRXhjZXB0aW9uKTsKICAgICAgICAgW0NhbGxX aXRoPVNjcmlwdEV4ZWN1dGlvbkNvbnRleHRdIElEQlRyYW5zYWN0aW9uIHRyYW5zYWN0aW9uIChp biBbT3B0aW9uYWxdIERPTVN0cmluZ0xpc3Qgc3RvcmVOYW1lcywgaW4gW09wdGlvbmFsXSB1bnNp Z25lZCBzaG9ydCBtb2RlLCBpbiBbT3B0aW9uYWxdIHVuc2lnbmVkIGxvbmcgdGltZW91dCkKICAg ICAgICAgICAgIHJhaXNlcyAoSURCRGF0YWJhc2VFeGNlcHRpb24pOwotICAgICAgICB2b2lkIGNs b3NlKCk7CisgICAgICAgIC8vIEZJWE1FOiBJbXBsZW1lbnQuCisgICAgICAgIC8vdm9pZCBjbG9z ZSgpOwogICAgIH07CiAKIH0K