49908 2010-11-22 06:55:47 -0800 [Qt] fast/regex/test1 fails on qt platform 2010-12-01 00:15:08 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All Linux RESOLVED FIXED P2 Normal --- 1 pvarga webkit-unassigned barraclough msaboff ossy zherczeg oldest_to_newest 312324 0 74549 pvarga 2010-11-22 06:55:47 -0800 Created attachment 74549 POC The fast/regex/test1 layout test is in the skipped list on qt platform. Reason is this test terminates when it prints a NUL character. The printing of the result of the matching of /abc\0def\00pqr\000xyz\0000AB/ pattern (Line: 455 in the test1-expected.txt) causes the problem. When it tries to print the first \0 in the result of the matching then the running of the test is aborted and it doesn't generate any more output therefore all latter tests fail. I think fast/regex/test4 have the same problem as well. I send a solution which uses the regular framework for testing thus the structure of these tests came closer to the other layout tests and the printing of the result doesn't terminate the running. I don't offer this patch for a review now becuase the comparison of the NUL character isn't successful therefore these tests are still failing. I haven't found a solution for the comparison problem yet. NOTE: This is on Qt platform and I didn't try it on mac yet. 315458 1 barraclough 2010-11-30 17:53:22 -0800 Hopefully this problem may be resolved by bug #50292. 315559 2 ossy 2010-12-01 00:15:08 -0800 (In reply to comment #1) > Hopefully this problem may be resolved by bug #50292. Absolutely. Thanks for the fix. 74549 2010-11-22 06:55:47 -0800 2010-11-22 06:55:47 -0800 POC 0001-fix-fast-regex-test1.patch text/plain 3053 pvarga RnJvbSAxZDhiYTMxNGIwNjAwNWYxOTViOGZhNTEwY2I2Y2I5YmI0NDg1ZDY0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBWYXJnYSA8cHZhcmdhQGluZi51LXN6ZWdlZC5odT4K RGF0ZTogTW9uLCAyMiBOb3YgMjAxMCAwNjo1MjoyMyAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIGZp eCBmYXN0IHJlZ2V4IHRlczEKCi0tLQogTGF5b3V0VGVzdHMvZmFzdC9yZWdleC9wY3JlLXRlc3Qt cnVubmVyLmpzIHwgICAxNSArKysrLS0tLS0tLS0tLS0KIExheW91dFRlc3RzL2Zhc3QvcmVnZXgv dGVzdDEuaHRtbCAgICAgICAgICB8ICAgMTcgKysrKysrKysrKy0tLS0tLS0KIExheW91dFRlc3Rz L2Zhc3QvcmVnZXgvdGVzdDQuaHRtbCAgICAgICAgICB8ICAgMTcgKysrKysrKysrKy0tLS0tLS0K IDMgZmlsZXMgY2hhbmdlZCwgMjQgaW5zZXJ0aW9ucygrKSwgMjUgZGVsZXRpb25zKC0pCgpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9yZWdleC9wY3JlLXRlc3QtcnVubmVyLmpzIGIvTGF5 b3V0VGVzdHMvZmFzdC9yZWdleC9wY3JlLXRlc3QtcnVubmVyLmpzCmluZGV4IDFmYzZiYTcuLjhl ZGJiZmUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvcmVnZXgvcGNyZS10ZXN0LXJ1bm5l ci5qcworKysgYi9MYXlvdXRUZXN0cy9mYXN0L3JlZ2V4L3BjcmUtdGVzdC1ydW5uZXIuanMKQEAg LTEsMTUgKzEsNiBAQAotaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKLSAgICBsYXlv dXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7Ci0KLXZhciBjb25zb2xlX21lc3NhZ2VzID0g bnVsbDsKLQogZnVuY3Rpb24gbG9nKG1lc3NhZ2UpCiB7Ci0gICAgaWYgKCFjb25zb2xlX21lc3Nh Z2VzKSB7Ci0gICAgICAgIGNvbnNvbGVfbWVzc2FnZXMgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50 KCJwcmUiKTsKLSAgICAgICAgZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZChjb25zb2xlX21lc3Nh Z2VzKTsKLSAgICB9Ci0gICAgY29uc29sZV9tZXNzYWdlcy5hcHBlbmRDaGlsZChkb2N1bWVudC5j cmVhdGVUZXh0Tm9kZShtZXNzYWdlICsgIlxuIikpOworICAgIGRlYnVnKG1lc3NhZ2UpOwogfQog CiBmdW5jdGlvbiBmZXRjaFRleHQodXJsKSB7CkBAIC02Miw3ICs1Myw3IEBAIGZ1bmN0aW9uIHJl bW92ZVRyYWlsaW5nU3BhY2VzKHN0cikgewogfQogCiBmdW5jdGlvbiBydW5QQ1JFVGVzdChudW1i ZXIsIG5hbWUpIHsKLSAgICBsb2cobmFtZSArICJcbiIpOworICAgIGRlc2NyaXB0aW9uKG5hbWUg KyAiXG4iKTsKIAogICAgIHZhciBpbnB1dFRleHQgPSBmZXRjaFRleHQoInRlc3RpbnB1dCIgKyBu dW1iZXIpOwogICAgIHZhciBvdXRwdXRUZXh0ID0gZmV0Y2hUZXh0KCJ0ZXN0b3V0cHV0IiArIG51 bWJlcik7CkBAIC0xNTEsNCArMTQyLDYgQEAgZnVuY3Rpb24gcnVuUENSRVRlc3QobnVtYmVyLCBu YW1lKSB7CiAgICAgICAgIGxvZygiIik7CiAgICAgfQogICAgIGxvZygiRE9ORSIpOworCisgICAg dmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7CiB9CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9mYXN0L3JlZ2V4L3Rlc3QxLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3JlZ2V4L3Rlc3QxLmh0 bWwKaW5kZXggMmVkMmM1NS4uMzgyNzI0MSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9y ZWdleC90ZXN0MS5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvcmVnZXgvdGVzdDEuaHRtbApA QCAtMSwxMCArMSwxMyBAQAorPCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9JRVRGLy9EVEQgSFRN TC8vRU4iPgorPGh0bWw+CiA8aGVhZD4KLTxzY3JpcHQgc3JjPSJwY3JlLXRlc3QtcnVubmVyLmpz Ij48L3NjcmlwdD4KLTxzY3JpcHQ+Ci1mdW5jdGlvbiBydW5UZXN0KCkgewotICAgIHJ1blBDUkVU ZXN0KDEsICJUZXN0IDE6IG1haW4gZnVuY3Rpb25hbGl0eS4iKTsKLX0KLTwvc2NyaXB0PgorPGxp bmsgcmVsPSJzdHlsZXNoZWV0IiBocmVmPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5j c3MiPgorPHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3Jp cHQ+CiA8L2hlYWQ+Ci08Ym9keSBvbmxvYWQgPSAncnVuVGVzdCgpJz4KKzxib2R5PgorPHAgaWQ9 ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQgc3Jj PSJwY3JlLXRlc3QtcnVubmVyLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+IHJ1blBDUkVUZXN0KDEs ICJUZXN0IDE6IG1haW4gZnVuY3Rpb25hbGl0eS4iKSA8L3NjcmlwdD4KIDwvYm9keT4KKzwvaHRt bD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvcmVnZXgvdGVzdDQuaHRtbCBiL0xheW91 dFRlc3RzL2Zhc3QvcmVnZXgvdGVzdDQuaHRtbAppbmRleCBkMWNjY2ZkLi42MmYzZTAwIDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L3JlZ2V4L3Rlc3Q0Lmh0bWwKKysrIGIvTGF5b3V0VGVz dHMvZmFzdC9yZWdleC90ZXN0NC5odG1sCkBAIC0xLDEwICsxLDEzIEBACis8IURPQ1RZUEUgSFRN TCBQVUJMSUMgIi0vL0lFVEYvL0RURCBIVE1MLy9FTiI+Cis8aHRtbD4KIDxoZWFkPgotPHNjcmlw dCBzcmM9InBjcmUtdGVzdC1ydW5uZXIuanMiPjwvc2NyaXB0PgotPHNjcmlwdD4KLWZ1bmN0aW9u IHJ1blRlc3QoKSB7Ci0gICAgcnVuUENSRVRlc3QoNCwgIlRlc3QgNDogVVRGLTggc3VwcG9ydC4i KTsKLX0KLTwvc2NyaXB0PgorPGxpbmsgcmVsPSJzdHlsZXNoZWV0IiBocmVmPSIuLi9qcy9yZXNv dXJjZXMvanMtdGVzdC1zdHlsZS5jc3MiPgorPHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291cmNlcy9q cy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+CiA8L2hlYWQ+Ci08Ym9keSBvbmxvYWQgPSAncnVuVGVz dCgpJz4KKzxib2R5PgorPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25zb2xl Ij48L2Rpdj4KKzxzY3JpcHQgc3JjPSJwY3JlLXRlc3QtcnVubmVyLmpzIj48L3NjcmlwdD4KKzxz Y3JpcHQ+IHJ1blBDUkVUZXN0KDQsICJUZXN0IDQ6IFVURi04IHN1cHBvcnQuIikgPC9zY3JpcHQ+ CiA8L2JvZHk+Cis8L2h0bWw+Ci0tIAoxLjcuMi4yCgo=