49903 2010-11-22 04:26:41 -0800 [GTK] Inspector: add a way to inspect a WebKitDOMNode 2010-11-26 09:43:21 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 cgarcia webkit-unassigned commit-queue mrobinson oldest_to_newest 312289 0 cgarcia 2010-11-22 04:26:41 -0800 Add API to WebKitWebInspector to inspect a node. 312291 1 74539 cgarcia 2010-11-22 04:30:29 -0800 Created attachment 74539 Add webkit_web_inspector_inspect() 313129 2 mrobinson 2010-11-23 22:25:19 -0800 Seems reasonable to me. Maybe webkit_web_inspector_inspect_node? We'll need one or two more GTK+ reviewers to approve the API change. 313203 3 74539 xan.lopez 2010-11-24 03:52:19 -0800 Comment on attachment 74539 Add webkit_web_inspector_inspect() View in context: https://bugs.webkit.org/attachment.cgi?id=74539&action=review > WebKit/gtk/webkit/webkitwebinspector.cpp:504 > + * @web_inspector: the #WebKitWebInspector that will do the inspection inspect_node would be better, I agree with Martin. > WebKit/gtk/webkit/webkitwebinspector.h:26 > #include <webkit/webkitdefines.h> You shouldn't include the whole dom header just to use WebKitDOMNode*. Including webkitdomdefines.h should be enough, I think. 313640 4 74838 cgarcia 2010-11-25 00:58:32 -0800 Created attachment 74838 Updated patch using inspect_node() and fixing includes 314052 5 74838 commit-queue 2010-11-26 09:43:16 -0800 Comment on attachment 74838 Updated patch using inspect_node() and fixing includes Clearing flags on attachment: 74838 Committed r72772: <http://trac.webkit.org/changeset/72772> 314053 6 commit-queue 2010-11-26 09:43:21 -0800 All reviewed patches have been landed. Closing bug. 74539 2010-11-22 04:30:29 -0800 2010-11-25 00:58:32 -0800 Add webkit_web_inspector_inspect() inspect-node.diff text/plain 2489 cgarcia ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggYmMwMGI4NS4uMzEwMGQwNCAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0xMS0yMiAg Q2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gSW5zcGVjdG9yOiBhZGQg YSB3YXkgdG8gaW5zcGVjdCBhIFdlYktpdERPTU5vZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ5OTAzCisKKyAgICAgICAgKiB3ZWJraXQvd2Via2l0 d2ViaW5zcGVjdG9yLmNwcDoKKyAgICAgICAgKHdlYmtpdF93ZWJfaW5zcGVjdG9yX2luc3BlY3Qp OgorICAgICAgICAqIHdlYmtpdC93ZWJraXR3ZWJpbnNwZWN0b3IuaDoKKwogMjAxMC0xMS0xOCAg WGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFy dGluIFJvYmluc29uLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2ViaW5z cGVjdG9yLmNwcCBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYmluc3BlY3Rvci5jcHAKaW5k ZXggZjIwNzkwNi4uNmM1YzdiMCAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0 d2ViaW5zcGVjdG9yLmNwcAorKysgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJpbnNwZWN0 b3IuY3BwCkBAIC0zMiw2ICszMiw3IEBACiAjaW5jbHVkZSAiUGFnZS5oIgogI2luY2x1ZGUgIlJl bmRlckxheWVyLmgiCiAjaW5jbHVkZSAiUmVuZGVyVmlldy5oIgorI2luY2x1ZGUgIndlYmtpdC9X ZWJLaXRET01Ob2RlUHJpdmF0ZS5oIgogI2luY2x1ZGUgIndlYmtpdG1hcnNoYWwuaCIKICNpbmNs dWRlICJ3ZWJraXRwcml2YXRlLmgiCiAKQEAgLTQ5OSw2ICs1MDAsMjMgQEAgdm9pZCB3ZWJraXRf d2ViX2luc3BlY3Rvcl9zaG93KFdlYktpdFdlYkluc3BlY3Rvciogd2ViSW5zcGVjdG9yKQogfQog CiAvKioKKyAqIHdlYmtpdF93ZWJfaW5zcGVjdG9yX2luc3BlY3Q6CisgKiBAd2ViX2luc3BlY3Rv cjogdGhlICNXZWJLaXRXZWJJbnNwZWN0b3IgdGhhdCB3aWxsIGRvIHRoZSBpbnNwZWN0aW9uCisg KiBAbm9kZTogdGhlICNXZWJLaXRET01Ob2RlIHRvIGluc3BlY3QKKyAqCisgKiBDYXVzZXMgdGhl IFdlYiBJbnNwZWN0b3IgdG8gaW5zcGVjdCB0aGUgZ2l2ZW4gbm9kZS4KKyAqCisgKiBTaW5jZTog MS4zLjcKKyAqLwordm9pZCB3ZWJraXRfd2ViX2luc3BlY3Rvcl9pbnNwZWN0KFdlYktpdFdlYklu c3BlY3Rvciogd2ViSW5zcGVjdG9yLCBXZWJLaXRET01Ob2RlKiBub2RlKQoreworICAgIGdfcmV0 dXJuX2lmX2ZhaWwoV0VCS0lUX0lTX1dFQl9JTlNQRUNUT1Iod2ViSW5zcGVjdG9yKSk7CisgICAg Z19yZXR1cm5faWZfZmFpbChXRUJLSVRfRE9NX0lTX05PREUobm9kZSkpOworCisgICAgd2ViSW5z cGVjdG9yLT5wcml2LT5wYWdlLT5pbnNwZWN0b3JDb250cm9sbGVyKCktPmluc3BlY3QoY29yZShu b2RlKSk7Cit9CisKKy8qKgogICogd2Via2l0X3dlYl9pbnNwZWN0b3JfaW5zcGVjdF9jb29yZGlu YXRlczoKICAqIEB3ZWJfaW5zcGVjdG9yOiB0aGUgI1dlYktpdFdlYkluc3BlY3RvciB0aGF0IHdp bGwgZG8gdGhlIGluc3BlY3Rpb24KICAqIEB4OiB0aGUgWCBjb29yZGluYXRlIG9mIHRoZSBub2Rl IHRvIGJlIGluc3BlY3RlZApkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vi aW5zcGVjdG9yLmggYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJpbnNwZWN0b3IuaAppbmRl eCBiZGU0ODU0Li41MjMxZWIwIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3 ZWJpbnNwZWN0b3IuaAorKysgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJpbnNwZWN0b3Iu aApAQCAtMjIsNiArMjIsNyBAQAogCiAjaW5jbHVkZSA8Z2xpYi1vYmplY3QuaD4KIAorI2luY2x1 ZGUgPHdlYmtpdC93ZWJraXRkb20uaD4KICNpbmNsdWRlIDx3ZWJraXQvd2Via2l0ZGVmaW5lcy5o PgogCiBHX0JFR0lOX0RFQ0xTCkBAIC02MSw2ICs2Miw5IEBAIFdFQktJVF9BUEkgY29uc3QgZ2No YXIqCiB3ZWJraXRfd2ViX2luc3BlY3Rvcl9nZXRfaW5zcGVjdGVkX3VyaShXZWJLaXRXZWJJbnNw ZWN0b3IqIHdlYl9pbnNwZWN0b3IpOwogCiBXRUJLSVRfQVBJIHZvaWQKK3dlYmtpdF93ZWJfaW5z cGVjdG9yX2luc3BlY3QoV2ViS2l0V2ViSW5zcGVjdG9yKiB3ZWJJbnNwZWN0b3IsIFdlYktpdERP TU5vZGUqIG5vZGUpOworCitXRUJLSVRfQVBJIHZvaWQKIHdlYmtpdF93ZWJfaW5zcGVjdG9yX2lu c3BlY3RfY29vcmRpbmF0ZXMoV2ViS2l0V2ViSW5zcGVjdG9yKiB3ZWJfaW5zcGVjdG9yLCBnZG91 YmxlIHgsIGdkb3VibGUgeSk7CiAKIFdFQktJVF9BUEkgdm9pZAo= 74838 2010-11-25 00:58:32 -0800 2010-11-26 09:43:16 -0800 Updated patch using inspect_node() and fixing includes inspect-node.diff text/plain 2516 cgarcia ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggZDYwOGU3Ny4uMzVhMzIzZiAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0xMS0yNSAg Q2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gSW5zcGVjdG9yOiBhZGQg YSB3YXkgdG8gaW5zcGVjdCBhIFdlYktpdERPTU5vZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ5OTAzCisKKyAgICAgICAgKiB3ZWJraXQvd2Via2l0 d2ViaW5zcGVjdG9yLmNwcDoKKyAgICAgICAgKHdlYmtpdF93ZWJfaW5zcGVjdG9yX2luc3BlY3Rf bm9kZSk6CisgICAgICAgICogd2Via2l0L3dlYmtpdHdlYmluc3BlY3Rvci5oOgorCiAyMDEwLTEx LTI0ICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBNYXJ0aW4gUm9iaW5zb24uCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3 ZWJpbnNwZWN0b3IuY3BwIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2ViaW5zcGVjdG9yLmNw cAppbmRleCBmMjA3OTA2Li42MjZkZjMyIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL3dlYmtpdC93 ZWJraXR3ZWJpbnNwZWN0b3IuY3BwCisrKyBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYmlu c3BlY3Rvci5jcHAKQEAgLTMyLDYgKzMyLDcgQEAKICNpbmNsdWRlICJQYWdlLmgiCiAjaW5jbHVk ZSAiUmVuZGVyTGF5ZXIuaCIKICNpbmNsdWRlICJSZW5kZXJWaWV3LmgiCisjaW5jbHVkZSAid2Vi a2l0L1dlYktpdERPTU5vZGVQcml2YXRlLmgiCiAjaW5jbHVkZSAid2Via2l0bWFyc2hhbC5oIgog I2luY2x1ZGUgIndlYmtpdHByaXZhdGUuaCIKIApAQCAtNDk5LDYgKzUwMCwyMyBAQCB2b2lkIHdl YmtpdF93ZWJfaW5zcGVjdG9yX3Nob3coV2ViS2l0V2ViSW5zcGVjdG9yKiB3ZWJJbnNwZWN0b3Ip CiB9CiAKIC8qKgorICogd2Via2l0X3dlYl9pbnNwZWN0b3JfaW5zcGVjdF9ub2RlOgorICogQHdl Yl9pbnNwZWN0b3I6IHRoZSAjV2ViS2l0V2ViSW5zcGVjdG9yIHRoYXQgd2lsbCBkbyB0aGUgaW5z cGVjdGlvbgorICogQG5vZGU6IHRoZSAjV2ViS2l0RE9NTm9kZSB0byBpbnNwZWN0CisgKgorICog Q2F1c2VzIHRoZSBXZWIgSW5zcGVjdG9yIHRvIGluc3BlY3QgdGhlIGdpdmVuIG5vZGUuCisgKgor ICogU2luY2U6IDEuMy43CisgKi8KK3ZvaWQgd2Via2l0X3dlYl9pbnNwZWN0b3JfaW5zcGVjdF9u b2RlKFdlYktpdFdlYkluc3BlY3Rvciogd2ViSW5zcGVjdG9yLCBXZWJLaXRET01Ob2RlKiBub2Rl KQoreworICAgIGdfcmV0dXJuX2lmX2ZhaWwoV0VCS0lUX0lTX1dFQl9JTlNQRUNUT1Iod2ViSW5z cGVjdG9yKSk7CisgICAgZ19yZXR1cm5faWZfZmFpbChXRUJLSVRfRE9NX0lTX05PREUobm9kZSkp OworCisgICAgd2ViSW5zcGVjdG9yLT5wcml2LT5wYWdlLT5pbnNwZWN0b3JDb250cm9sbGVyKCkt Pmluc3BlY3QoY29yZShub2RlKSk7Cit9CisKKy8qKgogICogd2Via2l0X3dlYl9pbnNwZWN0b3Jf aW5zcGVjdF9jb29yZGluYXRlczoKICAqIEB3ZWJfaW5zcGVjdG9yOiB0aGUgI1dlYktpdFdlYklu c3BlY3RvciB0aGF0IHdpbGwgZG8gdGhlIGluc3BlY3Rpb24KICAqIEB4OiB0aGUgWCBjb29yZGlu YXRlIG9mIHRoZSBub2RlIHRvIGJlIGluc3BlY3RlZApkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay93 ZWJraXQvd2Via2l0d2ViaW5zcGVjdG9yLmggYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJp bnNwZWN0b3IuaAppbmRleCBiZGU0ODU0Li40NThlMzcwIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3Rr L3dlYmtpdC93ZWJraXR3ZWJpbnNwZWN0b3IuaAorKysgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJr aXR3ZWJpbnNwZWN0b3IuaApAQCAtMjIsNiArMjIsNyBAQAogCiAjaW5jbHVkZSA8Z2xpYi1vYmpl Y3QuaD4KIAorI2luY2x1ZGUgPHdlYmtpdC93ZWJraXRkb21kZWZpbmVzLmg+CiAjaW5jbHVkZSA8 d2Via2l0L3dlYmtpdGRlZmluZXMuaD4KIAogR19CRUdJTl9ERUNMUwpAQCAtNjEsNiArNjIsOSBA QCBXRUJLSVRfQVBJIGNvbnN0IGdjaGFyKgogd2Via2l0X3dlYl9pbnNwZWN0b3JfZ2V0X2luc3Bl Y3RlZF91cmkoV2ViS2l0V2ViSW5zcGVjdG9yKiB3ZWJfaW5zcGVjdG9yKTsKIAogV0VCS0lUX0FQ SSB2b2lkCit3ZWJraXRfd2ViX2luc3BlY3Rvcl9pbnNwZWN0X25vZGUoV2ViS2l0V2ViSW5zcGVj dG9yKiB3ZWJJbnNwZWN0b3IsIFdlYktpdERPTU5vZGUqIG5vZGUpOworCitXRUJLSVRfQVBJIHZv aWQKIHdlYmtpdF93ZWJfaW5zcGVjdG9yX2luc3BlY3RfY29vcmRpbmF0ZXMoV2ViS2l0V2ViSW5z cGVjdG9yKiB3ZWJfaW5zcGVjdG9yLCBnZG91YmxlIHgsIGdkb3VibGUgeSk7CiAKIFdFQktJVF9B UEkgdm9pZAo=