4990 2005-09-14 22:39:51 -0700 WebKit needs to use a local pasteboard during testing 2005-12-19 11:55:09 -0800 1 1 1 Unclassified WebKit Tools / Tests 420+ Mac OS X 10.4 RESOLVED FIXED P4 Normal --- 1 eric darin justin.garcia oldest_to_newest 19653 0 eric 2005-09-14 22:39:51 -0700 WebKit needs to use a local pasteboard during testing Currently WebKit always uses the "generic" pasteboard for copy/paste, etc. This causes problems during testing because you are unable to safely use the pasteboard while runing run-webkit-tests for fear of causings test failures. There are also situations underwhich SSH sessions will not properly connect to the pasteboard server (pbs) and thus cause editing tests to fail. This could be a secret default which turned on various "debug only" behaviors in WebKit, or a single default just for disabling using the generic pasteboard. This would require small changes to both WebKit and DumpRenderTree. 19654 1 eric 2005-09-14 22:40:32 -0700 Dave had expressed interest in this. 21524 2 justin.garcia 2005-10-06 03:29:16 -0700 Is it even possible to have a local pasteboard? 21525 3 eric 2005-10-06 03:37:01 -0700 Sure: NSPasteBoard *myLocalPasteBoard = [[NSPasteBoard alloc] init]; 21604 4 justin.garcia 2005-10-09 01:24:51 -0700 Boy don't I feel silly. We should do this right away. 26139 5 darin 2005-12-18 14:27:10 -0800 I tried. [[NSPasteBoard alloc] init] does not work. But you can have a pasteboard not shared with any other process. I'll attach my patch. 26140 6 5141 darin 2005-12-18 14:30:03 -0800 Created attachment 5141 use a pasteboard with a unique name; next best thing to a local pasteboard We discussed using a local pasteboard, but as far as I can tell there's no such thing. I tried [[NSPasteboard alloc] init] and discovered that alloc is overriden to indicate you can't allocate your own NSPasteboard. 26148 7 justin.garcia 2005-12-18 14:55:32 -0800 Darin, didn't you mention that this change required some changes to updateLayout calls in the editing code? Are those attached to a different bug? 26149 8 5141 eric 2005-12-18 14:56:21 -0800 Comment on attachment 5141 use a pasteboard with a unique name; next best thing to a local pasteboard I'm not familiar with that pose-as syntax, but the change looks totally fine. r=me. 26156 9 darin 2005-12-18 15:16:38 -0800 (In reply to comment #7) > Darin, didn't you mention that this change required some changes to updateLayout calls > in the editing code? Are those attached to a different bug? I'm not certain of the relationship between this change and the failures I was seeing. The bug is bug 6142, but it seems likely it was just coincidence that I first saw those failures after applying this patch. 26158 10 darin 2005-12-18 15:33:34 -0800 (In reply to comment #8) > I'm not familiar with that pose-as syntax This is the low-level poseAs. There's also a higher level poseAs in NSObject, but there's no strong argument in favor of using that one over this. Historically in Safari it was important to use this one instead of the one that involved Objective-C method calls but I can't remember why. Here I was just using it because I had the code from Safari to copy and paste. 5141 2005-12-18 14:30:03 -0800 2005-12-18 14:56:21 -0800 use a pasteboard with a unique name; next best thing to a local pasteboard PrivatePasteboardPatch.txt text/plain 4811 darin SW5kZXg6IER1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLm0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmls ZTogL2N2cy9yb290L1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL0R1bXBSZW5kZXJUcmVlLm0s dgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMjAKZGlmZiAtcCAtdSAtcjEuMjAgRHVtcFJlbmRlclRy ZWUvRHVtcFJlbmRlclRyZWUubQotLS0gRHVtcFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUubQky OCBOb3YgMjAwNSAyMjoxNjoxNSAtMDAwMAkxLjIwCisrKyBEdW1wUmVuZGVyVHJlZS9EdW1wUmVu ZGVyVHJlZS5tCTE4IERlYyAyMDA1IDIyOjI5OjQyIC0wMDAwCkBAIC0yNiwxNSArMjYsMTAgQEAK ICAqIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0Yg U1VDSCBEQU1BR0UuCiAgKi8KIAotI2ltcG9ydCA8Rm91bmRhdGlvbi9OU1VSTFJlcXVlc3QuaD4K LSNpbXBvcnQgPEZvdW5kYXRpb24vTlNFcnJvci5oPgotCiAjaW1wb3J0IDxXZWJLaXQvRE9NRXh0 ZW5zaW9ucy5oPgogI2ltcG9ydCA8V2ViS2l0L0RPTVJhbmdlLmg+CiAjaW1wb3J0IDxXZWJLaXQv V2ViQ29yZVN0YXRpc3RpY3MuaD4KICNpbXBvcnQgPFdlYktpdC9XZWJEYXRhU291cmNlLmg+Ci0j aW1wb3J0IDxXZWJLaXQvV2ViRnJhbWUuaD4KLSNpbXBvcnQgPFdlYktpdC9XZWJGcmFtZUxvYWRE ZWxlZ2F0ZS5oPgogI2ltcG9ydCA8V2ViS2l0L1dlYkVkaXRpbmdEZWxlZ2F0ZS5oPgogI2ltcG9y dCA8V2ViS2l0L1dlYkZyYW1lVmlldy5oPgogI2ltcG9ydCA8V2ViS2l0L1dlYlByZWZlcmVuY2Vz Lmg+CkBAIC00MiwxMiArMzcsMTggQEAKIAogI2ltcG9ydCA8Q2FyYm9uL0NhcmJvbi5oPiAvLyBm b3IgR2V0Q3VycmVudEV2ZW50VGltZSgpCiAKKyNpbXBvcnQgPG9iamMvb2JqYy1ydW50aW1lLmg+ IC8vIGZvciBjbGFzc19wb3NlQXMKKwogI2RlZmluZSBDT01NT05fRElHRVNUX0ZPUl9PUEVOU1NM Ci0jaW1wb3J0IDxDb21tb25DcnlwdG8vQ29tbW9uRGlnZXN0Lmg+CisjaW1wb3J0IDxDb21tb25D cnlwdG8vQ29tbW9uRGlnZXN0Lmg+IC8vIGZvciBNRDUgZnVuY3Rpb25zCisKICNpbXBvcnQgPGdl dG9wdC5oPgogCiAjaW1wb3J0ICJUZXh0SW5wdXRDb250cm9sbGVyLmgiCiAKK0BpbnRlcmZhY2Ug RHVtcFJlbmRlclRyZWVQYXN0ZWJvYXJkIDogTlNQYXN0ZWJvYXJkCitAZW5kCisKIEBpbnRlcmZh Y2UgV2FpdFVudGlsRG9uZURlbGVnYXRlIDogTlNPYmplY3QKIEBlbmQKIApAQCAtODAsMTEgKzgx LDE0IEBAIHN0YXRpYyBpbnQgZHVtcFBpeGVscyA9IE5POwogc3RhdGljIGludCBkdW1wVHJlZSA9 IFlFUzsKIHN0YXRpYyBCT09MIHByaW50U2VwYXJhdG9yczsKIHN0YXRpYyBOU1N0cmluZyAqY3Vy cmVudFRlc3QgPSBuaWw7CitzdGF0aWMgTlNQYXN0ZWJvYXJkICpsb2NhbFBhc3RlYm9hcmQ7CiAK IGludCBtYWluKGludCBhcmdjLCBjb25zdCBjaGFyICphcmd2W10pCiB7CiAgICAgTlNBdXRvcmVs ZWFzZVBvb2wgKnBvb2wgPSBbW05TQXV0b3JlbGVhc2VQb29sIGFsbG9jXSBpbml0XTsKIAorICAg IGNsYXNzX3Bvc2VBcyhvYmpjX2dldENsYXNzKCJEdW1wUmVuZGVyVHJlZVBhc3RlYm9hcmQiKSwg b2JqY19nZXRDbGFzcygiTlNQYXN0ZWJvYXJkIikpOworCiAgICAgaW50IHdpZHRoID0gODAwOwog ICAgIGludCBoZWlnaHQgPSA2MDA7CiAgICAgCkBAIC0xNDQsMTAgKzE0OCwxMiBAQCBpbnQgbWFp bihpbnQgYXJnYywgY29uc3QgY2hhciAqYXJndltdKQogICAgICAgICB9CiAgICAgCiAgICAgaWYg KFtbW05TRm9udE1hbmFnZXIgc2hhcmVkRm9udE1hbmFnZXJdIGF2YWlsYWJsZU1lbWJlcnNPZkZv bnRGYW1pbHk6QCJBaGVtIl0gY291bnRdID09IDApIHsKLQkJZnByaW50ZihzdGRlcnIsICJcbkFo ZW0gZm9udCBpcyBub3QgYXZhaWxhYmxlLiBUaGlzIHNwZWNpYWwgc2ltcGxlIGZvbnQgaXMgdXNl ZCB0byBjb25zdHJ1Y3QgY2VydGFpbiB0eXBlcyBvZiBwcmVkaWN0YWJsZSB0ZXN0cy5cblxuVG8g cnVuIHJlZ3Jlc3Npb24gdGVzdHMsIHBsZWFzZSBnZXQgaXQgZnJvbSA8aHR0cDovL3dlYmtpdC5v cGVuZGFyd2luLm9yZy9xdWFsaXR5L0FoZW0udHRmPi5cbiIpOwotCQlleGl0KDEpOworICAgICAg ICBmcHJpbnRmKHN0ZGVyciwgIlxuQWhlbSBmb250IGlzIG5vdCBhdmFpbGFibGUuIFRoaXMgc3Bl Y2lhbCBzaW1wbGUgZm9udCBpcyB1c2VkIHRvIGNvbnN0cnVjdCBjZXJ0YWluIHR5cGVzIG9mIHBy ZWRpY3RhYmxlIHRlc3RzLlxuXG5UbyBydW4gcmVncmVzc2lvbiB0ZXN0cywgcGxlYXNlIGdldCBp dCBmcm9tIDxodHRwOi8vd2Via2l0Lm9wZW5kYXJ3aW4ub3JnL3F1YWxpdHkvQWhlbS50dGY+Llxu Iik7CisgICAgICAgIGV4aXQoMSk7CiAgICAgfQogICAgIAorICAgIGxvY2FsUGFzdGVib2FyZCA9 IFtOU1Bhc3RlYm9hcmQgcGFzdGVib2FyZFdpdGhVbmlxdWVOYW1lXTsKKwogICAgIFdlYlZpZXcg KndlYlZpZXcgPSBbW1dlYlZpZXcgYWxsb2NdIGluaXRXaXRoRnJhbWU6TlNNYWtlUmVjdCgwLCAw LCB3aWR0aCwgaGVpZ2h0KV07CiAgICAgV2FpdFVudGlsRG9uZURlbGVnYXRlICpkZWxlZ2F0ZSA9 IFtbV2FpdFVudGlsRG9uZURlbGVnYXRlIGFsbG9jXSBpbml0XTsKICAgICBFZGl0aW5nRGVsZWdh dGUgKmVkaXRpbmdEZWxlZ2F0ZSA9IFtbRWRpdGluZ0RlbGVnYXRlIGFsbG9jXSBpbml0XTsKQEAg LTE5MCw3ICsxOTYsMTEgQEAgaW50IG1haW4oaW50IGFyZ2MsIGNvbnN0IGNoYXIgKmFyZ3ZbXSkK ICAgICBbZGVsZWdhdGUgcmVsZWFzZV07CiAgICAgW2VkaXRpbmdEZWxlZ2F0ZSByZWxlYXNlXTsK IAorICAgIFtsb2NhbFBhc3RlYm9hcmQgcmVsZWFzZUdsb2JhbGx5XTsKKyAgICBsb2NhbFBhc3Rl Ym9hcmQgPSBuaWw7CisgICAgCiAgICAgW3Bvb2wgcmVsZWFzZV07CisKICAgICByZXR1cm4gMDsK IH0KIApAQCAtNDk3LDcgKzUwNyw3IEBAIHN0YXRpYyB2b2lkIGR1bXAodm9pZCkKIC0gKHZvaWQp bW91c2VEb3duCiB7CiAgICAgW1tbZnJhbWUgZnJhbWVWaWV3XSBkb2N1bWVudFZpZXddIGxheW91 dF07Ci0gICAgaWYoR2V0Q3VycmVudEV2ZW50VGltZSgpIC0gbGFzdENsaWNrID49IDEpCisgICAg aWYgKEdldEN1cnJlbnRFdmVudFRpbWUoKSAtIGxhc3RDbGljayA+PSAxKQogICAgICAgICBjbGlj a0NvdW50ID0gMTsKICAgICBlbHNlCiAgICAgICAgIGNsaWNrQ291bnQrKzsKQEAgLTU0MiwxMyAr NTUyLDE0IEBAIHN0YXRpYyB2b2lkIGR1bXAodm9pZCkKIHN0YXRpYyB2b2lkIGR1bXBSZW5kZXJU cmVlKGNvbnN0IGNoYXIgKmZpbGVuYW1lKQogewogICAgIENGU3RyaW5nUmVmIGZpbGVuYW1lU3Ry aW5nID0gQ0ZTdHJpbmdDcmVhdGVXaXRoQ1N0cmluZyhOVUxMLCBmaWxlbmFtZSwga0NGU3RyaW5n RW5jb2RpbmdVVEY4KTsKLSAgICBpZiAoZmlsZW5hbWVTdHJpbmcgPT0gTlVMTCkgeworICAgIGlm ICghZmlsZW5hbWVTdHJpbmcpIHsKICAgICAgICAgZnByaW50ZihzdGRlcnIsICJjYW4ndCBwYXJz ZSBmaWxlbmFtZSBhcyBVVEYtOFxuIik7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKICAgICBD RlVSTFJlZiBVUkwgPSBDRlVSTENyZWF0ZVdpdGhGaWxlU3lzdGVtUGF0aChOVUxMLCBmaWxlbmFt ZVN0cmluZywga0NGVVJMUE9TSVhQYXRoU3R5bGUsIEZBTFNFKTsKLSAgICBpZiAoVVJMID09IE5V TEwpIHsKKyAgICBpZiAoIVVSTCkgeworICAgICAgICBDRlJlbGVhc2UoZmlsZW5hbWVTdHJpbmcp OwogICAgICAgICBmcHJpbnRmKHN0ZGVyciwgImNhbid0IHR1cm4gJXMgaW50byBhIENGVVJMXG4i LCBmaWxlbmFtZSk7CiAgICAgICAgIHJldHVybjsKICAgICB9CkBAIC01NzEsMTEgKzU4MiwxMyBA QCBzdGF0aWMgdm9pZCBkdW1wUmVuZGVyVHJlZShjb25zdCBjaGFyICpmCiAgICAgICAgIFtbTlNS dW5Mb29wIGN1cnJlbnRSdW5Mb29wXSBydW5Nb2RlOk5TRGVmYXVsdFJ1bkxvb3BNb2RlIGJlZm9y ZURhdGU6W05TRGF0ZSBkaXN0YW50UGFzdF1dOwogICAgICAgICBbcG9vbCByZWxlYXNlXTsKICAg ICB9CisgICAgcG9vbCA9IFtbTlNBdXRvcmVsZWFzZVBvb2wgYWxsb2NdIGluaXRdOwogICAgIFtb ZnJhbWUgd2ViVmlld10gc2V0U2VsZWN0ZWRET01SYW5nZTpuaWwgYWZmaW5pdHk6TlNTZWxlY3Rp b25BZmZpbml0eURvd25zdHJlYW1dOworICAgIFtwb29sIHJlbGVhc2VdOwogfQogCiAvKiBIYXNo ZXMgYSBiaXRtYXAgYW5kIHJldHVybnMgYSB0ZXh0IHN0cmluZyBmb3IgY29tcGFyaXNvbiBhbmQg c2F2aW5nIHRvIGEgZmlsZSAqLwotTlNTdHJpbmcgKm1kNUhhc2hTdHJpbmdGb3JCaXRtYXAoTlNC aXRtYXBJbWFnZVJlcCAqYml0bWFwKQorc3RhdGljIE5TU3RyaW5nICptZDVIYXNoU3RyaW5nRm9y Qml0bWFwKE5TQml0bWFwSW1hZ2VSZXAgKmJpdG1hcCkKIHsKICAgICBNRDVfQ1RYIG1kNUNvbnRl eHQ7CiAgICAgdW5zaWduZWQgY2hhciBoYXNoWzE2XTsKQEAgLTU5MSwzICs2MDQsMTMgQEAgTlNT dHJpbmcgKm1kNUhhc2hTdHJpbmdGb3JCaXRtYXAoTlNCaXRtYQogCiAgICAgcmV0dXJuIFtOU1N0 cmluZyBzdHJpbmdXaXRoVVRGOFN0cmluZzpoZXhdOwogfQorCitAaW1wbGVtZW50YXRpb24gRHVt cFJlbmRlclRyZWVQYXN0ZWJvYXJkCisKKy8vIFJldHVybiBhIGxvY2FsIHBhc3RlYm9hcmQgc28g d2UgZG9uJ3QgZGlzdHVyYiB0aGUgcmVhbCBwYXN0ZWJvYXJkIHdoZW4gcnVubmluZyB0ZXN0cy4K KysgKE5TUGFzdGVib2FyZCAqKWdlbmVyYWxQYXN0ZWJvYXJkCit7CisgICAgcmV0dXJuIGxvY2Fs UGFzdGVib2FyZDsKK30KKworQGVuZAo=