49871 2010-11-20 16:20:24 -0800 [windows] font-size:0 text runs should have zero width 2012-04-10 02:31:50 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED http://www.php.net/manual/en/function.session-decode.php P2 Normal --- 1 jamesr webkit-unassigned aroben dglazkov eric fishd hyatt mihaip pravind.2k4 senorblanco oldest_to_newest 312011 0 jamesr 2010-11-20 16:20:24 -0800 The following should render with no gap between 'abc' and 'def': abc<span style="font-size:0">w</span>def but on the latest nightlies there's a large gap. This causes us to misrender the php.net manual which uses this pattern (for whatever reason). My guess it that we need to special-case platformWidthForGlyph(Glyph glyph) for the case when the font size is zero, but I don't currently have access to a windows development platform to verify. 312534 1 74601 jamesr 2010-11-22 14:49:11 -0800 Created attachment 74601 patch for chromium 312537 2 jamesr 2010-11-22 14:51:11 -0800 Here's a patch for the chromium SimpleFont* classes that need them. The OS X code seems to all work fine. I'm pretty positive that the Safari Win port needs a similar patch, but I'm not sure exactly how to handle boundsForGDIGlyph() and don't have access to a dev environment to test code changes on Safari/Win so I've left that codepath alone. 312542 3 74601 dglazkov 2010-11-22 14:57:36 -0800 Comment on attachment 74601 patch for chromium please don't break everything when landing this. 312547 4 jamesr 2010-11-22 15:04:24 -0800 Committed r72567: <http://trac.webkit.org/changeset/72567> 312555 5 aroben 2010-11-22 15:23:22 -0800 (In reply to comment #2) > I'm pretty positive that the Safari Win port needs a similar patch, but I'm not sure exactly how to handle boundsForGDIGlyph() I think you can handle it just like the other width functions. 313356 6 mihaip 2010-11-24 09:54:57 -0800 BTW, the updated test fails on the upstream Mac port on Leopard (presumably an ATSUI vs. CoreText difference): -PASS s.getBoundingClientRect().width is 0 +FAIL s.getBoundingClientRect().width should be 0. Was 2147483648. http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r72675%20(23809)/results.html 321787 7 eric 2010-12-14 01:34:25 -0800 Seems this should be closed? 599110 8 pravind.2k4 2012-04-10 02:31:50 -0700 The same behavior is seen on Safari windows. Please reopen the bug. I'm uploading the patch for the same. 74601 2010-11-22 14:49:11 -0800 2010-11-22 14:57:36 -0800 patch for chromium bug-49871-20101122144910.patch text/plain 5266 jamesr ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzNGVmZjNhMzg0ZjVlZWViNzNhYWI0MzdkNGUzYmZjNDJjMDc5ZTg3Li44ZjI3MTAz ZGY1N2NiYjFlMjkyZTk5ZjAwNzFkZjBkODdiYWQ3NGI3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTAtMTEtMjIgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIGZv bnQtc2l6ZTowIHRleHQgcnVucyBzaG91bGQgaGF2ZSB6ZXJvIHdpZHRoCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTg3MQorCisgICAgICAgIEV4cGFu ZHMgdGVzdCB0byBjaGVjayB3aWR0aCBpbiBhZGRpdGlvbiB0byBoZWlnaHQuCisKKyAgICAgICAg KiBmYXN0L3RleHQvZm9udC1zaXplLXplcm8tZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZhc3Qv dGV4dC9mb250LXNpemUtemVyby5odG1sOgorICAgICAgICAqIGZhc3QvdGV4dC9zY3JpcHQtdGVz dHMvZm9udC1zaXplLXplcm8uanM6CisKIDIwMTAtMTEtMTkgIEFudG9uIE11aGluICA8YW50b25t QGNocm9taXVtLm9yZz4KIAogICAgICAgICBOb3QgcmV2aWV3ZWQsIHJlbW92ZSBzdXBwcmVzc2lv biBmb3IgZmFzdC9yZXBhaW50L2lubGluZS1ibG9jay1vdmVyZmxvdy5odG1sLgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZmFzdC90ZXh0L2ZvbnQtc2l6ZS16ZXJvLWV4cGVjdGVkLnR4dCBiL0xh eW91dFRlc3RzL2Zhc3QvdGV4dC9mb250LXNpemUtemVyby1leHBlY3RlZC50eHQKaW5kZXggMDkz NjkwMjRjY2JjZTE5NWIwZDgwODEzNTRkZDY3NjA2MjA0ODEwNC4uMjBlMGNmYzFjYjUxMGQ5ODJl YjU1ZDY1ZThjZWNlNmMxYWNmYWM3OSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC90ZXh0 L2ZvbnQtc2l6ZS16ZXJvLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3RleHQv Zm9udC1zaXplLXplcm8tZXhwZWN0ZWQudHh0CkBAIC0xLDYgKzEsNyBAQAotVGVzdHMgdGhhdCB0 ZXh0IHdpdGggZm9udC1zaXplOjAgaGFzIHplcm8gaGVpZ2h0LgorVGVzdHMgdGhhdCB0ZXh0IHdp dGggZm9udC1zaXplOjAgaGFzIHplcm8gaGVpZ2h0IGFuZCB3aWR0aC4KIAogUEFTUyBzLmdldEJv dW5kaW5nQ2xpZW50UmVjdCgpLmhlaWdodCBpcyAwCitQQVNTIHMuZ2V0Qm91bmRpbmdDbGllbnRS ZWN0KCkud2lkdGggaXMgMAogUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQogCiBURVNU IENPTVBMRVRFCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3RleHQvZm9udC1zaXplLXpl cm8uaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvdGV4dC9mb250LXNpemUtemVyby5odG1sCmluZGV4 IDY4MjE0YTU5ZTM3YjZmMThkNDQ4YzUxNmU5N2IxM2QxM2YyZTMyYzMuLjdjNTdhNmJhYTQ4NmM1 MDliYWZkOTVlZTdmNjcyZjA1ZTVmY2FkNWYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3Qv dGV4dC9mb250LXNpemUtemVyby5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvdGV4dC9mb250 LXNpemUtemVyby5odG1sCkBAIC01LDcgKzUsNyBAQAogPHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291 cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+CiA8L2hlYWQ+CiA8Ym9keT4KLTxwIGlkPSJk ZXNjcmlwdGlvbiI+VGVzdHMgdGhhdCB0ZXh0IHdpdGggZm9udC1zaXplOjAgaGFzIHplcm8gaGVp Z2h0LjwvcD4KKzxwIGlkPSJkZXNjcmlwdGlvbiI+VGVzdHMgdGhhdCB0ZXh0IHdpdGggZm9udC1z aXplOjAgaGFzIHplcm8gaGVpZ2h0IGFuZCB3aWR0aC48L3A+CiA8ZGl2IGlkPSJjb25zb2xlIj48 L2Rpdj4KIDxzY3JpcHQgc3JjPSJzY3JpcHQtdGVzdHMvZm9udC1zaXplLXplcm8uanMiPjwvc2Ny aXB0PgogPHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2Ny aXB0PgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC90ZXh0L3NjcmlwdC10ZXN0cy9mb250 LXNpemUtemVyby5qcyBiL0xheW91dFRlc3RzL2Zhc3QvdGV4dC9zY3JpcHQtdGVzdHMvZm9udC1z aXplLXplcm8uanMKaW5kZXggNWI2OWY3ZjU5OTFjNjM4YTI2Y2RhNGNkNmE0YmYxNjMxODcyZWFm OC4uYTAxZDAxMmMxMzU2ZTg2YjljMmEzYTg4MjcxNzAxMGNiYjk3OWI2NyAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvZmFzdC90ZXh0L3NjcmlwdC10ZXN0cy9mb250LXNpemUtemVyby5qcworKysg Yi9MYXlvdXRUZXN0cy9mYXN0L3RleHQvc2NyaXB0LXRlc3RzL2ZvbnQtc2l6ZS16ZXJvLmpzCkBA IC00LDYgKzQsNyBAQCBzLmlubmVySFRNTCA9ICdUZXh0JzsKIGRvY3VtZW50LmJvZHkuYXBwZW5k Q2hpbGQocyk7CiAKIHNob3VsZEJlKCJzLmdldEJvdW5kaW5nQ2xpZW50UmVjdCgpLmhlaWdodCIs ICIwIik7CitzaG91bGRCZSgicy5nZXRCb3VuZGluZ0NsaWVudFJlY3QoKS53aWR0aCIsICIwIik7 CiAKIGRvY3VtZW50LmJvZHkucmVtb3ZlQ2hpbGQocyk7CiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUv Q2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWY3OWRiNzkwOTI2YjgzMDI5NzVh Y2QwY2FmZDkzOTAwZDk2N2UxMS4uYjE4ZmQ4MThlMTJiZjgzZjE0OWRiZTA4ZDQ1OTg1Mzk2YTFk Mjk3YyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0xMS0yMiAgSmFtZXMgUm9iaW5zb24gIDxqYW1lc3JA Y2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtjaHJvbWl1bV0gZm9udC1zaXplOjAgdGV4dCBydW5zIHNob3VsZCBoYXZlIHplcm8g d2lkdGgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ5 ODcxCisKKyAgICAgICAgUmV0dXJucyAwIGZyb20gcGxhdGZvcm1XaWR0aEZvckdseXBoIGlmIHRo ZSBzcGVjaWZpZWQgZm9udCBzaXplIGlzIDAuCisKKyAgICAgICAgVGVzdDogZmFzdC90ZXh0L2Zv bnQtc2l6ZS16ZXJvLmh0bWwKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVt L1NpbXBsZUZvbnREYXRhQ2hyb21pdW1XaW4uY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2ltcGxl Rm9udERhdGE6OnBsYXRmb3JtV2lkdGhGb3JHbHlwaCk6CisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvY2hyb21pdW0vU2ltcGxlRm9udERhdGFMaW51eC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpTaW1wbGVGb250RGF0YTo6cGxhdGZvcm1XaWR0aEZvckdseXBoKToKKwogMjAxMC0xMS0xOSAg RGFuaWVsIEJhdGVzICA8ZGJhdGVzQHJpbS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW50 b25pbyBHb21lcy4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21p dW0vU2ltcGxlRm9udERhdGFDaHJvbWl1bVdpbi5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2Nocm9taXVtL1NpbXBsZUZvbnREYXRhQ2hyb21pdW1XaW4uY3BwCmluZGV4IGVhMmViN2Nh ZGJkYTNlZjYxMzU2ZjAwYTk4ZmM5YThkYzQ5Mzg2MmQuLmJjZWYxZmVhNzc2NzdmOGM3ZDYwZmY4 ZDk2MzRkZDJiZDBlZGE4ZGQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2hyb21pdW0vU2ltcGxlRm9udERhdGFDaHJvbWl1bVdpbi5jcHAKKysrIGIvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9TaW1wbGVGb250RGF0YUNocm9taXVtV2luLmNwcApAQCAt MTY3LDYgKzE2Nyw5IEBAIEZsb2F0UmVjdCBTaW1wbGVGb250RGF0YTo6cGxhdGZvcm1Cb3VuZHNG b3JHbHlwaChHbHlwaCkgY29uc3QKIAogZmxvYXQgU2ltcGxlRm9udERhdGE6OnBsYXRmb3JtV2lk dGhGb3JHbHlwaChHbHlwaCBnbHlwaCkgY29uc3QKIHsKKyAgICBpZiAoIW1fcGxhdGZvcm1EYXRh LnNpemUoKSkKKyAgICAgICAgcmV0dXJuIDA7CisKICAgICBIREMgZGMgPSBHZXREQygwKTsKICAg ICBIR0RJT0JKIG9sZEZvbnQgPSBTZWxlY3RPYmplY3QoZGMsIG1fcGxhdGZvcm1EYXRhLmhmb250 KCkpOwogCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1Np bXBsZUZvbnREYXRhTGludXguY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1 bS9TaW1wbGVGb250RGF0YUxpbnV4LmNwcAppbmRleCBlN2ZmOWVlYTAwZjFiNzJhZTdkNzdkZDc5 MDE5NjE0YjZhYzdjNGRmLi5jNTE5MGZjYzZlZmQzOGE1MDQ4ZTBhZWQ0NmQ4MDYyNDFlNDI2NTUy IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1NpbXBsZUZv bnREYXRhTGludXguY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0v U2ltcGxlRm9udERhdGFMaW51eC5jcHAKQEAgLTUzLDYgKzUzLDE4IEBAIHN0YXRpYyBjb25zdCBz aXplX3QgbWF4VkRNWFRhYmxlU2l6ZSA9IDEwMjQgKiAxMDI0OyAgLy8gMSBNQgogCiB2b2lkIFNp bXBsZUZvbnREYXRhOjpwbGF0Zm9ybUluaXQoKQogeworICAgIGlmICghbV9wbGF0Zm9ybURhdGEu c2l6ZSgpKSB7CisgICAgICAgIG1fYXNjZW50ID0gMDsKKyAgICAgICAgbV9kZXNjZW50ID0gMDsK KyAgICAgICAgbV9saW5lR2FwID0gMDsKKyAgICAgICAgbV9saW5lU3BhY2luZyA9IDA7CisgICAg ICAgIG1fYXZnQ2hhcldpZHRoID0gMDsKKyAgICAgICAgbV9tYXhDaGFyV2lkdGggPSAwOworICAg ICAgICBtX3hIZWlnaHQgPSAwOworICAgICAgICBtX3VuaXRzUGVyRW0gPSAwOworICAgICAgICBy ZXR1cm47CisgICAgfQorCiAgICAgU2tQYWludCBwYWludDsKICAgICBTa1BhaW50OjpGb250TWV0 cmljcyBtZXRyaWNzOwogCkBAIC0xNzcsNiArMTg5LDkgQEAgRmxvYXRSZWN0IFNpbXBsZUZvbnRE YXRhOjpwbGF0Zm9ybUJvdW5kc0ZvckdseXBoKEdseXBoKSBjb25zdAogICAgIAogZmxvYXQgU2lt cGxlRm9udERhdGE6OnBsYXRmb3JtV2lkdGhGb3JHbHlwaChHbHlwaCBnbHlwaCkgY29uc3QKIHsK KyAgICBpZiAoIW1fcGxhdGZvcm1EYXRhLnNpemUoKSkKKyAgICAgICAgcmV0dXJuIDA7CisKICAg ICBTa0FTU0VSVChzaXplb2YoZ2x5cGgpID09IDIpOyAgIC8vIGNvbXBpbGUtdGltZSBhc3NlcnQK IAogICAgIFNrUGFpbnQgcGFpbnQ7Cg==