49870 2010-11-20 14:52:14 -0800 [Qt] Dragging a selection should use a rendering of the selection as "cursor" for the drag 2010-11-20 22:57:51 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 49872 1 kling webkit-qt-unassigned abarth eric webkit.review.bot oldest_to_newest 311995 0 kling 2010-11-20 14:52:14 -0800 We need to implement Frame::dragImageForSelection() and hook it up in DragClientQt::startDrag() 311999 1 74488 kling 2010-11-20 15:03:00 -0800 Created attachment 74488 Proposed patch 312055 2 74488 tonikitoo 2010-11-20 22:28:22 -0800 Comment on attachment 74488 Proposed patch r=me. I assume it can't be tested :( 312056 3 kling 2010-11-20 22:33:56 -0800 (In reply to comment #2) > I assume it can't be tested :( Indeed ;( But thanks for reviewing! 312057 4 74488 kling 2010-11-20 22:36:45 -0800 Comment on attachment 74488 Proposed patch Clearing flags on attachment: 74488 Committed r72494: <http://trac.webkit.org/changeset/72494> 312058 5 kling 2010-11-20 22:36:55 -0800 All reviewed patches have been landed. Closing bug. 312062 6 webkit.review.bot 2010-11-20 22:57:51 -0800 http://trac.webkit.org/changeset/72494 might have broken Qt Linux Release The following tests are not passing: fast/events/tabindex-focus-blur-all.html 74488 2010-11-20 15:03:00 -0800 2010-11-20 22:36:45 -0800 Proposed patch bug-49870.diff text/plain 4864 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Yjc0ZmFhMS4uOGU5ODVlMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMCBAQAogMjAxMC0xMS0yMCAgQW5kcmVhcyBLbGlu ZyAgPGtsaW5nQHdlYmtpdC5vcmc+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgW1F0XSBEcmFnZ2luZyBhIHNlbGVjdGlvbiBzaG91bGQgdXNlIGEgcmVu ZGVyaW5nIG9mIHRoZSBzZWxlY3Rpb24gYXMgImN1cnNvciIgZm9yIHRoZSBkcmFnCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTg3MAorCisgICAgICAg IEltcGxlbWVudCBGcmFtZTo6ZHJhZ0ltYWdlRm9yU2VsZWN0aW9uKCkgYW5kIHRoZSBuZWNlc3Nh cnkgRHJhZ0ltYWdlIGhlbHBlcnMgZm9yIFF0LgorCisgICAgICAgICogcGFnZS9xdC9GcmFtZVF0 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lOjpkcmFnSW1hZ2VGb3JTZWxlY3Rpb24pOgor ICAgICAgICAqIHBsYXRmb3JtL3F0L0RyYWdJbWFnZVF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OmRlbGV0ZURyYWdJbWFnZSk6CisgICAgICAgIChXZWJDb3JlOjpjcmVhdGVEcmFnSW1hZ2VGcm9t SW1hZ2UpOgorCisyMDEwLTExLTIwICBBbmRyZWFzIEtsaW5nICA8a2xpbmdAd2Via2l0Lm9yZz4K KwogICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBLaWx6ZXIuCiAKICAgICAgICAgUGF0aDogUmVt b3ZlIHVudXNlZCBtZXRob2Qgc3dhcCgpCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BhZ2UvcXQvRnJh bWVRdC5jcHAgYi9XZWJDb3JlL3BhZ2UvcXQvRnJhbWVRdC5jcHAKaW5kZXggZWQ3NWViOC4uNDY3 NTkyYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL3F0L0ZyYW1lUXQuY3BwCisrKyBiL1dlYkNv cmUvcGFnZS9xdC9GcmFtZVF0LmNwcApAQCAtMjMsNiArMjMsOSBAQAogCiAjaW5jbHVkZSAiY29u ZmlnLmgiCiAjaW5jbHVkZSAiRnJhbWUuaCIKKyNpbmNsdWRlICJGcmFtZVZpZXcuaCIKKyNpbmNs dWRlICJJbWFnZS5oIgorI2luY2x1ZGUgIkltYWdlQnVmZmVyLmgiCiAKICNpbmNsdWRlICJOb3RJ bXBsZW1lbnRlZC5oIgogCkBAIC0zNiw4ICszOSwyNyBAQCBEcmFnSW1hZ2VSZWYgRnJhbWU6Om5v ZGVJbWFnZShOb2RlKikKIAogRHJhZ0ltYWdlUmVmIEZyYW1lOjpkcmFnSW1hZ2VGb3JTZWxlY3Rp b24oKQogewotICAgIG5vdEltcGxlbWVudGVkKCk7Ci0gICAgcmV0dXJuIDA7CisgICAgaWYgKCFz ZWxlY3Rpb24oKS0+aXNSYW5nZSgpKQorICAgICAgICByZXR1cm4gMDsKKworICAgIG1fZG9jLT51 cGRhdGVMYXlvdXQoKTsKKworICAgIEludFJlY3QgcGFpbnRpbmdSZWN0ID0gZW5jbG9zaW5nSW50 UmVjdChzZWxlY3Rpb24oKS0+Ym91bmRzKCkpOworICAgIE93blB0cjxJbWFnZUJ1ZmZlcj4gYnVm ZmVyKEltYWdlQnVmZmVyOjpjcmVhdGUocGFpbnRpbmdSZWN0LnNpemUoKSkpOworICAgIGlmICgh YnVmZmVyKQorICAgICAgICByZXR1cm4gMDsKKworICAgIEdyYXBoaWNzQ29udGV4dCogY29udGV4 dCA9IGJ1ZmZlci0+Y29udGV4dCgpOworICAgIGNvbnRleHQtPnRyYW5zbGF0ZSgtcGFpbnRpbmdS ZWN0LngoKSwgLXBhaW50aW5nUmVjdC55KCkpOworICAgIGNvbnRleHQtPmNsaXAoRmxvYXRSZWN0 KDAsIDAsIHBhaW50aW5nUmVjdC5yaWdodCgpLCBwYWludGluZ1JlY3QuYm90dG9tKCkpKTsKKwor ICAgIFBhaW50QmVoYXZpb3IgcHJldmlvdXNQYWludEJlaGF2aW9yID0gbV92aWV3LT5wYWludEJl aGF2aW9yKCk7CisgICAgbV92aWV3LT5zZXRQYWludEJlaGF2aW9yKFBhaW50QmVoYXZpb3JTZWxl Y3Rpb25Pbmx5KTsKKyAgICBtX3ZpZXctPnBhaW50Q29udGVudHMoY29udGV4dCwgcGFpbnRpbmdS ZWN0KTsKKyAgICBtX3ZpZXctPnNldFBhaW50QmVoYXZpb3IocHJldmlvdXNQYWludEJlaGF2aW9y KTsKKworICAgIFJlZlB0cjxJbWFnZT4gaW1hZ2UgPSBidWZmZXItPmNvcHlJbWFnZSgpOworICAg IHJldHVybiBjcmVhdGVEcmFnSW1hZ2VGcm9tSW1hZ2UoaW1hZ2UuZ2V0KCkpOwogfQogCiB9CmRp ZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL3F0L0RyYWdJbWFnZVF0LmNwcCBiL1dlYkNvcmUv cGxhdGZvcm0vcXQvRHJhZ0ltYWdlUXQuY3BwCmluZGV4IDNhMDc3ZTEuLmIxNTNlODggMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vcXQvRHJhZ0ltYWdlUXQuY3BwCisrKyBiL1dlYkNvcmUv cGxhdGZvcm0vcXQvRHJhZ0ltYWdlUXQuY3BwCkBAIC0zNiw4ICszNiw5IEBAIEludFNpemUgZHJh Z0ltYWdlU2l6ZShEcmFnSW1hZ2VSZWYpCiAgICAgcmV0dXJuIEludFNpemUoMCwgMCk7CiB9CiAK LXZvaWQgZGVsZXRlRHJhZ0ltYWdlKERyYWdJbWFnZVJlZikKK3ZvaWQgZGVsZXRlRHJhZ0ltYWdl KERyYWdJbWFnZVJlZiBpbWFnZSkKIHsKKyAgICBkZWxldGUgaW1hZ2U7CiB9CiAKIERyYWdJbWFn ZVJlZiBzY2FsZURyYWdJbWFnZShEcmFnSW1hZ2VSZWYgaW1hZ2UsIEZsb2F0U2l6ZSkKQEAgLTUw LDkgKzUxLDEyIEBAIERyYWdJbWFnZVJlZiBkaXNzb2x2ZURyYWdJbWFnZVRvRnJhY3Rpb24oRHJh Z0ltYWdlUmVmIGltYWdlLCBmbG9hdCkKICAgICByZXR1cm4gaW1hZ2U7CiB9CiAKLURyYWdJbWFn ZVJlZiBjcmVhdGVEcmFnSW1hZ2VGcm9tSW1hZ2UoSW1hZ2UqKQorRHJhZ0ltYWdlUmVmIGNyZWF0 ZURyYWdJbWFnZUZyb21JbWFnZShJbWFnZSogaW1hZ2UpCiB7Ci0gICAgcmV0dXJuIDA7CisgICAg aWYgKCFpbWFnZSkKKyAgICAgICAgcmV0dXJuIDA7CisKKyAgICByZXR1cm4gbmV3IFFQaXhtYXAo KmltYWdlLT5uYXRpdmVJbWFnZUZvckN1cnJlbnRGcmFtZSgpKTsKIH0KIAogRHJhZ0ltYWdlUmVm IGNyZWF0ZURyYWdJbWFnZUljb25Gb3JDYWNoZWRJbWFnZShDYWNoZWRJbWFnZSopCmRpZmYgLS1n aXQgYS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwppbmRleCA4M2Nl ZDdmLi44MTliMjYzIDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisrKyBiL1dlYktp dC9xdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0xMS0yMCAgQW5kcmVhcyBLbGlu ZyAgPGtsaW5nQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgW1F0XSBEcmFnZ2luZyBhIHNlbGVjdGlvbiBzaG91bGQgdXNlIGEgcmVu ZGVyaW5nIG9mIHRoZSBzZWxlY3Rpb24gYXMgImN1cnNvciIgZm9yIHRoZSBkcmFnCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTg3MAorCisgICAgICAg ICogV2ViQ29yZVN1cHBvcnQvRHJhZ0NsaWVudFF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRy YWdDbGllbnRRdDo6c3RhcnREcmFnKTogUGFzcyB0aGUgRHJhZ0ltYWdlIHRvIFFEcmFnOjpzZXRQ aXhtYXAoKQorCiAyMDEwLTExLTIwICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdt YWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByNzI0NzEuCmRpZmYg LS1naXQgYS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRHJhZ0NsaWVudFF0LmNwcCBiL1dlYktp dC9xdC9XZWJDb3JlU3VwcG9ydC9EcmFnQ2xpZW50UXQuY3BwCmluZGV4IDUyMjI5ZGMuLmYxMzYz MjggMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9EcmFnQ2xpZW50UXQuY3Bw CisrKyBiL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9EcmFnQ2xpZW50UXQuY3BwCkBAIC04Niw3 ICs4Niw3IEBAIHZvaWQgRHJhZ0NsaWVudFF0Ojp3aWxsUGVyZm9ybURyYWdTb3VyY2VBY3Rpb24o RHJhZ1NvdXJjZUFjdGlvbiwgY29uc3QgSW50UG9pbnQmCiB7CiB9CiAKLXZvaWQgRHJhZ0NsaWVu dFF0OjpzdGFydERyYWcoRHJhZ0ltYWdlUmVmLCBjb25zdCBJbnRQb2ludCYsIGNvbnN0IEludFBv aW50JiwgQ2xpcGJvYXJkKiBjbGlwYm9hcmQsIEZyYW1lKiBmcmFtZSwgYm9vbCkKK3ZvaWQgRHJh Z0NsaWVudFF0OjpzdGFydERyYWcoRHJhZ0ltYWdlUmVmIGRyYWdJbWFnZSwgY29uc3QgSW50UG9p bnQmLCBjb25zdCBJbnRQb2ludCYsIENsaXBib2FyZCogY2xpcGJvYXJkLCBGcmFtZSogZnJhbWUs IGJvb2wpCiB7CiAjaWZuZGVmIFFUX05PX0RSQUdBTkREUk9QCiAgICAgUU1pbWVEYXRhKiBjbGlw Ym9hcmREYXRhID0gc3RhdGljX2Nhc3Q8Q2xpcGJvYXJkUXQqPihjbGlwYm9hcmQpLT5jbGlwYm9h cmREYXRhKCk7CkBAIC05NCw3ICs5NCw5IEBAIHZvaWQgRHJhZ0NsaWVudFF0OjpzdGFydERyYWco RHJhZ0ltYWdlUmVmLCBjb25zdCBJbnRQb2ludCYsIGNvbnN0IEludFBvaW50JiwgQ2xpCiAgICAg UVdpZGdldCogdmlldyA9IG1fd2ViUGFnZS0+dmlldygpOwogICAgIGlmICh2aWV3KSB7CiAgICAg ICAgIFFEcmFnKiBkcmFnID0gbmV3IFFEcmFnKHZpZXcpOwotICAgICAgICBpZiAoY2xpcGJvYXJk RGF0YSAmJiBjbGlwYm9hcmREYXRhLT5oYXNJbWFnZSgpKQorICAgICAgICBpZiAoZHJhZ0ltYWdl KQorICAgICAgICAgICAgZHJhZy0+c2V0UGl4bWFwKCpkcmFnSW1hZ2UpOworICAgICAgICBlbHNl IGlmIChjbGlwYm9hcmREYXRhICYmIGNsaXBib2FyZERhdGEtPmhhc0ltYWdlKCkpCiAgICAgICAg ICAgICBkcmFnLT5zZXRQaXhtYXAocXZhcmlhbnRfY2FzdDxRUGl4bWFwPihjbGlwYm9hcmREYXRh LT5pbWFnZURhdGEoKSkpOwogICAgICAgICBEcmFnT3BlcmF0aW9uIGRyYWdPcGVyYXRpb25NYXNr ID0gY2xpcGJvYXJkLT5zb3VyY2VPcGVyYXRpb24oKTsKICAgICAgICAgZHJhZy0+c2V0TWltZURh dGEoY2xpcGJvYXJkRGF0YSk7Cg==