49865 2010-11-20 08:50:35 -0800 REGRESSION(r72471): broke two IME tests on Qt (Requested by kling on #webkit). 2010-11-20 09:33:45 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 49787 1 webkit.review.bot webkit.review.bot commit-queue kling oldest_to_newest 311932 0 webkit.review.bot 2010-11-20 08:50:35 -0800 http://trac.webkit.org/changeset/72471 broke the build: broke two IME tests on Qt (Requested by kling on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 311933 1 74482 webkit.review.bot 2010-11-20 08:50:56 -0800 Created attachment 74482 ROLLOUT of r72471 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID --ignore-builders where ATTACHMENT_ID is the ID of this attachment. 311941 2 74482 commit-queue 2010-11-20 09:33:40 -0800 Comment on attachment 74482 ROLLOUT of r72471 Clearing flags on attachment: 74482 Committed r72475: <http://trac.webkit.org/changeset/72475> 311942 3 commit-queue 2010-11-20 09:33:45 -0800 All reviewed patches have been landed. Closing bug. 74482 2010-11-20 08:50:56 -0800 2010-11-20 09:33:40 -0800 ROLLOUT of r72471 bug-49865-20101120165052.patch text/plain 2913 webkit.review.bot ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwIGIvV2ViS2l0L3F0L0FwaS9x d2VicGFnZS5jcHAKaW5kZXggYTgxYWQwOGE2NDRjNWI4NDNlZTg2ZDk0OGIzMDYxNDNkYjY0YWJh ZS4uMmU4YzZiN2M4ZmEwMzUzNTE2MmRlYjM5MmZmMTVmMjcxZmI0OGVmNSAxMDA2NDQKLS0tIGEv V2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5j cHAKQEAgLTEwODAsMTUgKzEwODAsOSBAQCB2b2lkIFFXZWJQYWdlUHJpdmF0ZTo6aW5wdXRNZXRo b2RFdmVudChRSW5wdXRNZXRob2RFdmVudCAqZXYpCiAgICAgICAgIH0KICAgICB9CiAKLSAgICBp ZiAobm9kZSAmJiBldi0+cmVwbGFjZW1lbnRMZW5ndGgoKSA+IDApIHsKLSAgICAgICAgaW50IGN1 cnNvclBvcyA9IGZyYW1lLT5zZWxlY3Rpb24oKS0+ZXh0ZW50KCkub2Zmc2V0SW5Db250YWluZXJO b2RlKCk7Ci0gICAgICAgIGludCBzdGFydCA9IGN1cnNvclBvcyArIGV2LT5yZXBsYWNlbWVudFN0 YXJ0KCk7Ci0gICAgICAgIHNldFNlbGVjdGlvblJhbmdlKG5vZGUsIHN0YXJ0LCBzdGFydCArIGV2 LT5yZXBsYWNlbWVudExlbmd0aCgpKTsKLSAgICAgICAgLy8gQ29tbWl0IHJlZ2FyZGxlc3Mgb2Yg d2hldGhlciBjb21taXRTdHJpbmcgaXMgZW1wdHksIHRvIGdldCByaWQgb2Ygc2VsZWN0aW9uLgor ICAgIGlmICghZXYtPmNvbW1pdFN0cmluZygpLmlzRW1wdHkoKSkKICAgICAgICAgZWRpdG9yLT5j b25maXJtQ29tcG9zaXRpb24oZXYtPmNvbW1pdFN0cmluZygpKTsKLSAgICB9IGVsc2UgaWYgKCFl di0+Y29tbWl0U3RyaW5nKCkuaXNFbXB0eSgpKQotICAgICAgICBlZGl0b3ItPmNvbmZpcm1Db21w b3NpdGlvbihldi0+Y29tbWl0U3RyaW5nKCkpOwotICAgIGlmICghaGFzU2VsZWN0aW9uICYmICFl di0+cHJlZWRpdFN0cmluZygpLmlzRW1wdHkoKSkKKyAgICBlbHNlIGlmICghaGFzU2VsZWN0aW9u ICYmICFldi0+cHJlZWRpdFN0cmluZygpLmlzRW1wdHkoKSkKICAgICAgICAgZWRpdG9yLT5zZXRD b21wb3NpdGlvbihldi0+cHJlZWRpdFN0cmluZygpLCB1bmRlcmxpbmVzLCAwLCAwKTsKIAogICAg IGV2LT5hY2NlcHQoKTsKZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQv cXQvQ2hhbmdlTG9nCmluZGV4IGVlYzQ5NGVjZTQxNGFhN2M3Nzc0YjlmYzUyYTVkYjE5MDMxZmJh OWYuLjgzY2VkN2YwMmZmMzgxMDUzM2MyYTNlYzA5Yzk5Mzg1ZDRjNTAwN2IgMTAwNjQ0Ci0tLSBh L1dlYktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE2IEBACisyMDEwLTExLTIwICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWls LmNvbT4KKworICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByNzI0NzEuCisgICAgICAg IGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzcyNDcxCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00OTg2NQorCisgICAgICAgIGJyb2tlIHR3 byBJTUUgdGVzdHMgb24gUXQgKFJlcXVlc3RlZCBieSBrbGluZyBvbiAjd2Via2l0KS4KKworICAg ICAgICAqIEFwaS9xd2VicGFnZS5jcHA6CisgICAgICAgIChRV2ViUGFnZVByaXZhdGU6OmlucHV0 TWV0aG9kRXZlbnQpOgorICAgICAgICAqIHRlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHA6 CisgICAgICAgICh0c3RfUVdlYlBhZ2U6OmlucHV0TWV0aG9kcyk6CisKIDIwMTAtMTEtMTkgIEty aXN0aWFuIEFtbGllICA8a3Jpc3RpYW4uYW1saWVAbm9raWEuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IEFuZHJlYXMgS2xpbmcuCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvdGVzdHMvcXdlYnBh Z2UvdHN0X3F3ZWJwYWdlLmNwcCBiL1dlYktpdC9xdC90ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBh Z2UuY3BwCmluZGV4IDFmNmFkYTBjMjgwNDMwMzljMmQ1ZDZiMTlhZTU5YjczMGViYWY4NDcuLjQx Mzk4NGEwNTBlOTc1Y2RiZmI0YmQ4MGU2ZWM5MDg4ZDE4YzgxMjMgMTAwNjQ0Ci0tLSBhL1dlYktp dC9xdC90ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3BwCisrKyBiL1dlYktpdC9xdC90ZXN0 cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3BwCkBAIC0xNTY4LDIwICsxNTY4LDYgQEAgdm9pZCB0 c3RfUVdlYlBhZ2U6OmlucHV0TWV0aG9kcygpCiAgICAgcGFnZS0+ZXZlbnQoJmV2cHJlcyk7CiAg ICAgcGFnZS0+ZXZlbnQoJmV2cmVsKTsKIAotICAgIHsKLSAgICAgICAgUUxpc3Q8UUlucHV0TWV0 aG9kRXZlbnQ6OkF0dHJpYnV0ZT4gYXR0cmlidXRlczsKLSAgICAgICAgUUlucHV0TWV0aG9kRXZl bnQgZXZlbnQoUVN0cmluZygpLCBhdHRyaWJ1dGVzKTsKLSAgICAgICAgZXZlbnQuc2V0Q29tbWl0 U3RyaW5nKCJYWFgiLCAwLCAwKTsKLSAgICAgICAgcGFnZS0+ZXZlbnQoJmV2ZW50KTsKLSAgICAg ICAgZXZlbnQuc2V0Q29tbWl0U3RyaW5nKFFTdHJpbmcoKSwgLTIsIDIpOyAvLyBFcmFzZSB0d28g Y2hhcmFjdGVycy4KLSAgICAgICAgcGFnZS0+ZXZlbnQoJmV2ZW50KTsKLSAgICAgICAgZXZlbnQu c2V0Q29tbWl0U3RyaW5nKFFTdHJpbmcoKSwgLTEsIDEpOyAvLyBFcmFzZSBvbmUgY2hhcmFjdGVy LgotICAgICAgICBwYWdlLT5ldmVudCgmZXZlbnQpOwotICAgICAgICB2YXJpYW50ID0gcGFnZS0+ aW5wdXRNZXRob2RRdWVyeShRdDo6SW1TdXJyb3VuZGluZ1RleHQpOwotICAgICAgICB2YWx1ZSA9 IHZhcmlhbnQudmFsdWU8UVN0cmluZz4oKTsKLSAgICAgICAgUUNPTVBBUkUodmFsdWUsIFFTdHJp bmcoIlF0V2ViS2l0IikpOwotICAgIH0KLQogICAgIC8vTW92ZSB0byB0aGUgc3RhcnQgb2YgdGhl IGxpbmUKICAgICBwYWdlLT50cmlnZ2VyQWN0aW9uKFFXZWJQYWdlOjpNb3ZlVG9TdGFydE9mTGlu ZSk7CiAK