49858 2010-11-19 22:21:21 -0800 Add a mechanism for Windows pre-build/pre-link/post-build events to be separated into individual cmd files 2010-11-29 16:10:46 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 sfalken sfalken aroben oldest_to_newest 311870 0 sfalken 2010-11-19 22:21:21 -0800 Add a mechanism for Windows pre-build/pre-link/post-build events to be separated into individual cmd files 311871 1 74467 sfalken 2010-11-19 22:25:21 -0800 Created attachment 74467 Patch 312408 2 74467 bweinstein 2010-11-22 10:45:27 -0800 Comment on attachment 74467 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=74467&action=review The changes looks good, just think the ChangeLog could use a little more information for other people wanting to move scripts into their own files. > JavaScriptCore/ChangeLog:6 > + Add a mechanism for Windows pre-build/pre-link/post-build events to be separated into individual cmd files > + https://bugs.webkit.org/show_bug.cgi?id=49858 It might be nice here to talk a little more about how other projects create/adopt these new cmd files (create them next to the vsprops files, with the correct names (ProjectName + Pre/Post + Build/Link). 312410 3 74467 aroben 2010-11-22 10:46:45 -0800 Comment on attachment 74467 Patch I agree with Brian's comments. It's weird that WTF doesn't have a pre-build event. Maybe that's a relic from when it (instead of JavaScriptCoreGenerated) was the first project? 314706 4 sfalken 2010-11-29 16:10:46 -0800 Committed r72846: <http://trac.webkit.org/changeset/72846> 74467 2010-11-19 22:25:21 -0800 2010-11-22 10:46:45 -0800 Patch bug-49858-20101119222506.patch text/plain 5923 sfalken SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDcyNDY3KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMTEtMTkgIFN0ZXZlIEZh bGtlbmJ1cmcgIDxzZmFsa2VuQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSBtZWNoYW5pc20gZm9yIFdpbmRvd3MgcHJlLWJ1 aWxkL3ByZS1saW5rL3Bvc3QtYnVpbGQgZXZlbnRzIHRvIGJlIHNlcGFyYXRlZCBpbnRvIGluZGl2 aWR1YWwgY21kIGZpbGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00OTg1OAorCisgICAgICAgICogSmF2YVNjcmlwdENvcmUudmNwcm9qL1dURi9XVEZD b21tb24udnNwcm9wczoKKyAgICAgICAgKiBKYXZhU2NyaXB0Q29yZS52Y3Byb2ovV1RGL1dURlBv c3RCdWlsZC5jbWQ6IEFkZGVkLgorICAgICAgICAqIEphdmFTY3JpcHRDb3JlLnZjcHJvai9XVEYv V1RGUHJlQnVpbGQuY21kOiBBZGRlZC4KKwogMjAxMC0xMS0xOSAgV2lsbGlhbSBDaGFuICA8d2ls bGNoYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIExldmluLgpJ bmRleDogSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUudmNwcm9qL1dURi9XVEZDb21tb24u dnNwcm9wcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS52Y3By b2ovV1RGL1dURkNvbW1vbi52c3Byb3BzCShyZXZpc2lvbiA3MjQ2NykKKysrIEphdmFTY3JpcHRD b3JlL0phdmFTY3JpcHRDb3JlLnZjcHJvai9XVEYvV1RGQ29tbW9uLnZzcHJvcHMJKHdvcmtpbmcg Y29weSkKQEAgLTE3LDEyICsxNyw0IEBACiAJCUFkZGl0aW9uYWxEZXBlbmRlbmNpZXM9InVzZXIz Mi5saWIiDQogCQlPdXRwdXRGaWxlPSIkKE91dERpcilcJChQcm9qZWN0TmFtZSkkKFdlYktpdENv bmZpZ1N1ZmZpeCkubGliIg0KIAkvPg0KLQk8VG9vbA0KLQkJTmFtZT0iVkNQb3N0QnVpbGRFdmVu dFRvb2wiDQotCQlDb21tYW5kTGluZT0iaWYgZXhpc3QgJnF1b3Q7JChXZWJLaXRPdXRwdXREaXIp XGJ1aWxkZmFpbGVkJnF1b3Q7IGRlbCAmcXVvdDskKFdlYktpdE91dHB1dERpcilcYnVpbGRmYWls ZWQmcXVvdDsiDQotCS8+DQotCTxUb29sDQotCQlOYW1lPSJWQ1ByZUJ1aWxkRXZlbnRUb29sIg0K LQkJQ29tbWFuZExpbmU9IiVTeXN0ZW1Ecml2ZSVcY3lnd2luXGJpblx3aGljaC5leGUgYmFzaCYj eDBEOyYjeDBBO2lmIGVycm9ybGV2ZWwgMSBzZXQgUEFUSD0lU3lzdGVtRHJpdmUlXGN5Z3dpblxi aW47JVBBVEglJiN4MEQ7JiN4MEE7Y21kIC9jJiN4MEQ7JiN4MEE7Ig0KLQkvPg0KIDwvVmlzdWFs U3R1ZGlvUHJvcGVydHlTaGVldD4NCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29y ZS52Y3Byb2ovV1RGL1dURlBvc3RCdWlsZC5jbWQKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENv cmUvSmF2YVNjcmlwdENvcmUudmNwcm9qL1dURi9XVEZQb3N0QnVpbGQuY21kCShyZXZpc2lvbiAw KQorKysgSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUudmNwcm9qL1dURi9XVEZQb3N0QnVp bGQuY21kCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxIEBACitpZiBleGlzdCAiJChXZWJLaXRPdXRw dXREaXIpXGJ1aWxkZmFpbGVkIiBkZWwgIiQoV2ViS2l0T3V0cHV0RGlyKVxidWlsZGZhaWxlZCIN CkluZGV4OiBKYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS52Y3Byb2ovV1RGL1dURlByZUJ1 aWxkLmNtZAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS52Y3By b2ovV1RGL1dURlByZUJ1aWxkLmNtZAkocmV2aXNpb24gMCkKKysrIEphdmFTY3JpcHRDb3JlL0ph dmFTY3JpcHRDb3JlLnZjcHJvai9XVEYvV1RGUHJlQnVpbGQuY21kCShyZXZpc2lvbiAwKQpAQCAt MCwwICsxLDMgQEAKKyVTeXN0ZW1Ecml2ZSVcY3lnd2luXGJpblx3aGljaC5leGUgYmFzaA0KK2lm IGVycm9ybGV2ZWwgMSBzZXQgUEFUSD0lU3lzdGVtRHJpdmUlXGN5Z3dpblxiaW47JVBBVEglDQor Y21kIC9jDQpJbmRleDogV2ViS2l0TGlicmFyaWVzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJLaXRMaWJyYXJpZXMvQ2hhbmdlTG9nCShyZXZpc2lvbiA3MjQ2NykKKysrIFdlYktpdExpYnJh cmllcy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0xMS0x OSAgU3RldmUgRmFsa2VuYnVyZyAgPHNmYWxrZW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIG1lY2hhbmlzbSBmb3IgV2lu ZG93cyBwcmUtYnVpbGQvcHJlLWxpbmsvcG9zdC1idWlsZCBldmVudHMgdG8gYmUgc2VwYXJhdGVk IGludG8gaW5kaXZpZHVhbCBjbWQgZmlsZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTQ5ODU4CisKKyAgICAgICAgKiB3aW4vdG9vbHMvdnNwcm9wcy9j b21tb24udnNwcm9wczoKKyAgICAgICAgKiB3aW4vdG9vbHMvdnNwcm9wcy9yZWxlYXNlLnZzcHJv cHM6CisKIDIwMTAtMTEtMTggIFN0ZXZlIEZhbGtlbmJ1cmcgIDxzZmFsa2VuQGFwcGxlLmNvbT4K IAogICAgICAgICBSdWJiZXItc3RhbXBlZCBieSBBZGFtIFJvYmVuLgpJbmRleDogV2ViS2l0TGli cmFyaWVzL3dpbi90b29scy92c3Byb3BzL2NvbW1vbi52c3Byb3BzCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YktpdExpYnJhcmllcy93aW4vdG9vbHMvdnNwcm9wcy9jb21tb24udnNwcm9wcwkocmV2aXNpb24g NzI0NjcpCisrKyBXZWJLaXRMaWJyYXJpZXMvd2luL3Rvb2xzL3ZzcHJvcHMvY29tbW9uLnZzcHJv cHMJKHdvcmtpbmcgY29weSkKQEAgLTYsNyArNiw3IEBACiAJT3V0cHV0RGlyZWN0b3J5PSIkKFdl YktpdE91dHB1dERpcilcYmluIgogCUludGVybWVkaWF0ZURpcmVjdG9yeT0iJChXZWJLaXRPdXRw dXREaXIpXG9ialwkKFByb2plY3ROYW1lKVwkKENvbmZpZ3VyYXRpb25OYW1lKSIKIAk+Ci0JPFRv b2wKKyAgPFRvb2wKIAkJTmFtZT0iVkNDTENvbXBpbGVyVG9vbCIKIAkJQWRkaXRpb25hbE9wdGlv bnM9Ii9HUyIKIAkJUHJlcHJvY2Vzc29yRGVmaW5pdGlvbnM9IldJTjMyO19XSU5ET1dTO1dJTlZF Uj0weDUwMTtfV0lOMzJfV0lOTlQ9MHg1MDE7X1dJTjMyX0lFPTB4NjAwO19DUlRfU0VDVVJFX0NQ UF9PVkVSTE9BRF9TVEFOREFSRF9OQU1FUz0xO19fUFJPRFVDVElPTl9fPTAkKFByb2R1Y3Rpb25C dWlsZCk7X0hBU19FWENFUFRJT05TPTA7QlVJTERJTkdfJChQcm9qZWN0TmFtZSkiCkBAIC0xNywx MiArMTcsMTIgQEAKIAkJRGVidWdJbmZvcm1hdGlvbkZvcm1hdD0iMyIKIAkJRGlzYWJsZVNwZWNp ZmljV2FybmluZ3M9IjQwMTg7NDA2ODs0MDk5OzQxMDA7NDEyNzs0MTM4OzQxODA7NDE4OTs0MjAx OzQyNDQ7NDI1MTs0Mjc1OzQyODg7NDI5MTs0MzA1OzQzNDQ7NDM1NTs0Mzg5OzQ1MDM7NDUwNTs0 NTEwOzQ1MTI7NDYxMDs0NzA2OzQ4MDA7NDk1MTs0OTUyOzQ5OTY7NjAxMTs2MDMxOzYyMTE7NjI0 Njs2MjU1OzYzODciCiAJLz4KLQk8VG9vbAorICA8VG9vbAogCQlOYW1lPSJWQ0xpYnJhcmlhblRv b2wiCiAJCUFkZGl0aW9uYWxPcHRpb25zPSIvaWdub3JlOjQyMjEiCiAJCU91dHB1dEZpbGU9IiQo T3V0RGlyKVwkKFByb2plY3ROYW1lKSQoV2ViS2l0Q29uZmlnU3VmZml4KS5saWIiCiAJLz4KLQk8 VG9vbAorICA8VG9vbAogCQlOYW1lPSJWQ0xpbmtlclRvb2wiCiAJCUxpbmtMaWJyYXJ5RGVwZW5k ZW5jaWVzPSJmYWxzZSIKICAgICAgICAgICAgICAgICBBZGRpdGlvbmFsT3B0aW9ucz0iL1NBRkVT RUggL0ZJWEVEOk5PIC9keW5hbWljYmFzZSAvaWdub3JlOjQyMjEiCkBAIC0zMywyMiArMzMsMzQg QEAKIAkJSW1wb3J0TGlicmFyeT0iJChXZWJLaXRPdXRwdXREaXIpXGxpYlwkKFRhcmdldE5hbWUp LmxpYiIKIAkJVGFyZ2V0TWFjaGluZT0iMSIKIAkvPgotCTxUb29sCisgIDxUb29sCiAJCU5hbWU9 IlZDTUlETFRvb2wiCiAJCVByZXByb2Nlc3NvckRlZmluaXRpb25zPSJfX1BST0RVQ1RJT05fXz0w JChQcm9kdWN0aW9uQnVpbGQpIgogCQlXYXJuQXNFcnJvcj0idHJ1ZSIKIAkJSGVhZGVyRmlsZU5h bWU9IiQoT3V0RGlyKVwkKElucHV0TmFtZSkuaCIKIAkvPgotCTxUb29sCisgIDxUb29sCiAJCU5h bWU9IlZDUmVzb3VyY2VDb21waWxlclRvb2wiCiAJCUN1bHR1cmU9IjEwMzMiCiAJCUFkZGl0aW9u YWxJbmNsdWRlRGlyZWN0b3JpZXM9IiZxdW90OyQoSW50RGlyKVxpbmNsdWRlJnF1b3Q7IgogCS8+ Ci0JPFVzZXJNYWNybworICA8VG9vbAorCQlOYW1lPSJWQ1ByZUJ1aWxkRXZlbnRUb29sIgorCQlD b21tYW5kTGluZT0iaWYgZXhpc3QgJnF1b3Q7JChQcm9qZWN0RGlyKVwkKFByb2plY3ROYW1lKVBy ZUJ1aWxkLmNtZCZxdW90OyAmcXVvdDskKFByb2plY3REaXIpXCQoUHJvamVjdE5hbWUpUHJlQnVp bGQuY21kJnF1b3Q7IgorCS8+CisgIDxUb29sCisJCU5hbWU9IlZDUHJlTGlua0V2ZW50VG9vbCIK KwkJQ29tbWFuZExpbmU9ImlmIGV4aXN0ICZxdW90OyQoUHJvamVjdERpcilcJChQcm9qZWN0TmFt ZSlQcmVMaW5rLmNtZCZxdW90OyAmcXVvdDskKFByb2plY3REaXIpXCQoUHJvamVjdE5hbWUpUHJl TGluay5jbWQmcXVvdDsiCisJLz4KKyAgPFRvb2wKKwkJTmFtZT0iVkNQb3N0QnVpbGRFdmVudFRv b2wiCisJCUNvbW1hbmRMaW5lPSJpZiBleGlzdCAmcXVvdDskKFByb2plY3REaXIpXCQoUHJvamVj dE5hbWUpUG9zdEJ1aWxkLmNtZCZxdW90OyAmcXVvdDskKFByb2plY3REaXIpXCQoUHJvamVjdE5h bWUpUG9zdEJ1aWxkLmNtZCZxdW90OyIKKwkvPgorICA8VXNlck1hY3JvCiAJCU5hbWU9IlByb2R1 Y3Rpb25CdWlsZCIKIAkJVmFsdWU9IiQoUFJPRFVDVElPTikiCiAJLz4KLQk8VXNlck1hY3JvCisg IDxVc2VyTWFjcm8KIAkJTmFtZT0iQW5hbHl6ZVdpdGhMYXJnZVN0YWNrIgogCQlWYWx1ZT0iIgog CS8+CkluZGV4OiBXZWJLaXRMaWJyYXJpZXMvd2luL3Rvb2xzL3ZzcHJvcHMvcmVsZWFzZS52c3By b3BzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYktpdExpYnJhcmllcy93aW4vdG9vbHMvdnNwcm9wcy9yZWxl YXNlLnZzcHJvcHMJKHJldmlzaW9uIDcyNDY3KQorKysgV2ViS2l0TGlicmFyaWVzL3dpbi90b29s cy92c3Byb3BzL3JlbGVhc2UudnNwcm9wcwkod29ya2luZyBjb3B5KQpAQCAtMTgsMTAgKzE4LDYg QEAKIAkJT3B0aW1pemVGb3JXaW5kb3dzOTg9IjEiCiAJLz4KIAk8VG9vbAotCQlOYW1lPSJWQ1By ZUxpbmtFdmVudFRvb2wiCi0JCUNvbW1hbmRMaW5lPSJpZiBub3QgZXhpc3QgJnF1b3Q7JChXZWJL aXRPdXRwdXREaXIpXHB1YmxpY1xzeW0mcXVvdDsgbWtkaXIgJnF1b3Q7JChXZWJLaXRPdXRwdXRE aXIpXHB1YmxpY1xzeW0mcXVvdDsiCi0JLz4KLQk8VG9vbAogCQlOYW1lPSJWQ1Jlc291cmNlQ29t cGlsZXJUb29sIgogCQlQcmVwcm9jZXNzb3JEZWZpbml0aW9ucz0iTkRFQlVHIgogCS8+Cg==