49847 2010-11-19 18:03:11 -0800 Add a didFail WKContextDownloadClient callback 2010-11-19 18:21:37 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca webkit.review.bot oldest_to_newest 311791 0 andersca 2010-11-19 18:03:11 -0800 Add a didFail WKContextDownloadClient callback 311794 1 74452 andersca 2010-11-19 18:05:22 -0800 Created attachment 74452 Patch 311796 2 webkit.review.bot 2010-11-19 18:07:44 -0800 Attachment 74452 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebKit2/ChangeLog', u'WebKit2/UIProcess/API/C/WKContext.h', u'WebKit2/UIProcess/Downloads/DownloadProxy.cpp', u'WebKit2/UIProcess/WebDownloadClient.cpp', u'WebKit2/UIProcess/WebDownloadClient.h']" exit_code: 1 WebKit2/UIProcess/WebDownloadClient.h:34: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 311802 3 andersca 2010-11-19 18:21:37 -0800 Committed r72461: <http://trac.webkit.org/changeset/72461> 74452 2010-11-19 18:05:22 -0800 2010-11-19 18:06:26 -0800 Patch bug-49847-20101119180523.patch text/plain 4800 andersca ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg MmM0NWNhNGQwYTQxZjMyYWFmMWJhYTM1ZmFjMzAyYzdjMmNkMmFmMi4uMzgwZTExNmU0NmY4ODQ0 MmQ0ZWY1NGE4NGIyYzA1ZTNhMzdmOThiMiAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyNCBAQAogMjAxMC0xMS0xOSAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIGRpZEZhaWwgV0tDb250ZXh0RG93bmxv YWRDbGllbnQgY2FsbGJhY2sKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTQ5ODQ3CisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0MvV0tDb250ZXh0Lmg6 CisgICAgICAgIEFkZCBkaWRGYWlsIGNhbGxiYWNrLgorCisgICAgICAgICogVUlQcm9jZXNzL0Rv d25sb2Fkcy9Eb3dubG9hZFByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6RG93bmxvYWRQcm94 eTo6ZGlkRmFpbCk6CisgICAgICAgIENhbGwgV2ViRG93bmxvYWRDbGllbnQ6OmRpZEZhaWwuCisK KyAgICAgICAgKiBVSVByb2Nlc3MvV2ViRG93bmxvYWRDbGllbnQuY3BwOgorICAgICAgICAoV2Vi S2l0OjpXZWJEb3dubG9hZENsaWVudDo6ZGlkRmFpbCk6CisgICAgICAgIENhbGwgdGhlIGRpZEZh aWwgY2xpZW50IGZ1bmN0aW9uLgorCisKKzIwMTAtMTEtMTkgIEFuZGVycyBDYXJsc3NvbiAgPGFu ZGVyc2NhQGFwcGxlLmNvbT4KKwogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgogCiAg ICAgICAgIEV4dGVuZCBzYW5kYm94IHdoZW4gZG93bmxvYWRpbmcgZmlsZXMKZGlmZiAtLWdpdCBh L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLQ29udGV4dC5oIGIvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL0MvV0tDb250ZXh0LmgKaW5kZXggY2RhZDBmZjdhZjMzNTcwZGUyODM1MmMxYjkxNjEzZWY1 YzRhNjM2NC4uOTBjYThlOTFlZGQxMWZmZmI5MjhhYTcwZGUxYmI3N2NlYjNjN2NkOCAxMDA2NDQK LS0tIGEvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tDb250ZXh0LmgKKysrIGIvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL0MvV0tDb250ZXh0LmgKQEAgLTc3LDYgKzc3LDcgQEAgdHlwZWRlZiBib29s ICgqV0tDb250ZXh0RG93bmxvYWRTaG91bGREZWNvZGVTb3VyY2VEYXRhT2ZNSU1FVHlwZUNhbGxi YWNrKShXS0NvbnQKIHR5cGVkZWYgV0tTdHJpbmdSZWYgKCpXS0NvbnRleHREb3dubG9hZERlY2lk ZURlc3RpbmF0aW9uV2l0aFN1Z2dlc3RlZEZpbGVuYW1lQ2FsbGJhY2spKFdLQ29udGV4dFJlZiBj b250ZXh0LCBXS0Rvd25sb2FkUmVmIGRvd25sb2FkLCBXS1N0cmluZ1JlZiBmaWxlbmFtZSwgYm9v bCogYWxsb3dPdmVyd3JpdGUsIGNvbnN0IHZvaWQgKmNsaWVudEluZm8pOwogdHlwZWRlZiB2b2lk ICgqV0tDb250ZXh0RG93bmxvYWREaWRDcmVhdGVEZXN0aW5hdGlvbkNhbGxiYWNrKShXS0NvbnRl eHRSZWYgY29udGV4dCwgV0tEb3dubG9hZFJlZiBkb3dubG9hZCwgV0tTdHJpbmdSZWYgcGF0aCwg Y29uc3Qgdm9pZCAqY2xpZW50SW5mbyk7CiB0eXBlZGVmIHZvaWQgKCpXS0NvbnRleHREb3dubG9h ZERpZEZpbmlzaENhbGxiYWNrKShXS0NvbnRleHRSZWYgY29udGV4dCwgV0tEb3dubG9hZFJlZiBk b3dubG9hZCwgY29uc3Qgdm9pZCAqY2xpZW50SW5mbyk7Cit0eXBlZGVmIHZvaWQgKCpXS0NvbnRl eHREb3dubG9hZERpZEZhaWxDYWxsYmFjaykoV0tDb250ZXh0UmVmIGNvbnRleHQsIFdLRG93bmxv YWRSZWYgZG93bmxvYWQsIFdLRXJyb3JSZWYgZXJyb3IsIGNvbnN0IHZvaWQgKmNsaWVudEluZm8p OwogCiBzdHJ1Y3QgV0tDb250ZXh0RG93bmxvYWRDbGllbnQgewogICAgIGludCAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdmVy c2lvbjsKQEAgLTg4LDYgKzg5LDcgQEAgc3RydWN0IFdLQ29udGV4dERvd25sb2FkQ2xpZW50IHsK ICAgICBXS0NvbnRleHREb3dubG9hZERlY2lkZURlc3RpbmF0aW9uV2l0aFN1Z2dlc3RlZEZpbGVu YW1lQ2FsbGJhY2sgICAgIGRlY2lkZURlc3RpbmF0aW9uV2l0aFN1Z2dlc3RlZEZpbGVuYW1lOwog ICAgIFdLQ29udGV4dERvd25sb2FkRGlkQ3JlYXRlRGVzdGluYXRpb25DYWxsYmFjayAgICAgICAg ICAgICAgICAgICAgICAgZGlkQ3JlYXRlRGVzdGluYXRpb247CiAgICAgV0tDb250ZXh0RG93bmxv YWREaWRGaW5pc2hDYWxsYmFjayAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkaWRG aW5pc2g7CisgICAgV0tDb250ZXh0RG93bmxvYWREaWRGYWlsQ2FsbGJhY2sgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBkaWRGYWlsOwogfTsKIHR5cGVkZWYgc3RydWN0IFdLQ29u dGV4dERvd25sb2FkQ2xpZW50IFdLQ29udGV4dERvd25sb2FkQ2xpZW50OwogCmRpZmYgLS1naXQg YS9XZWJLaXQyL1VJUHJvY2Vzcy9Eb3dubG9hZHMvRG93bmxvYWRQcm94eS5jcHAgYi9XZWJLaXQy L1VJUHJvY2Vzcy9Eb3dubG9hZHMvRG93bmxvYWRQcm94eS5jcHAKaW5kZXggN2RkMmE0ZTU3YmEz NmEyZjBhNDRiOTY2NzY1MzJhNGZkODY0ZDJjMi4uMmUxMzQzYzEyYjE0MDczYWY2YzU5NjE4OTg2 MjFiMzY2YTcyNGEwOSAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9VSVByb2Nlc3MvRG93bmxvYWRzL0Rv d25sb2FkUHJveHkuY3BwCisrKyBiL1dlYktpdDIvVUlQcm9jZXNzL0Rvd25sb2Fkcy9Eb3dubG9h ZFByb3h5LmNwcApAQCAtMTIyLDkgKzEyMiwxMiBAQCB2b2lkIERvd25sb2FkUHJveHk6OmRpZEZp bmlzaCgpCiAgICAgbV93ZWJDb250ZXh0LT5kb3dubG9hZENsaWVudCgpLmRpZEZpbmlzaChtX3dl YkNvbnRleHQsIHRoaXMpOwogfQogCi12b2lkIERvd25sb2FkUHJveHk6OmRpZEZhaWwoY29uc3Qg UmVzb3VyY2VFcnJvciYpCit2b2lkIERvd25sb2FkUHJveHk6OmRpZEZhaWwoY29uc3QgUmVzb3Vy Y2VFcnJvciYgZXJyb3IpCiB7Ci0gICAgLy8gRklYTUU6IEltcGxlbWVudC4KKyAgICBpZiAoIW1f d2ViQ29udGV4dCkKKyAgICAgICAgcmV0dXJuOworCisgICAgbV93ZWJDb250ZXh0LT5kb3dubG9h ZENsaWVudCgpLmRpZEZhaWwobV93ZWJDb250ZXh0LCB0aGlzLCBlcnJvcik7CiB9CiAKIH0gLy8g bmFtZXNwYWNlIFdlYktpdApkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViRG93bmxv YWRDbGllbnQuY3BwIGIvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViRG93bmxvYWRDbGllbnQuY3BwCmlu ZGV4IGE4ZTc3OTg0ZWY1ODZiYWVkM2Q1ODAwNTdiMzg3NDM1MWVmOTVjY2YuLjdlNjlkOTY3NTUz YWM4M2JjM2M2MTc0MDEwOTg5NzA4Y2JhOTI5YjUgMTAwNjQ0Ci0tLSBhL1dlYktpdDIvVUlQcm9j ZXNzL1dlYkRvd25sb2FkQ2xpZW50LmNwcAorKysgYi9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJEb3du bG9hZENsaWVudC5jcHAKQEAgLTg4LDYgKzg4LDE0IEBAIHZvaWQgV2ViRG93bmxvYWRDbGllbnQ6 OmRpZEZpbmlzaChXZWJDb250ZXh0KiB3ZWJDb250ZXh0LCBEb3dubG9hZFByb3h5KiBkb3dubG9h CiAgICAgICAgIHJldHVybjsKICAgICAKICAgICBtX2NsaWVudC5kaWRGaW5pc2godG9BUEkod2Vi Q29udGV4dCksIHRvQVBJKGRvd25sb2FkUHJveHkpLCBtX2NsaWVudC5jbGllbnRJbmZvKTsKLX0g ICAgCit9CisKK3ZvaWQgV2ViRG93bmxvYWRDbGllbnQ6OmRpZEZhaWwoV2ViQ29udGV4dCogd2Vi Q29udGV4dCwgRG93bmxvYWRQcm94eSogZG93bmxvYWRQcm94eSwgY29uc3QgUmVzb3VyY2VFcnJv ciYgZXJyb3IpCit7CisgICAgaWYgKCFtX2NsaWVudC5kaWRGYWlsKQorICAgICAgICByZXR1cm47 CisKKyAgICBtX2NsaWVudC5kaWRGYWlsKHRvQVBJKHdlYkNvbnRleHQpLCB0b0FQSShkb3dubG9h ZFByb3h5KSwgdG9BUEkoZXJyb3IpLCBtX2NsaWVudC5jbGllbnRJbmZvKTsKK30KIAogfSAvLyBu YW1lc3BhY2UgV2ViS2l0CmRpZmYgLS1naXQgYS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJEb3dubG9h ZENsaWVudC5oIGIvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViRG93bmxvYWRDbGllbnQuaAppbmRleCBh ZGYxODc5YTQ0N2VjN2E2MjM1ZGI2MGJmMjZiZjI2NjIyNmMwNzQ3Li43Yzc1NjA1MzE0NmIzYmVj NmY3YTZiZDlkYjA0MzlhYzk2NzEyY2E5IDEwMDY0NAotLS0gYS9XZWJLaXQyL1VJUHJvY2Vzcy9X ZWJEb3dubG9hZENsaWVudC5oCisrKyBiL1dlYktpdDIvVUlQcm9jZXNzL1dlYkRvd25sb2FkQ2xp ZW50LmgKQEAgLTMxLDYgKzMxLDcgQEAKICNpbmNsdWRlIDx3dGYvRm9yd2FyZC5oPgogCiBuYW1l c3BhY2UgV2ViQ29yZSB7CisgICAgY2xhc3MgUmVzb3VyY2VFcnJvcjsKICAgICBjbGFzcyBSZXNv dXJjZVJlc3BvbnNlOwogfQogCkBAIC00OCw2ICs0OSw3IEBAIHB1YmxpYzoKICAgICBTdHJpbmcg ZGVjaWRlRGVzdGluYXRpb25XaXRoU3VnZ2VzdGVkRmlsZW5hbWUoV2ViQ29udGV4dCosIERvd25s b2FkUHJveHkqLCBjb25zdCBTdHJpbmcmIGZpbGVuYW1lLCBib29sJiBhbGxvd092ZXJ3cml0ZSk7 CiAgICAgdm9pZCBkaWRDcmVhdGVEZXN0aW5hdGlvbihXZWJDb250ZXh0KiwgRG93bmxvYWRQcm94 eSosIGNvbnN0IFN0cmluZyYgcGF0aCk7CiAgICAgdm9pZCBkaWRGaW5pc2goV2ViQ29udGV4dCos IERvd25sb2FkUHJveHkqKTsKKyAgICB2b2lkIGRpZEZhaWwoV2ViQ29udGV4dCosIERvd25sb2Fk UHJveHkqLCBjb25zdCBXZWJDb3JlOjpSZXNvdXJjZUVycm9yJik7CiB9OwogCiB9IC8vIG5hbWVz cGFjZSBXZWJLaXQK