49829 2010-11-19 14:01:21 -0800 WebKit2: Add WKViewRef API for executing edit commands 2011-03-03 21:28:43 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Windows 7 RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 1 sam jeffm darin jeffm oldest_to_newest 311679 0 sam 2010-11-19 14:01:21 -0800 We need API for SelectAll, Undo and Redo on WKView. In WebKit1, this was handled by a custom WM_COMMAND, but there is no reason to copy that approach. 314463 1 sam 2010-11-29 09:29:41 -0800 <rdar://problem/8705950> 361961 2 jeffm 2011-03-03 14:46:04 -0800 *** Bug 55710 has been marked as a duplicate of this bug. *** 361963 3 jeffm 2011-03-03 14:47:54 -0800 I believe the commands we need to support are cut/copy/paste, delete, select all, and undo/redo. 361971 4 84632 jeffm 2011-03-03 14:54:10 -0800 Created attachment 84632 Patch 362016 5 84632 darin 2011-03-03 15:38:57 -0800 Comment on attachment 84632 Patch I think this should be a WKPage API, not a WKView API. I also think this should take WebCore command names rather than a fixed set of command numbers. I’m going to say review- for now, but you can put this back up for review if others disagree. 362026 6 jeffm 2011-03-03 15:47:29 -0800 Because this is a Windows-specific API, both Sam and Anders agree it should be in WKView, since WKPage has no Windows-specific implementation. I would rather use the WebCore Editor command name strings directly, but I'm not sure what the best way to expose these through the API (if we need to do that at all, we could just assume the client knows what the command names are, I suppose). 362032 7 jeffm 2011-03-03 15:50:21 -0800 I suggested to Anders that we could just document the Editor command names in a comment block in WKView.h, and he agreed. I'll submit another patch that uses the command names instead, but I'm going to leave the API in WKView. 362039 8 84645 jeffm 2011-03-03 16:05:46 -0800 Created attachment 84645 Patch 362040 9 84645 andersca 2011-03-03 16:08:33 -0800 Comment on attachment 84645 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=84645&action=review > Source/WebKit2/UIProcess/API/C/win/WKView.h:54 > + Valid command name strings include: Maybe this could mention that it accepts all WebCore editing commands? > Source/WebKit2/UIProcess/API/C/win/WKView.h:64 > +WK_EXPORT void WKViewExecuteCommand(WKViewRef view, WKStringRef command); It's probably simpler if this takes a const char* since edit commands are all ASCII and that would make it easier for API clients. 362041 10 84645 andersca 2011-03-03 16:09:25 -0800 Comment on attachment 84645 Patch Nah, it's fine to take a WKStringRef. I changed my mind. 362042 11 jeffm 2011-03-03 16:12:02 -0800 Committed r80295: <http://trac.webkit.org/changeset/80295> 362094 12 darin 2011-03-03 16:59:54 -0800 (In reply to comment #6) > Because this is a Windows-specific API Why is this a Windows-specific API? 362095 13 darin 2011-03-03 17:00:15 -0800 I’d love to have this API on all platforms. 362128 14 jeffm 2011-03-03 17:38:06 -0800 (In reply to comment #13) > I’d love to have this API on all platforms. There's a semantic mismatch between Mac and Windows in where menu items are set up (and executed). On the Mac, we can do this all in the OpenSource side of the world in WKView.mm. On Windows, though, we have to do all this in the app. According to Sam, we're not defining the final WebKit2 API set at this point, we're focused on making the API work for Safari specifically in the short term. We can certainly revisit this when we are ready to think about an API design that will work for more clients. 362163 15 darin 2011-03-03 18:07:55 -0800 I still think this call should have gone on WKPage. I don’t see any argument here for why putting it on WKView is superior. The argument seems to be “there is code a little like this in the Mac’s WKView” and “we haven’t needed this on Mac” and neither convinces me. I’m slightly annoyed that we added this to what seems to me to be the wrong class. 362249 16 jeffm 2011-03-03 21:20:20 -0800 OK, I will move this API to WKPage. New bug coming soon. 362258 17 jeffm 2011-03-03 21:28:43 -0800 Created bug 55744. 84632 2011-03-03 14:54:10 -0800 2011-03-03 16:05:43 -0800 Patch bug-49829-20110303145408.patch text/plain 3477 jeffm SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgwMjg2KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDMtMDMgIEplZmYgTWls bGVyICA8amVmZm1AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFdlYktpdDI6IEFkZCBXS1ZpZXdSZWYgQVBJIGZvciBleGVjdXRpbmcg ZWRpdCBjb21tYW5kcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NDk4MjkKKyAgICAgICAgCisgICAgICAgIEFkZGVkIFdLVmlld0V4ZWN1dGVDb21tYW5k KCkgYWxvbmcgd2l0aCBlbnVtIHZhbHVlcyBmb3IgdGhlIGVkaXQgY29tbWFuZHMgd2UgbmVlZC4K KworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQy93aW4vV0tWaWV3LmNwcDoKKyAgICAgICAgKGNy ZWF0ZUNvbW1hbmROYW1lTWFwKTogQWRkZWQuCisgICAgICAgIChjb21tYW5kTmFtZUZvcldLVmll d0NvbW1hbmQpOiBBZGRlZC4KKyAgICAgICAgKFdLVmlld0V4ZWN1dGVDb21tYW5kKTogQWRkZWQu CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9DL3dpbi9XS1ZpZXcuaDogQWRkZWQgV0tWaWV3RXhl Y3V0ZUNvbW1hbmQoKSBhbmQgV0tWaWV3Q29tbWFuZCBlbnVtLgorCiAyMDExLTAzLTAzICBNYWNp ZWogU3RhY2hvd2lhayAgPG1qc0BhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQnJh ZHkgRWlkc29uLgpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL3dpbi9XS1Zp ZXcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy93aW4v V0tWaWV3LmNwcAkocmV2aXNpb24gODAyMzgpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL0Mvd2luL1dLVmlldy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI2LDYgKzI2LDcgQEAKICNp bmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJXS1ZpZXcuaCIKIAorI2luY2x1ZGUgIkhhc2hN YXAuaCIKICNpbmNsdWRlICJXS0FQSUNhc3QuaCIKICNpbmNsdWRlICJXZWJWaWV3LmgiCiAKQEAg LTgxLDMgKzgyLDM3IEBAIFdLVmlld0ZpbmRJbmRpY2F0b3JDYWxsYmFjayBXS1ZpZXdHZXRGaW4K IHsgICAgCiAgICAgcmV0dXJuIHRvSW1wbCh2aWV3UmVmKS0+Z2V0RmluZEluZGljYXRvckNhbGxi YWNrKGNvbnRleHQpOwogfQorCit0eXBlZGVmIEhhc2hNYXA8aW50MzJfdCwgU3RyaW5nPiBDb21t YW5kTmFtZU1hcDsKKworc3RhdGljIGNvbnN0IENvbW1hbmROYW1lTWFwKiBjcmVhdGVDb21tYW5k TmFtZU1hcCgpCit7CisgICAgQ29tbWFuZE5hbWVNYXAqIG1hcCA9IG5ldyBIYXNoTWFwPGludDMy X3QsIFN0cmluZz47CisgICAgCisgICAgbWFwLT5hZGQoa1dLVmlld0NvcHksICJDb3B5Iik7Cisg ICAgbWFwLT5hZGQoa1dLVmlld0N1dCwgIkN1dCIpOworICAgIG1hcC0+YWRkKGtXS1ZpZXdEZWxl dGUsICJEZWxldGUiKTsKKyAgICBtYXAtPmFkZChrV0tWaWV3UGFzdGUsICJQYXN0ZSIpOworICAg IG1hcC0+YWRkKGtXS1ZpZXdSZWRvLCAiUmVkbyIpOworICAgIG1hcC0+YWRkKGtXS1ZpZXdTZWxl Y3RBbGwsICJTZWxlY3RBbGwiKTsKKyAgICBtYXAtPmFkZChrV0tWaWV3VW5kbywgIlVuZG8iKTsK KyAgICAKKyAgICByZXR1cm4gbWFwOworfQorCitzdGF0aWMgU3RyaW5nIGNvbW1hbmROYW1lRm9y V0tWaWV3Q29tbWFuZChXS1ZpZXdDb21tYW5kIGNvbW1hbmQpCit7CisgICAgLy8gTWFwIFdLVmll d0NvbW1hbmRzIGludG8gRWRpdG9yIGNvbW1hbmQgbmFtZXMuCisgICAgc3RhdGljIGNvbnN0IENv bW1hbmROYW1lTWFwKiBjb21tYW5kTmFtZU1hcCA9IGNyZWF0ZUNvbW1hbmROYW1lTWFwKCk7Cisg ICAgQ29tbWFuZE5hbWVNYXA6OmNvbnN0X2l0ZXJhdG9yIGl0ID0gY29tbWFuZE5hbWVNYXAtPmZp bmQoY29tbWFuZCk7CisgICAgaWYgKGl0ICE9IGNvbW1hbmROYW1lTWFwLT5lbmQoKSkKKyAgICAg ICAgcmV0dXJuIGl0LT5zZWNvbmQ7CisgICAgCisgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7Cisg ICAgcmV0dXJuIFN0cmluZygpOworfQorCit2b2lkIFdLVmlld0V4ZWN1dGVDb21tYW5kKFdLVmll d1JlZiB2aWV3UmVmLCBXS1ZpZXdDb21tYW5kIGNvbW1hbmQpCit7CisgICAgdG9JbXBsKHZpZXdS ZWYpLT5wYWdlKCktPmV4ZWN1dGVFZGl0Q29tbWFuZChjb21tYW5kTmFtZUZvcldLVmlld0NvbW1h bmQoY29tbWFuZCkpOworfQpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL3dp bi9XS1ZpZXcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0Mv d2luL1dLVmlldy5oCShyZXZpc2lvbiA4MDIzOCkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvQy93aW4vV0tWaWV3LmgJKHdvcmtpbmcgY29weSkKQEAgLTMzLDYgKzMzLDE3IEBACiBl eHRlcm4gIkMiIHsKICNlbmRpZgogCitlbnVtIFdLVmlld0NvbW1hbmQgeworICAgIGtXS1ZpZXdD b3B5ID0gMSwKKyAgICBrV0tWaWV3Q3V0ID0gMiwKKyAgICBrV0tWaWV3RGVsZXRlID0gMywKKyAg ICBrV0tWaWV3UGFzdGUgPSA0LAorICAgIGtXS1ZpZXdSZWRvID0gNSwKKyAgICBrV0tWaWV3U2Vs ZWN0QWxsID0gNiwKKyAgICBrV0tWaWV3VW5kbyA9IDcKK307Cit0eXBlZGVmIGVudW0gV0tWaWV3 Q29tbWFuZCBXS1ZpZXdDb21tYW5kOworCiBXS19FWFBPUlQgV0tUeXBlSUQgV0tWaWV3R2V0VHlw ZUlEKCk7CiAKIFdLX0VYUE9SVCBXS1ZpZXdSZWYgV0tWaWV3Q3JlYXRlKFJFQ1QgcmVjdCwgV0tD b250ZXh0UmVmIGNvbnRleHQsIFdLUGFnZUdyb3VwUmVmIHBhZ2VHcm91cCwgSFdORCBwYXJlbnRX aW5kb3cpOwpAQCAtNTAsNiArNjEsOCBAQCB0eXBlZGVmIHZvaWQgKCpXS1ZpZXdGaW5kSW5kaWNh dG9yQ2FsbGJhCiBXS19FWFBPUlQgdm9pZCBXS1ZpZXdTZXRGaW5kSW5kaWNhdG9yQ2FsbGJhY2so V0tWaWV3UmVmIHZpZXcsIFdLVmlld0ZpbmRJbmRpY2F0b3JDYWxsYmFjayBjYWxsYmFjaywgdm9p ZCogY29udGV4dCk7CiBXS19FWFBPUlQgV0tWaWV3RmluZEluZGljYXRvckNhbGxiYWNrIFdLVmll d0dldEZpbmRJbmRpY2F0b3JDYWxsYmFjayhXS1ZpZXdSZWYgdmlldywgdm9pZCoqIGNvbnRleHQp OwogCitXS19FWFBPUlQgdm9pZCBXS1ZpZXdFeGVjdXRlQ29tbWFuZChXS1ZpZXdSZWYgdmlldywg V0tWaWV3Q29tbWFuZCBjb21tYW5kKTsKKwogI2lmZGVmIF9fY3BsdXNwbHVzCiB9CiAjZW5kaWYK 84645 2011-03-03 16:05:46 -0800 2011-03-03 16:09:25 -0800 Patch bug-49829-20110303160544.patch text/plain 2112 jeffm SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDgwMjk0KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDMtMDMgIEplZmYgTWls bGVyICA8amVmZm1AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFdlYktpdDI6IEFkZCBXS1ZpZXdSZWYgQVBJIGZvciBleGVjdXRpbmcg ZWRpdCBjb21tYW5kcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NDk4MjkKKworICAgICAgICBBZGRlZCBXS1ZpZXdFeGVjdXRlQ29tbWFuZCgpIGFuZCBk b2N1bWVudGVkIHNvbWUgb2YgdGhlIFdlYkNvcmUgRWRpdG9yQ29tbWFuZCBzdHJpbmdzLgorCisg ICAgICAgICogVUlQcm9jZXNzL0FQSS9DL3dpbi9XS1ZpZXcuY3BwOgorICAgICAgICAoV0tWaWV3 RXhlY3V0ZUNvbW1hbmQpOiBBZGRlZC4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0Mvd2luL1dL Vmlldy5oOiBBZGRlZCBXS1ZpZXdFeGVjdXRlQ29tbWFuZCgpIGFuZCBjb21tZW50IGJsb2NrIHdp dGggV2ViQ29yZSBFZGl0b3JDb21tYW5kIHN0cmluZ3MuCisKIDIwMTEtMDMtMDMgIEplc3NpZSBC ZXJsaW4gIDxqYmVybGluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIFJv YmVuLgpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL3dpbi9XS1ZpZXcuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy93aW4vV0tWaWV3 LmNwcAkocmV2aXNpb24gODAyMzgpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0Mv d2luL1dLVmlldy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTgxLDMgKzgxLDggQEAgV0tWaWV3Rmlu ZEluZGljYXRvckNhbGxiYWNrIFdLVmlld0dldEZpbgogeyAgICAKICAgICByZXR1cm4gdG9JbXBs KHZpZXdSZWYpLT5nZXRGaW5kSW5kaWNhdG9yQ2FsbGJhY2soY29udGV4dCk7CiB9CisKK3ZvaWQg V0tWaWV3RXhlY3V0ZUNvbW1hbmQoV0tWaWV3UmVmIHZpZXdSZWYsIFdLU3RyaW5nUmVmIGNvbW1h bmQpCit7CisgICAgdG9JbXBsKHZpZXdSZWYpLT5wYWdlKCktPmV4ZWN1dGVFZGl0Q29tbWFuZCh0 b0ltcGwoY29tbWFuZCktPnN0cmluZygpKTsKK30KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvQy93aW4vV0tWaWV3LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9DL3dpbi9XS1ZpZXcuaAkocmV2aXNpb24gODAyMzgpCisrKyBTb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL0Mvd2luL1dLVmlldy5oCSh3b3JraW5nIGNvcHkpCkBAIC01MCw2 ICs1MCwxOSBAQCB0eXBlZGVmIHZvaWQgKCpXS1ZpZXdGaW5kSW5kaWNhdG9yQ2FsbGJhCiBXS19F WFBPUlQgdm9pZCBXS1ZpZXdTZXRGaW5kSW5kaWNhdG9yQ2FsbGJhY2soV0tWaWV3UmVmIHZpZXcs IFdLVmlld0ZpbmRJbmRpY2F0b3JDYWxsYmFjayBjYWxsYmFjaywgdm9pZCogY29udGV4dCk7CiBX S19FWFBPUlQgV0tWaWV3RmluZEluZGljYXRvckNhbGxiYWNrIFdLVmlld0dldEZpbmRJbmRpY2F0 b3JDYWxsYmFjayhXS1ZpZXdSZWYgdmlldywgdm9pZCoqIGNvbnRleHQpOwogCisvKgorICAgIFZh bGlkIGNvbW1hbmQgbmFtZSBzdHJpbmdzIGluY2x1ZGU6CisgICAgCisgICAgIkN1dCIKKyAgICAi Q29weSIKKyAgICAiUGFzdGUiCisgICAgIlNlbGVjdEFsbCIKKyAgICAiVW5kbyIKKyAgICAiUmVk byIKKyovCisKK1dLX0VYUE9SVCB2b2lkIFdLVmlld0V4ZWN1dGVDb21tYW5kKFdLVmlld1JlZiB2 aWV3LCBXS1N0cmluZ1JlZiBjb21tYW5kKTsKKwogI2lmZGVmIF9fY3BsdXNwbHVzCiB9CiAjZW5k aWYK